Suraj Khurana

Improved: Updated tasks.checkstyleMain.maxErrors to 24550 ~(-1280)

Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-framework into trunk

Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for framework component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace. '{' is not followed by whitespace. '}' is not followed by whitespace. '}' is not preceded with whitespace. 'typecast' is not followed by whitespace. 'try' is not followed by whitespace. ';' is preceded with whitespace.

  1. … 146 more files in changeset.
Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-framework into trunk

Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for applications component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace. '{' is not followed by whitespace. '}' is not followed by whitespace. '}' is not preceded with whitespace. 'typecast' is not followed by whitespace. 'try' is not followed by whitespace. ';' is preceded with whitespace.

  1. … 91 more files in changeset.
Improved: Updated tasks.checkstyleMain.maxErrors to 25829 ~(-327)

Improved: Corrected all checkstyle issues related to succeeding space for comma in framework directory. (OFBIZ-11805) Thanks Jacques and Ritesh Kumar for review.

  1. … 19 more files in changeset.
Improved: Corrected all checkstyle issues related to succeeding space for comma in applications directory. (OFBIZ-11805) Thanks Jacques and Ritesh Kumar for review.

  1. … 37 more files in changeset.
Improved: Corrected typo in license header text in ModelActionVisitor.java, ModelConditionVisitor.java and ModelFieldVisitor.java. While working on some checkstyle issues, I found this typo.

Improved: Removed unused SuppressWarnings and added proper space after comma and before { in LoginServices.java. (OFBIZ-11805) Thanks: Pawan Verma Also updated tasks.checkstyleMain.maxErrors (-5).

Improved: updates tasks.checkstyleMain.maxErrors to 26161 ~(-270)

Improved: Corrected remaining ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805)

  1. … 21 more files in changeset.
Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-framework into trunk

Improved: Corrected remaining ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805)

Improved: updates tasks.checkstyleMain.maxErrors to 26432 (-249)

Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors in applications component. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review.

  1. … 32 more files in changeset.
Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-framework into trunk

Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review.

  1. … 20 more files in changeset.
Improved: Converted deleteContentKeywords service from mini-lang to groovy DSL. (OFBIZ-11391) Thanks Devanshu Vyas for reporting and Yogesh Naroliya for the patch.

Improved: Converted createContentFromDataResource service from mini-lang to groovy DSL. (OFBIZ-11377) Thanks Devanshu Vyas for reporting and Anushi Gupta for the patch.

Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-framework into trunk

Improved: Converted getContentAndDataResource service from mini-lang to groovy DSL. (OFBIZ-11382) Thanks Devanshu Vyas for reporting and Ravi Lodhi for the patch.

Fixed: Console warnings related to OrderHeader caching. (OFBIZ-11858) Thanks Praveen Sharma for the patch and Jacques for review.

Fixed: Console warnings related to OrderHeader caching. (OFBIZ-11858) Thanks Praveen Sharma for the patch and Jacques for review.

Fixed: Console warnings related to OrderHeader caching. (OFBIZ-11858) Thanks Praveen Sharma for the patch and Jacques for review.

Updated: tasks.checkstyleMain.maxErrors to 26759 (-48)

Updated: tasks.checkstyleMain.maxErrors to 26807 (-38)

Fixed: Unnecessary iterations and setting inventory for all productFacilities in setLastInventoryCount. (OFBIZ-11796)

Instead of updating all product facilities records on one inventory item change, we should be changing only specific product facility record for that the inventory item belongs to. Thanks Jacques, Pierre, Pawan and Arun for the review.

Fixed: Unnecessary iterations and setting inventory for all productFacilities in setLastInventoryCount. (OFBIZ-11796)

Instead of updating all product facilities records on one inventory item change, we should be changing only specific product facility record for that the inventory item belongs to. Thanks Jacques, Pierre, Pawan and Arun for the review.

Fixed: Unnecessary iterations and setting inventory for all productFacilities in setLastInventoryCount. (OFBIZ-11796)

Instead of updating all product facilities records on one inventory item change, we should be changing only specific product facility record for that the inventory item belongs to. Thanks Jacques, Pierre, Pawan and Arun for the review.