Clone
 

suraj khurana <64310724+surajkhurana@users.noreply.github.com> in ofbiz-framework

Improved: Make shipment services loosely coupled with work-effort generation. (#132)

* Improved: Make shipment services loosely coupled with work-effort generation.

(OFBIZ-11678)

Removed workeffort generation related code in separate service, in createShipment and updateShipment service. In this effort, createShipment has been successfully changed to entity-auto as well.

Thanks: Pierre Smits and Arun Patidar for discussion and review.

Improved: Converted createPaymentContent, updatePaymentContent services from mini-lang to groovy. (#155)

(OFBIZ-11501)(OFBIZ-11502)

Thanks Devanshu Vyas for reporting and Sourabh Punyani for providing the patch.

Improved: Refactor simple methods names as per naming convention best practices. (#137)

(OFBIZ-11700)

Improved: Called service directly instead of simple methoda call as service has been changed to entity-auto. (#142)

(OFBIZ-11616)

Also, updated time sheet related test data as timesheet status should be appropriate before updating or deleting.

Improved: Converted all Timesheet related CRUD services from simple to entity-auto (#88)

* Improved: Converted all Timesheet related CRUD entities from simple to entity-auto

(OFBIZ-11616)

Improved: Converted some simple services services from simple to entity-auto. (#136)

(OFBIZ-11698)

Converted services: deleteOrderAdjustment, removeShoppingList and removed simple method for already converted deleteFinAccount.

    • -1
    • +5
    /applications/order/servicedef/secas.xml
Improved: Converted WorkEffort related services from simple to entity-auto. (#135)

(OFBIZ-11690)

Removed: Deprecated entity captureBillingAccountPayments since release 17.12. (#131)

(OFBIZ-11435)

Also, added deprecated since tag in some old entities and fields. This is done as per current policy to deprecate entities/services.

Thanks Pierre for reporting and Jacques for review.

Improved: Converted all GlReconciliationEntry related CRUD services from simple to entity-auto (#129)

* Improved: Converted all GlReconciliationEntry related CRUD services from simple to entity-auto

(OFBIZ-11662)

Improved: Converted remaining ElectronicText related CRUD services from simple to entity-auto (#120)

(OFBIZ-11664)

Improved: Converted all CustRequestItem related CRUD services from simple to entity-auto (#118)

(OFBIZ-11663)

    • -0
    • +13
    /applications/order/servicedef/secas.xml
Improved: Converted all TechDataCalendar related CRUD services from simple to entity-auto (#112)

(OFBIZ-11632)

Improved: Converted all AcctgTrans related CRUD services from simple to entity-auto (#103)

* Improved: Converted all AcctgTrans related CRUD services from simple to entity-auto

(OFBIZ-11640)

Improved: Converted all GlReconciliation related CRUD services from simple to entity-auto (#110)

(OFBIZ-11642)

Improved: Converted all RequirementRole related CRUD services from simple to entity-auto (#105)

(OFBIZ-11641)

It was using same permission for all CRUD operation, updated logical permissions corresponding to each action.

    • -1
    • +4
    /applications/order/servicedef/secas.xml
Improved: Converted all RequirementCustRequest related CRUD services from simple to entity-auto (#102)

(OFBIZ-11638)

Also, renamed associatedRequirementWithRequestItem to proper name and corrected occurences including tests.

    • -1
    • +1
    /applications/order/servicedef/secas.xml
Improved: Converted all TechDataCalendarWeek related CRUD services from simple to entity-auto (#109)

(OFBIZ-11644)

Improved: Converted all TechDataCalendarExcWeek related CRUD services from simple to entity-auto (#104)

(OFBIZ-11636)

Improved: Converted all CustRequestAttribute related CRUD services from simple to entity-auto (#101)

(OFBIZ-11637)

Added seca rule to updateCustRequestLastModifiedDate on commit operation of this service, earlier it was called inline.

    • -1
    • +8
    /applications/order/servicedef/secas.xml
Improved: Converted all EmplLeave related CRUD services from simple to entity-auto (#97)

(OFBIZ-11630)

Also, added comments for similar types entity-auto services and clubbed them for better visibility.

Improved: Converted all TimeEntry related CRUD services from simple to entity-auto (#99)

(OFBIZ-11624)

Also, removed unused services named unlinkInvoiceFromTimeEntry, whcih simply clears TimeEntry field, so used updateTimeEntry instead.

    • -1
    • +2
    /applications/accounting/widget/InvoiceForms.xml
Improved: Converted all TechDataCalendarExcDay related CRUD services from simple to entity-auto (#96)

Improved: Converted all TechDataCalendarExcDay related CRUD services from simple to entity-auto

(OFBIZ-11622)

Also, added a permission service for MANUFACTURING related base permission.

Improved: Converted all SalaryStep related CRUD services from simple to entity-auto (#98)

Improved: Converted all SalaryStep related CRUD services from simple to entity-auto

(OFBIZ-11631)

Improved: Marked addRequirementTask as deprecated and make it entity-auto service as it was simply creating record of WorkRequirementFulfillment. (#100)

Improved: Marked addRequirementTask as deprecated and make it entity-auto service as it was simply creating record of WorkRequirementFulfillment.

(OFBIZ-11634)

We have already service createWorkRequirementFulfillment available to do this job so makring it as deprecated.

Thanks Jacques for review.

Improved: Converted all CustRequestContent related CRUD services from simple to entity-auto (#94)

* Improved: Converted all CustRequestContent related CRUD services from simple to entity-auto

(OFBIZ-11627)

* Improved: Added seca rule for checkStatusCustRequest while invoke and updateCustRequestLastModifiedDate while commit for services related to CustRequestContent.

    • -0
    • +19
    /applications/order/servicedef/secas.xml
Improved: Converted all TrackingCodeOrder related CRUD services from simple to entity-auto (#92)

* Improved: Converted all TrackingCodeOrder related CRUD services from simple to entity-auto

(OFBIZ-11625)

Improved: Converted all CustRequestParty related CRUD services from simple to entity-auto (#95)

* Improved: Converted all CustRequestParty related CRUD services from simple to entity-auto

(OFBIZ-11621)

    • -0
    • +27
    /applications/order/servicedef/secas.xml
Improved: Converted all TimesheetRole related CRUD services from simple to entity-auto (#90)

* Improved: Converted all TimesheetRole related CRUD services from simple to entity-auto

(OFBIZ-11617)

Improved: All the service level error messages for missing required field for order component (#86)

* Improved: All the service level error messages for missing required field for order component

(OFBIZ-7736)

Thanks Ratnesh Upadhyay for reporting and Ankush Upadhyay for providing the updated patch

Improved: Converted all TrackingCodeOrderReturn related CRUD services from simple to entity-auto (#89)

* Improved: Converted all TrackingCodeOrderReturn related CRUD services from simple to entity-auto

(OFBIZ-11623)