Clone
 

mathieu lirzin <mthl@apache.org> in ofbiz-framework

Improved: Update checkstyle max error count

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869186 13f79535-47bb-0310-9956-ffa450edef68

Improved: Turn ‘DependsOnInfo’ into a String (OFBIZ-11264)

`depends-on` XML tag doesn't have any `loader` or `location` attribute so

DependsOnInfo does not need to extend ResourceInfo.

When removing the class derivation, DependsOnInfo now becomes a simple box

containing a String attribute. In order to make the manipulation of dependency

information simpler, the attribute is now inlined as a simple String value.

Thanks: Samuel Trégouët for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869185 13f79535-47bb-0310-9956-ffa450edef68

Improved: Add ‘ComponentConfig#toString’ to ease debugging (OFBIZ-11264)

Thanks: Samuel Trégouët for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869184 13f79535-47bb-0310-9956-ffa450edef68

Improved: Rewrite ‘ComponentContainer#loadComponentsInDirectory’ (OFBIZ-11264)

Use a more declarative style with the stream API.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869183 13f79535-47bb-0310-9956-ffa450edef68

Improved: Delay the construction of component classpaths (OFBIZ-11264)

The list of component classpath elements was constructed iteratively

while loading components. This list was additionally used to check if

a component was actually loaded. This implementation was leading to

hard to understand code that has been replaced by a more appropriate

‘LinkedHashSet’ object.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869182 13f79535-47bb-0310-9956-ffa450edef68

Improved: Remove unnecessary ‘throws’ declarations (OFBIZ-11264)

Some declared and/or documented exceptions that were not actually

thrown.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869181 13f79535-47bb-0310-9956-ffa450edef68

Improved: Import ‘ComponentDef’ and ‘DependsOnInfo’ inner-classes (OFBIZ-11264)

This allows to use shorter name when using an variable or parameter of

those types.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869180 13f79535-47bb-0310-9956-ffa450edef68

Improved: Upgrade Groovy 2.4.16 → 2.5.8 (OFBIZ-11268)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869136 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Fix javadoc build (OFBIZ-11007)

This fixes the javadoc errors introduced in revision 1868963.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869039 13f79535-47bb-0310-9956-ffa450edef68

Improved: Lint unit tests

This makes no behavioral changes, only coding style fixes.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869037 13f79535-47bb-0310-9956-ffa450edef68

  1. … 12 more files in changeset.
Improved: Merge ‘UtilObjectUnitTest’ into ‘UtilObjectTests’ (OFBIZ-11067)

Those classes were testing the same class.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869023 13f79535-47bb-0310-9956-ffa450edef68

Improved: Turn ‘UtilObjectTests’ into a unit test class (OFBIZ-11067)

Adapt ‘UtilObjectUnitTest’ test class to avoid side effects when

testing allowed serialization classes.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869022 13f79535-47bb-0310-9956-ffa450edef68

Improved: Define specific ‘maxErrors’ for main/test source sets. (OFBIZ-11262)

Previously a common maximum “checkstyle” error count was provided for

the main/test source sets. This means that there was no effective

detection of newly introduced coding style errors in tests. We are

now defining separate error counts to avoid new tests to introduce

such errors.

Thanks: Gil Portenseigne for identifying this limitation.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869010 13f79535-47bb-0310-9956-ffa450edef68

Improved: Use utilitary ‘OFBizTestCase#getLogin’ in ‘ServicePermissionTests’ (OFBIZ-11262)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869009 13f79535-47bb-0310-9956-ffa450edef68

Improved: Do not use deprecated ‘Class#newInstance’ (OFBIZ-11262)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869008 13f79535-47bb-0310-9956-ffa450edef68

Improved: Do not use deprecated ‘Proxyclass#getConstructor’ (OFBIZ-11262)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869007 13f79535-47bb-0310-9956-ffa450edef68

Improved: Do not use deprecated ‘javax.security.cert.X509Certificate’ (OFBIZ-11262)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869006 13f79535-47bb-0310-9956-ffa450edef68

Improved: Refactor ‘UtilObject#getObjectException’ (OFBIZ-11261)

This moves most of the behavior inside the ‘SafeObjectInputStream’

class which has been refactored too.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869004 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Handle whitelist of serializable classes from properties (OFBIZ-11261)

There was a bug regarding the way the ‘ListOfSafeObjectsForInputStream’ value

defined in the “SafeObjectInputStream.properties” file was handled. Mistakenly

only one class identifier was allowed.

The tests have not been backported from ‘trunk’ because of the way

‘UtilProperties#setPropertyValueInMemory’ work in 18.12.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1869003 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Handle whitelist of serializable classes from properties (OFBIZ-11261)

There was a bug regarding the way the ‘ListOfSafeObjectsForInputStream’ value

defined in the “SafeObjectInputStream.properties” file was handled. Mistakenly

only one class identifier was allowed.

Some unit tests have been added to check that the identified bug is fixed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869001 13f79535-47bb-0310-9956-ffa450edef68

Implemented: Handle URI templates in request maps (OFBIZ-11007)

It is now possible to use segmented paths by using URI templates like

‘/foo/bar/{baz}’ in the ‘uri’ attribute of <request-map> elements.

Thanks: Artemiy Rozovyk for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868963 13f79535-47bb-0310-9956-ffa450edef68

Improved: Lint ‘ControlServlet’ partially (OFBIZ-11007)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868962 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Use ‘ConcurrentHashMap’ to avoid ‘ConcurrentModificationException’ (OFBIZ-11258)

When trying to load components in their dependency order the

‘toBeLoadedComponents’ map is modified while being iterated over which

is not safe for non-concurrent maps.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1868666 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Use ‘ConcurrentHashMap’ to avoid ‘ConcurrentModificationException’ (OFBIZ-11258)

When trying to load components in their dependency order the

‘toBeLoadedComponents’ map is modified while being iterated over which

is not safe for non-concurrent maps.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868665 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Fix regression introduced in revision 1867409 (OFBIZ-11192)

‘null’ was an unspecified valid value for the second argument of the

‘ComponentContainer#retrieveComponentConfig’ method.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868657 13f79535-47bb-0310-9956-ffa450edef68

Improved: Move APACHE2_HEADER_FOR_XML to “src/main/resources” (OFBIZ-11161)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868646 13f79535-47bb-0310-9956-ffa450edef68

Improved: Adapt ‘ContainerConfig#getConfigurations’ (OFBIZ-11256)

Remove unused declared ‘ContainerException’ in signature and fix the

javadoc to match the actual specification.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868630 13f79535-47bb-0310-9956-ffa450edef68

Improved: Mark ‘ContainerConfig#configurations’ as final (OFBIZ-11256)

Use uppercase to match coding standards.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868629 13f79535-47bb-0310-9956-ffa450edef68

Improved: Avoid unecessary breakage in ‘ContainerConfig’ (OFBIZ-11256)

This restores ‘public’ modifiers on fields and move the ‘Property’

inner class back to ‘Configuration’ to avoid breakage of client code

extending the ‘Container’ interface.

In order to smooth the transition towards using getters instead of

direct field accesss, the public modifiers on fields are now marked as

deprecated.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868628 13f79535-47bb-0310-9956-ffa450edef68

Implemented: Allow deprecated public fields (OFBIZ-11256)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868627 13f79535-47bb-0310-9956-ffa450edef68