Checkout
 

sf in httpd

vote+promote

note docs commit in proposal

update docs xforms

  1. … 5 more files in changeset.
Describe new behavior of ServerLimit

This has changed a bit after the fix for PR 53555. Better wording is welcome.

Split proposal for PR 53555 into smaller chunks

Replace jim's proposal into smaller chunks that are IMHO easier to review.

The end result is the same, except for the CHANGES entry and one comment that I

added to r1770752 vs. the Bugzilla patch and that was missing in jim's patch.

mpm_event: add clarifying comment

from jim

Use all available scoreboard slots

Allow to use all slots up to ServerLimit. This makes 'scoreboard full'

errors much less likely.

And if ther is a situation where the scoreboard is full, don't make any

more processes finish gracefully due to reduced load until some old

processes have terminated. Otherwise, the situation would get worse once

the load increases again.

ap_daemon_limit is renamed to the more descriptive active_server_limit,

to make sure that all its uses are taken care of.

PR 53555

ap_reclaim_child_processes(): Implement terminate immediately

The behavior for terminate == 1 was documented but not implemented. Do

that now.

ap_reclaim_child_processes() ignores its first argument

note this in the docs, add comment

Revert "On exit, don't write to other generations' scoreboard slots"

As we have removed the possibility to re-use used scoreboard slots in r1757031,

we don't need this check anymore.

mpm_event: don't re-use scoreboard slots that are still in use

This causes inconsistent data in the scoreboard (due to async

connections) and makes it difficult to determine what is going on.

Therefore it is not a useful fix for the scoreboard-full issues (PR

53555).

The consent on the dev list is that we should allocate/use more

scoreboard entries instead.

mpm_event: minor code simplification

- move variable initializations into declarations

- use max_workers variable

mod_status: note stopping procs in async info table

* add new column "stopping", denoting if a process is shutting down

* add additional "(old gen)", if a process is from before a graceful reload

* add counts of processes and stopping processes to summary line

vote + promote

Fix comment typo

Fix segfault with logresolve -c and IPv6

Due to a logic error, there could be a NULL pointer dereference.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823259

Make ap_find_child_by_pid() look at all slots that have ever been used.

This is preparation to allow to use more scoreboard slots in mpm event.

add comments

Document which directives set which variables

On exit, don't write to other generations' scoreboard slots

Don't take over scoreboard slots from gracefully finishing threads

Otherwise the old and the new thread will both update the same scoreboard slot

with undefined results.

Display process slot number in the async overview

Exit threads early during shutdown, part 2

Follow up to r1738466: During graceful shutdown, when the listener thread is

closing a connection, it needs to wake up a worker thread so that it may

terminate.

Exit threads early during shutdown

During graceful shutdown, if there are more running worker threads than open

connections, terminate some threads. This frees resources faster, which may be

needed for new processes.

Terminate keep-alive connections when dying

When shutting down a process gracefully, terminate keep-alive connections so

that we don't get any new requests which may keep the dying process alive

longer.

fix compiler warning about missing prototype

vote+comment
comment mod_systemd

vote+promote

update log number

rename some variables to be more descriptive

pid -> pslot

tid -> tslot

remove unused 'sd'