Clone
 

jon skeet <jskeet@apache.org> in ant-git

Fixed up JavaDocs (where possible) to remove warnings (mostly about breakiterator).

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@273159 13f79535-47bb-0310-9956-ffa450edef68

    • -1
    • +1
    /src/main/org/apache/tools/ant/Main.java
  1. … 7 more files in changeset.
Fix-up of JavaDocs for filters (and a couple of style fixes too).

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@272615 13f79535-47bb-0310-9956-ffa450edef68

Made the purpose of the no-arg constructor more obvious.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@272574 13f79535-47bb-0310-9956-ffa450edef68

Double doh - don't append the first character twice.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@272567 13f79535-47bb-0310-9956-ffa450edef68

Doh - use @exception, not @throws

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@272565 13f79535-47bb-0310-9956-ffa450edef68

Fixed up JavaDocs, improved efficiency of readLine.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@272564 13f79535-47bb-0310-9956-ffa450edef68

Fixed up JavaDocs so they build without errors. The main changes were: o Capitalisation. Please capitalise the first word of a new sentence, otherwise break-iterator complains. o @created tags. These aren't valid JavaDoc, and the info is in CVS anyway...

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@272051 13f79535-47bb-0310-9956-ffa450edef68

Added @ant.datatype tag.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@272050 13f79535-47bb-0310-9956-ffa450edef68

Fixed up JavaDoc comments again.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@272049 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +3
    /src/main/org/apache/tools/ant/TaskAdapter.java
Expanded JavaDoc comments on variable names.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271754 13f79535-47bb-0310-9956-ffa450edef68

    • -5
    • +14
    /src/main/org/apache/tools/ant/Main.java
Fixed up the fix-up to obey "Must not be null" etc style.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271750 13f79535-47bb-0310-9956-ffa450edef68

JavaDoc now builds without warnings again - thanks Erik :)

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271719 13f79535-47bb-0310-9956-ffa450edef68

Reapplied previous JavaDoc patch.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271718 13f79535-47bb-0310-9956-ffa450edef68

Answered my own previous question concerning thread safety.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271709 13f79535-47bb-0310-9956-ffa450edef68

JavaDoc changes.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271641 13f79535-47bb-0310-9956-ffa450edef68

JavaDoc changes, and raised a potential multithreading issue. Search for XXX to see details.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271640 13f79535-47bb-0310-9956-ffa450edef68

    • -5
    • +94
    /src/main/org/apache/tools/ant/XmlLogger.java
JavaDoc comments and a couple of code changes.

Code changes:

Removed an unneeded nullity test null instanceof Foo is always false.

Changed replaceChild(UnknownElement, Object) with two methods:

replaceChild(UnknownElement,Task) and

replaceChild(UnknownElement,RuntimeConfigurable) to make it

absolutely clear that you can't just replace the children with random

elements.

I must admit I'm still far from entirely clear exactly how

UnknownElement works. It probably counts as black magic...

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271639 13f79535-47bb-0310-9956-ffa450edef68

    • -11
    • +181
    /src/main/org/apache/tools/ant/Target.java
JavaDoc comments.

Note: maybeConfigure implies that calling it twice will have no effect.

I have a suspicion that children would be added twice. Search for XXX

to find the details.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271638 13f79535-47bb-0310-9956-ffa450edef68

    • -33
    • +126
    /src/main/org/apache/tools/ant/Task.java
Fixed (another) problem of <tt>...<tt> screwing up the rest of the page.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271608 13f79535-47bb-0310-9956-ffa450edef68

    • -1
    • +1
    /docs/manual/OptionalTasks/telnet.html
Fixed problem of <tt>...<tt> screwing up the rest of the page.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271607 13f79535-47bb-0310-9956-ffa450edef68

    • -1
    • +1
    /docs/manual/OptionalTasks/telnet.html
JavaDoc comments.

Also added a query about the use/otherwise of wrappers when

it comes to adding text - search for XXX to find the details

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271604 13f79535-47bb-0310-9956-ffa450edef68

Added reference to the <tag> option in JavaDoc. (Is this the correct position? Someone hit me with a cluestick if I should have added it at the top of the section or in a different section.)

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271602 13f79535-47bb-0310-9956-ffa450edef68

Temporary zip files used for update weren't being deleted, as doUpdate is reset during cleanUp.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271574 13f79535-47bb-0310-9956-ffa450edef68

Fixed problem which gave (on Windows) output such as:

[java] First line of real output

[java]

[java] Second line of real output

[java]

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271563 13f79535-47bb-0310-9956-ffa450edef68

Invalid scope parameters now throw exceptions. Repeated scope elements generate verbose messages.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271561 13f79535-47bb-0310-9956-ffa450edef68

Added tag option documentation.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271559 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +44
    /docs/manual/CoreTasks/javadoc.html
Added todo tag to javadoc task so that JavaDocs will now build them appropriately.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271556 13f79535-47bb-0310-9956-ffa450edef68

Put @todo tags back in now that there's support for them.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271555 13f79535-47bb-0310-9956-ffa450edef68

Added support for the -tag option in JavaDoc 1.4

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271553 13f79535-47bb-0310-9956-ffa450edef68

JavaDoc comments.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@271548 13f79535-47bb-0310-9956-ffa450edef68

    • -11
    • +25
    /src/main/org/apache/tools/ant/TaskAdapter.java