Clone
 

jesse n. glick <jglick@apache.org> in ant-git

sconnolly advises using TODO rather than XXX in comments.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1504315 13f79535-47bb-0310-9956-ffa450edef68

    • -1
    • +1
    /manual/tutorial-tasks-filesets-properties.html
    • -1
    • +1
    /src/main/org/apache/tools/ant/Main.java
    • -1
    • +1
    /src/main/org/apache/tools/ant/Task.java
  1. … 22 more files in changeset.
#43362 follow-ups: missing/incorrect @since; minor doc improvements and corrections.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1484767 13f79535-47bb-0310-9956-ffa450edef68

Deleted line break introduced by accident in antoine’s 1476700.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1477713 13f79535-47bb-0310-9956-ffa450edef68

#54641: XSLTC error. Use String.replaceAll rather than StringUtils, since some versions of Xalan (as patched by Oracle) try to load the class while compiling the stylesheet.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1453414 13f79535-47bb-0310-9956-ffa450edef68

Still more diagnostics for #54641.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1453400 13f79535-47bb-0310-9956-ffa450edef68

Unused import.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1453399 13f79535-47bb-0310-9956-ffa450edef68

StringUtils.replace is obsolete.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1453133 13f79535-47bb-0310-9956-ffa450edef68

Diagnosis of XMLResultAggregatorTest.testFrames failure on Java 7.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1453122 13f79535-47bb-0310-9956-ffa450edef68

Restored Java 5 compilability.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1453118 13f79535-47bb-0310-9956-ffa450edef68

Was not compatible to make systemClasspath (and systemBootClasspath) final; the NetBeans Ant integration in fact overwrites this value (for a reason).

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1453111 13f79535-47bb-0310-9956-ffa450edef68

    • -2
    • +2
    /src/main/org/apache/tools/ant/types/Path.java
Junit → JUnit

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1453094 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +74
    /src/tests/junit/org/example/junit/JUnit4Skippable.java
Odd indentation.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1453089 13f79535-47bb-0310-9956-ffa450edef68

JDK 5 javac is apparently buggy; @Override should be allowed on methods implemented from an interface.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1373836 13f79535-47bb-0310-9956-ffa450edef68

Rounding out signature of DeweyDecimal and writing some tests.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1373811 13f79535-47bb-0310-9956-ffa450edef68

#53622: faster VectorSet.retainAll.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1367741 13f79535-47bb-0310-9956-ffa450edef68

Stronger tests in preparation for #53622.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1367736 13f79535-47bb-0310-9956-ffa450edef68

#53617: fixed POM URLs. (Patch thanks to Eric Barboni.)

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1367076 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +1
    /src/etc/poms/ant-apache-log4j/pom.xml
    • -0
    • +1
    /src/etc/poms/ant-apache-regexp/pom.xml
    • -0
    • +1
    /src/etc/poms/ant-apache-resolver/pom.xml
    • -0
    • +1
    /src/etc/poms/ant-apache-xalan2/pom.xml
    • -0
    • +1
    /src/etc/poms/ant-commons-logging/pom.xml
  1. … 9 more files in changeset.
#53571: ClassLoader problems with Subclass of JUnitTask

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1363748 13f79535-47bb-0310-9956-ffa450edef68

@Override not supported when implementing interface methods in JDK 5 javac. (Spec compliance bug fixed in JDK 6 even for -source 5.)

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1345337 13f79535-47bb-0310-9956-ffa450edef68

    • -1
    • +0
    /src/main/org/apache/tools/ant/Main.java
#53347: <javac> by default fails when run on JDK 8. Follow-up to revision 1236803.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1345316 13f79535-47bb-0310-9956-ffa450edef68

JDK 5.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1328096 13f79535-47bb-0310-9956-ffa450edef68

JDK 5.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1328047 13f79535-47bb-0310-9956-ffa450edef68

JDK 5.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1328028 13f79535-47bb-0310-9956-ffa450edef68

#52829: ResourceCollection now Iterable<Resource>.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1326760 13f79535-47bb-0310-9956-ffa450edef68

  1. … 66 more files in changeset.
Switch to JDK 5 as baseline.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1326751 13f79535-47bb-0310-9956-ffa450edef68

https://builds.apache.org/pview/job/Ant-Build-Matrix/475/jdk=JDK%201.5%20(latest),label=Ubuntu/testReport/src.tests.antunit.taskdefs/hostinfo-test_xml/testApache/ src/tests/antunit/taskdefs/hostinfo-test.xml:53: Assertion failed https://builds.apache.org/pview/job/Ant-Build-Matrix/475/jdk=JDK%201.5%20(latest),label=Ubuntu/testReport/src.tests.antunit.taskdefs/hostinfo-test_xml/testApacheNoPrefix/ src/tests/antunit/taskdefs/hostinfo-test.xml:70: Expected 'eos' but was 'aurora-2012' From my Linux machine: $ host www.apache.org www.apache.org has address 140.211.11.131 www.apache.org has address 192.87.106.229 www.apache.org has IPv6 address 2001:610:1:80bc:192:87:106:229 www.apache.org mail is handled by 10 minotaur.apache.org. $ host 140.211.11.131 131.11.211.140.in-addr.arpa domain name pointer eos.apache.org. $ host 192.87.106.229 229.106.87.192.in-addr.arpa is an alias for 229.224.106.87.192.in-addr.arpa. 229.224.106.87.192.in-addr.arpa domain name pointer aurora-2012.apache.org.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1311532 13f79535-47bb-0310-9956-ffa450edef68

https://builds.apache.org/pview/job/Ant-Build-Matrix/475/jdk=JDK%201.5%20(latest),label=Ubuntu/testReport/junit/(root)/%3Cinit%3E/src_tests_antunit_taskdefs_import_url_test_xml/ .../src/tests/antunit/taskdefs/import-url-test.xml:74: The following error occurred while executing this line: .../src/tests/antunit/taskdefs/import-url-test.xml:48: java.lang.IllegalStateException: zip file closed at org.apache.tools.ant.ProjectHelper.addLocationToBuildException(ProjectHelper.java:551) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:395) at org.apache.tools.ant.taskdefs.CallTarget.execute(CallTarget.java:105) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:592) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) at org.apache.tools.ant.Task.perform(Task.java:348) at org.apache.tools.ant.Target.execute(Target.java:392) at org.apache.tools.ant.Target.performTasks(Target.java:413) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1399) at org.apache.tools.ant.Project.executeTarget(Project.java:1368) at org.apache.ant.antunit.AntUnitScriptRunner.runTarget(AntUnitScriptRunner.java:237) at org.apache.ant.antunit.AntUnitScriptRunner.runSuite(AntUnitScriptRunner.java:303) at org.apache.ant.antunit.AntUnit.doFile(AntUnit.java:268) at org.apache.ant.antunit.AntUnit.doResourceCollection(AntUnit.java:247) at org.apache.ant.antunit.AntUnit.execute(AntUnit.java:218) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:592) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) at org.apache.tools.ant.Task.perform(Task.java:348) at org.apache.tools.ant.Target.execute(Target.java:392) at org.apache.tools.ant.Target.performTasks(Target.java:413) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1399) at org.apache.tools.ant.Project.executeTarget(Project.java:1368) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1251) at org.apache.tools.ant.Main.runBuild(Main.java:811) at org.apache.tools.ant.Main.startAnt(Main.java:217) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) Caused by: .../src/tests/antunit/taskdefs/import-url-test.xml:48: java.lang.IllegalStateException: zip file closed at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:116) at org.apache.tools.ant.Task.perform(Task.java:348) at org.apache.tools.ant.Target.execute(Target.java:392) at org.apache.tools.ant.helper.ProjectHelper2.parse(ProjectHelper2.java:180) at org.apache.tools.ant.ProjectHelper.configureProject(ProjectHelper.java:82) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:393) ... 32 more Caused by: java.lang.IllegalStateException: zip file closed at java.util.zip.ZipFile.ensureOpen(ZipFile.java:518) at java.util.zip.ZipFile.getEntry(ZipFile.java:251) at java.util.jar.JarFile.getEntry(JarFile.java:204) at sun.net.www.protocol.jar.URLJarFile.getEntry(URLJarFile.java:90) at sun.net.www.protocol.jar.JarURLConnection.connect(JarURLConnection.java:112) at sun.net.www.protocol.jar.JarURLConnection.getInputStream(JarURLConnection.java:124) at com.sun.org.apache.xerces.internal.impl.XMLEntityManager.setupCurrentEntity(XMLEntityManager.java:973) at com.sun.org.apache.xerces.internal.impl.XMLVersionDetector.determineDocVersion(XMLVersionDetector.java:184) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:798) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:764) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:148) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1242) at org.apache.tools.ant.helper.ProjectHelper2.parse(ProjectHelper2.java:307) at org.apache.tools.ant.helper.ProjectHelper2.parse(ProjectHelper2.java:168) at org.apache.tools.ant.taskdefs.ImportTask.importResource(ImportTask.java:229) at org.apache.tools.ant.taskdefs.ImportTask.execute(ImportTask.java:163) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:592) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) ... 37 more

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1311527 13f79535-47bb-0310-9956-ffa450edef68

Indentation.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1297273 13f79535-47bb-0310-9956-ffa450edef68

Random failures in AntClassLoaderTest traceable to different jobs overwriting the same test.jar.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1297271 13f79535-47bb-0310-9956-ffa450edef68

Permit -Drun.junit.report=false (saved about three seconds off single test run).

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1297269 13f79535-47bb-0310-9956-ffa450edef68