Clone
 

eedy <cqlcqlc@gmail.com> in Trafodion

COMMENT-ON Bug fix : add escape quote regression test

1. add escape quote regression test

    • -8
    • +11
    /core/sql/regress/compGeneral/EXPECTED072
COMMENT-ON Bug fix : add escape quote support for single quote character in comment string.

1. fix error when single quote in comment string

2. add escape quote for SHOWDDL statement

fix potential result mismatch caused by result order

    • -46
    • +17
    /core/sql/regress/compGeneral/EXPECTED045
add regression test for new sub limit clauses

    • -1
    • +120
    /core/sql/regress/compGeneral/EXPECTED045
    • -0
    • +17
    /core/sql/regress/compGeneral/FILTER045
    • -2
    • +44
    /core/sql/regress/compGeneral/TEST045
add regression test for COMMENT-ON statement

    • -0
    • +1154
    /core/sql/regress/compGeneral/EXPECTED072
    • -0
    • +17
    /core/sql/regress/compGeneral/FILTER072
    • -0
    • +261
    /core/sql/regress/compGeneral/TEST072
    • -0
    • +20
    /core/sql/regress/compGeneral/TEST072.cpp
    • -0
    • +32
    /core/sql/regress/compGeneral/TEST072.java
add limit clause support for LOAD-INTO statement.

add limit clause support for LOAD-INTO statement.

add limit clause for insert-as-select statement

add limit clause for insert-as-select statement

new COMMENT-ON SQL statement: resolve merge conflict

1. resolve enum type conflict while merging to esgyn

    • -1
    • +1
    /core/sql/sqlcomp/CmpSeabaseDDLview.cpp
limit clause support in create-as-select/load-into-select: syntax support

1. add syntax support

new COMMENT-ON SQL statement: review change - error path

1. switch compile context in comment-on error path

2. correct spellings and others

    • -0
    • +1
    /core/sql/sqlcomp/CmpSeabaseDDLschema.cpp
    • -1
    • +1
    /core/sql/sqlcomp/CmpSeabaseDDLview.cpp
new COMMENT-ON SQL statement: review change - fix a error in new build-in view

1. fix a error in new build-in view

new COMMENT-ON SQL statement: review change - undo all MD changes

1. undo all MD changes since we have changed to use TEXT table to store

comments

    • -6
    • +5
    /core/sql/sqlcomp/CmpSeabaseDDLcommon.cpp
    • -1
    • +1
    /core/sql/sqlcomp/CmpSeabaseDDLschema.cpp
    • -4
    • +4
    /core/sql/sqlcomp/CmpSeabaseDDLtable.cpp
    • -15
    • +8
    /core/sql/sqlcomp/CmpSeabaseDDLupgrade.h
new COMMENT-ON SQL statement: review change - TEXT table modification

1. mv storage of COMMENTs in TEXT table

    • -31
    • +59
    /core/sql/sqlcomp/CmpSeabaseDDLcommentOn.cpp
    • -0
    • +13
    /core/sql/sqlcomp/CmpSeabaseDDLcommon.cpp
    • -6
    • +10
    /core/sql/sqlcomp/CmpSeabaseDDLmd.h
    • -1
    • +12
    /core/sql/sqlcomp/CmpSeabaseDDLschema.cpp
    • -2
    • +16
    /core/sql/sqlcomp/CmpSeabaseDDLtable.cpp
    • -0
    • +8
    /core/sql/sqlcomp/CmpSeabaseDDLview.cpp
new COMMENT-ON SQL statement: review change

1. handle return value of function getSeabaseObjectComment

2. add a new error code : 1033 - CAT_UNABLE_TO_RETRIEVE_COMMENTS

3. add showddl support for sequence comment

4. moved function getSeabaseObjectComment to file

CmpSeabaseDDLcommentOn.cpp

5. changed str_sprintf to sprintf

    • -1
    • +1
    /core/sql/sqlcomp/CmpDDLCatErrorCodes.h
    • -20
    • +60
    /core/sql/sqlcomp/CmpDescribe.cpp
    • -2
    • +118
    /core/sql/sqlcomp/CmpSeabaseDDLcommentOn.cpp
    • -1
    • +5
    /core/sql/sqlcomp/CmpSeabaseDDLschema.cpp
    • -116
    • +0
    /core/sql/sqlcomp/CmpSeabaseDDLtable.cpp
new COMMENT-ON SQL statement: review change - delete allocated spaces for function CmpSeabaseDDL::getSeabaseObjectComment

1. delete allocated COMMENT spaces after used.

    • -46
    • +65
    /core/sql/sqlcomp/CmpDescribe.cpp
    • -8
    • +6
    /core/sql/sqlcomp/CmpSeabaseDDLschema.cpp
    • -52
    • +30
    /core/sql/sqlcomp/CmpSeabaseDDLtable.cpp
new COMMENT-ON SQL statement: review change - add support for sequence and columns of view

1. add comment support for sequence generator

2. add comment support for columns of view

3. wrong comments and spellings

    • -22
    • +25
    /core/sql/sqlcomp/CmpSeabaseDDLcommentOn.cpp
    • -1
    • +1
    /core/sql/sqlcomp/CmpSeabaseDDLschema.cpp
    • -5
    • +5
    /core/sql/sqlcomp/CmpSeabaseDDLtable.cpp
new COMMENT-ON SQL statement: add COMMENT syntax support for sqlci

1. add COMMENT syntax support for sqlci

new COMMENT-ON SQL statement: fix showddl schema error

1. fix error while showddl schema with comment

    • -8
    • +9
    /core/sql/sqlcomp/CmpSeabaseDDLschema.cpp
new COMMENT-ON SQL statement: init

1. new SQL syntax: COMMENT ON

2. new component privilege: SQL_OPERATIONS::COMMENT

3. MD table changes: add new column for tables "_MD_".OBJECTS and

"_MD_".COLUMNS

4. SHOWDDL changes: add COMMENT-ON output for each object

5. new build-in views: "_MD_".OBJECT_COMMENT_VIEW and

"_MD_".COLUMN_COMMENT_VIEW

    • -0
    • +148
    /core/sql/parser/StmtDDLCommentOn.h
    • binary
    /core/sql/regress/privs1/EXPECTED133
    • -0
    • +14
    /core/sql/regress/privs1/EXPECTED137
    • -7
    • +152
    /core/sql/sqlcomp/CmpDescribe.cpp
  1. … 11 more files in changeset.