Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[NO ISSUE][COMP] Incorrect result with composite secondary index

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Secondary BTree index with composite key should not be chosen

if one of its key fields can be null or missing and

the query does not match all index expressions

Change-Id: Ia598df3d3fa879f8ebe5269fa1f295e1b890c8bf

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/5343

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

  1. … 36 more files in changeset.
[NO ISSUE][IDX][COMP] Creating an open index on non-declared fields

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

This patch is to fix creating an open index on non-declared fields.

When compiling the CREATE INDEX DDL statement, it is assumed

that all nested record fields will be of type ARecordType. However, for

open indexes, any nested non-declared record field will be optional.

In this case, the type will be AUnion(ARecordType) which results

in type casting exceptions for certain situations. An example is:

CREATE INDEX idx ON ds(a.b.c: int, a.b.d: string). Both a and b could

have the type AUnion(ARecordType). This patch takes care of such cases.

Change-Id: I9f09ed73f27090c5be7b1a665f4591b29a8cda12

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3045

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -0
    • +38
    ./non-enforced-composite-key/01.sqlpp
    • -0
    • +38
    ./non-enforced-composite-key/02.sqlpp
    • -0
    • +40
    ./non-enforced-composite-key/03.sqlpp
    • -0
    • +39
    ./non-enforced-composite-key/04.sqlpp
    • -0
    • +39
    ./non-enforced-composite-key/05.sqlpp
    • -0
    • +39
    ./non-enforced-composite-key/06.sqlpp
    • -0
    • +39
    ./non-enforced-composite-key/07.sqlpp
    • -0
    • +39
    ./non-enforced-composite-key/08.sqlpp
    • -0
    • +39
    ./non-enforced-composite-key/09.sqlpp
    • -0
    • +39
    ./non-enforced-composite-key/10.sqlpp
    • -0
    • +39
    ./non-enforced-composite-key/11.sqlpp
    • -0
    • +42
    ./non-enforced-composite-key/12.sqlpp
  1. … 90 more files in changeset.
Revert "[ASTERIXDB-2454] Remove non-unique AQL tests"

This reverts commit f372c96ddb3414e7f4f54b13059b065310157d65.

Change-Id: Ie8c4c9b50ed3daf528c75168b6d9c2d675cd04a5

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3001

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

  1. … 4537 more files in changeset.
[ASTERIXDB-2454] Remove non-unique AQL tests

Change-Id: I13f676e9322f8b94e8c9686b261e8752a7100722

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2979

Reviewed-by: Taewoo Kim <wangsaeu@gmail.com>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 4537 more files in changeset.
Fix open field CREATE INDEX syntax (AQL and SQLPP).

Our CREATE INDEX syntax for open fields didn't match our semantics.

Our semantics allow to-be-indexed open field(s) to be MISSING.

We don't support (or offer :-)) tighter semantics than that.

Our syntax didn't require creators to say this, but now it does:

Old: CREATE INDEX myIdx on MyDSet(myTime: datetime) ENFORCED;

New: CREATE INDEX myIdx on MyDSet(myTime: datetime?) ENFORCED;

Have now addressed all of Till's comments (I think).

Change-Id: I32bf8bc5ac1c0e6aa6744ca8f91a197311219814

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1106

Reviewed-by: Yingyi Bu <buyingyi@gmail.com>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 773 more files in changeset.