ant-ivy

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
tidy up the code

  1. … 14 more files in changeset.
another fail() that should be an expected exception; import assertions statically, too

rediscovered a couple of tests :-)

tidy up the code

    • -1
    • +1
    /test/java/org/apache/ivy/TestHelper.java
use switch rather than a chain of if’s

    • -13
    • +17
    /src/java/org/apache/ivy/ant/IvyBuildList.java
tersify logic ;->

simplify set construction

    • -2
    • +1
    /test/java/org/apache/ivy/MainTest.java
refactor tests with hardcoded Maven Central URL

showcase of parameterised tests with introspection :-) (requires hamcrest-library where Matchers dwell)

do not fail, assert

use expected exception and try-finally for post-mortem (until JUnit 5 ;-)

keep test parts as private as possible

chop extraneous throws, fix imports and javadoc

    • -6
    • +2
    /test/java/org/apache/ivy/ant/FileUtilTest.java
  1. … 39 more files in changeset.
Do not use try-catch-fail to re-throw exceptions in tests

  1. … 4 more files in changeset.
New URL for Maven Central

  1. … 4 more files in changeset.
IVY-511 coding conventions

    • -128
    • +128
    /test/java/org/apache/ivy/util/ConfiguratorTest.java
Checkstyle, continued

    • -14
    • +15
    /src/java/org/apache/ivy/util/FileUtil.java
    • -28
    • +35
    /test/java/org/apache/ivy/TestHelper.java
  1. … 25 more files in changeset.
Checkstyle

More uses of isNullOrEmpty/isEmpty

    • -3
    • +5
    /src/java/org/apache/ivy/ant/IvyBuildNumber.java
Entry -> Map.Entry

  1. … 7 more files in changeset.
StringBuffer -> StringBuilder

Check spelling

Refactor append()

FindBugs: deprecate static DateFormat

FindBugs: use native line breaks

FindBugs: make currentLockHolders final

FindBugs: iterate entry sets

    • -7
    • +5
    /src/java/org/apache/ivy/util/Configurator.java
IVY-309 refactor all those split-trim-join and unwrap some logic

    • -14
    • +5
    /src/java/org/apache/ivy/Ivy14.java
    • -1
    • +3
    /src/java/org/apache/ivy/ant/IvyAntSettings.java
    • -39
    • +42
    /src/java/org/apache/ivy/ant/IvyDeliver.java
    • -14
    • +18
    /src/java/org/apache/ivy/ant/IvyInstall.java
  1. … 52 more files in changeset.
Revert previous change