Checkout
lgo
committed
on 20 May 08
Fix issue #3137: use a consistent error code when a path is not found in the
repository. DAV uses a 404 status code to indicate missing pat… Show more
Fix issue #3137: use a consistent error code when a path is not found in the

repository. DAV uses a 404 status code to indicate missing paths, so we now

convert that code to SVN_ERR_FS_NOT_FOUND, as we do for ra_local and ra_svn.

As this is client side only, this patch also removes all instances were we

test for the now deprecated error code SVN_ERR_RA_DAV_PATH_NOT_FOUND.

* subversion/include/svn_error_codes.h

 (SVN_ERR_RA_DAV_PATH_NOT_FOUND): Deprecate error code.

* subversion/libsvn_ra_serf/ra_serf.h

 (svn_ra_serf__error_on_status): New function declaration.

* subversion/libsvn_ra_serf/util.c

 (svn_ra_serf__error_on_status): New function definition.

* subversion/libsvn_ra_serf/serf.c

 (svn_ra_serf__has_capability,

  svn_ra_serf__check_path,

  svn_ra_serf__stat): Use SVN_ERR_FS_NOT_FOUND error code here ..

* subversion/libsvn_ra_serf/util.c

 (svn_ra_serf__discover_root): .. and here.

* subversion/libsvn_ra_serf/mergeinfo.c

 (svn_ra_serf__get_mergeinfo): Use svn_ra_serf__error_on_status here ..

* subversion/libsvn_ra_serf/getlocationsegments.c

 (svn_ra_serf__get_location_segments): ..

* subversion/libsvn_ra_serf/blame.c

 (svn_ra_serf__get_file_revs): ..

* subversion/libsvn_ra_serf/update.c

 (handle_stream): ..

* subversion/libsvn_ra_serf/property.c

 (svn_ra_serf__wait_for_props): ..

* subversion/libsvn_ra_serf/getlocations.c

 (svn_ra_serf__get_locations): ..

* subversion/libsvn_ra_serf/commit.c

 (checkout_dir): .. and here.

 (checkout_dir, get_version_url): Use better error code.

 (checkout_file): Use svn_ra_serf__error_on_status and better error code.

* subversion/libsvn_ra_neon/props.c

 (svn_ra_neon__get_one_prop,

  svn_ra_neon__search_for_starting_props,

  svn_ra_neon__do_check_path,

  svn_ra_neon__do_stat): Use SVN_ERR_FS_NOT_FOUND error code here ..

* subversion/libsvn_ra_neon/get_locks.c

 (svn_ra_neon__get_locks): ..

* subversion/libsvn_ra_neon/util.c

 (generate_error): ..

* subversion/libsvn_ra_neon/commit.c

 (commit_add_file): .. and here.

* subversion/libsvn_ra_neon/session.c

 (svn_ra_neon__has_capability): Don't check for SVN_ERR_RA_DAV_PATH_NOT_FOUND.

* subversion/svn/mkdir-cmd.c

 (svn_cl__mkdir): Don't check for SVN_ERR_RA_DAV_PATH_NOT_FOUND.

* subversion/libsvn_client/merge.c

 (filter_self_referential_mergeinfo,

  calculate_remaining_ranges,

  get_mergeinfo_walk_cb): Don't check for SVN_ERR_RA_DAV_PATH_NOT_FOUND.

Show less