Checkout
stefan2
committed
on 02 Sep 15
[Reverted in r1700797 and re-applied as part of r1700799.]
Remove support for mark & seek from "buffered read" stream wrapper as it
was deem… Show more
[Reverted in r1700797 and re-applied as part of r1700799.]

Remove support for mark & seek from "buffered read" stream wrapper as it

was deemed to difficult to handle.  See also here:

http://mail-archives.apache.org/mod_mbox/subversion-dev/201509.mbox/%3CCAP_GPNjwhjD1Ds5%2ByYKiqr2NwzbhmnGq%3DqtB8jowBUJty7_Z3Q%40mail.gmail.com%3E

* subversion/include/svn_io.h

 (svn_stream_wrap_buffered_read): Remove all references to mark & seek

                                  other than saying we don't support them.

* subversion/libsvn_subr/stream.c

 (buffering_stream_wrapper_baton): Remove all elements used for mark & seek.

 (buffering_stream_wrapper_mark): Drop.

 (read_handler_buffering_wrapper): Simplify as we always exhaust the buffer

                                   and can completely discard it now.

 (decrement_mark_count,

  mark_handler_buffering_wrapper,

  seek_handler_buffering_wrapper,

  assert_zero_mark_count): Drop.

 (svn_stream_wrap_buffered_read): Update. Allocate the buffer only one and

                                  do that here.

* subversion/svnadmin/svnadmin.c

 (subcommand_load_revprops): Update API caller.

* subversion/svnfsfs/load-index-cmd.c

 (subcommand__load_index): Update API caller.

* subversion/tests/libsvn_subr/stream-test.c

 (test_stream_buffered_wrapper): Update API caller.

Show less