Checkout
Daniel Shahaf
committed
on 25 Feb 14
Fix accidentally-global variables.

[ Changes to libsvn_subr and named_atomic-test-common.h reverted in r1571500 ]

* configure.ac
(CMAINT… Show more
Fix accidentally-global variables.

[ Changes to libsvn_subr and named_atomic-test-common.h reverted in r1571500 ]

* configure.ac

 (CMAINTAINERFLAGS): Add -Wmissing-variable-declarations.

* subversion/libsvn_fs_fs/hotcopy.c

 (hotcopy_body_baton):

* subversion/libsvn_fs_x/hotcopy.c

 (hotcopy_body_baton):

* subversion/libsvn_repos/hooks.c

 (parse_hooks_env_option_baton, parse_hooks_env_section_baton):

* subversion/libsvn_wc/wc_db.c

 (struct op_delete_many_baton_t):

* subversion/svn/file-merge.c

 (struct file_merge_baton):

   Remove accidental declaration of global variables.

* subversion/libsvn_subr/ctype.c

 (svn_ctype_table_internal):

* subversion/svndumpfilter/svndumpfilter.c

 (filtering_vtable):

* subversion/svnserve/svnserve.c

 (connection_pools, threads):

* subversion/tests/libsvn_fs_x/string-table-test.c

 (basic_strings):

* subversion/tests/libsvn_subr/hashdump-test.c

 (proplist, new_proplist, review):

* subversion/tests/libsvn_subr/io-test.c

 (test_file_definitions_template):

* subversion/tests/libsvn_subr/named_atomic-test-common.h

 (name_namespace, name_namespace1, name_namespace2):

* subversion/tests/libsvn_subr/packed-data-test.c

 (sub_records, test_data_:

* subversion/tests/libsvn_subr/prefix-string-test.c

 (test_cases):

* subversion/tests/libsvn_subr/priority-queue-test.c

 (numbers, expected_modified):

* subversion/tests/libsvn_subr/string-test.c

 (phrase_1, phrase_2):

* subversion/tests/libsvn_subr/time-test.c

 (test_timestamp, test_timestring, test_old_timestring):

* subversion/tests/libsvn_subr/translate-test.c

 (base_origin_subtests):

* subversion/tests/svn_test_main.c

 (mode_filter):

   Make these variables file-static.

* subversion/tests/svn_test_main.c

 (test_argc, test_argv):

* tools/server-side/mod_dontdothat/mod_dontdothat.c

 (dontdothat_module):

   Make these variables truly global by also declaring them extern. Show less