Checkout Tools
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Following up on r1659509, extend the whitespace cleanup script to include

.sql and .sh files

* tools/dev/remove-trailing-whitespace.sh

Update script.

* autogen.sh

* subversion/libsvn_wc/wc-metadata.sql

* subversion/libsvn_wc/wc-queries.sql

* subversion/tests/cmdline/dav-mirror-autocheck.sh

* subversion/tests/cmdline/davautocheck.sh

* subversion/tests/cmdline/lock_tests.py

* tools/buildbot/slaves/i686-debian-sarge1/svnlog.sh

* tools/buildbot/slaves/svn-x64-centos/svnbuild.sh

* tools/buildbot/slaves/svn-x64-centos/svnlog.sh

* tools/buildbot/slaves/svn-x64-macosx-gnu-shared/svnlog.sh

* tools/buildbot/slaves/svn-x64-macosx-gnu-shared-daily-ra_serf/svnlog.sh

* tools/buildbot/slaves/ubuntu-x64/svnlog.sh

* tools/client-side/svn-ssl-fingerprints.sh

* tools/dev/benchmarks/large_dirs/create_bigdir.sh

* tools/dist/dist.sh

* tools/dist/nightly.sh

* tools/hook-scripts/mailer/tests/mailer-init.sh

* tools/po/po-update.sh

Apply whitespace cleanup.

  1. … 18 more files in changeset.
Remove bashism in mailer.py test suite

* mailer/tests/mailer-init.sh

Change echo -e to more portable printf

Patch by: Oleksandr Chumachenko <ledest@gmail.com>

Approved by: philip

Fix problems with the mailer.py test suite and fix mailer.py not showing

directories with property deletions as being modified.

When using svn.repos.replay() property deletions don't show up in the

returned changelist from editor.get_changes().items() since the

changed_dir_prop function on the delta editor never gets called. This

could be a bug in the Python bindings or our C code. Setting send_deltas

to true and calling svn.repos.replay2() resolves the problem.

Some of the failures were simply that the group output is in a different

order than it was in the file. I suspect that the order of output from

mailer.py is not determinate, so long term this test setup will likely

have to be rewritten.

* mailer/mailer.py

(Commit.__init__): Switch to using svn.repos.replay2() and pass 1 for

send_deltas.

* mailer/tests/mailer-init.sh

Use --force when setting the svn:new_svn_prop since we reject properties

starting with svn: when we don't know about them. Set the mime-type

when adding a binary file since we only check for binary files by the

mime-type.

* mailer/tests/mailer-t1.output

Reorder some of the output to match the generated output (at least for me)

  1. … 1 more file in changeset.
Add license headers where possible, or exclude the file in rat-excludes.

* build/config.guess : Added to rat-excludes

* build/config.sub : Added to rat-excludes

* subversion/bindings/swig/python/tests/trac/versioncontrol/__init__.py :

Added to rat-excludes

* subversion/tests/cmdline/dav-mirror-autocheck.sh : Added a License

* subversion/tests/cmdline/svntest/err.py Added to rat-excludes

* subversion/tests/manual/tree-conflicts-add-vs-add.py : Added a License

* tools/buildbot/master/public_html/buildbot.css : Added to rat-excludes

* tools/client-side/svn-ssl-fingerprints.sh : Added a License

* tools/dev/iz/defect.dem : Added to rat-excludes

* tools/dev/iz/ff2csv.command : Added to rat-excludes

* tools/dev/unix-build/Makefile.svn : Added a License

* tools/dev/wc-format.py : Added a License

* tools/dev/wc-ng/bump-to-19.py : Added a License

* tools/dev/wc-ng/populate-pristine.py : Added a License

* tools/dev/windows-build/Makefile : Added a License

* tools/dev/windows-build/document-version.pl : Added a License

* tools/examples/svnlog2html.rb : Added a License

* tools/hook-scripts/commit-email.rb : Added a License

* tools/hook-scripts/mailer/tests/mailer-t1.output : Added to rat-excludes

* tools/hook-scripts/mailer/tests/mailer.conf : Added a License

Approved by: rhuijben

  1. … 12 more files in changeset.
Extend "mailer.py" with an option "search_logmsg=REGEXP" to allow filtering

based on matching expressions in the log message such as bug id's.

Patch by: Justin Vallon <justin.vallon{_AT_}deshaw.com>

* tools/hook-scripts/mailer/mailer.conf.example

Add documentation and an example of the new configuration options.

* tools/hook-scripts/mailer/mailer.py

(Commit): Pass the log message to the which_groups() call.

(PropChange, Lock): Pass no log message to the which_groups() call.

(Config): Parse the new option and extend the which_groups() function

to include groups specified through matching the log message.

* tools/hook-scripts/mailer/tests/mailer.conf

(bugtracker): New section with the new configuration options.

* tools/hook-scripts/mailer/tests/mailer-init.sh

Put some example bug id's into some of the commit messages.

* tools/hook-scripts/mailer/tests/mailer-t1.output

Adjust for the additions and changes to the expected output.

  1. … 2 more files in changeset.
Apply ASF license headers to a number of files included under that license

but lacking said header.

Patch by: Niall Pemberton <niallp{_AT_}apache.org>

  1. … 173 more files in changeset.
Python 3 compatibility:

Update calls to print() in 'tools' directory.

* tools/backup/hot-backup.py.in:

* tools/bdb/erase-all-text-data.py:

* tools/bdb/svn-bdb-view.py:

* tools/bdb/whatis-rep.py:

* tools/client-side/change-svn-wc-format.py:

* tools/client-side/server-version.py:

* tools/dev/check-license.py:

* tools/dev/contribulyze.py:

* tools/dev/datecheck.py:

* tools/dev/gen-javahl-errors.py:

* tools/dev/graph-dav-servers.py:

* tools/dev/iz/ff2csv.py:

* tools/dev/iz/find-fix.py:

* tools/dev/mlpatch.py:

* tools/dev/normalize-dump.py:

* tools/dev/po-merge.py:

* tools/dev/random-commits.py:

* tools/dev/scramble-tree.py:

* tools/dev/svn-merge-revs.py:

* tools/dev/verify-history.py:

* tools/dev/which-error.py:

* tools/dist/gen_nightly_ann.py:

* tools/dist/getsigs.py:

* tools/dist/post-to-tigris.py:

* tools/dist/write-announcement.py:

* tools/examples/blame.py:

* tools/examples/check-modified.py:

* tools/examples/dumpprops.py:

* tools/examples/getfile.py:

* tools/examples/get-location-segments.py:

* tools/examples/geturl.py:

* tools/examples/putfile.py:

* tools/examples/revplist.py:

* tools/examples/svnlook.py:

* tools/examples/svnshell.py:

* tools/hook-scripts/mailer/tests/mailer-tweak.py:

* tools/hook-scripts/svn2feed.py:

* tools/po/l10n-report.py:

* tools/server-side/fsfs-reshard.py:

* tools/server-side/svn-backup-dumps.py: Call print() or file.write().

  1. … 39 more files in changeset.
Python 3 compatibility:

Use str.join() instead of string.join().

* build/generator/gen_base.py:

* build/generator/gen_make.py:

* build/generator/gen_vcnet_vcproj.py:

* build/generator/gen_win.py:

* build/generator/swig/header_wrappers.py:

* subversion/libsvn_subr/genctype.py:

* subversion/tests/cmdline/commit_tests.py:

* tools/dev/iz/find-fix.py:

* tools/examples/svnshell.py:

* tools/hook-scripts/mailer/mailer.py:

* tools/hook-scripts/mailer/tests/mailer-t1.sh: Use str.join() instead of

string.join().

  1. … 10 more files in changeset.
* build/buildcheck.sh:

* build/PrintPath:

* build/getversion.py:

* build/install-sh:

* subversion/tests/cmdline/svnadmin_tests.py:

* subversion/tests/cmdline/log_tests.py:

* subversion/tests/cmdline/trans_tests.py:

* subversion/tests/cmdline/svnlook_tests.py:

* subversion/tests/cmdline/switch_tests.py:

* subversion/tests/cmdline/externals_tests.py:

* subversion/tests/cmdline/diff_tests.py:

* subversion/tests/cmdline/copy_tests.py:

* subversion/tests/cmdline/stat_tests.py:

* subversion/tests/cmdline/svnversion_tests.py:

* subversion/tests/cmdline/prop_tests.py:

* subversion/tests/cmdline/basic_tests.py:

* subversion/tests/cmdline/update_tests.py:

* subversion/tests/cmdline/utf8_tests.py:

* subversion/tests/cmdline/commit_tests.py:

* subversion/tests/cmdline/schedule_tests.py:

* subversion/tests/cmdline/merge_tests.py:

* subversion/tests/cmdline/getopt_tests.py:

* contrib/client-side/svn_all_diffs.pl:

* contrib/client-side/search-svnlog.pl:

* contrib/client-side/svn_load_dirs/svn_load_dirs.pl.in:

* contrib/cgi/mirror_dir_through_svn.cgi:

* tools/client-side/showchange.pl:

* tools/dist/dist.sh:

* tools/hook-scripts/commit-access-control.pl.in:

* tools/hook-scripts/svnperms.py:

* tools/hook-scripts/mailer/mailer.py:

* tools/hook-scripts/mailer/tests/mailer-init.sh:

* tools/hook-scripts/mailer/tests/mailer-t1.sh:

* tools/hook-scripts/mailer/tests/mailer-tweak.py:

* tools/hook-scripts/commit-email.pl.in:

* tools/dev/stress.pl:

* tools/dev/gnuify-changelog.pl:

* tools/dev/prebuild-cleanup.sh:

* tools/examples/dumpprops.py:

* tools/examples/check-modified.py:

* tools/examples/svnlook.py:

* tools/examples/svnshell.py:

* tools/examples/geturl.py:

* tools/examples/putfile.py:

* tools/examples/revplist.py:

* tools/examples/getfile.py:

* tools/examples/blame.py:

* doc/tools/bin/run-fop.sh:

* autogen.sh:

* gen-make.py:

Set svn:executable property to "*".

  1. … 47 more files in changeset.
Revert property change diff feature code (r21695, r21684). I spoke

against this approach on the list back in September of 2006 (WHOA!),

and just now realized that it was still present in our trunk code.

As I indicated in discussion with Matthias Weinert <wein@mccw.de> (see

archives here: http://svn.haxx.se/dev/archive-2006-09/0978.shtml), I

like the idea of doing a better job of showing property changes, but

the approach taken was, in my opinion, far too complex for the typical

user's needs, and visually overwhelming.

NOTE: I tried this reversion once already and made a message things.

In r26779, I undid my mess and restored these files to their

state as of r26776. So, sadly, this is actually my *second*

attempt at cleanly reverting the propchange diff code.

NOTE: The mailer.py tests are currently failing, but this was the

case prior to this change, too. I suspect the merge tracking

feature changes in core Subversion have thrown things off a bit.

* tools/hook-scripts/mailer/mailer.py,

* tools/hook-scripts/mailer/tests/mailer-t1.output,

* tools/hook-scripts/mailer/tests/mailer.conf,

* tools/hook-scripts/mailer/mailer.conf.example

Remove property diff feature and supporting code.

  1. … 2 more files in changeset.
* tools/hook-scripts/mailer/mailer.py

* tools/hook-scripts/mailer/tests/mailer-t1.output

* tools/hook-scripts/mailer/tests/mailer.conf

* tools/hook-scripts/mailer/mailer.conf.example

Restore all these to the way they looked in r26776.

  1. … 2 more files in changeset.
[This change was later reverted, cleaned up, and recommitted; see r26780.]

Revert property change diff feature code (r21695, r21684). I spoke

against this approach on the list back in September of 2006 (WHOA!),

and just now realized that it was still present in our trunk code.

As I indicated in discussion with Matthias Weinert <wein@mccw.de> (see

archives here: http://svn.haxx.se/dev/archive-2006-09/0978.shtml), I

like the idea of doing a better job of showing property changes, but

the approach taken was, in my opinion, far too complex for the typical

user's needs, and visually overwhelming.

* tools/hook-scripts/mailer/mailer.py,

* tools/hook-scripts/mailer/tests/mailer-t1.output,

* tools/hook-scripts/mailer/tests/mailer.conf,

* tools/hook-scripts/mailer/mailer.conf.example

Remove property diff feature and supporting code.

  1. … 2 more files in changeset.
Some minor corrections regarding property handling in mailer.py's

commit messages.

* tools/hook-scripts/mailer/mailer.conf.example

Change default values of the property handling parameters

show_props, ignore_props, generate_propdiffs and ignore_propdiffs

to show no property changes summary, to show diffs for all property

changes and to not ignore any property names (and correct a typo).

* tools/hook-scripts/mailer/mailer.py

(DiffGenerator.__getitem__),

(PropDiffGenerator._get_diff):

Change format of the date of /dev/null

in diffs (which stands for empty/new files and properties).

(TextCommitRenderer._render_props):

Move adding of trailing '/' to directory paths out of a if clause

to ensure that it is applied for every property.

(TextCommitRenderer._render_propdiffs):

Use count variables instead of length of list to check if there are

properties to generate diffs for.

* tools/hook-scripts/mailer/tests/mailer.conf

Set show_props to an empty value for one group and correct a typo.

* tools/hook-scripts/mailer/tests/mailer-t1.output

Reflect changes in /dev/null date format in diffs and new show_props

value for on group in test output.

  1. … 2 more files in changeset.
Add property handling to mailer.py's commit messages.

It is now possible to also report changes of properties (including

diffs) with a commit message. Therefore several new classes were

added to mailer.py. To configure the reporting of property changes

four new parameters are added to mailer.conf. Without adding these

parameters to an existing configuration file no property changes

will be reported.

New configuration parameters:

show_props configure which property changes to report

(valid options are any combination of

'add_path add copy_path modify delete_path

delete')

ignore_props configure which property names shall be ignored

in the list of changed properties

generate_propdiffs configure for which property changes diffs

shall be created

(valid options are any combination of

'add_path add copy_path modify delete_path

delete')

ignore_propdiffs configure which property names shall be ignored

when creating diffs for changed properties

* tools/hook-scripts/mailer/mailer.py

New classes:

PropSelections

PropDiffSelections

PropDiffGenerator.

New functions:

TextCommitRenderer._get_prop_list

TextCommitRenderer._render_props

TextCommitRenderer.__render_props

TextCommitRenderer._render_propdiffs

TextCommitRenderer.__render_propdiffs.

Several appropriate changes to other classes and functions.

* tools/hook-scripts/mailer/mailer.conf.example

New parameters show_props, ignore_props, generate_propdiffs and

ignore_propdiffs.

* tools/hook-scripts/mailer/tests/mailer.conf

New parameters show_props, ignore_props, generate_propdiffs and

ignore_propdiffs.

* tools/hook-scripts/mailer/tests/mailer-t1.output

Now containing property changes.

  1. … 2 more files in changeset.
Enhance labels of diffs in mailer.py to contain more information and to

be of better use for patch programs:

- always show the according revision number in brackets after the date

- if available show date and time of the file

(e. g. for source of modified file)

- add more and specific hints about the file included in brackets after

the date (e. g. show special texts for copied files)

- use /dev/null and 00:00:00 1970 for empty files so that patch programs

recognize that the file is new/deleted

* tools/hook-scripts/mailer/mailer.py

(DiffGenerator.__getitem__):

Get date of base revision (if available) and enhance diff labels with

more information (as listed above).

(Repository.get_rev_prop):

Add optional second parameter to specify a revision for which the

revision property shall be fetched (default: current revision).

* tools/hook-scripts/mailer/tests/mailer-t1.output

Adjust to new diff labels.

  1. … 1 more file in changeset.
Improve output of mailer.py by removing carriage returns to avoid

duplicated line breaks and displaying 'Binary file (source and/or

target)' instead of 'Binary files' if a diff of two files contains

binary ones.

* tools/hook-scripts/mailer/mailer.py

(DiffContent.__getitem__):

Remove carriage returns (0x0D) from the line to avoid duplicated

line breaks.

(TextCommitRenderer._render_diffs):

- Immediately return if no diff is provided.

- If a diff contains binary files we don't know for sure if both are

binary or not, so display 'Binary file (source and/or target)'

instead of 'Binary files'.

* tools/hook-scripts/mailer/tests/mailer-t1.output

Now saying 'Binary file (source and/or target). No diff available.'

for diffs of two files where at least one file is binary.

  1. … 1 more file in changeset.
Cosmetic changes to mailer.py (and the conf file in the test directory).

* tools/hook-scripts/mailer/mailer.py

(Commit.__init__),

(DiffURLSelections._get_url):

Shorten lines which are too long.

(TextCommitRenderer._render_diffs):

Correct typo in comment for this function.

* tools/hook-scripts/mailer/tests/mailer.conf

Remove duplicate blank from comment for generate_diffs.

  1. … 1 more file in changeset.
Enhance test t1 for mailer.py by adding two additional configuration

groups with restricted for_path and show_nonmatching_paths set to 'no'

in one group.

* tools/hook-scripts/mailer/tests/mailer.conf

Add three groups to mailer.py configuration:

- [All] (replacing default)

- [file plus other areas] (for_paths = file.*)

- [file] (for_paths = file.* and show_nonmatching_paths = no)

* tools/hook-scripts/mailer/tests/mailer-t1.output

Adjust to new configuration groups.

Enhance test t1 for mailer.py:

- Add, copy, modify and delete properties

- Add and modify binary file

* tools/hook-scripts/mailer/tests/mailer-init.sh

Add commands which do add, copy, modify and delete properties

and add and modify a binary file.

* tools/hook-scripts/mailer/tests/mailer-t1.output

Adjust to new repository content/history.

Add support for replaced paths to mailer.py. These paths are now

reported as 'Replaced' and not as 'Added' any more.

* tools/hook-scripts/mailer/mailer.py

(generate_content):

Add separate lists for replaced paths.

(generate_list):

Add changekind 'R' for replaced paths.

(TextCommitRenderer.render):

Add rendering of lists of replaced paths.

* tools/hook-scripts/mailer/tests/mailer-t1.output

Replaced path in revision 7 now appears as 'Replaced' instead of

'Added'.

  1. … 1 more file in changeset.
Set property svn:eol-style to native for tools/hook-scripts/mailer/tests/mailer-t1.output to avoid problems with line ending styles.
Remove leading slashes in several paths in output from mailer.py.

* tools/hook-scripts/mailer.py

(remove_leading_slashes):

New global function to remove leading slashes from paths (strings).

(generate_list):

Apply remove_leading_slashes to base_path.

(DiffGenerator.__getitem__):

Apply remove_leading_slashes to several paths.

* tools/hook-scripts/mailer/tests/mailer-t1.output

Remove all leading slashes in paths.

  1. … 1 more file in changeset.
* tools/hook-scripts/mailer/tests/mailer.conf

Adopt the changes made to tools/hook-scripts/mailer/mailer.example.conf

in revisions 21153, 21310 and 21333.

Change the interpretation of the generate_diffs option in mailer.py.

'copy' now means 'path is copied and not changed afterwards' and

'modify' now means 'path is modified or a copy of another path that

was modified after copying'.

With this change 'modify' shows *all* modified paths whereas 'copy'

now allows to see diffs for copied paths (which is the whole path (file)

like it is for 'add').

* tools/hook-scripts/mailer/mailer.py

Interpret the values 'modify' and 'copy' of the generate_diffs option

as described above. Therefor introduce a new diff kind 'W' for paths

that were copied and modified afterwards.

* tools/hook-scripts/mailer/mailer.conf.example

- Add explanation of the possible values of the generate_diffs option

according to the change described above.

- Minor corrections in text.

* tools/hook-scripts/mailer/tests/mailer-t1.output

Reflect change described above.

  1. … 2 more files in changeset.
Replace implementation details and user visibility instances of

"remove" with "delete" in mailer.py. This is partially motivated by a

desire for consistency ("delete" is used more often than "remove"),

and partially to free up namespace of actions-beginning-with-R so that

support for showing "replaced" (that is, deleted and added anew) items

can be added later.

Patch by: Mathias Weinert <mathias.weinert@gfa-net.de>

* tools/hook-scripts/mailer/mailer.py

Replace several occurences of "remove" with "delete" as used in

variable names or script output; also replace the action code 'R' with 'D'.

* tools/hook-scripts/mailer/tests/mailer-t1.output

Reflect aforementioned mailer.py change in expected output.

  1. … 1 more file in changeset.
Trim trailing whitespace.

* tools/hook-scripts/mailer/mailer.conf.example,

* tools/hook-scripts/mailer/mailer.py,

* tools/hook-scripts/mailer/tests/mailer.conf:

Trim trailing whitespace.

  1. … 2 more files in changeset.
Make mailer-init.sh and mailer-t1.sh independent from calling directory.

* tools/hook-scripts/mailer/tests/mailer-init.sh

* tools/hook-scripts/mailer/tests/mailer-t1.sh

* tools/hook-scripts/mailer/tests/mailer-t1.output

update to current output of mailer.py.

Make diff of mailer.py's output more robust by doing additional

standardizations.

* tools/hook-scripts/mailer/tests/mailer-tweak.py:

do also tweak author to make output from mailer.py better comparable.

* tools/hook-scripts/mailer/tests/mailer-t1.sh:

Set time zone to GST to ensure that mailer.py everywhere reports the

same commit times.

Convert output from mailer.py to Unix EOL style to make the output

better comparable.

Add configuration file for mailer.py tests.

* tools/hook-scripts/mailer/tests/mailer.conf:

Add configuration file to ensure that mailer.py uses the expected

configuration.

* tools/hook-scripts/mailer/tests/mailer-t1.sh:

Use provided mailer.conf to ensure that expected configuration

options are used.