Checkout Tools
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Make the C tests work with the --enable-optimize configure option.

Because the main() function used to be defined in libsvn_test,

the -flto option (which performs rather aggressive link-time

optimizations) would cause the linker to remove all "unreferenced"

static functions ... which includes all the actual tests.

Which this change, main() is now defined in each test driver.

* subversion/tests/svn_test.h

(test_funcs, svn_test_max_threads): Remove external declarations.

(svn_test_main): New prototype for the (existing-but-renamed) test driver.

(SVN_TEST_MAIN): Bolierplate macro that generates a main() implementation.

* subversion/tests/svn_test_main.c

(svn_test_main): Renamed from 'main', and takes two extra parameters,

'max_threads' and 'test_funcs'. Propagates test_funcs to get_array_size,

do_test_num and do_tests_concurrently.

(get_array_size, do_test_num,

test_params_t, test_thread, do_tests_concurrently): Require a test_funcs

parameter. All uses updated.

* subversion/tests/libsvn_client/client-test.c,

subversion/tests/libsvn_client/mtcc-test.c,

subversion/tests/libsvn_delta/random-test.c,

subversion/tests/libsvn_delta/window-test.c,

subversion/tests/libsvn_diff/diff-diff3-test.c,

subversion/tests/libsvn_diff/parse-diff-test.c,

subversion/tests/libsvn_fs/fs-test.c,

subversion/tests/libsvn_fs/locks-test.c,

subversion/tests/libsvn_fs_base/

subversion/tests/libsvn_fs_base/changes-test.c,

subversion/tests/libsvn_fs_base/fs-base-test.c,

subversion/tests/libsvn_fs_base/strings-reps-test.c,

subversion/tests/libsvn_fs_fs/fs-fs-pack-test.c,

subversion/tests/libsvn_fs_x/fs-x-pack-test.c,

subversion/tests/libsvn_fs_x/string-table-test.c,

subversion/tests/libsvn_ra/ra-test.c,

subversion/tests/libsvn_ra_local/ra-local-test.c,

subversion/tests/libsvn_repos/repos-test.c,

subversion/tests/libsvn_subr/auth-test.c,

subversion/tests/libsvn_subr/cache-test.c,

subversion/tests/libsvn_subr/checksum-test.c,

subversion/tests/libsvn_subr/compat-test.c,

subversion/tests/libsvn_subr/config-test.c,

subversion/tests/libsvn_subr/crypto-test.c,

subversion/tests/libsvn_subr/dirent_uri-test.c,

subversion/tests/libsvn_subr/error-code-test.c,

subversion/tests/libsvn_subr/error-test.c,

subversion/tests/libsvn_subr/hashdump-test.c,

subversion/tests/libsvn_subr/io-test.c,

subversion/tests/libsvn_subr/mergeinfo-test.c,

subversion/tests/libsvn_subr/named_atomic-test.c,

subversion/tests/libsvn_subr/opt-test.c,

subversion/tests/libsvn_subr/packed-data-test.c,

subversion/tests/libsvn_subr/path-test.c,

subversion/tests/libsvn_subr/prefix-string-test.c,

subversion/tests/libsvn_subr/priority-queue-test.c,

subversion/tests/libsvn_subr/revision-test.c,

subversion/tests/libsvn_subr/root-pools-test.c,

subversion/tests/libsvn_subr/skel-test.c,

subversion/tests/libsvn_subr/spillbuf-test.c,

subversion/tests/libsvn_subr/sqlite-test.c,

subversion/tests/libsvn_subr/stream-test.c,

subversion/tests/libsvn_subr/string-test.c,

subversion/tests/libsvn_subr/subst_translate-test.c,

subversion/tests/libsvn_subr/time-test.c,

subversion/tests/libsvn_subr/translate-test.c,

subversion/tests/libsvn_subr/utf-test.c,

subversion/tests/libsvn_wc/conflict-data-test.c,

subversion/tests/libsvn_wc/db-test.c,

subversion/tests/libsvn_wc/entries-compat.c,

subversion/tests/libsvn_wc/op-depth-test.c,

subversion/tests/libsvn_wc/pristine-store-test.c,

subversion/tests/libsvn_wc/wc-queries-test.c,

subversion/tests/libsvn_wc/wc-test.c:

(max_threads): Renamed from svn_test_max_threads and made static.

(test_funcs): Made static.

(SVN_TEST_MAIN): Expanded boilerplate main() function.

  1. … 54 more files in changeset.
Fix accidentally-global variables.

[ Changes to libsvn_subr and named_atomic-test-common.h reverted in r1571500 ]

* configure.ac

(CMAINTAINERFLAGS): Add -Wmissing-variable-declarations.

* subversion/libsvn_fs_fs/hotcopy.c

(hotcopy_body_baton):

* subversion/libsvn_fs_x/hotcopy.c

(hotcopy_body_baton):

* subversion/libsvn_repos/hooks.c

(parse_hooks_env_option_baton, parse_hooks_env_section_baton):

* subversion/libsvn_wc/wc_db.c

(struct op_delete_many_baton_t):

* subversion/svn/file-merge.c

(struct file_merge_baton):

Remove accidental declaration of global variables.

* subversion/libsvn_subr/ctype.c

(svn_ctype_table_internal):

* subversion/svndumpfilter/svndumpfilter.c

(filtering_vtable):

* subversion/svnserve/svnserve.c

(connection_pools, threads):

* subversion/tests/libsvn_fs_x/string-table-test.c

(basic_strings):

* subversion/tests/libsvn_subr/hashdump-test.c

(proplist, new_proplist, review):

* subversion/tests/libsvn_subr/io-test.c

(test_file_definitions_template):

* subversion/tests/libsvn_subr/named_atomic-test-common.h

(name_namespace, name_namespace1, name_namespace2):

* subversion/tests/libsvn_subr/packed-data-test.c

(sub_records, test_data_:

* subversion/tests/libsvn_subr/prefix-string-test.c

(test_cases):

* subversion/tests/libsvn_subr/priority-queue-test.c

(numbers, expected_modified):

* subversion/tests/libsvn_subr/string-test.c

(phrase_1, phrase_2):

* subversion/tests/libsvn_subr/time-test.c

(test_timestamp, test_timestring, test_old_timestring):

* subversion/tests/libsvn_subr/translate-test.c

(base_origin_subtests):

* subversion/tests/svn_test_main.c

(mode_filter):

Make these variables file-static.

* subversion/tests/svn_test_main.c

(test_argc, test_argv):

* tools/server-side/mod_dontdothat/mod_dontdothat.c

(dontdothat_module):

Make these variables truly global by also declaring them extern.

  1. … 21 more files in changeset.
Add "--parallel" option to our C tests.

Besides shaving off a few seconds off our total test execution time,

parallel execution also stresses our code and the tests themselves

harder. It uncovers things like improperly separated working sets

that make post-failure analysis harder.

Parallel mode is only available with APR 1.3+ and threads enabled.

The option will simply be ignored in other configurations. Further

limitations are cleanups being delayed to after all tests completed

and segfaults not being intercepted.

Some tests can't be executed in parallel. Therefore, we introduce

svn_test_max_threads a simple upper limit to the number of threads

supported that each test must define alongside the test_funcs array.

This patch sets it to "1" in many cases because the tests are so

small that multi-threaded execution is simply not worth it.

* build/run_tests.py

(TestHarness._run_c_test): Pass --parallel option to the individual

test applications.

* subversion/tests/svn_test.h

(svn_test_max_threads): Declare new external setting to be set by

every test application.

* subversion/tests/svn_test_main.c

(parallel): New command line option presence flag.

(parallel_opt,

cl_options): Declare the new "--parallel" option.

(svn_test_add_dir_cleanup): Synchronize shared pool access since

this might be called from multiple

threads at the same time.

(log_results): Result logger function factored out from do_test_num

to be shared between serialized and parallel test

execution code.

(do_test_num): Use that new function.

(test_params_t,

test_thread,

do_tests_concurrently): Threads, their parameter and the thread

starter for thread-pooled test execution.

(main): Handle the new option.

Call concurrent execution when in PARALLEL mode.

* subversion/tests/libsvn_delta/random-test.c

subversion/tests/libsvn_subr/named_atomic-test.c

(svn_test_max_threads): These tests don't support concurrent execution.

* subversion/tests/libsvn_delta/random-test.c

subversion/tests/libsvn_delta/window-test.c

subversion/tests/libsvn_diff/parse-diff-test.c

subversion/tests/libsvn_ra_local/ra-local-test.c

subversion/tests/libsvn_ra/ra-test.c

subversion/tests/libsvn_subr/auth-test.c

subversion/tests/libsvn_subr/cache-test.c

subversion/tests/libsvn_subr/checksum-test.c

subversion/tests/libsvn_subr/compat-test.c

subversion/tests/libsvn_subr/config-test.c

subversion/tests/libsvn_subr/crypto-test.c

subversion/tests/libsvn_subr/dirent_uri-test.c

subversion/tests/libsvn_subr/error-code-test.c

subversion/tests/libsvn_subr/error-test.c

subversion/tests/libsvn_subr/hashdump-test.c

subversion/tests/libsvn_subr/mergeinfo-test.c

subversion/tests/libsvn_subr/named_atomic-test.c

subversion/tests/libsvn_subr/opt-test.c

subversion/tests/libsvn_subr/packed-data-test.c

subversion/tests/libsvn_subr/path-test.c

subversion/tests/libsvn_subr/prefix-string-test.c

subversion/tests/libsvn_subr/priority-queue-test.c

subversion/tests/libsvn_subr/revision-test.c

subversion/tests/libsvn_subr/root-pools-test.c

subversion/tests/libsvn_subr/skel-test.c

subversion/tests/libsvn_subr/spillbuf-test.c

subversion/tests/libsvn_subr/sqlite-test.c

subversion/tests/libsvn_subr/stream-test.c

subversion/tests/libsvn_subr/string-test.c

subversion/tests/libsvn_subr/subst_translate-test.c

subversion/tests/libsvn_subr/time-test.c

subversion/tests/libsvn_subr/utf-test.c

subversion/tests/libsvn_wc/conflict-data-test.c

subversion/tests/libsvn_wc/wc-queries-test.c:

(svn_test_max_threads): These are too small to benefit from multi-threading.

* subversion/tests/libsvn_client/client-test.c

subversion/tests/libsvn_diff/diff-diff3-test.c

subversion/tests/libsvn_fs_base/changes-test.c

subversion/tests/libsvn_fs_base/fs-base-test.c

subversion/tests/libsvn_fs_base/strings-reps-test.c

subversion/tests/libsvn_fs_fs/fs-fs-pack-test.c

subversion/tests/libsvn_fs/fs-test.c

subversion/tests/libsvn_fs/locks-test.c

subversion/tests/libsvn_fs_x/fs-x-pack-test.c

subversion/tests/libsvn_fs_x/string-table-test.c

subversion/tests/libsvn_repos/repos-test.c

subversion/tests/libsvn_subr/io-test.c

subversion/tests/libsvn_subr/translate-test.c

subversion/tests/libsvn_wc/db-test.c

subversion/tests/libsvn_wc/op-depth-test.c

subversion/tests/libsvn_wc/wc-test.c

(svn_test_max_threads): Set concurrency limit to whatever various test

runs suggested as the most efficient value.

* subversion/tests/libsvn_wc/entries-compat.c

subversion/tests/libsvn_wc/pristine-store-test.c

(svn_test_max_threads): Set concurrency limit to "unbounded".

  1. … 54 more files in changeset.
Test out my new and fancy ASF commit priviledges by changing the copyright

wording in our license headers to reflect ownership by the ASF.

* NOTICE:

Change terminology to ASF, and update a link.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the ASF, and update the project website.

* everywhere:

Change license text to reflect ASF ownership.

  1. … 891 more files in changeset.
Relicense Subversion under the Apache License, Version 2.0.

* NOTICE: New.

* LICENSE: New.

* COPYING,

subversion/LICENSE: Remove.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the SVN Corp, and that it contains contributions from

many people, as referenced in NOTICE.

* subversion/bindings/swig/python/LICENSE_FOR_PYTHON_BINDINGS:

Relicense the SVN parts under Apache 2.0.

* everywhere:

Change copyright notices in file headers to reflect the Apache 2.0 license.

  1. … 882 more files in changeset.
Replace deprecated test func macros in the C tests. This eliminates the need

to do the following dance in every test function:

*msg = "foo";

if (msg_only)

return SVN_NO_ERROR;

This does not remove the deprecated symbols from svn_test.h; I plan to do it

in a follow up commit.

[ in subversion/tests ]

* libsvn_client/client-test.c,

libsvn_delta/random-test.c,

libsvn_delta/range-index-test.h,

libsvn_delta/window-test.c,

libsvn_diff/diff-diff3-test.c,

libsvn_diff/parse-diff-test.c,

libsvn_fs/fs-test.c,

libsvn_fs/locks-test.c,

libsvn_fs_base/changes-test.c,

libsvn_fs_base/fs-base-test.c,

libsvn_fs_base/key-test.c,

libsvn_fs_base/strings-reps-test.c,

libsvn_fs_fs/fs-pack-test.c,

libsvn_ra_local/ra-local-test.c,

libsvn_repos/repos-test.c,

libsvn_subr/auth-test.c,

libsvn_subr/cache-test.c,

libsvn_subr/checksum-test.c,

libsvn_subr/compat-test.c,

libsvn_subr/config-test.c,

libsvn_subr/dirent_uri-test.c,

libsvn_subr/error-test.c,

libsvn_subr/hashdump-test.c,

libsvn_subr/mergeinfo-test.c,

libsvn_subr/opt-test.c,

libsvn_subr/path-test.c,

libsvn_subr/revision-test.c,

libsvn_subr/skel-test.c,

libsvn_subr/stream-test.c,

libsvn_subr/string-test.c,

libsvn_subr/target-test.c,

libsvn_subr/time-test.c,

libsvn_subr/translate-test.c,

libsvn_subr/utf-test.c,

libsvn_wc/tree-conflict-data-test.c:

Do the above described transformation.

  1. … 34 more files in changeset.
Channeling Erik Hülsmann, remove all trailing whitespace within our source

tree:

for extsn in c h cpp java py pl rb; do

sed -i -e 's/[ \t]*$//' `find . -name "*.$extsn" | xargs grep '[ \t]$' -l`

done

Inspired by: ehu

  1. … 449 more files in changeset.
Reformat the code to use a consistent no-space-before-param-list-paren style.

See here for the vote that decided this:

http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=111877

From: "Peter N. Lundblad" <peter@famlundblad.se>

To: "Peter N. Lundblad" <peter@famlundblad.se>

cc: dev@subversion.tigris.org

Subject: Results of: [VOTE] New space-before-parens style

Date: Wed, 8 Feb 2006 12:00:35 +0100 (CET)

Message-ID: <Pine.LNX.4.55.0602080918350.10805@localhost.localdomain>

I took the opportunity to make spacing among all parens in SVN_ERR

macro calls consistent. But I did not address consistency of casts,

nor whether a function name should always appear below its return type

in declarations and definitions, nor whether there should be a space

before/after the "*" when declaring pointer return types.

* www/hacking.html

(coding-style): Document that we are no-space-before-paren now.

* everywhere: Reformat.

  1. … 365 more files in changeset.
Allow date inputs without leading zeros, for convenience.

Disallow zero as a day-of-month number.

Patch by: Christopher Ness <chris@nesser.org>

* subversion/libsvn_subr/date.c: Don't require leading zeros in the Month,

Day and Hour for templates which have separators.

Check to make sure the day is not less than 1.

* subversion/tests/libsvn_subr/time-test.c: Add tests to verify the changes.

  1. … 1 more file in changeset.
Reorganization of the C test libraries and includes.

Move the misplaced svn_test.h file out of subversion/include/.

Merge libsvn_test_fs into libsvn_test.

* build.conf (libsvn_test): Tweak sources and libs, merging in values from

libsvn_test_fs.

(libsvn_test_fs): Remove.

* subversion/include/svn_test.h: Move...

* subversion/tests/svn_test.h: ...to here.

* subversion/tests/fs-helpers.c: Rename...

* subversion/tests/svn_test_fs.c: ...to this.

* subversion/tests/fs-helpers.h: Rename...

* subversion/tests/svn_test_fs.h: ...to this.

* subversion/tests/svn_tests_main.c: Rename...

* subversion/tests/svn_test_main.c: ...to this.

* subversion/tests/libsvn_delta/random-test.c:

* subversion/tests/libsvn_diff/diff-diff3-test.c:

* subversion/tests/libsvn_fs/locks-test.c:

* subversion/tests/libsvn_fs_base/changes-test.c:

* subversion/tests/libsvn_fs_base/fs-test.c:

* subversion/tests/libsvn_fs_base/key-test.c:

* subversion/tests/libsvn_fs_base/skel-test.c:

* subversion/tests/libsvn_fs_base/strings-reps-test.c:

* subversion/tests/libsvn_ra_local/ra-local-test.c:

* subversion/tests/libsvn_repos/dir-delta-editor.c:

* subversion/tests/libsvn_repos/repos-test.c:

* subversion/tests/libsvn_subr/compat-test.c:

* subversion/tests/libsvn_subr/config-test.c:

* subversion/tests/libsvn_subr/hashdump-test.c:

* subversion/tests/libsvn_subr/opt-test.c:

* subversion/tests/libsvn_subr/path-test.c:

* subversion/tests/libsvn_subr/stream-test.c:

* subversion/tests/libsvn_subr/string-test.c:

* subversion/tests/libsvn_subr/time-test.c:

* subversion/tests/libsvn_subr/utf-test.c:

* subversion/tests/libsvn_wc/translate-test.c:

Change #includes appropriately.

  1. … 29 more files in changeset.
Merge locking branch to trunk, by comparing trunkURL with branchURL.

This is not a test. This is an actual addition of a very large feature.

This merge passes 'make check' over all three RA implementations.

To see commit logs for this feature, examine /branches/locking, r11749:13570.

  1. … 183 more files in changeset.
* subversion/tests/libsvn_subr/time-test.c

(test_time_from_cstring_old): Clear expected errors.

Fix security bug in svn_time_from_cstring().

Bug found by: Stefan Esser <s.esser@e-matters.de>

Patch is also based upon his work.

Details at: http://security.e-matters.de/advisories/082004.html

This issue is known as CAN-2004-0397 at http://cve.mitre.org/

* subversion/libsvn_subr/time.c

(old_timestamp_format): %s should always have a length specified when

used with sscanf.

* subversion/tests/libsvn_subr/time-test.c

Add regression test for security bug in svn_time_from_cstring().

  1. … 1 more file in changeset.
Wrap (most) overly long lines in subversion/ tree

  1. … 43 more files in changeset.
Avoid conflicting with a builtin name in the C99 library:

* subversion/tests/libsvn_subr/time-test.c

(compare_results, test_parse_date): Use 'expt' instead of 'expl'.

* subversion/libsvn_subr/date.c

(template_match, svn_parse_date): Use 'expt' instead of 'expl'.

Thanks to Philip Martin.

  1. … 1 more file in changeset.
Remove the getdate.y-based date-parser, replacing it with a simpler

though less powerful one. This change includes improvements based on

suggestions from Branko Čibej, Karl Fogel, and Philip Martin. The

original patch was provided by C. Scott Ananian <cscott@cscott.net>,

the final change is the result of collaboration between Greg Hudson

and Mark Benedetto King. See 1.0-cand issue #408.

Patch by: C. Scott Ananian <cscott@cscott.net>

(See above for details.)

[Note: The three file adds/deletes immediately below should have

happened in this revision, but were committed in r8328 instead,

because I forgot that 'patch', unlike 'svn merge', doesn't do tree

changes.]

* subversion/libsvn_subr/date.c: New file.

* subversion/libsvn_subr/getdate.y: Deleted.

* subversion/libsvn_subr/getdate.cw: Deleted.

* subversion/include/svn_time.h:

(struct getdate_time): Removed.

(svn_parse_date): Update prototype and documentation comment to reflect

the new interface.

* subversion/tests/libsvn_subr/time-test.c (test_parse_date):

Date-parsing tests added.

* subversion/libsvn_subr/opt.c

(parse_one_rev): Add pool parameter, and use the new svn_parse_date

interface.

(svn_opt_parse_revision): Pass pool into parse_one_rev().

* autogen.sh:

Remove generation of getdate.c from getdate.y.

* doc/book/REVIEW: Add notes for fitz on updating ch03 and ch09.

* INSTALL:

Remove bison/yacc dependency, renumber subsequent dependencies.

* build/win32/svn_config.dsp, build/win32/svn_config.vcproj:

build/generator/gen_win.py (__init__):

Remove special-case handling of getdate.c.

* subversion/bindings/swig/core.i:

Remove "struct getdate_time" verbiage.

* packages/rpm/mandrake-9.0/subversion.spec,

packages/rpm/mandrake-9.1/subversion.spec,

packages/rpm/mandrake-9.2/subversion.spec:

Remove dependency on bison and flex. (We've never depended on flex.)

  1. … 12 more files in changeset.
Update copyright notices for 2004, resolving issue #1651.

(See also revision 8019, which fixed a couple of missed spots.)

  1. … 361 more files in changeset.
More pickiness from the C-Mike regarding test strings.

* subversion/tests/clients/cmdline/svntest/testcase.py

(TestCase._check_name): Disallow test strings that are capitalized.

* subversion/tests/svn_tests_main.c

(do_test_num): Do the same nifty test-string validation for the C

tests that we do for the Python tests (50 characters or fewer, no

terminating periods, no capitalized first characters, please).

* subversion/tests/libsvn_diff/diff-diff3-test.c

* subversion/tests/libsvn_subr/time-test.c

* subversion/tests/libsvn_wc/translate-test.c

* subversion/tests/libsvn_fs/strings-reps-test.c

* subversion/tests/libsvn_fs/fs-test.c

* subversion/tests/libsvn_repos/repos-test.c

Cleanup test descriptions.

  1. … 7 more files in changeset.
* Just about everything else that wasn't test output, a binary file,

or already to set to CRLF: Set svn:eol-style to native.

  1. … 658 more files in changeset.
Touch every file in the repository :) 2003 is here, update all the

copyright statements. Also, update the sample `svn --version' output

to be consistent with the current client.

  1. … 443 more files in changeset.
Remove src_err field of errors; it wasn't getting enough use to

justify its existence. (And it was getting used inconsistently.)

* include/svn_error.h, libsvn_subr/error.c

(svn_error_create, svn_error_createf): Remove src_err argument. All

call sites changed.

* include/svn_types.h (svn_error_t): Remove src_err field.

* include/svn_error_codes.h, libsvn_fs/err.c, libsvn_fs/trail.c

(SVN_ERR_FS_BERKELEY_DEADLOCK): New error code for deadlocks.

(db_err_to_apr_err): New helper function to decide when to use

new error code.

(svn_fs__dberr, svn_fs__dberrf): Return new apr error code for

deadlocks.

(svn_fs__retry_txn): Check for new apr error code instead of

checking src_err. Don't leak error memory when aborting trail.

  1. … 140 more files in changeset.
More nts to cstring cleanup.

* subversion/tests/clients/cmdline/basic_tests.py (nonexistent_repository):

Replace svn_path_is_empty_nts with svn_path_is_empty.

Replace svn_path_empty with svn_path_is_empty.

* subversion/tests/libsvn_subr/time-test.c (test_time_invariant):

Replace svn_time_to_nts with svn_time_to_cstring.

* tools/examples/svnlook.py (cmd_date):

Replace util.svn_time_from_nts with util.svn_time_from_cstring.

* tools/examples/svnshell.py (_format_date):

Replace util.svn_time_from_nts with util.svn_time_from_cstring.

  1. … 3 more files in changeset.
Rename _nts to _cstring, to make our API terminology consistent.

* include/svn_time.h, libsvn_subr/time.c

(svn_time_to_nts, svn_time_from_nts, svn_time_to_human_nts): Rename.

* include/svn_xml.h, libsvn_subr/xml.c

(svn_xml_escape_cstring, svn_xml_unescape_cstring): Rename.

All call sites changed for above renames.

  1. … 24 more files in changeset.
Just be glad you're not updating over libsvn_ra_pigeons...

* everywhere: Remove "local variables:" eval blocks.

* subversion/libsvn_repos/hooks.c: But leave the vim stuff here.

* tools/dev/svn-dev.el, doc/book/tools/svnbook.el:

Get rid of obsolete loading instructions.

* HACKING: Describe how to load the elisp files from .emacs.

* doc/book/HACKING: Add querulous comment.

  1. … 338 more files in changeset.
Simplify error interface by allocating errors in a subpool of the

global pool, since they must be freed explicitly anyway.

* libsvn_subr/svn_error.c: Split into error.c and pool.c, since errors

are no longer especially related to pools. (And since svn_error.c

was an anachronistic name.)

* include/svn_error.h, libsvn_subr/error.c

(svn_error_create, svn_error_createf, svn_error_clear): Remove pool

argument. Allocate errors in a subpool of the global pool. All

call sites changed. Also, collect file and line information in

all cases; it's useful for debugging with gdb even if we don't

display it.

(svn_error_clear_all): Replace with svn_error_clear. All call sites

changed.

(svn_error_init_error_pool, svn_error__set_error_pool,

svn_error__get_error_pool): Remove.

* libsvn_subr/pool.c

(svn_pool__inherit_error_pool): Remove.

(svn_pool_create, svn_pool_clear): Remove all the error pool stuff.

Use SVN_POOL_ROOTED_HERE to distinguish the top-level svn pool so

we can reallocate the allocator mutex on clear. Abort with

abort(), not abort_on_pool_failure().

* libsvn_fs/tree.c (conflict_err),

libsvn_fs/fs_skels.c (skel_err),

libsvn_fs/err.c, libsvn_fs/err.h (svn_fs__dberr, svn_fs__dberrf),

libsvn_repos/load.c (stream_ran_dry, stream_malformed),

libsvn_repos/commit.c (out_of_date),

libsvn_repos/delta.c (not_a_dir_error),

libsvn_delta/svndiff.c (count_and_verify_instructions),

libsvn_ra_dav/ra_dav.h, libsvn_ra_dav/util.c (svn_ra_dav__convert_error),

tests/libsvn_fs/fs-test.c (check_no_fs_error, verify_entry),

tests/libsvn_subr/hashdump-test.c (check),

tests/libsvn_delta/random-test.c (compare_files):

Remove pool argument. All call sites changed.

* mod_dav_svn/mod_dav_svn.c (dav_svn_header_parser): Remove; no need

to init error pool now.

* mod_dav_svn/repos.c (dav_svn_get_resource): No need to init error

pool now.

* libsvn_ra_dav/commit.c (put_baton_t): Don't need pool field any more.

* libsvn_ra_dav/util.c (parser_ctx_t): Don't need pool field any more,

and since this gets us down to just an svn_error_t *, just use an

svn_error_t **. All usage sites changed accordingly.

  1. … 137 more files in changeset.
Add XFAIL support to the C testing framework.

* subversion/include/svn_test.h (svn_test_driver_t, svn_test_descriptor_t,

test_funcs, SVN_TEST_NULL, SVN_TEST_PASS, SVN_TEST_XFAIL): New declarations.

(svn_test_rand): Moved here from subversion/tests/svn_tests.h.

* subversion/tests/svn_tests.h: Removed, all uses changed to use

subversion/include/svn_test.h instead.

* subversion/tests/svn_tests_main.c: (test_funcs): Removed, use

declaration from header.

(do_test_num): Change msg_only and test output, and return code to match

that of the Python tests, and add support for XFAIL.

* subversion/tests/libsvn_fs/key-test.c,

subversion/tests/libsvn_fs/fs-test.c,

subversion/tests/libsvn_fs/changes-test.c,

subversion/tests/libsvn_fs/skel-test.c,

subversion/tests/libsvn_fs/strings-reps-test.c,

subversion/tests/libsvn_wc/translate-test.c,

subversion/tests/libsvn_subr/stringtest.c,

subversion/tests/libsvn_subr/hashdump-test.c,

subversion/tests/libsvn_subr/path-test.c,

subversion/tests/libsvn_subr/time-test.c,

subversion/tests/libsvn_ra_local/ra-local-test.c,

subversion/tests/libsvn_repos/repos-test.c,

subversion/tests/libsvn_delta/deltaparse-test.c,

subversion/tests/libsvn_delta/random-test.c: Update the implementation

of the test_funcs array, include "svn_test.h" where necessary, and remove

all references to subversion/tests/svn_tests.h.

* subversion/tests/libsvn_fs/fs-test.c (link_test): Mark as XFAIL.

  1. … 16 more files in changeset.
Generate ISO-8601 dates to the repository from now on. Also canonize

dates on 'svnadmin dump'. The new repository datestamps look like this:

2002-06-22T09:14:58.030390Z

* subversion/libsvn_subr/time.c

(svn_time_to_nts): Generate new style timestamps.

* subversion/tests/libsvn_subr/time-test.c

(test_time_to_nts): Enable the test.

(test_funcs): Ditto.

* subversion/libsvn_repos/dump.c: Include svn_time.h.

(write_revision_record): Canonize dates.

  1. … 2 more files in changeset.
Make svn_time_from_nts return an error instead of the value

directly. Also a minor fix to keep svn_time_from_nts from crashing if

bad dates are given in.

* subversion/include/svn_time.h

(svn_time_from_nts): Changed interface to return an error.

* subversion/include/svn_error_codes.h

(SVN_ERR_BAD_DATE): New error code.

* subversion/libsvn_subr/time.c

(svn_time_from_nts): Adapted to return an error.

(find_matching_string): Added size argument for max size. No longer

crashes if a string cannot be found.

* subversion/libsvn_repos/rev_hunt.c

(get_time): Adapt for svn_time_from_nts returning an error.

* subversion/tests/libsvn_subr/time-test.c (test_time_from_nts): Ditto.

(test_time_from_nts_old): Ditto.

(test_time_invariant): Ditto.

* subversion/tests/libsvn_fs/fs-test.c (commit_date): Ditto.

* subversion/svnlook/main.c (do_date): Ditto.

* subversion/libsvn_wc/update_editor.c (change_dir_prop): Ditto.

* subversion/libsvn_wc/entries.c (svn_wc__atts_to_entry): Ditto.

* subversion/libsvn_wc/questions.c (svn_wc__timestamps_equal_p): Ditto.

(svn_wc__timestamps_equal_p): Commented out time to string and back

conversion.

  1. … 9 more files in changeset.
* subversion/tests/libsvn_subr/time-test.c

(test_time_to_nts): Temporarily comment this out, as it's generating

unused-function warnings.

* subversion/ac-helpers/find_apr.m4,

subversion/ac-helpers/find_apu.m4: Update to latest revisions from

the cvs trees (1.13 and 1.6 respectively).

  1. … 2 more files in changeset.
This is the first part of the changes for issue 614, eg. to make svn

use ISO-8601 timestamps.

It makes svn_time_from_nts understand a new style of timestamps,

roughly looking like this:

2002-05-13T19:00:50.966679Z

For now, the code still generates old style timestamps, but that is to

be fixed after the next tarball is out.

This change should be completely non-intrusive - you should see no

change in behaviour. The only change which possibly might bite is the

change of using apr_time_exp_gmt instead of apr_time_exp_lt - but that

should not matter if APR has no bugs.

* subversion/libsvn_subr/time.c (timestamp_format): Change format to

the new format.

(old_timestamp_format): New variable.

(svn_time_to_nts): Use apr_time_exp_gmt to get the time in GMT.

Add commented version for printing the new format, but use the old

format still.

(svn_time_from_nts): Make it understand both new and old formats.

* subversion/tests/libsvn_subr/time-test.c: New file, tests for the

time conversion functions, both new and old format.

* build.conf (time-test): Added building of the new test.

  1. … 3 more files in changeset.