Checkout Tools
  • last updated 8 hours ago
Constraints: committers
Constraints: files
Constraints: dates

Changeset 1536307 is being indexed.

Introduce a null-pointer constant that we can use as a termination sentinel

in variable argument lists. This avoids the ugliness of writing

"(char *) NULL" all over the place.

* subversion/include/svn_types.h (SVN_VA_NULL): New symbol.

* subversion/include/svn_dirent_uri.h (svn_dirent_join_many),

subversion/include/svn_path.h (svn_path_join_many),

subversion/include/svn_xml.h (svn_xml_make_open_tag):

Update docstrings, mentioning SVN_VA_NULL as the argument list terminator.

[Lots of implementation files]: Replace typecast-NULL with SVN_VA_NULL in

function calls with variable argument lists.

  1. … 89 more files in changeset.
Cast NULL to (char *) in vararg calls to svn_dirent_join_many

and svn_path_join_many.

* subversion/libsvn_fs_fs/lock.c

(digest_path_from_digest, digest_path_from_path): here

* subversion/libsvn_fs_fs/transaction.c

(create_txn_dir, create_txn_dir_pre_1_5): here

* subversion/libsvn_fs_fs/util.c

(svn_fs_fs__path_rev_packed, svn_fs_fs__path_rev_shard,

svn_fs_fs__path_rev, svn_fs_fs__path_revprops_shard,

svn_fs_fs__path_revprops_pack_shard, svn_fs_fs__path_revprops,

svn_fs_fs__path_txn_dir, svn_fs_fs__path_txn_proto_rev,

svn_fs_fs__path_txn_proto_rev_lock, svn_fs_fs__path_node_origin): here

* subversion/libsvn_fs_x/lock.c

(digest_path_from_digest, digest_path_from_path): here

* subversion/libsvn_fs_x/transaction.c

(create_txn_dir): here

* subversion/libsvn_fs_x/util.c

(svn_fs_x__path_rev_packed, svn_fs_x__path_rev_shard,



svn_fs_x__path_txn_dir, svn_fs_x__path_txn_proto_rev,

svn_fs_x__path_txn_proto_rev_lock, svn_fs_x__path_node_origin): here

* subversion/libsvn_subr/config_file.c

(svn_config__sys_config_path, svn_config_get_user_config_path): here

* subversion/libsvn_wc/adm_files.c

(svn_wc__adm_child): here

* subversion/libsvn_wc/upgrade.c

(build_lockfile_path, bump_to_29): here

* subversion/libsvn_wc/wc_db.c

(svn_wc__db_temp_wcroot_tempdir): here

* subversion/libsvn_wc/wc_db_pristine.c

(get_pristine_fname): here

* subversion/mod_authz_svn/mod_authz_svn.c

(get_access_conf): here

* subversion/tests/cmdline/entries-dump.c

(entries_dump): here

* subversion/tests/libsvn_client/client-test.c

(test_patch): here

* subversion/tests/libsvn_fs_fs/fs-fs-pack-test.c

(pack_filesystem, pack_even_filesystem, recover_fully_packed): here

* subversion/tests/libsvn_fs_x/fs-x-pack-test.c

(pack_filesystem, pack_even_filesystem, recover_fully_packed): here

* subversion/tests/libsvn_subr/dirent_uri-test.c

(test_dirent_join): here

* subversion/tests/libsvn_subr/path-test.c

(test_path_join): here

* subversion/tests/libsvn_wc/entries-compat.c

(test_entries_alloc, test_stubs): here

  1. … 18 more files in changeset.
* **/**

Run tools/dev/ to remove all trailing whitespace

before we branch 1.8, like we did before creating previous branches.

No functional changes.

  1. … 199 more files in changeset.
Merge the in-repo-authz branch back to trunk.


  1. … 23 more files in changeset.
* subversion/tests/libsvn_subr/path-test.c

(test_path_splitext): Removed unused result member of tests struct.

Combine two unit test files, one of which only had one test in it.

* subversion/tests/libsvn_subr/path-test.c

(condense_targets_func_t, condense_targets_tests_helper,

test_path_condense_targets): Move these here from target-test.c.

(test_funcs): Add 'test_path_condense_targets'.

* subversion/tests/libsvn_subr/target-test.c

Delete this file.

* build.conf

(target-test): Remove this section.

(__ALL__): Remove 'target-test'.

  1. … 2 more files in changeset.
Reintegrate integrate-string-improvements branch into /trunk.
  1. … 83 more files in changeset.
Following up on r1090699, try to fix the non-Windows path tests.

* subversion/tests/libsvn_subr/dirent_uri-test.c

(test_dirent_local_style): Remove uncanonical paths from tests.

* subversion/tests/libsvn_subr/path-test.c

(test_path_local_style): Remove uncanonical paths from tests.

  1. … 1 more file in changeset.
Make the conversion functions from internal path style to local style assume

that their input is canonical. But just to be safe don't make the dirent

variant fail on non canonical paths.

These functions are used in too many error messages to make them take the

penalty of full canonicalization on all their input. (My profiler says that

just this canonicalize in the to local style function takes over 0.5% of

my checkout time, while it is never needed.)

* subversion/include/svn_dirent_uri.h

(header): Remove *_local_style from the list of functions that allows non

canonical paths.

* subversion/libsvn_subr/dirent_uri.c

(SVN_USE_DOS_PATHS): Update comment.

(local_style): Remove expensive canonicalization.

(svn_relpath_local_style): Add maintainer mode only path style verification,

like we do in other path functions.

* subversion/tests/libsvn_subr/dirent_uri-test.c

(SVN_USE_DOS_PATHS): Update comment.

(test_dirent_local_style): Add two testcases.

(test_relpath_local_style): Remove now invalid case.

(test_dirent_internal_style): Add new case.

* subversion/tests/libsvn_subr/path-test.c

(SVN_USE_DOS_PATHS): Define macro and update all users.

(test_path_canonicalize): Enable testvalue that was disabled.

(test_path_local_style): Update expected result.

  1. … 3 more files in changeset.
Reintegrate the 'uris-as-urls' branch into trunk.

(Merged /subversion/branches/uris-as-urls:r1060426-1064427.)

This should wrap up issue #2028.

  1. … 73 more files in changeset.
Update every occurence of the Subversion repository URL to,

except in CHANGES (for sentimental reasons, I guess).

* contrib/cgi/mirror_dir_through_svn.README,

* contrib/client-side/emacs/psvn.el,

* contrib/client-side/svnmerge/,

* contrib/hook-scripts/,

* contrib/server-side/svn-fast-backup,

* contrib/server-side/,

* contrib/server-side/,

* doc/user/cvs-crossover-guide.html,

* notes/fs_dumprestore.txt,

* notes/http-and-webdav/webdav-usage.html,

* notes/interactive-conflict-resolution.txt,

* notes/merge-tracking/func-spec.html,

* notes/merge-tracking/requirements.html,

* notes/merge-tracking/summit.html,

* notes/object-model.txt,

* notes/obliterate/hooks/post-obliterate.tmpl,

* notes/obliterate/hooks/pre-obliterate.tmpl,

* notes/obliterate/plan-milestones.html,

* notes/subversion-design.html,

* notes/variance-adjusted-patching.html,

* packages/windows-innosetup/Pre.rtf,

* packages/windows-WiX/BuildSubversion/WixDialog/loc/en-us/Pre.rtf,

* subversion/bindings/javahl/native/JNIUtil.cpp,

* subversion/bindings/javahl/src/org/apache/subversion/javahl/,

* subversion/bindings/javahl/src/org/apache/subversion/javahl/,

* subversion/bindings/javahl/src/org/tigris/subversion/javahl/,

* subversion/bindings/javahl/src/org/tigris/subversion/javahl/,

* subversion/bindings/javahl/src/org/tigris/subversion/javahl/,

* subversion/bindings/swig/perl/native/,

* subversion/libsvn_repos/repos.c,

* subversion/libsvn_wc/wc_db.h,

* subversion/tests/cmdline/,

* subversion/tests/libsvn_subr/path-test.c,

* tools/buildbot/slaves/README,

* tools/client-side/,

* tools/client-side/,

* tools/client-side/,

* tools/dev/,

* tools/dev/,

* tools/dev/,

* tools/dist/ Update Subversion repository URL to apache.

  1. … 40 more files in changeset.
Test out my new and fancy ASF commit priviledges by changing the copyright

wording in our license headers to reflect ownership by the ASF.


Change terminology to ASF, and update a link.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the ASF, and update the project website.

* everywhere:

Change license text to reflect ASF ownership.

  1. … 891 more files in changeset.
Following up on r39958, move 2 deprecated path functions to deprecated.c and

update test results for a small change in results on Windows.

The change in result on Windows allows old code using svn_path_canonicalize()/

svn_path_internal_style() to produce canonical dirents after the drive letter

casing restrictions were updated.

* subversion/libsvn_subr/deprecated.c

(svn_path_canonicalize): New function; wrapper around uri/dirent support.

(svn_path_is_canonical): New function wrapper around uri/dirent support.

* subversion/libsvn_subr/path.c


svn_path_local_style): Remove functions. These functions were

added to deprecated.c in r39958.


svn_path_is_canonical): Remove functions.

* subversion/tests/libsvn_subr/path-test.c


test_path_internal_style): Expect upper case driveletters on Windows.

  1. … 2 more files in changeset.
Relicense Subversion under the Apache License, Version 2.0.

* NOTICE: New.



subversion/LICENSE: Remove.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the SVN Corp, and that it contains contributions from

many people, as referenced in NOTICE.

* subversion/bindings/swig/python/LICENSE_FOR_PYTHON_BINDINGS:

Relicense the SVN parts under Apache 2.0.

* everywhere:

Change copyright notices in file headers to reflect the Apache 2.0 license.

  1. … 882 more files in changeset.
Replace deprecated test func macros in the C tests. This eliminates the need

to do the following dance in every test function:

*msg = "foo";

if (msg_only)

return SVN_NO_ERROR;

This does not remove the deprecated symbols from svn_test.h; I plan to do it

in a follow up commit.

[ in subversion/tests ]

* libsvn_client/client-test.c,



































Do the above described transformation.

  1. … 34 more files in changeset.
Fix a typo in comment.

* subversion/tests/libsvn_subr/path-test.c

(): s/funtions/functions/

In path-test, undef SVN_DEPRECATED so that we don't get deprecation

warnings. Add a couple missing commas to the test arrays.

* subversion/tests/libsvn_subr/path-test.c:

(): ensure SVN_DEPRECATED is empty before including svn_path.h

(test_path_local_style): add a missing comma in the tests[] def.

(test_path_internal_style): add a missing comma in the tests[] def.

Fix svn_path_local_style() and svn_path_internal_style() behavior on

UNC paths.

* subversion/libsvn_subr/path.c

(svn_path_local_style, svn_path_internal_style):

Call svn_dirent_*() instead of svn_uri_*() on UNC paths.

* subversion/tests/libsvn_subr/path-test.c

(test_path_local_style, test_path_internal_style): New function.

(test_funcs): Add new tests.

  1. … 1 more file in changeset.
Revert path-test changed of r33424 to show that UNC path support

in the svn_path_*() functions is currently broken.

r33424 removed UNC path support from svn_uri_*() functions and

shouldn't have disabled it for svn_path_*().

* subversion/tests/libsvn_subr/path-test.c

(test_path_dirname, test_path_canonicalize, test_path_is_ancestor,

test_path_is_canonical): Re-enable old test values.

Follow-up to r35614:

* subversion/tests/libsvn_subr/path-test.c

(test_path_join): Simplify code.

Suggested by: gstein

* subversion/tests/libsvn_subr/path-test.c

(test_path_join): Fix compiler warning.

Delete trailing whitespace.

Follow-up to r26317 and r27598.

* build/generator/

* build/generator/

* build/generator/

* contrib/client-side/svnmerge/

* subversion/bindings/ctypes-python/csvn/

* subversion/bindings/ctypes-python/csvn/

* subversion/bindings/ctypes-python/examples/

* subversion/bindings/ctypes-python/

* subversion/bindings/ctypes-python/test/

* subversion/bindings/ctypes-python/test/

* subversion/bindings/ctypes-python/test/

* subversion/bindings/ctypes-python/test/

* subversion/bindings/ctypes-python/test/

* subversion/bindings/javahl/src/org/tigris/subversion/javahl/

* subversion/include/private/svn_auth_private.h:

* subversion/include/private/svn_sqlite.h:

* subversion/include/private/svn_wc_private.h:

* subversion/include/svn_auth.h:

* subversion/include/svn_checksum.h:

* subversion/include/svn_client.h:

* subversion/include/svn_cmdline.h:

* subversion/include/svn_dirent_uri.h:

* subversion/include/svn_path.h:

* subversion/include/svn_props.h:

* subversion/libsvn_client/commit_util.c:

* subversion/libsvn_client/copy.c:

* subversion/libsvn_client/deprecated.c:

* subversion/libsvn_client/export.c:

* subversion/libsvn_client/externals.c:

* subversion/libsvn_client/info.c:

* subversion/libsvn_client/merge.c:

* subversion/libsvn_client/mergeinfo.h:

* subversion/libsvn_client/ra.c:

* subversion/libsvn_client/repos_diff.c:

* subversion/libsvn_fs_base/bdb/checksum-reps-table.c:

* subversion/libsvn_fs_base/bdb/checksum-reps-table.h:

* subversion/libsvn_fs_base/bdb/miscellaneous-table.c:

* subversion/libsvn_fs_base/bdb/reps-table.c:

* subversion/libsvn_fs_base/dag.c:

* subversion/libsvn_fs_base/dag.h:

* subversion/libsvn_fs_base/err.h:

* subversion/libsvn_fs_base/fs.c:

* subversion/libsvn_fs_base/reps-strings.c:

* subversion/libsvn_fs_base/tree.c:

* subversion/libsvn_fs_base/tree.h:

* subversion/libsvn_fs_base/util/fs_skels.c:

* subversion/libsvn_fs_fs/dag.h:

* subversion/libsvn_fs_fs/fs_fs.h:

* subversion/libsvn_fs/fs-loader.c:

* subversion/libsvn_fs/fs-loader.h:

* subversion/libsvn_fs_fs/rep-cache.c:

* subversion/libsvn_fs_fs/rep-cache.h:

* subversion/libsvn_fs_fs/tree.c:

* subversion/libsvn_ra/compat.c:

* subversion/libsvn_ra_neon/log.c:

* subversion/libsvn_ra_neon/session.c:

* subversion/libsvn_ra_serf/log.c:

* subversion/libsvn_ra_serf/update.c:

* subversion/libsvn_ra_serf/util.c:

* subversion/libsvn_ra_serf/win32_auth_sspi.c:

* subversion/libsvn_repos/hooks.c:

* subversion/libsvn_repos/log.c:

* subversion/libsvn_repos/repos.h:

* subversion/libsvn_subr/checksum.c:

* subversion/libsvn_subr/cmdline.c:

* subversion/libsvn_subr/config_file.c:

* subversion/libsvn_subr/config_win.c:

* subversion/libsvn_subr/dirent_uri.c:

* subversion/libsvn_subr/dso.c:

* subversion/libsvn_subr/io.c:

* subversion/libsvn_subr/nls.c:

* subversion/libsvn_subr/simple_providers.c:

* subversion/libsvn_subr/sqlite.c:

* subversion/libsvn_subr/ssl_client_cert_pw_providers.c:

* subversion/libsvn_subr/stream.c:

* subversion/libsvn_subr/win32_crypto.c:

* subversion/libsvn_wc/adm_ops.c:

* subversion/libsvn_wc/diff.c:

* subversion/libsvn_wc/props.c:

* subversion/libsvn_wc/status.c:

* subversion/libsvn_wc/tree_conflicts.c:

* subversion/libsvn_wc/tree_conflicts.h:

* subversion/libsvn_wc/update_editor.c:

* subversion/libsvn_wc/wc_db.h:

* subversion/svn/cl.h:

* subversion/svndumpfilter/main.c:

* subversion/svnlook/main.c:

* subversion/svn/propedit-cmd.c:

* subversion/svn/propget-cmd.c:

* subversion/svnserve/main.c:

* subversion/svn/status-cmd.c:

* subversion/svn/tree-conflicts.c:

* subversion/svn/util.c:

* subversion/tests/cmdline/

* subversion/tests/cmdline/

* subversion/tests/cmdline/

* subversion/tests/cmdline/

* subversion/tests/cmdline/

* subversion/tests/cmdline/

* subversion/tests/cmdline/

* subversion/tests/cmdline/

* subversion/tests/cmdline/svntest/

* subversion/tests/cmdline/svntest/

* subversion/tests/cmdline/

* subversion/tests/cmdline/

* subversion/tests/cmdline/

* subversion/tests/libsvn_repos/repos-test.c:

* subversion/tests/libsvn_subr/checksum-test.c:

* subversion/tests/libsvn_subr/dirent_uri-test.c:

* subversion/tests/libsvn_subr/path-test.c:

* subversion/tests/libsvn_subr/target-test.c:

* subversion/tests/libsvn_wc/tree-conflict-data-test.c:

* tools/examples/ Delete trailing whitespace.

  1. … 112 more files in changeset.
Fix some the svn_uri_canonicalize and svn_canonicalize_path tests on

Windows. Remove the UNC-path test cases for the svn_path functions, as those

are not canonical uris.

Patch by: rhuijben


(Testcases by me.)

* subversion/libsvn_subr/dirent_uri.c

(canonicalize): Only consider '//' as the start of a UNC path when working

with dirents, not uris.

* subversion/tests/libsvn_subr/dirent_uri-test.c

(test_path_dirname, test_path_canonicalize,

test_path_is_ancestor, test_path_is_canonical): Comment out UNC-path test

cases. The svn_path functions aren't documented to support UNC paths, and

they don't work for all svn_path functions either.

  1. … 1 more file in changeset.
Add some URL test cases for svn_path_join and document that svn_path_join_many

doesn't support URLs.

* subversion/tests/libsvn_subr/path-test.c

(test_path_join): Add URL test cases for svn_path_join, make sure they aren't

run for svn_path_join_many.

* subversion/include/svn_path.h

(svn_path_join_many): Add note about URLs not being supported.

  1. … 1 more file in changeset.
Issue #2028: Separate directory entry & URI manipulation function from the

to-be deprecated svn_path functions. Start with svn_dirent_is_root.

* subversion/include/svn_path.h

(svn_dirent_is_root): Remove this declaration here, keep it #ifndef-ed for now

for compatibility reasons.

* subversion/libsvn_subr/path.c

(global): Include "svn_dirent_uri.h"

(svn_dirent_is_root): Remove this function here.

* subversion/tests/libsvn_subr/path-test.c

(test_dirent_is_root): Remove here.

(test_funcs): Remove test_dirent_is_root here.

* subversion/include/svn_dirent_uri.h

* subversion/libsvn_subr/dirent_uri.c

* subversion/tests/libsvn_subr/dirent_uri-test.c

New files, contain declaration, definition & test for svn_dirent_is_root.

* build.conf

(dirent_uri-test): New target.

(__ALL_TESTS__): Add dirent_uri-test.

* subversion/libsvn_subr/target.c

* subversion/libsvn_wc/util.c

* subversion/libsvn_wc/update_editor.c

* subversion/libsvn_wc/lock.c

* subversion/libsvn_client/mergeinfo.c

* subversion/libsvn_client/add.c

* subversion/libsvn_client/commit.c

* subversion/libsvn_repos/repos.c

(global): Include "svn_dirent_uri.h".

  1. … 14 more files in changeset.
Issue #2028: Prepare for move from svn_path* to svn_dirent* and svn_uri* API.

Document current (buggy) behavior of the svn_path* functions in terms of more


Most of this testcases are ressurected from r23906.

* subversion/tests/libsvn_subr/path-test.c

(test_is_url, test_is_uri_safe, test_join, test_basename, test_dirname,

test_decompose, test_canonicalize, test_remove_component,

test_get_longest_ancestor, test_splitext,

test_compose): Rename to test_path_*.

(test_is_root): Rename to test_dirent_is_root.

(test_path_is_url, test_path_join, test_path_basename,

test_path_dirname, test_path_canonicalize,

test_path_remove_component, test_path_get_longest_ancestor): Add new testcases

for Windows dirents and UNC paths.

(test_funcs): Update to renamed test functions.

Follow up r33254 with some tests.

* subversion/tests/libsvn_subr/path-test.c


test_is_canonical): Add testcases.

Windows standards dictate drive letters are in upper case, so let's

make svn_path_canonicalize do the same. Our test suite expects the same

as it does case sensitive compares on normalized paths.

Suggested by: rhuijben

* subversion/libsvn_subr/path.c

(svn_path_canonicalize): Change drive letter to upper case instead of


* subversion/tests/libsvn_subr/path-test.c


test_is_canonical): Update the 'drive letter' test cases.

  1. … 1 more file in changeset.
Follow up r33240 with a fix for the canonicalization of UNC server names.

This should handle the Windows buildbot test failures.

* subversion/libsvn_subr/path.c

(svn_path_canonicalize): Fix decision on when a path is UNC or not.

* subversion/tests/libsvn_subr/path-test.c


test_is_canonical): Add some basic test cases.

  1. … 1 more file in changeset.
On Windows, convert the disc letter of file:// URIs and the server name of

UNC paths to lower case during canonicalization. This is in line with the

approach chosen to fix issue #2475.

* subversion/libsvn_subr/path.c

(svn_path_canonicalize): Convert drive letter if file:// URIs and server

name in UNC paths to lower case. Adds small optimization for checking

empty hostname paths.

* subversion/tests/libsvn_subr/path-test.c


test_is_canonical): Add extra test cases for file:// URIs and UNC paths.

  1. … 1 more file in changeset.