Checkout Tools
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove svn_eol__detect_file_eol() which was added during 1.7 development

but is now unused. It also had known bugs.

* subversion/include/private/svn_eol_private.h

(svn_eol__detect_file_eol): Remove declaration and docstring.

* subversion/libsvn_subr/eol.c

(svn_eol__detect_file_eol): Remove.

* subversion/tests/libsvn_subr/eol-test.c: Remove this entire file since

it was only testing svn_eol__detect_file_eol().

* build.conf: Adjust for removed file. Hope I won't break the Windows build.

  1. … 3 more files in changeset.
In the C unit test suite, replace all uses of SVN_ERR_ASSERT() with

SVN_TEST_ASSERT() to not have a failed assertion core dump the

process.

Suggested by: danielsh

* subversion/tests/libsvn_client/client-test.c,

* subversion/tests/libsvn_subr/eol-test.c,

* subversion/tests/libsvn_wc/pristine-store-test.c,

* subversion/tests/svn_test_fs.c:

s/SVN_ERR_ASSERT/SVN_TEST_ASSERT/g.

  1. … 3 more files in changeset.
Test out my new and fancy ASF commit priviledges by changing the copyright

wording in our license headers to reflect ownership by the ASF.

* NOTICE:

Change terminology to ASF, and update a link.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the ASF, and update the project website.

* everywhere:

Change license text to reflect ASF ownership.

  1. … 891 more files in changeset.
Follow-up to r38983: The new eol functions are supposed to be private,

not public, so rename them accordingly.

* subversion/libsvn_subr/eol.c,

subversion/include/private/svn_eol_private.h

(svn_eol_find_eol_start, svn_eol_detect_eol,

svn_eol_detect_file_eol): Renamed from these ...

(svn_eol__find_eol_start, svn_eol__detect_eol,

svn_eol__detect_file_eol): ... to these.

* subversion/libsvn_diff/diff_file.c,

subversion/tests/libsvn_subr/eol-test.c,

subversion/libsvn_client/patch.c: Track renames.

Patch by: Edmund Wong <ed@kdtc.net>

Found by: arfrever

  1. … 4 more files in changeset.
Move functions concerned with EOL parsing from libsvn_subr/subst.c

to libsvn_subr/eol.c. This allows further consolidation of code

concerned with EOL-parsing instead of being all over the place.

Note that functions concerned with the svn:eol-style property are not

affected by this change.

[ Note from the future: The change to build.conf was accidentally not

committed, and was instead committed in r38984. ]

* build.conf:

(subst-test): Rename to ...

(eol-test): ... this.

(__ALL_TESTS__): Track renamed test.

(msvc-export): Add private\svn_eol_private.h.

* subversion/include/private/svn_eol_private.h: New.

* subversion/libsvn_subr/subst.c,

subversion/include/svn_subst.h

(svn_subst_find_eol_start, svn_subst_detect_eol,

svn_subst_detect_file_eol): Move these functions from here ...

* subversion/libsvn_subr/eol.c,

subversion/include/private/svn_eol_private.h

(svn_eol_find_eol_start, svn_eol_detect_eol,

svn_eol_detect_file_eol): ... to these new files and rename them.

* subversion/libsvn_client/patch.c,

subversion/libsvn_diff/diff-file.c: Track renamed functions.

* subversion/tests/libsvn_subr/subst-test.c: Rename to ...

* subversion/tests/libsvn_subr/eol-test.c: ... this, and track renamed

functions.

Patch by: Edmund Wong <ed{_AT_}kdtc.net>

Suggested by: stsp

  1. … 7 more files in changeset.
Use one test program for newline conversion and keyword substitution.

* subversion/tests/libsvn_subr/subst-test.c: Replaces eol-test.c.

* subversion/tests/libsvn_subr/eol-test.c: Renamed, see above.

* build.conf (subst-test): Replaces eol-test.

  1. … 2 more files in changeset.
Tests for eol conversion subroutines. Those routines currently abort,

but once they're done, these tests should pass.

This is part of work on issue #524.

* subversion/tests/libsvn_subr/eol-test.c: New file, new tests.

* build.conf (eol-test): New test program in libsvn_subr.

* subversion/include/svn_error_codes.h (SVN_ERR_IO_CORRUPT_EOL): New

error code.

* subversion/include/svn_io.h (svn_io_convert_eol): Take const char

pointers for the paths, not svn_stringbuf_t.

* subversion/libsvn_subr/io.c (svn_io_convert_eol): Same.

  1. … 4 more files in changeset.