Checkout Tools
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Changeset 866391 is being indexed.

Channeling Erik Hülsmann, remove all trailing whitespace within our source

tree:

for extsn in c h cpp java py pl rb; do

sed -i -e 's/[ \t]*$//' `find . -name "*.$extsn" | xargs grep '[ \t]$' -l`

done

Inspired by: ehu

  1. … 448 more files in changeset.
Follow-up to r26222.

* subversion/tests/libsvn_repos/repos-test.c

(rmlocks): Update call to svn_repos_begin_report2.

Followup to r24861: replace a docstring with a brief comment.

* subversion/libsvn_repos/repos.c

* subversion/libsvn_subr/config_file.c

* subversion/tests/libsvn_diff/diff-diff3-test.c

* subversion/tests/libsvn_repos/repos-test.c

(NL) Replace docstring with a brief comment.

Patch by: Peter Samuelson <peter@p12n.org>

  1. … 3 more files in changeset.
Change of convention for multiline string literal. No semantics changes.

Patch by: Jonathan Gilbert <o2w9gs702@sneakemail.com>

Tweaked by: me

* subversion/libsvn_repos/repos.c

* subversion/libsvn_subr/config_file.c

* subversion/tests/libsvn_diff/diff-diff3-test.c

* subversion/tests/libsvn_repos/repos-test.c

(NL) Introduce shorter version of APR_EOL_STR.

() Replace APR_EOL_STR with NL macro in string literals. Move it to line with

text and align NL macro to end on the 79th column.

  1. … 3 more files in changeset.
* subversion/tests/libsvn_repos/repos-test.c

Code formatting changes only -- no logic changes.

Merge the sparse-directories branch to trunk.

See notes/sparse-directories.txt for work remaining. Special thanks

to dlr, lundblad, and malcolm for their help in getting the branch to

mergeability.

  1. … 70 more files in changeset.
Fix a bug in the authz code, related to issue #2388: if the authz global access

check is inconclusive (ie. no decision could be made), access should be denied,

not authorized.

Patch by: Joe Schaefer <joe@sunstarsys.com>

* subversion/libsvn_repos/authz.c

(authz_global_parse_section): Continue walking the authz config as long as

the access is not determined.

(authz_get_global_access): Return FALSE if the access could not be

conclusively determined.

* subversion/tests/libsvn_repos/repos-test.c

(authz): Add a section to the test configuration that triggers the bug. Fix

the test loop to actually run all unit tests.

  1. … 1 more file in changeset.
Replace calls to apr_array_push() with invocations of the APR_ARRAY_PUSH macro.

Followup to r22958.

* subversion/libsvn_fs_base/reps-strings.c

* subversion/libsvn_fs_base/bdb/txn-table.c

* subversion/libsvn_fs_base/bdb/changes-table.c

* subversion/libsvn_fs_base/revs-txns.c

* subversion/libsvn_fs_base/util/fs_skels.c

* subversion/libsvn_subr/error.c

* subversion/libsvn_subr/svn_string.c

* subversion/libsvn_subr/auth.c

* subversion/libsvn_subr/opt.c

* subversion/libsvn_subr/target.c

* subversion/libsvn_subr/path.c

* subversion/libsvn_ra_local/ra_plugin.c

* subversion/libsvn_client/prop_commands.c

* subversion/libsvn_client/locking_commands.c

* subversion/libsvn_client/blame.c

* subversion/libsvn_client/changelist.c

* subversion/libsvn_client/log.c

* subversion/libsvn_client/commit.c

* subversion/mod_dav_svn/reports/log.c

* subversion/mod_dav_svn/reports/update.c

* subversion/tests/libsvn_subr/target-test.c

* subversion/tests/libsvn_repos/repos-test.c

* subversion/libsvn_repos/log.c

* subversion/libsvn_repos/rev_hunt.c

* subversion/svn/checkout-cmd.c

* subversion/svn/status-cmd.c

* subversion/libsvn_ra_dav/commit.c

* subversion/libsvn_ra_dav/fetch.c

* subversion/svnserve/serve.c

Use the APR_ARRAY_PUSH macro where appropriate.

  1. … 28 more files in changeset.
In the spirit of r22918, use the APR_ARRAY_IDX macro to index into arrays,

instead of referencing the elements of the array directly.

* subversion/libsvn_fs_base/reps-strings.c

* subversion/libsvn_fs_base/util/fs_skels.c

* subversion/libsvn_subr/error.c

* subversion/libsvn_subr/svn_string.c

* subversion/libsvn_subr/opt.c

* subversion/libsvn_subr/target.c

* subversion/libsvn_ra_local/ra_plugin.c

* subversion/libsvn_client/locking_commands.c

* subversion/libsvn_client/diff.c

* subversion/libsvn_client/log.c

* subversion/libsvn_client/commit_util.c

* subversion/libsvn_ra_serf/log.c

* subversion/mod_dav_svn/reports/update.c

* subversion/tests/libsvn_subr/target-test.c

* subversion/tests/libsvn_repos/repos-test.c

* subversion/libsvn_ra_svn/client.c

* subversion/libsvn_ra_svn/marshal.c

* subversion/libsvn_ra_dav/log.c

* subversion/libsvn_ra_dav/fetch.c

* subversion/libsvn_ra_dav/replay.c

* subversion/svnserve/serve.c

Use APR_ARRAY_IDX where appropriate.

  1. … 20 more files in changeset.
* subversion/tests/libsvn_repos/repos-test.c (commit_editor_authz): Tweak

pool usage to avoid a core dump with pool debugging and --enable-dso.

See http://svn.haxx.se/dev/archive-2006-03/1253.shtml and its thread.

Patch by: Malcolm Rowe <malcolm-svn-dev@farside.org.uk>

Remove a "repos" test introduced in r21407 that didn't actually

involve the repos layer, and replace it with an extra line in a

pre-existing "fs" test. This test is XFAIL, but passes under BDB.

* subversion/tests/libsvn_repos/repos-test.c

(created_rev_root): Removed.

(test_funcs): Removed created_rev_root.

* subversion/tests/libsvn_fs/fs-test.c

(test_node_created_rev): Confirm that a newly-created txn root has

the same node_created_revs as the rev root it came from.

(test_funcs): Make test_node_created_rev an XFAIL.

  1. … 1 more file in changeset.
Simplify test for Issue #2608, which doesn't actually

require any revisions in the repository.

* subversion/tests/libsvn_repos/repos-test.c

(created_rev_root): Don't bother making any revisions.

Follow up to r21407: a test that fails in some situations should

be marked as XFail!

* subversion/tests/libsvn_repos/repos-test.c

(test_funcs): mark created_rev_root as XFailing for now.

New lower-level test for Issue #2608. Passes with bdb, fails with

fsfs. (There's no way to do a conditional XFAIL for C tests

unfortunately.)

* subversion/tests/libsvn_repos/repos-test.c

(created_rev_root): New test for issue #2608.

(test_funcs): Add new test.

Finish issue #2600 -- svn diff follows history incorrectly on file in

renamed directory.

The problem was a bug in the svn_fs_closest_copy() implementations.

Fortunately, there are now C tests for both the FS and repos layers,

plus a Python test for the original 'svn diff' recipe, so I feel

pretty confident that this particular issue won't easily reappear.

* subversion/tests/libsvn_repos/repos-test.c

(test_funcs): No longer expect node_locations2() to fail.

* subversion/tests/libsvn_fs/fs-test.c

(test_funcs): No longer expect closest_copy_test() to fail.

* subversion/tests/cmdline/diff_tests.py

(test_list): No longer expect diff_in_renamed_folder() to fail.

* subversion/libsvn_fs_fs/tree.c

(fs_closest_copy): Use the right dag_node_t when checking for the

item-created-in-copy-target special case.

* subversion/libsvn_fs_base/tree.c

(txn_body_closest_copy): Use the right dag_node_t when checking for

the item-created-in-copy-target special case.

  1. … 4 more files in changeset.
Add a new, currently XFAILing, test for issue #2600, a bug reported on

the mailing list (http://svn.haxx.se/dev/archive-2006-08/0098.shtml).

Hopefully I'll have a solution soon.

* subversion/tests/libsvn_repos/repos-test.c

(node_locations2): New.

(test_funcs): Reference the new test.

Fix for issue #2486: Svnserve 1.3 authz: writing on subfolder requires read

access on repository root. Removed overly restrictive tests for read access

when opening root or opening a directory.

Patch by: Lieven Govaerts <lgo@mobsol.be>

* subversion/libsvn_repos/commit.c:

(open_root): removed check on read access

(open_directory): removed check on read access

* subversion/tests/cmdline/authz_tests.py:

new file, contains tests for issue #2486.

* subversion/tests/cmdline/svntest/actions.py:

(run_and_verify_commit): add --username and --password parameters to the

commit.

* subversion/tests/cmdline/svntest/main.py:

(get_authz_file_path): new function

(get_svnserve_conf_file_path): new function

* subversion/tests/libsvn_repos/repos-test.c:

(commit_editor_authz): removed a now obsolete part of the test.

  1. … 4 more files in changeset.
Reformat the code to use a consistent no-space-before-param-list-paren style.

See here for the vote that decided this:

http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=111877

From: "Peter N. Lundblad" <peter@famlundblad.se>

To: "Peter N. Lundblad" <peter@famlundblad.se>

cc: dev@subversion.tigris.org

Subject: Results of: [VOTE] New space-before-parens style

Date: Wed, 8 Feb 2006 12:00:35 +0100 (CET)

Message-ID: <Pine.LNX.4.55.0602080918350.10805@localhost.localdomain>

I took the opportunity to make spacing among all parens in SVN_ERR

macro calls consistent. But I did not address consistency of casts,

nor whether a function name should always appear below its return type

in declarations and definitions, nor whether there should be a space

before/after the "*" when declaring pointer return types.

* www/hacking.html

(coding-style): Document that we are no-space-before-paren now.

* everywhere: Reformat.

  1. … 363 more files in changeset.
Stop calling deprecated APIs; call the revised versions instead. In all

cases except the first, don't try to use any new features of the new APIs.

* subversion/libsvn_client/commit_util.c

(harvest_committables): Call the new svn_wc_walk_entries2() and enable

cancellation in it.

* subversion/libsvn_client/diff.c

(do_merge, diff_repos_wc): Call the new svn_ra_do_diff2().

* subversion/libsvn_client/ra.c

(open_tmp_file): Call the new svn_io_open_unique_file2().

* subversion/libsvn_repos/dump.c

(svn_repos_dump_fs2): Call the new svn_repos_replay2().

* subversion/libsvn_wc/adm_ops.c

(svn_wc_process_committed2): Call itself to recurse, not its predecessor.

(erase_from_wc): Call the new svn_io_get_dirents2(). (The new part of the

result is not used.)

* subversion/libsvn_wc/status.c

(get_dir_status): Call the new svn_io_get_dirents2(). (The new part of the

result was already being used; the reimplementation of the old function

happened to provide it.)

* subversion/mod_dav_svn/repos.c

(dav_svn_deliver): Call the new svn_io_get_dirents2().

* subversion/svndumpfilter/main.c

(filtering_vtable): Upgrade to svn_repos_parser_fns2_t.

(do_filter): Call the new svn_repos_parse_dumpstream2().

* subversion/svnlook/main.c

(generate_delta_tree): Call the new svn_repos_replay2().

(do_log): Call the new svn_subst_translate_cstring2().

(do_history): Call the new svn_repos_history2().

* subversion/svnsync/main.c

(open_tmp_file): Call the new svn_io_open_unique_file2().

* subversion/tests/libsvn_repos/repos-test.c

(node_tree_delete_under_copy): Call the new svn_repos_replay2().

  1. … 10 more files in changeset.
Fix some inconsistent source formatting (because it was hindering my attempts

to automate a bigger change).

* subversion/libsvn_diff/diff4.c

* subversion/libsvn_diff/diff_file.c

* subversion/libsvn_diff/lcs.c

* subversion/libsvn_diff/token.c

* subversion/libsvn_repos/load.c

* subversion/tests/libsvn_repos/repos-test.c

* tools/diff/diff.c

* tools/diff/diff3.c

* tools/diff/diff4.c

For static functions, always have "static" on the same line as the return

type.

  1. … 8 more files in changeset.
Fix error leaks, adding SVN_ERR() where appropriate.

Found by: julianfoad

* subversion/libsvn_client/locking_commands.c,

subversion/tests/libsvn_repos/repos-test.c,

subversion/libsvn_repos/dump.c,

subversion/libsvn_repos/commit.c,

subversion/svn/util.c,

subversion/libsvn_fs_fs/fs_fs.c

Add SVN_ERR() wrappers to handle errors returned from called functions.

  1. … 5 more files in changeset.
Replace calls to the deprecated functions svn_wc_create_tmp_file and

svn_io_open_unique_file with their ...2() successors.

  1. … 25 more files in changeset.
Follow-up to r16046. Fix regression, making the case where

passing a transaction to svn_repos_get_commit_editor4 didn't work, because

the transaction couldn't be comittted while closing the edit.

Suggested by: clkao

* subversion/tests/libsvn_repos/repos-test.c (dummy_commit_cb): New function.

(commit_continue_txn): New test.

(test_funcs): Add it.

* subversion/libsvn_repos/commit.c (close_edit): Don't error if we aren't the

owner of the transaction.

  1. … 1 more file in changeset.
Partial fix for Issue #443: post-commit hook script (error) output lost

This is step 5 : Replace all usage of svn_commit_callback_t with

svn_commit_callback2_t.

Patch by: Madan U Sreenivasan <madan@collab.net>

(Tweaked by me.)

* subversion/libsvn_ra/wrapper_template.h

(compat_get_commit_editor): Use svn_compat_wrap_commit_callback.

* subversion/libsvn_ra/ra_loader.c: Include svn_types.h.

(svn_ra_get_commit_editor2): New function using svn_commit_callback2_t.

(svn_ra_get_commit_editor): Wrap svn_ra_get_commit_editor2.

* subversion/libsvn_ra/ra_loader.h

(svn_ra__vtable_t): Modified the get_commit_editor member to use

svn_commit_callback2_t instead of svn_commit_callback_t.

* subversion/include/svn_repos.h

(svn_repos_get_commit_editor4): New version of svn_repos_get_commit_editor3

to use svn_commit_callback2_t.

(svn_repos_get_commit_editor3): Deprecated.

* subversion/include/svn_types.h

(svn_commit_info_dup): New API.

(svn_commit_callback2_t): New callback similar to svn_commit_callback_t

but using the svn_commit_info_t structure and with an new pol argument.

(svn_commit_callback_t): Deprecated.

(svn_compat_wrap_commit_callback): New API to wrap commit_baton

and provide a svn_commit_callback_t type callback.

* subversion/include/svn_ra.h

(svn_ra_get_commit_editor2): New version of svn_ra_get_commit_editor

using svn_commit_callback2_t.

(svn_ra_get_commit_editor): Deprecated.

* subversion/libsvn_subr/constructors.c

(svn_commit_info_dup): New function.

* subversion/libsvn_subr/compat.c: New file to provide compatibility

for deprecated callback types.

* subversion/libsvn_ra_local/ra_plugin.c

(deltify_etc_baton): Use svn_commit_callback2_t.

(deltify_etc): Now uses the svn_commit_callback2_t signature

and callbacks.

(svn_ra_local__get_commit_editor): Use svn_client_commit_callback2_t.

* subversion/libsvn_client/delete.c

(delete_urls): Use svn_ra_get_commit_editor2 instead of

svn_ra_get_commit_editor.

* subversion/libsvn_client/client.h

(svn_client__commit_callback): Comply with new svn_commit_callback2_t

signature.

* subversion/libsvn_client/copy.c

(repos_to_repos_copy, wc_to_repos_copy): Use svn_ra_get_commit_editor2 instead of

svn_ra_get_commit_editor.

* subversion/libsvn_client/commit_util.c

(svn_client__commit_callback): Modified function to use

svn_commit_info_t.

* subversion/libsvn_client/add.c

(mkdir_urls): Use svn_ra_get_commit_editor2 instead of

svn_ra_get_commit_editor.

* subversion/libsvn_client/commit.c

(get_ra_editor): Use svn_ra_get_commit_editor2.

* subversion/tests/libsvn_repos/repos-test.c

(commit_editor_authz): Use svn_repos_get_commit_editor4.

* subversion/libsvn_repos/commit.c

(edit_baton): Now uses svn_commit_callback2_t.

(close_edit): Use svn_commit_callback2_t based callback.

(svn_repos_get_commit_editor4): New function.

(svn_repos_get_commit_editor3): Modified to wrap around the

svn_repos_get_commit_editor4 function.

(svn_repos_get_commit_editor2): Modified to wrap around the

svn_repos_get_commit_editor3 function.

(svn_repos_get_commit_editor): Modified to wrap around the

svn_repos_get_commit_editor2 function.

* subversion/libsvn_ra_svn/client.c

(ra_svn_commit_callback_baton_t): Now uses svn_commit_callback2_t.

(ra_svn_end_commit): Add pool argument. Use svn_commit_info_t.

(ra_svn_commit): Use svn_commit_callback2_t.

* subversion/libsvn_ra_dav/ra_dav.h

(svn_ra_dav__get_commit_editor): Use svn_commit_callback2_t.

* subversion/libsvn_ra_dav/commit.c

(commit_ctx_t): Use svn_commit_callback2_t.

(commit_close_edit): use svn_commit_info_t.

(svn_ra_dav__get_commit_editor): Use svn_commit_callback2_t.

* subversion/svnserve/serve.c

(commit_callback_baton_t): Add pool member.

(commit_done): Use svn_commit_info_t.

(commit): Use svn_repos_get_commit_editor4.

Initialize ccb->pool

  1. … 20 more files in changeset.
Fix a nasty SEGFAULT that could occur when folks use a non-absolute FS

path as input to svn_repos_trace_node_locations.

* subversion/libsvn_repos/rev_hunt.c

(svn_repos_trace_node_locations): Ensure that the input FS path is absolute.

* subversion/tests/libsvn_repos/repos-test.c

(node_locations): Repeat the test, using the non-absolute FS path form.

  1. … 1 more file in changeset.
Add facilities in the authz lookup library to perform a global lookup,

that is to check whether a user has a given access level granted by

any authz rule. This is the first stage of fixing issue #2388.

* subversion/include/svn_repos.h

(svn_repos_authz_check_access): Document the possibility of passing

a NULL path to perform a global access lookup.

* subversion/libsvn_repos/authz.c

(svn_repos_authz_check_access): Test for NULL paths and perform a

global access lookup if necessary.

(authz_get_global_access, authz_global_parse_section): New

functions.

* subversion/tests/libsvn_repos/repos-test.c

(authz): Add tests to validate the behaviour of global lookups.

  1. … 2 more files in changeset.
* subversion/tests/libsvn_repos/repos-test.c

(commit_authz_cb, commit_editor_authz): Make static to kill a gcc warning.

Add authz callback support to the commit editor.

Patch by: David Anderson <david.anderson@calixo.net>

* subversion/include/svn_error_codes.h

New error message.

* subversion/include/svn_repos.h

(svn_repos_authz_access_t): Move to the begginning of file to avoid

warnings about undeclared types.

(svn_repos_authz_callback_t): New callback type for extended authz

lookups.

(svn_repos_get_commit_editor3): Rev API, add an authz callback and

pointer.

(svn_repos_get_commit_editor2): Deprecate.

* subversion/libsvn_repos/commit.c

(edit_baton): New fields for authz.

(check_authz): New internal function.

(open_root, delete_entry, add_directory, open_directory,

apply_textdelta, add_file, open_file, change_file_prop,

change_dir_prop): Perform authz lookups.

* subversion/libsvn_ra_local/ra_plugin.c

(svn_ra_local__get_commit_editor): Use the new commit editor API.

* subversion/svnserve/serve.c

(commit): Use the new commit editor API.

* subversion/tests/libsvn_repos/repos-test.c

(commit_authz_cb): Callback implementation for the commit editor

authz test.

(commit_editor_authz): New test.

  1. … 5 more files in changeset.
Make the repos-test authz tests cleanup after themselves.

* subversion/tests/libsvn_repos/repos-test.c

Fix some space-before-paren inconsistencies.

(authz_get_handle): Always try to close and remove the authz_test_*

temporary file.

Bugfix for overly-strict rejection by recursive authz lookup algorithm.

Original bug report here:

http://subversion.tigris.org/servlets/ReadMsg?listName=users&msgNo=35734

Suggested by: Bernd Rinn <bernd@sdf.lonestar.org>

Patch by: David Anderson <david.anderson@calixo.net>

* subversion/libsvn_repos/authz.c

(authz_parse_section): use svn_path_is_ancestor to establish

relationships between paths instead of just strncmp.

* subversion/tests/libsvn_repos/repos-test.c

(authz): New regression test.

  1. … 1 more file in changeset.