Checkout Tools
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Changeset 872427 is being indexed.

Fix 'svn_dso_initialize' which was *silently* failing to create lock

and causing later accessors to fail.

* subversion/libsvn_subr/dso.c

(svn_dso_initialize): When 'apr_thread_mutex_create' is not successful,

abort.

Reviewed by: stsp

Fix several files with svn:eol-style missing.

* subversion/libsvn_subr/constructors.c,

subversion/libsvn_subr/user.c,

subversion/libsvn_subr/atomic.c,

subversion/libsvn_subr/compat.c,

subversion/libsvn_subr/dso.c,

subversion/libsvn_client/util.c,

subversion/libsvn_client/compat_providers.c,

subversion/libsvn_client/repos_diff_summarize.c,

subversion/libsvn_ra_serf/merge.c,

subversion/libsvn_ra_serf/serf.c,

subversion/libsvn_ra_serf/xml.c,

subversion/libsvn_ra_serf/propfind_buckets.c,

subversion/libsvn_ra_serf/locks.c,

subversion/libsvn_ra_serf/getlocks.c,

subversion/libsvn_ra_serf/util.c,

subversion/libsvn_ra_serf/getdate.c,

subversion/libsvn_ra_serf/blame.c,

subversion/libsvn_ra_serf/log.c,

subversion/libsvn_ra_serf/update.c,

subversion/libsvn_ra_serf/property.c,

subversion/libsvn_ra_serf/commit.c,

subversion/libsvn_ra_serf/getlocations.c,

subversion/libsvn_ra_serf/options.c,

subversion/libsvn_ra_serf/replay.c,

subversion/mod_dav_svn/mirror.c,

subversion/mod_dav_svn/reports/replay.c,

subversion/tests/libsvn_subr/error-test.c,

subversion/libsvn_ra_svn/streams.c,

subversion/libsvn_ra_svn/sasl_auth.c,

subversion/libsvn_ra_svn/simple_auth.c,

subversion/libsvn_delta/debug_editor.c,

subversion/libsvn_ra_dav/replay.c,

subversion/svnserve/sasl_auth.c,

tools/server-side/svnauthz-validate.c,

contrib/server-side/mod_dontdothat/mod_dontdothat.c:

Set the svn:eol-style=native.

  1. … 34 more files in changeset.
Fix compile error when APR_HAS_DSO is not defined (e.g. on RISC OS).

* subversion/include/svn_dso.h

* subversion/libsvn_subr/dso.c

(svn_dso_load): Only declare the function when APR_HAS_DSO is

defined (required because apr_dso_handle_t also won't be

available).

Patch by: Alex Waugh <alex@alexwaugh.com>

(Tweaked by me.)

Review by: rooneg

  1. … 1 more file in changeset.
Follow up to r20996 with some cleanups.

* subversion/include/svn_dso.h

(svn_dso_initialize): Make void argument explicit.

* subversion/libsvn_subr/dso.c

(NOT_THERE): Cast to void * to avoid warnings about comparing different

types of pointers.

  1. … 1 more file in changeset.
Make --enable-dso work in the face of global bdb environment caching.

Really this time.

This adds a custom wrapper for APR's dso loading code, which loads the

DSOs into a global pool that will persist long enough that we don't risk

having the DSO unloaded before any cleanup functions it registered are

called. Note that this only works if the new initialization function is

called early enough, otherwise we are still vulnerable to the problem.

Note that I have marked the new functions as being added in 1.4.0, if we

do not backport this revision to 1.4.x then this will have to be changed.

* subversion/include/svn_dso.h: New header.

* subversion/libsvn_subr/dso.c: New function, holds the DSO wrapper code.

* subversion/libsvn_ra/ra_loader.c

Stop including apr_dso.h. Include svn_dso.h.

(load_ra_module): Use svn_dso_load instead of apr_dso_load.

* subversion/libsvn_fs/fs-loader.c

Remove include of apr_dso.h, add include of svn_dso.h.

(load_module): Use svn_dso_load, not apr_dso_load.

* subversion/libsvn_subr/cmdline.c

Include svn_dso.h.

(svn_cmdline_init): Call svn_dso_initialize.

* subversion/mod_dav_svn/mod_dav_svn.c

Include svn_dso.h.

(init_dso): New hook function.

(register_hooks): Register init_dso to be called as early as possible.

  1. … 5 more files in changeset.