Checkout Tools
  • last updated 3 hours ago
Constraints: committers
Constraints: files
Constraints: dates

Changeset 1044467 is being indexed.

Fix error leaks.

* everywhere:

Add missing SVN_ERR() calls.

* subversion/libsvn_repos/load-fs-vtable.c

(make_node_baton): Return an svn_error_t *.

(new_node_record): Track return type change.

* subversion/svnadmin/main.c (main),

subversion/svndumpfilter/main.c (main),

subversion/svnlook/main.c (main),

subversion/svnrdump/svnrdump.c (main),

subversion/svnsync/main.c (main):

Use SVN_INT_ERR() around subcommand_help() or help_cmd().

  1. … 34 more files in changeset.
* subversion/libsvn_repos/load-fs-vtable.c

(apply_textdelta, set_fulltext): Remove null checks before calling

svn_checksum_to_cstring(), as that can handle null since r1040831.

* subversion/libsvn_repos/load-fs-vtable.c

(set_node_property): Add a comment documenting an ugly but necessary cast.

Finish issue #3733 ("API layering violation in repository loading


Bifurcate load.c into load.c and load-fs-vtable.c, keeping the

dumpstream parse logic in load.c, and our specific loader vtable

implementation bits in load-fs-vtable.c. This alone causes build

failures due to illegal knowledge bleed between these blocks of the

API (you know, the complaint noted in this issue), so also made the

additional changes below:

* subversion/libsvn_repos/load.c

(parse_property_block): Move mergeinfo normalization from here ...

* subversion/libsvn_repos/load-fs-vtable.c

(set_node_property): ... to here.

  1. … 1 more file in changeset.