Checkout Tools
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Changeset 871387 is being indexed.

Fix issue #3137: use a consistent error code when a path is not found in the

repository. DAV uses a 404 status code to indicate missing paths, so we now

convert that code to SVN_ERR_FS_NOT_FOUND, as we do for ra_local and ra_svn.

As this is client side only, this patch also removes all instances were we

test for the now deprecated error code SVN_ERR_RA_DAV_PATH_NOT_FOUND.

* subversion/include/svn_error_codes.h

(SVN_ERR_RA_DAV_PATH_NOT_FOUND): Deprecate error code.

* subversion/libsvn_ra_serf/ra_serf.h

(svn_ra_serf__error_on_status): New function declaration.

* subversion/libsvn_ra_serf/util.c

(svn_ra_serf__error_on_status): New function definition.

* subversion/libsvn_ra_serf/serf.c

(svn_ra_serf__has_capability,

svn_ra_serf__check_path,

svn_ra_serf__stat): Use SVN_ERR_FS_NOT_FOUND error code here ..

* subversion/libsvn_ra_serf/util.c

(svn_ra_serf__discover_root): .. and here.

* subversion/libsvn_ra_serf/mergeinfo.c

(svn_ra_serf__get_mergeinfo): Use svn_ra_serf__error_on_status here ..

* subversion/libsvn_ra_serf/getlocationsegments.c

(svn_ra_serf__get_location_segments): ..

* subversion/libsvn_ra_serf/blame.c

(svn_ra_serf__get_file_revs): ..

* subversion/libsvn_ra_serf/update.c

(handle_stream): ..

* subversion/libsvn_ra_serf/property.c

(svn_ra_serf__wait_for_props): ..

* subversion/libsvn_ra_serf/getlocations.c

(svn_ra_serf__get_locations): ..

* subversion/libsvn_ra_serf/commit.c

(checkout_dir): .. and here.

(checkout_dir, get_version_url): Use better error code.

(checkout_file): Use svn_ra_serf__error_on_status and better error code.

* subversion/libsvn_ra_neon/props.c

(svn_ra_neon__get_one_prop,

svn_ra_neon__search_for_starting_props,

svn_ra_neon__do_check_path,

svn_ra_neon__do_stat): Use SVN_ERR_FS_NOT_FOUND error code here ..

* subversion/libsvn_ra_neon/get_locks.c

(svn_ra_neon__get_locks): ..

* subversion/libsvn_ra_neon/util.c

(generate_error): ..

* subversion/libsvn_ra_neon/commit.c

(commit_add_file): .. and here.

* subversion/libsvn_ra_neon/session.c

(svn_ra_neon__has_capability): Don't check for SVN_ERR_RA_DAV_PATH_NOT_FOUND.

* subversion/svn/mkdir-cmd.c

(svn_cl__mkdir): Don't check for SVN_ERR_RA_DAV_PATH_NOT_FOUND.

* subversion/libsvn_client/merge.c

(filter_self_referential_mergeinfo,

calculate_remaining_ranges,

get_mergeinfo_walk_cb): Don't check for SVN_ERR_RA_DAV_PATH_NOT_FOUND.

  1. … 17 more files in changeset.
ra_serf: Fix issue #3138: make get_locations and get_location_segments return

an error when the target url isn't found in the repository. This also fixes an

abort on exit of 'svn merge'.

* subversion/libsvn_ra_serf/getlocations.c

(svn_ra_serf__get_locations): Raise SVN_ERR_RA_DAV_PATH_NOT_FOUND error when

the target item doesn't exist in the repository.

* subversion/libsvn_ra_serf/getlocationsegments.c

(svn_ra_serf__get_location_segments): idem.

* subversion/libsvn_ra_serf/mergeinfo.c

(svn_ra_serf__get_mergeinfo): Raise the error when the target item doesn't

exist in the repository.

* subversion/tests/cmdline/merge_tests.py

(merge_unknown_url): New test.

(test_list): Run the new test.

* subversion/tests/cmdline/mergeinfo_tests.py

(mergeinfo_on_unknown_url): New test.

(test_list): Run the new test.

  1. … 4 more files in changeset.
Housekeeping: In the spirit of r26317, remove trailing whitespace in our

repository.

(This touches files in various and sundry parts of the tree, which I shan't

enumerate here.)

  1. … 93 more files in changeset.
Some simplifications to ra-serf's get-locations implementation.

* subversion/libsvn_ra_serf/getlocations.c

(svn_ra_serf__get_locations): Use svn_ra_serf__get_baseline_info()

helper function, and lose a bunch of duplicated logic as a result.

* subversion/include/svn_error_codes.h

(SVN_ERR_WC_COPYFROM_PATH_NOT_FOUND):

* subversion/libsvn_ra_serf/blame.c

(svn_ra_serf__get_file_revs):

* subversion/libsvn_ra_serf/commit.c

(open_root,

add_directory,

close_file):

* subversion/libsvn_ra_serf/property.c

(svn_ra_serf__get_baseline_info):

* subversion/libsvn_ra_serf/serf.c

(svn_ra_serf__get_latest_revnum,

fetch_path_props,

svn_ra_serf__check_path,

svn_ra_serf__get_dir):

* subversion/libsvn_ra_serf/update.c

(fetch_file,

end_report,

finish_report):

* subversion/libsvn_ra_serf/util.c

(svn_ra_serf__discover_root):

* subversion/libsvn_ra_serf/getlocations.c

(svn_ra_serf__get_locations):

Kill trailing periods to meet our error message conventions.

  1. … 7 more files in changeset.
Merged all non-NTLM specific changes of ra_serf-auth branch to trunk:

- difference between trunk r27079 and branches/ra_serf-auth r27090

- reverted subversion/include/svn_error_codes.h,

subversion/libsvn_ra_serf/README,

subversion/libsvn_ra_serf/win32_auth_sspi.c,

subversion/libsvn_ra_serf/win32_auth_sspi.h

TODO - ra_serf-auth,

- reverted NTLM handler from subversion/libsvn_ra_serf/auth.c

  1. … 6 more files in changeset.
* subversion/libsvn_ra_serf/xml.c

(svn_ra_serf__find_attr): Remove; change all callers to use

svn_xml_get_attr_value instead.

  1. … 8 more files in changeset.
ra_serf: Fix error leakage and improve error reporting.

* subversion/libsvn_ra_serf/getlocations.c

(svn_ra_serf__get_locations): Return detailed error from server if

available.

ra_serf: remove a series of PROPFIND related aborts, replaced them with a

correct error message:

* subversion/libsvn_ra_serf/blame.c

(svn_ra_serf__get_file_revs)

* subversion/libsvn_ra_serf/commit.c

(open_root, add_directory, close_file)

* subversion/libsvn_ra_serf/getlocations.c

(svn_ra_serf__get_locations)

* subversion/libsvn_ra_serf/log.c

(svn_ra_serf__get_log)

* subversion/libsvn_ra_serf/serf.c

(svn_ra_serf__get_latest_revnum, fetch_path_props, svn_ra_serf__check_path,

svn_ra_serf__get_dir)

* subversion/libsvn_ra_serf/update.c

(end_report, finish_report)

* subversion/libsvn_ra_serf/util.c

(svn_ra_serf__discover_root)

  1. … 6 more files in changeset.
Fix several files with svn:eol-style missing.

* subversion/libsvn_subr/constructors.c,

subversion/libsvn_subr/user.c,

subversion/libsvn_subr/atomic.c,

subversion/libsvn_subr/compat.c,

subversion/libsvn_subr/dso.c,

subversion/libsvn_client/util.c,

subversion/libsvn_client/compat_providers.c,

subversion/libsvn_client/repos_diff_summarize.c,

subversion/libsvn_ra_serf/merge.c,

subversion/libsvn_ra_serf/serf.c,

subversion/libsvn_ra_serf/xml.c,

subversion/libsvn_ra_serf/propfind_buckets.c,

subversion/libsvn_ra_serf/locks.c,

subversion/libsvn_ra_serf/getlocks.c,

subversion/libsvn_ra_serf/util.c,

subversion/libsvn_ra_serf/getdate.c,

subversion/libsvn_ra_serf/blame.c,

subversion/libsvn_ra_serf/log.c,

subversion/libsvn_ra_serf/update.c,

subversion/libsvn_ra_serf/property.c,

subversion/libsvn_ra_serf/commit.c,

subversion/libsvn_ra_serf/getlocations.c,

subversion/libsvn_ra_serf/options.c,

subversion/libsvn_ra_serf/replay.c,

subversion/mod_dav_svn/mirror.c,

subversion/mod_dav_svn/reports/replay.c,

subversion/tests/libsvn_subr/error-test.c,

subversion/libsvn_ra_svn/streams.c,

subversion/libsvn_ra_svn/sasl_auth.c,

subversion/libsvn_ra_svn/simple_auth.c,

subversion/libsvn_delta/debug_editor.c,

subversion/libsvn_ra_dav/replay.c,

subversion/svnserve/sasl_auth.c,

tools/server-side/svnauthz-validate.c,

contrib/server-side/mod_dontdothat/mod_dontdothat.c:

Set the svn:eol-style=native.

  1. … 34 more files in changeset.
ra_serf: Rename getloc.c to getlocations.c to disambiguate with getlocks.c.

  1. … 1 more file in changeset.