Checkout Tools
  • last updated 45 mins ago
Constraints: committers
Constraints: files
Constraints: dates
Just remove svn_fs_base__key_compare().

The function has different semantics than strcmp, but this doesn't matter for

how we use it. Leaving the macro around essentially means we need to document

strcmp again which is silly.

* subversion/libsvn_fs_base/key-gen.h

(svn_fs_base__key_compare): Remove.

* subversion/libsvn_fs_base/revs-txns.c

(delete_txn_tree): Update callers to use strcmp directly.

* subversion/libsvn_fs_base/tree.c

(get_copy_inheritance, txn_body_copied_from, txn_body_history_prev): ...

  1. … 2 more files in changeset.
Remove the overthought svn_fs_base__key_compare() function.

The old implmenetation ran strlen() on both strings, which in my opinion is a

really dubious optimization. I kinda doubt that walking both strings twice in

cases where the key is the same size is optimally better than saving the

character comparisons when they are different sizes. I'd bet that we're

comparing identically sized strings a lot of the time. Forcing -1, 0, or 1

as the only return values seems entirely pointless to me since the only thing

we ever do is test for 0 when calling this.

This incidentally fixes a compiler warning since we we were putting the return

of strlen into an int which isn't necessarily the same size as the strlen().

* subversion/libsvn_fs_base/key-gen.h

(svn_fs_base__key_compare): Convert the function to a macro to strcmp and

update the documentation to not promise things strcmp() doesn't promise.

* subversion/libsvn_fs_base/key-gen.c

(svn_fs_base__key_compare): Delete.

  1. … 1 more file in changeset.
Test out my new and fancy ASF commit priviledges by changing the copyright

wording in our license headers to reflect ownership by the ASF.


Change terminology to ASF, and update a link.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the ASF, and update the project website.

* everywhere:

Change license text to reflect ASF ownership.

  1. … 891 more files in changeset.
Relicense Subversion under the Apache License, Version 2.0.

* NOTICE: New.



subversion/LICENSE: Remove.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the SVN Corp, and that it contains contributions from

many people, as referenced in NOTICE.

* subversion/bindings/swig/python/LICENSE_FOR_PYTHON_BINDINGS:

Relicense the SVN parts under Apache 2.0.

* everywhere:

Change copyright notices in file headers to reflect the Apache 2.0 license.

  1. … 882 more files in changeset.
Move the skel code to libsvn_subr for private use by other libs.

- Renamed functions into svn_skel__* namespace

- Created #defines for old names, mapping to new. This keeps this change

to a small, manageable size.

- Adjusted #include lines for location of new header

- Applied const to some skel function params

- Switched some 0 values to NULL in the skel code (old -> new style)

* subversion/libsvn_fs_base/util/skel.h: renamed to ...

* subversion/include/private/svn_skel.h: here.

- renamed functions, add const to params

(svn_skel__getsize, svn_skel__putsize): moved from key-gen.h

* subversion/libsvn_fs_base/util/skel.c: renamed to ...

* subversion/libsvn_subr/skel.c: here.

- renamed functions, add const to params

(svn_skel__getsize, svn_skel__putsize): moved from key-gen.c

* subversion/libsvn_fs_base/key-gen.h:

(svn_fs_base__getsize, svn_fs_base__putsize): moved to svn_skel.h

* subversion/libsvn_fs_base/key-gen.c:

(svn_fs_base__getsize, svn_fs_base__putsize): moved to skel.c

* subversion/libsvn_fs_base/bdb/dbt.h:

* subversion/libsvn_fs_base/bdb/copies-table.c:

* subversion/libsvn_fs_base/bdb/lock-tokens-table.c:

* subversion/libsvn_fs_base/bdb/nodes-table.c:

* subversion/libsvn_fs_base/bdb/txn-table.c:

* subversion/libsvn_fs_base/bdb/locks-table.c:

* subversion/libsvn_fs_base/bdb/rev-table.c:

* subversion/libsvn_fs_base/util/fs_skels.h:

* subversion/libsvn_fs_base/util/fs_skels.c:

* subversion/tests/libsvn_fs_base/changes-test.c:

* subversion/tests/libsvn_fs_base/skel-test.c:

* subversion/tests/libsvn_fs_base/strings-reps-test.c:

- adjust includes

  1. … 17 more files in changeset.
* subversion/libsvn_fs_base/key-gen.h: Tiny comment tweak.

Reformat the code to use a consistent no-space-before-param-list-paren style.

See here for the vote that decided this:

From: "Peter N. Lundblad" <>

To: "Peter N. Lundblad" <>


Subject: Results of: [VOTE] New space-before-parens style

Date: Wed, 8 Feb 2006 12:00:35 +0100 (CET)

Message-ID: <Pine.LNX.4.55.0602080918350.10805@localhost.localdomain>

I took the opportunity to make spacing among all parens in SVN_ERR

macro calls consistent. But I did not address consistency of casts,

nor whether a function name should always appear below its return type

in declarations and definitions, nor whether there should be a space

before/after the "*" when declaring pointer return types.

* www/hacking.html

(coding-style): Document that we are no-space-before-paren now.

* everywhere: Reformat.

  1. … 365 more files in changeset.
Fix small errors in comments.

* subversion/include/svn_client.h

* subversion/include/svn_error.h

* subversion/include/svn_io.h

* subversion/include/svn_utf.h

* subversion/include/svn_wc.h

* subversion/include/svn_xml.h

* subversion/libsvn_delta/svndiff.c

* subversion/libsvn_fs_base/key-gen.h

* subversion/libsvn_fs_fs/fs_fs.c

* subversion/svn/blame-cmd.c

Fix typos and similar small errors in comments.

* subversion/svn/main.c

* subversion/svnadmin/main.c

* subversion/svndumpfilter/main.c

* subversion/svnlook/main.c

* subversion/svnserve/main.c

Remove an incorrect comment.

* subversion/libsvn_subr/io.c

Update a comment to reflect changes in APR.

* subversion/include/svn_fs.h

* subversion/include/svn_user.h

Change some comments into Doxygen style.

  1. … 17 more files in changeset.
Merge the changes from the fs-abstraction branch. This allows the

libsvn_fs_fs filesystem to sit alongside the old BDB filesystem in the

same executable.

  1. … 89 more files in changeset.