Checkout Tools
  • last updated 1 hour ago
Constraints: committers
Constraints: files
Constraints: dates
Fix the build over BDB.

* subversion/libsvn_fs_base/err.c

(svn_fs_base__err_dangling_rev): Log the UUID rather than the fs' diskpath.

Test out my new and fancy ASF commit priviledges by changing the copyright

wording in our license headers to reflect ownership by the ASF.


Change terminology to ASF, and update a link.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the ASF, and update the project website.

* everywhere:

Change license text to reflect ASF ownership.

  1. … 891 more files in changeset.
Relicense Subversion under the Apache License, Version 2.0.

* NOTICE: New.



subversion/LICENSE: Remove.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the SVN Corp, and that it contains contributions from

many people, as referenced in NOTICE.

* subversion/bindings/swig/python/LICENSE_FOR_PYTHON_BINDINGS:

Relicense the SVN parts under Apache 2.0.

* everywhere:

Change copyright notices in file headers to reflect the Apache 2.0 license.

  1. … 882 more files in changeset.
Merge the fs-rep-sharing branch to trunk.

This gives us significant space savings on both bdb and fsfs. See the

branch for individual log messages.

  1. … 38 more files in changeset.
Tweak the svn_fs_bdb__miscellaneous_get() interface to match the feel

of our property handling stuffs (and purge unnecessary bits that

result from this change).

* subversion/libsvn_fs_base/bdb/miscellaneous-table.h,

* subversion/libsvn_fs_base/bdb/miscellaneous-table.c

(svn_fs_bdb__miscellaneous_get): Return NULL for missing items

instead of a custom error.

* subversion/include/svn_error_codes.h

(SVN_ERR_FS_NO_SUCH_MISCELLANY): Remove as unused.

* subversion/libsvn_fs_base/err.h,

* subversion/libsvn_fs_base/err.c

(svn_fs_base__err_no_such_miscellany): Remove as unused.

* subversion/libsvn_fs_base/tree.c

(txn_body_miscellaneous_get): Track changes to the

svn_fs_bdb__miscellaneous_get() interface.

  1. … 5 more files in changeset.
Rename the 'metadata' BDB database to 'miscellaneous' (to preserve the

nanofeature of having all those tables end with 's').

* subversion/libsvn_fs_base/tree.h,

* subversion/libsvn_fs_base/tree.c

Rename a gang of functions and structures, for which all

callers/consumers were updated:

struct metadata_set_args -> struct miscellaneous_set_args

txn_body_metadata_set() -> txn_body_miscellaneous_set

svn_fs_base__metadata_set() -> svn_fs_base__miscellaneous_set

struct metadata_get_args -> struct miscellaneous_get_args

txn_body_metadata_get() -> txn_body_miscellaneous_get

svn_fs_base__metadata_get() -> svn_fs_base__miscellaneous_get

* subversion/libsvn_fs_base/bdb/metadata-table.h,

* subversion/libsvn_fs_base/bdb/metadata-table.c

Renamed to...

* subversion/libsvn_fs_base/bdb/miscellaneous-table.h,

* subversion/libsvn_fs_base/bdb/miscellaneous-table.c

...this. Also, rename the functions *within* the files (all callers

updated, too):

svn_fs_bdb__open_metadata_table -> svn_fs_bdb__open_miscellaneous_table

svn_fs_bdb__metadata_set -> svn_fs_bdb__miscellaneous_set

svn_fs_bdb__metadata_get -> svn_fs_bdb__miscellaneous_get

* subversion/libsvn_fs_base/notes/structure

Fix the BNF for the 'checksum-reps' table, and add such for the

'miscellaneous' table.

* subversion/libsvn_fs_base/fs.c

(cleanup_fs): Track renames of functions and #defines, and

expect/demand the new database file name.

* subversion/libsvn_fs_base/fs.h



(base_fs_data_t): Rename 'metadata' variable to 'miscellaneous'.

* subversion/libsvn_fs_base/err.h,

* subversion/libsvn_fs_base/err.c

(svn_fs_base__err_no_such_miscellany): Was

svn_fs_base__err_no_such_metadata, and now returns an error

message that refers to the new table name.

* subversion/include/svn_error_codes.h


  1. … 11 more files in changeset.
Add a `metadata' table for Berkeley DB filesystems. This is just a place

to stash key/value pairs which are of interest to the filesystem.

* subversion/libsvn_fs_base/bdb/metadata-table.c,



* subversion/libsvn_fs_base/fs.c

(cleanup_fs): Cleanup metadata table.

(open_databases): Open metadata table.

* subversion/libsvn_fs_base/fs.h


(base_fs_data_t): Add metadata table.

* subversion/libsvn_fs_base/err.c,


(svn_fs_base__err_no_such_metadata): New.

* subversion/include/svn_error_codes.h


  1. … 6 more files in changeset.
Make 45 pass with --fs-type bdb again.

* subversion/libsvn_fs_base/err.c

(svn_fs_base__err_dangling_rev): Change error text to be more

consistent with what FSFS uses (and sound less like an internal

corruption of the repository anyway).

Add new 'node-origins' table, which is an index mapping node IDs ->

origin node revision IDs, for BDB-backed repositories.

* subversion/libsvn_fs_base/err.h,

* subversion/libsvn_fs_base/err.c

(svn_fs_base__err_no_such_node_origin): New.

* subversion/libsvn_fs_base/bdb/node-origins-table.h,

* subversion/libsvn_fs_base/bdb/node-origins-table.c

New files, implementing functionality for the new BDB `node-origins' table.

* subversion/libsvn_fs_base/fs.c

(cleanup_fs): Cleanup the `node-origins' table.

(open_databases): Open (or create) the `node-origins' table.

(base_hotcopy): Copy the `node-origins' table.

* subversion/libsvn_fs_base/fs.h

(base_fs_data_t): Add 'node_origins' member.

* subversion/include/svn_error_codes.h


  1. … 6 more files in changeset.
Move re-usable functions from err.c file in libsvn-fs-fs and

libsvn-fs-base libraries to fs-util.c file in libsvn-fs-util library.

* subversion/include/private/svn_fs_util.h

* subversion/libsvn_fs_util/fs-util.c

(svn_fs__check_fs, svn_fs__err_not_mutable,

svn_fs__err_not_directory, svn_fs__err_not_file,

svn_fs__err_no_such_lock, svn_fs__err_lock_expired,

svn_fs__err_no_user, svn_fs__err_lock_owner_mismatch,

svn_fs__err_path_already_locked): New functions, the result of a

merger from similar functions redundantly defined in both FS backend


* subversion/libsvn_fs_base/err.c

* subversion/libsvn_fs_base/err.h

(svn_fs_base__check_fs, svn_fs_base__err_not_mutable,

svn_fs_base__err_not_directory, svn_fs_base__err_not_file,

svn_fs_base__err_no_such_lock, svn_fs_base__err_lock_expired,

svn_fs_base__err_no_user, svn_fs_base__err_lock_owner_mismatch,

svn_fs_base__err_path_already_locked): Relocated to (and renamed

in) svn_fs_util.

* subversion/libsvn_fs_fs/err.c

* subversion/libsvn_fs_fs/err.h

(svn_fs_fs__check_fs, svn_fs_fs__err_not_mutable,

svn_fs_fs__err_not_directory, svn_fs_fs__err_not_file,

svn_fs_fs__err_no_such_lock, svn_fs_fs__err_lock_expired,

svn_fs_fs__err_no_user, svn_fs_fs__err_lock_owner_mismatch,

svn_fs_fs__err_path_already_locked): Relocated to (and renamed

in) svn_fs_util.

* subversion/libsvn_fs_base/tree.c,

* subversion/libsvn_fs_base/bdb/locks-table.c,

* subversion/libsvn_fs_base/bdb/lock-tokens-table.c,

* subversion/libsvn_fs_base/bdb/rev-table.c,

* subversion/libsvn_fs_base/uuid.c,

* subversion/libsvn_fs_base/fs.c,

* subversion/libsvn_fs_base/revs-txns.c,

* subversion/libsvn_fs_base/lock.c,

* subversion/libsvn_fs_fs/tree.c,

* subversion/libsvn_fs_fs/fs_fs.c,

* subversion/libsvn_fs_fs/lock.c

Include new library "private/svn_fs_util.h". Update references to

relocated (and renamed) error-generation functions.

Approved by: cmpilato

  1. … 16 more files in changeset.
Reformat the code to use a consistent no-space-before-param-list-paren style.

See here for the vote that decided this:

From: "Peter N. Lundblad" <>

To: "Peter N. Lundblad" <>


Subject: Results of: [VOTE] New space-before-parens style

Date: Wed, 8 Feb 2006 12:00:35 +0100 (CET)

Message-ID: <Pine.LNX.4.55.0602080918350.10805@localhost.localdomain>

I took the opportunity to make spacing among all parens in SVN_ERR

macro calls consistent. But I did not address consistency of casts,

nor whether a function name should always appear below its return type

in declarations and definitions, nor whether there should be a space

before/after the "*" when declaring pointer return types.

* www/hacking.html

(coding-style): Document that we are no-space-before-paren now.

* everywhere: Reformat.

  1. … 365 more files in changeset.
Delete some unused functions (and a string constant).

* subversion/libsvn_fs_base/err.c

* subversion/libsvn_fs_base/err.h

(svn_fs_base__err_corrupt_node_revision, svn_fs_base__err_corrupt_clone,

svn_fs_base__err_corrupt_id, svn_fs_base__err_corrupt_nodes_key,

svn_fs_base__err_corrupt_next_id, svn_fs_base__err_path_syntax): Delete.

(corrupt_id): Delete (from err.c).

(svn_fs_base__err_corrupt_representation): Delete (from err.h).

* subversion/libsvn_fs_fs/err.c

* subversion/libsvn_fs_fs/err.h

(svn_fs_fs__err_corrupt_node_revision, svn_fs_fs__err_corrupt_fs_revision,

svn_fs_fs__err_corrupt_id, svn_fs_fs__err_corrupt_clone,

svn_fs_fs__err_dangling_rev, svn_fs_fs__err_corrupt_nodes_key,

svn_fs_fs__err_corrupt_next_id, svn_fs_fs__err_corrupt_txn,

svn_fs_fs__err_corrupt_copy, svn_fs_fs__err_path_syntax,

svn_fs_fs__err_no_such_txn, svn_fs_fs__err_no_such_copy,

svn_fs_fs__err_bad_lock_token): Delete.

(corrupt_id): Delete (from err.c).

(svn_fs_fs__err_corrupt_representation): Delete (from err.h).

* subversion/libsvn_fs_fs/key-gen.c

* subversion/libsvn_fs_fs/key-gen.h

(svn_fs_fs__getsize, svn_fs_fs__putsize, NEXT_KEY_KEY, svn_fs_fs__same_keys):


  1. … 5 more files in changeset.
Remove spurious differences between similar source files.

* subversion/libsvn_fs_base/err.c

Mark some messages for internationalisation.

Tweak white space.

* subversion/libsvn_fs_base/err.h

Correct some comments.

* subversion/libsvn_fs_fs/err.c

Remove an unused include file.

Rearrange the order of functions to match the libsvn_fs_base version.

Tweak white space.

* subversion/libsvn_fs_fs/err.h

Rearrange the order of functions to match the libsvn_fs_base version.

Tweak white space.

  1. … 3 more files in changeset.
Rename a locking error code for clarity.

* subversion/include/svn_error_codes.h

(SVN_ERR_FS_PATH_LOCKED): Rename to ...

(SVN_ERR_FS_PATH_ALREADY_LOCKED): New name; change message accordingly.

* subversion/libsvn_fs_base/err.c

* subversion/libsvn_fs_base/err.h

(svn_fs_base__err_path_locked): Rename to ...

(svn_fs_base__err_path_already_locked): New name; change message accordingly.

* subversion/libsvn_fs_fs/err.c

* subversion/libsvn_fs_fs/err.h

(svn_fs_fs__err_path_locked): Rename to ...

(svn_fs_fs__err_path_already_locked): New name; change message accordingly.

* subversion/include/svn_error.h (SVN_ERR_IS_LOCK_ERROR)

* subversion/include/svn_fs.h (svn_fs_lock)

* subversion/libsvn_fs_base/lock.c (txn_body_lock)

* subversion/libsvn_fs_fs/lock.c (lock_body)

* subversion/libsvn_ra_dav/commit.c (commit_delete_entry)

Update call sites and comments accordingly.

  1. … 9 more files in changeset.
Merge locking branch to trunk, by comparing trunkURL with branchURL.

This is not a test. This is an actual addition of a very large feature.

This merge passes 'make check' over all three RA implementations.

To see commit logs for this feature, examine /branches/locking, r11749:13570.

  1. … 183 more files in changeset.
Mark (error) messages for translation in libsvn_fs_base and libsvn_fs_fs.
  1. … 10 more files in changeset.
Rationalize #includes in C source files.

If a file does not use symbols from a given header, then do not include

that header.

If a file uses symbols from a given header 'H', and H was only being

included via another header that neither needs nor guarantees to include

H, then include H directly.

(By "symbols from a given header" I mean symbols that it either defines

itself or pulls in from other headers with the specific intention of

providing them to its users.)

  1. … 149 more files in changeset.
_() markers added in many places with strings involving revision numbers.

Also removed single quotes around revision numbers.

Approved by bliss.

  1. … 21 more files in changeset.
Eliminate all uses of SVN_REVNUM_T_FMT in every C source file that used it.

Replace every occurence with 'ld' and concatenate string constants


Approved by brane.

  1. … 55 more files in changeset.
Stop consuming the public svn_fs API from the FS modules. This should

break the cyclical dependencies between libsvn_fs and the FS modules.

* libsvn_fs_base/tree.c,









libsvn_fs_fs/err.c: Don't use the public svn_fs API. Use direct

field references or internal functions as appropriate.

  1. … 9 more files in changeset.
Merge the changes from the fs-abstraction branch. This allows the

libsvn_fs_fs filesystem to sit alongside the old BDB filesystem in the

same executable.

  1. … 89 more files in changeset.