Checkout Tools
Constraints: committers
Constraints: files
Constraints: dates
Fix various typos detected by codespell

* libsvn_client/add.c, libsvn_client/blame.c, libsvn_client/commit_util.c,

libsvn_client/conflicts.c, libsvn_client/copy.c, libsvn_client/diff.c,

libsvn_client/export.c, libsvn_client/import.c, libsvn_client/merge.c,

libsvn_client/mergeinfo.c, libsvn_client/mergeinfo.h, libsvn_client/patch.c,

libsvn_client/switch.c, libsvn_client/update.c, libsvn_delta/branch_compat.c,

libsvn_delta/compat.c, libsvn_delta/compose_delta.c, libsvn_delta/svndiff.c,

libsvn_delta/xdelta.c, libsvn_diff/deprecated.c, libsvn_diff/diff_file.c,

libsvn_fs/fs-loader.c, libsvn_fs_base/bdb/locks-table.c, libsvn_fs_base/fs.c,

libsvn_fs_base/key-gen.c, libsvn_fs_base/notes/fs-history,

libsvn_fs_base/reps-strings.c, libsvn_fs_base/tree.c,

libsvn_fs_fs/cached_data.c, libsvn_fs_fs/hotcopy.c, libsvn_fs_fs/index.c,

libsvn_fs_fs/low_level.c, libsvn_fs_fs/pack.c, libsvn_fs_fs/structure,

libsvn_fs_fs/temp_serializer.c, libsvn_fs_fs/transaction.c,

libsvn_fs_fs/tree.c, libsvn_fs_fs/util.h, libsvn_fs_x/cached_data.c,

libsvn_fs_x/caching.c, libsvn_fs_x/hotcopy.c, libsvn_fs_x/id.h,

libsvn_fs_x/index.c, libsvn_fs_x/low_level.c, libsvn_fs_x/pack.c,

libsvn_fs_x/rev_file.c, libsvn_fs_x/structure, libsvn_fs_x/temp_serializer.c,

libsvn_fs_x/transaction.c, libsvn_fs_x/tree.c, libsvn_fs_x/util.h,

libsvn_ra/ra_loader.c, libsvn_ra/ra_loader.h, libsvn_ra/util.c,

libsvn_ra/wrapper_template.h, libsvn_ra_local/ra_plugin.c,

libsvn_ra_serf/commit.c, libsvn_ra_serf/get_file.c,

libsvn_ra_serf/property.c, libsvn_ra_serf/ra_serf.h, libsvn_ra_serf/update.c,

libsvn_ra_serf/util.c, libsvn_ra_svn/client.c, libsvn_ra_svn/cyrus_auth.c,

libsvn_ra_svn/marshal.c, libsvn_repos/authz_parse.c, libsvn_repos/commit.c,

libsvn_repos/compat.c, libsvn_repos/hooks.c, libsvn_repos/load.c,

libsvn_repos/log.c, libsvn_repos/notify.c, libsvn_repos/repos.c,

libsvn_repos/repos.h, libsvn_subr/cache-memcache.c, libsvn_subr/cmdline.c,

libsvn_subr/config_file.c, libsvn_subr/date.c, libsvn_subr/gpg_agent.c,

libsvn_subr/io.c, libsvn_subr/object_pool.c, libsvn_subr/path.c,

libsvn_subr/prompt.c, libsvn_subr/string.c, libsvn_subr/sysinfo.c,

libsvn_subr/temp_serializer.c, libsvn_subr/utf.c, libsvn_subr/utf8proc.c,

libsvn_subr/version.c, libsvn_subr/win32_xlate.c, libsvn_subr/x509parse.c,

libsvn_wc/conflicts.c, libsvn_wc/conflicts.h, libsvn_wc/copy.c,

libsvn_wc/lock.c, libsvn_wc/wc_db.c, libsvn_wc/wc_db.h,


(): Spelling fixes

  1. … 97 more files in changeset.
Fix an out-of-bounds read in the delta combiner.

* subversion/libsvn_delta/compose_delta.c (copy_source_ops):

When initializing fix_limit, do not read past the end of the offsets array.

* subversion/libsvn_delta/compose_delta.c (copy_source_ops): Avoid a warning

about condition always being true by unconditionally issuing the second

half of an overlapping target copy.

Also make reading the code slightly easier by making fix_offset and fix_limit

local constants.

Reintegrate integrate-string-improvements branch into /trunk.
  1. … 83 more files in changeset.
Adjust references to pre-ASF-migration revisions by the +840074 offset.

Did *.h, *.c, and *.py files this go-round. Was thinking of doing everything

in five minutes, until I saw CHANGES (which needs a conversion script unless

you enjoy grunt work).

* subversion/libsvn_client/externals.c

* subversion/libsvn_client/log.c

* subversion/libsvn_client/repos_diff.c

* subversion/libsvn_delta/compose_delta.c

* subversion/libsvn_subr/error.c

* subversion/libsvn_subr/io.c

* subversion/libsvn_wc/diff.c

* subversion/svnserve/serve.c

* subversion/tests/cmdline/

* subversion/tests/cmdline/

* subversion/tests/cmdline/

* subversion/tests/cmdline/

* subversion/tests/cmdline/

* subversion/tests/cmdline/

* subversion/tests/libsvn_repos/repos-test.c

* tools/buildbot/master/

* tools/dev/

  1. … 16 more files in changeset.
Just padding my stats.

(Actually, doing my regular trailing whitespace removal, similar to r875968.)

* everywhere:

for extsn in c h cpp java py pl rb; do

sed -i -e 's/[ \t]*$//' `find . -name "*.$extsn" | xargs grep '[ \t]$' -l`


  1. … 166 more files in changeset.
Various local optimizations. These opportunities became visible after

significantly optimizing other parts of svn. The total savings for a 'svn

export' is almost 3 percent.

The largest savings can be attributed to the svndiff.c

changes (~1.5%) and the checksum parser (~1%).

* subversion/include/svn_delta.h

(enum svn_delta_action): Document that these enum values must match the

encoding values.

* subversion/libsvn_delta/compose_delta.c

(search_offset_index, copy_source_ops): Use size_t to index memory. This

is mainly a consistency fix but may actually result in slightly higher

performance due to fewer conversions.

* subversion/libsvn_delta/svndiff.c

(decode_file_offset, decode_size): Use slightly more efficient


(decode_instruction): Directly map action codes, avoiding a 'switch'.

* subversion/libsvn_subr/checksum.c

(svn_checksum_parse_hex): Eliminate calls to locale-aware CRT functions.

At least with MS compilers, these are very expensive.

* subversion/libsvn_subr/stream.c

(stream_readline): Hoist 'numbytes' from the loop: it is invariant until


Patch by: Stefan Fuhrmann <stefanfuhrmann{_AT_}>

  1. … 4 more files in changeset.
Optimize the copy operation table lookup.

* subversion/libsvn_delta/compose_delta.c

(search_offset_index): Add hint parameter and use a simpler binary

search implementation.

(copy_source_ops): Add hint parameter to pass through to

search_offset_index. Check for upper limit on-the-fly.

(svn_txdelta_compose_windows): Pass default value for hint to


Patch by: stefanfuhrmann < at >

Test out my new and fancy ASF commit priviledges by changing the copyright

wording in our license headers to reflect ownership by the ASF.


Change terminology to ASF, and update a link.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the ASF, and update the project website.

* everywhere:

Change license text to reflect ASF ownership.

  1. … 891 more files in changeset.
Relicense Subversion under the Apache License, Version 2.0.

* NOTICE: New.



subversion/LICENSE: Remove.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the SVN Corp, and that it contains contributions from

many people, as referenced in NOTICE.

* subversion/bindings/swig/python/LICENSE_FOR_PYTHON_BINDINGS:

Relicense the SVN parts under Apache 2.0.

* everywhere:

Change copyright notices in file headers to reflect the Apache 2.0 license.

  1. … 882 more files in changeset.
Removed an unused function.

* subversion/libsvn_wc/compose_delta.c:

(svn_txdelta__compose_windows): removed. dunno why it ever existed.

* subversion/libsvn_delta/compose_delta.c

(build_range_list): Replace assert() with SVN_ERR_MALFUNCTION_NO_RETURN()

to remove warning on no return value.

* subversion/libsvn_delta/compose_delta.c

(build_range_list): Remove some unreachable code.

r30661 removed the only use of the vdelta algorithm from Subversion,

so we clean up the now-dead code.

I did leave the misnamed vdelta-test alone.

* subversion/libsvn_delta/vdelta.c


* subversion/libsvn_delta/delta.h

(svn_txdelta__vdelta): Remove.

* subversion/libsvn_delta/compose_delta.c

(build_range_list): Tweak comment that referred to VD_KEY_SIZE.

* subversion/libsvn_delta/text_delta.c

(struct txdelta_baton): Tweak comment on buf member.

(compute_window, svn_txdelta__insert_op): Tweak comment.

* subversion/libsvn_delta/xdelta.c

(svn_txdelta__xdelta): Tweak comment.

* subversion/libsvn_fs_fs/fs_fs.c

(get_contents): Tweak comment.

* subversion/mod_dav_svn/reports/update.c

(upd_open_file): Tweak comment.

  1. … 6 more files in changeset.
Channeling Erik Hülsmann, remove all trailing whitespace within our source


for extsn in c h cpp java py pl rb; do

sed -i -e 's/[ \t]*$//' `find . -name "*.$extsn" | xargs grep '[ \t]$' -l`


Inspired by: ehu

  1. … 449 more files in changeset.
Reformat the code to use a consistent no-space-before-param-list-paren style.

See here for the vote that decided this:

From: "Peter N. Lundblad" <>

To: "Peter N. Lundblad" <>


Subject: Results of: [VOTE] New space-before-parens style

Date: Wed, 8 Feb 2006 12:00:35 +0100 (CET)

Message-ID: <Pine.LNX.4.55.0602080918350.10805@localhost.localdomain>

I took the opportunity to make spacing among all parens in SVN_ERR

macro calls consistent. But I did not address consistency of casts,

nor whether a function name should always appear below its return type

in declarations and definitions, nor whether there should be a space

before/after the "*" when declaring pointer return types.

* www/hacking.html

(coding-style): Document that we are no-space-before-paren now.

* everywhere: Reformat.

  1. … 365 more files in changeset.
Add private interlibrary compatibility wrappers:

svn_txdelta__apply_instructions(), svn_txdelta__compose_windows().

Followup to: r17290 (removal of these functions)

r16614 (first introduction of private interlibrary compat wrapper)

* subversion/libsvn_delta/compose_delta.c (svn_txdelta__compose_windows):

* subversion/libsvn_delta/text_delta.c (svn_txdelta__apply_instructions):

Add compatibility wrapper.

  1. … 1 more file in changeset.
Fix violations of our policy regarding public/private symbols.

* subversion/libsvn_delta/delta.h


svn_txdelta__apply_instructions): remove declarations here...

* subversion/include/svn_delta.h


svn_txdelta_apply_instructions): ... and declare here, as public funcs.

* subversion/libsvn_delta/compose_delta.c

(svn_txdelta_compose_windows): was svn_txdelta__compose_windows.

* subversion/libsvn_delta/text_delta.c

(svn_txdelta_apply_instructions): was svn_txdelta_apply_instructions.

(apply_window): call public function instead of private one.

* subversion/libsvn_fs_base/reps-strings.c

(../libsvn_delta/delta.h): stop #including private library header.

(compose_handler): call public functions instead of private ones.

(rep_undeltify_range): call public function instead of private one.

* subversion/libsvn_fs_fs/fs_fs.c

(../libsvn_delta/delta.h): stop #including private library header.

(get_combined_window): call public function instead of private one.

(get_contents): call public function instead of private one.

* subversion/tests/libsvn_delta/random-test.c

(do_random_combine_test): call public function instead of private one.

* subversion/tests/libsvn_delta/vdelta-test.c

(main): call public function instead of private one.

  1. … 7 more files in changeset.
* subversion/libsvn_delta/compose_delta.c

(copy_source_ops): Add a FIXME comment to some dubious code.

* subversion/libsvn_delta/text_delta.c

(svn_txdelta__apply_instructions): Remove an assert since it's

pointless to test "unsigned >= 0".

  1. … 1 more file in changeset.
Follow up to r11401:

* subversion/libsvn_delta/compose_delta.c

(copy_source_ops): Define a MIN macro if there isn't one already

provided, and use it instead of defining our own custom macro and

then undefing it, which might result in a) blowing away another

macro of the same name, and then b) removing that macro out from

underneath the system that put it into place.

Resolve issue #2096: We were temporarily #defining MIN, and then

#undefining it when done. But some systems define MIN themselves, and

not only did our definition replace theirs (not a big deal, since ours

almost certainly did exactly the same thing as the system's), when we

later undefined it, we effectively removed both definitions. Oops.

Solution: use a different name.

* subversion/libsvn_delta/compose_delta.c

(copy_source_ops): Use TMP_MIN instead of MIN, to avoid overlap with

a possible system-defined MIN.

Simplify the delta combiner interface.

* libsvn_delta/compose_delta.c (svn_txdelta__compose_windows): Punt

the context parameter and assume that both deltas are valid.

* libsvn_delta/delta.h

(svn_txdelta__compose_ctx_t): Eliminate.

(svn_txdelta__compose_windows): Punt the context parameter, and

don't document anything about returning NULL if window_B has no

src ops.

* libsvn_fs/reps-strings.c (compose_handler): Punt the context

parameter and the handling of the nonexistent edge cases which

follow from it.

* tests/libsvn_delta/random-test.c (do_random_combine_test): Punt the

contest parameter. Check ourselves if window_B is NULL or

window_B->src_ops is 0.

  1. … 3 more files in changeset.
Update copyright notices for 2004, resolving issue #1651.

(See also revision 8019, which fixed a couple of missed spots.)

  1. … 361 more files in changeset.
The great tab cleanup. Replace all tabs with the appropriate amount

of spaces. Running "svn diff --diff-cmd /usr/bin/diff -x -w" shows no


  1. … 56 more files in changeset.
Get the delta code to use svn_filesize_t or apr_size_t instead of

apr_off_t. This fixes issue 639.

* subversion/include/svn_delta.h (svn_txdelta_window_t::sview_offset):

Use svn_filesize_t instead of apr_off_t.

* subversion/libsvn_delta/compose_delta.c: Replace all uses of apr_off_t

with apr_size_t. All offsets and sizes in the delta combiner are

relative to the window size, and that always fits into and apr_size_t.

(search_offset_index): Remove useless assert now that 'offset' is unsigned.

* subversion/libsvn_delta/delta.h (svn_txdelta__compose_ctx_t::sview_offset):

Use svn_filesize_t instead of apr_off_t.

(svn_txdelta__insert_op): Make 'offset' and 'length' apr_size_t instead

of apr_off_t, since that's what goes into the delta op.

* subversion/libsvn_delta/svndiff.c (encode_int, append_encoded_int):

Use svn_filesize_t instead of apr_off_t.

(decode_baton): Make last_sview_offset an svn_filesize_t.

(decode_int): Use svn_filesize_t instead of apr_off_t. Wherever we decode

an apr_size_t value, add a cast and a comment.

* subversion/libsvn_delta/vdelta.c (store_mapping): Store an apr_size_t,

not an apr_off_t. All uses were already passing apr_size_t's.

* subversion/libsvn_delta/text_delta.c (svn_txdelta_stream_t::pos):

Use svn_filesize_t instead of apr_off_t.

(apply_baton::sbuf_offset): Likewise.

(svn_txdelta__insert_op): Make 'offset' and 'length' apr_size_t.

  1. … 5 more files in changeset.
* Just about everything else that wasn't test output, a binary file,

or already to set to CRLF: Set svn:eol-style to native.

  1. … 658 more files in changeset.
Touch every file in the repository :) 2003 is here, update all the

copyright statements. Also, update the sample `svn --version' output

to be consistent with the current client.

  1. … 443 more files in changeset.
* subversion/libsvn_delta/compose_delta.c

(build_range_list): Fix misspellings in assert message.

Just be glad you're not updating over libsvn_ra_pigeons...

* everywhere: Remove "local variables:" eval blocks.

* subversion/libsvn_repos/hooks.c: But leave the vim stuff here.

* tools/dev/svn-dev.el, doc/book/tools/svnbook.el:

Get rid of obsolete loading instructions.

* HACKING: Describe how to load the elisp files from .emacs.

* doc/book/HACKING: Add querulous comment.

  1. … 338 more files in changeset.
Finishing issue #531.

Merged from -r2412:2781 /branches/issue-531-dev to /trunk.

  1. … 10 more files in changeset.