Checkout Tools
  • last updated 1 hour ago
Constraints: committers
Constraints: files
Constraints: dates

Changeset 863278 is being indexed.

Destroy the APR subpool before every successful return statement.

[in subversion/libsvn_client/]

* delete.c


* repos_diff.c


* externals.c


* list.c


Destroy the APR subpool before returning successfully to prevent

iterative pool creation.

Approved by: dlr

Patch by: me

  1. … 3 more files in changeset.
cancelation -> cancellation.

* subversion/libsvn_ra_dav/util.c

* subversion/libsvn_delta/cancel.c

* subversion/libsvn_client/list.c

Make sure we spell "cancellation" the same way everywhere. :-)

Found by: Ed Price <ed.price{_AT_}>

  1. … 2 more files in changeset.
1.4.x API: Fix svn_ra_get_dir2() to obey output parameters convention,

and also fix the underlying vtable implementation.

Re-order parameters:

* subversion/libsvn_ra/ra_loader.h (svn_ra_get_dir2)

* subversion/libsvn_ra/ra_loader.c (svn_ra_get_dir2)

* subversion/libsvn_ra_local/ra_plugin.c (svn_ra_local__get_dir)

* subversion/libsvn_ra_serf/serf.c (svn_ra_serf__get_dir)

* subversion/libsvn_ra_svn/client.c (ra_svn_get_dir)

* subversion/libsvn_ra_dav/ra_dav.h (svn_ra_dav__get_dir)

* subversion/libsvn_ra_dav/fetch.c (svn_ra_dav__get_dir)

Adjust calls to RA_VTABLE.get_dir():

* subversion/libsvn_ra/wrapper_template.h (compat_get_dir)

* subversion/libsvn_ra/ra_loader.c (svn_ra_get_dir, svn_ra_get_dir2)

Adjust calls to svn_ra_get_dir2():

* subversion/libsvn_client/repos_diff.c (get_dirprops_from_ra)

* subversion/libsvn_client/info.c (push_dir_info, svn_client_info)

* subversion/libsvn_client/prop_commands.c (remote_propget, remote_proplist)

* subversion/libsvn_client/list.c (get_dir_contents, svn_client_list)

  1. … 12 more files in changeset.
Make svn_client_list (new in 1.4.x) use the usual convention for the

placement of the client context object.

Note that this must be merged back to 1.4.x before it is released, or

we will have to revert it for compatibility reasons.

* subversion/include/svn_client.h

(svn_client_list): Move the ctx argument to second to last.

* subversion/libsvn_client/list.c

(svn_client_list): Adjust argument order.

(svn_client_ls3): Update call to svn_client_list.

* subversion/svn/list-cmd.c

(svn_cl__list): Update call to svn_client_list.

* subversion/bindings/swig/ruby/svn/client.rb

(Svn::Client::Context#list): Update call to Client.list.

  1. … 3 more files in changeset.
Fix typos in comments.

* subversion/libsvn_fs_base/notes/structure

Typo fix from Kamesh Jayachandran <>.

* subversion/libsvn_repos/dump.c

Pronunciation consistency fix from Ed Price <>.

* subversion/libsvn_repos/load.c

Move a doc string from inside to just before the function.

* subversion/libsvn_subr/path.c

Delete an obsolete comment.

* subversion/include/svn_io.h

* subversion/include/svn_repos.h

* subversion/include/svn_utf.h

* subversion/libsvn_client/client.h

* subversion/libsvn_client/list.c

* subversion/libsvn_fs_fs/revs-txns.c

* subversion/libsvn_wc/adm_files.c

Fix typos.

  1. … 10 more files in changeset.
Reformat the code to use a consistent no-space-before-param-list-paren style.

See here for the vote that decided this:

From: "Peter N. Lundblad" <>

To: "Peter N. Lundblad" <>


Subject: Results of: [VOTE] New space-before-parens style

Date: Wed, 8 Feb 2006 12:00:35 +0100 (CET)

Message-ID: <Pine.LNX.4.55.0602080918350.10805@localhost.localdomain>

I took the opportunity to make spacing among all parens in SVN_ERR

macro calls consistent. But I did not address consistency of casts,

nor whether a function name should always appear below its return type

in declarations and definitions, nor whether there should be a space

before/after the "*" when declaring pointer return types.

* www/hacking.html

(coding-style): Document that we are no-space-before-paren now.

* everywhere: Reformat.

  1. … 365 more files in changeset.
Fix a lifetime issue with the old svn_client_ls functions.

* subversion/libsvn_client/list.c

(store_dirent): Copy the path into the correct pool before using

it as the hash key.

Fix issue #1809: Replace svn_client_ls and make recursive ls streamy. Make it

possible to determine if the target of an svn_client_list is a file or

directory by always including the listed target dirent in the result.

* subversion/include/svn_types.h (svn_dirent_t): Add note about extending the


(svn_dirent_dup): New function.

* subversion/include/svn_client.h

(svn_client_list_func_t): New typedef.

(svn_client_list): Rename from svn_client_ls4 and change the arguments

to use a callback instead of putting everything in hash tables.

(svn_client_ls3): Expand docstring.

* subversion/libsvn_subr/constructors.c (svn_dirent_dup): New function.

* subversion/libsvn_client/list.c: Rename from ls.c.

(get_dir_contents): Call callback instead of putting things in hashes.

Add docstring.

(svn_client_list): Rename from svn_client_ls4 and use callback instead of

hashes. Report the dirent for the target of the operation for both files

and directories.

(ls_baton, store_dirent): New.

(svn_client_ls3): Rewrite in terms of svn_client_list.

* subversion/svn/cl.h

(svn_cl__list): Rename from svn_cl__ls.

* subversion/svn/list-cmd.c: Rename from ls-cmd.c.

(print_baton): New struct.

(print_dirent): Rename from print_dirents, implement svn_client_list_func_t.

Print one dirent.

(print_dirent_xml): Rename from print_dirents_xml, implement

svn_client_list_func_t. Remove useless comments. Print one dirent.

(svn_cl__list): Rename from svn_cl__ls; caller updated.

Use new svn_client_list. Print XML element list here if in XML mode.

Refactor two nested if statements into one.

  1. … 8 more files in changeset.