Checkout Tools
  • last updated 1 hour ago
Constraints: committers
Constraints: files
Constraints: dates

Changeset 858545 is being indexed.

Reformat the code to use a consistent no-space-before-param-list-paren style.

See here for the vote that decided this:

From: "Peter N. Lundblad" <>

To: "Peter N. Lundblad" <>


Subject: Results of: [VOTE] New space-before-parens style

Date: Wed, 8 Feb 2006 12:00:35 +0100 (CET)

Message-ID: <Pine.LNX.4.55.0602080918350.10805@localhost.localdomain>

I took the opportunity to make spacing among all parens in SVN_ERR

macro calls consistent. But I did not address consistency of casts,

nor whether a function name should always appear below its return type

in declarations and definitions, nor whether there should be a space

before/after the "*" when declaring pointer return types.

* www/hacking.html

(coding-style): Document that we are no-space-before-paren now.

* everywhere: Reformat.

  1. … 365 more files in changeset.
Fix a lifetime issue with the old svn_client_ls functions.

* subversion/libsvn_client/list.c

(store_dirent): Copy the path into the correct pool before using

it as the hash key.

Fix issue #1809: Replace svn_client_ls and make recursive ls streamy. Make it

possible to determine if the target of an svn_client_list is a file or

directory by always including the listed target dirent in the result.

* subversion/include/svn_types.h (svn_dirent_t): Add note about extending the


(svn_dirent_dup): New function.

* subversion/include/svn_client.h

(svn_client_list_func_t): New typedef.

(svn_client_list): Rename from svn_client_ls4 and change the arguments

to use a callback instead of putting everything in hash tables.

(svn_client_ls3): Expand docstring.

* subversion/libsvn_subr/constructors.c (svn_dirent_dup): New function.

* subversion/libsvn_client/list.c: Rename from ls.c.

(get_dir_contents): Call callback instead of putting things in hashes.

Add docstring.

(svn_client_list): Rename from svn_client_ls4 and use callback instead of

hashes. Report the dirent for the target of the operation for both files

and directories.

(ls_baton, store_dirent): New.

(svn_client_ls3): Rewrite in terms of svn_client_list.

* subversion/svn/cl.h

(svn_cl__list): Rename from svn_cl__ls.

* subversion/svn/list-cmd.c: Rename from ls-cmd.c.

(print_baton): New struct.

(print_dirent): Rename from print_dirents, implement svn_client_list_func_t.

Print one dirent.

(print_dirent_xml): Rename from print_dirents_xml, implement

svn_client_list_func_t. Remove useless comments. Print one dirent.

(svn_cl__list): Rename from svn_cl__ls; caller updated.

Use new svn_client_list. Print XML element list here if in XML mode.

Refactor two nested if statements into one.

  1. … 8 more files in changeset.