Checkout Tools
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Update issue tracker links in comments, from Tigris (issuezilla) to Apache (Jira).

URL fragment identifiers like '#desc5' are left in place, not yet updated.

This is a merge of r1828508 from the 'shelve-checkpoint' branch where I

committed it by mistake.

  1. … 43 more files in changeset.
Swap the argument order of svn_utf_initialize2() in its definition and all its

callers to follow our standard ordering rules.

* subversion/include/svn_utf.h

(svn_utf_initialize2): Reorder arguments.

* subversion/libsvn_subr/cmdline.c

(svn_cmdline_init): Update caller.

* subversion/libsvn_subr/deprecated.c

(svn_utf_initialize): Update caller.

* subversion/libsvn_subr/utf.c

(svn_utf_initialize2): Update argument order.

* subversion/mod_dav_svn/mod_dav_svn.c

(init): Update caller.

  1. … 4 more files in changeset.
Add missing SVN_DEPRECATED tags on functions being deprecated for 1.8.

* subversion/include/svn_client.h

(svn_client_move6): As above.

* subversion/include/svn_io.h

(svn_io_stat_dirent,

svn_io_start_cmd2): As above.

* subversion/include/svn_repos.h

(svn_repos_begin_report2): As above.

* subversion/include/svn_utf.h

(svn_utf_initialize): As above. Also correct the cross-reference to the

newer function.

* subversion/include/svn_wc.h

(svn_wc_move): As above.

  1. … 4 more files in changeset.
* subversion/include/svn_utf.h

Comment formatting tweak only.

Add support for determining the display width of a unicode string, and make

use of this when trimming lines for display by the internal file merge tool.

Based on suitably licensed code by Markus Kuhn:

http://www.cl.cam.ac.uk/~mgk25/ucs/wcwidth.c

* LICENSE, NOTICE: Add Markus Kuhn copyright notices.

* subversion/include/svn_utf.h

(svn_utf_cstring_utf8_width): Declare.

* subversion/libsvn_subr/utf_width.c: New file, implementation of the above

newly declared function. This file is based on Markus Kuhn's code, and has

been adapted to use APR types. The svn_utf_cstring_utf8_width() function

was written from scratch and replaces Markus' mk_wcswidth() function.

* subversion/svn/file-merge.c

(MAX_LINE_DISPLAY_LEN): Rename to ...

(LINE_DISPLAY_WIDTH): ... this, because it is not a maximum but a fixed

length since all lines are either trimmed or padded to this length.

(prepare_line_for_display): Use the new character display width support

to properly detect the width of unicode characters (tested with a bunch

of asian texts from wikipedia). Track rename of MAX_LINE_DISPLAY_LEN.

  1. … 4 more files in changeset.
For issue #2487, "mod_dav_svn and locales fail to play nicely together",

add a new configuration option which allows Subversion libraries called

from mod_dav_svn to process UTF-8 strings, instead of just ASCII strings.

Because httpd is not locale-aware, we cannot assume that a native character

set other than ASCII is present in the environment that mod_dav_svn runs in.

UTF-8 is backward compatible to ASCII, and all paths within Subversion

repositories are already encoded in UTF-8. Thus, we can safely allow UTF-8

without running into character set conversion issues in code called from

mod_dav_svn.

Basic testing shows that httpd is prepared to tolerate non-ASCII characters,

even though it doesn't seem to interpret them. E.g. it logs such characters

as hex codes preceded by a backslash.

The new configuration option is called SVNUseUTF8 and can be set to

"On" or "Off" (the default is "Off"). It is a global option that takes

effect for all repository locations defined in the configuration file.

When the option is "On", files that contain UTF-8 characters in their

names can be processed by the pre-lock hook, hooks are able to write

UTF-8 characters to stdout and stderr, and filesystem paths to Subversion

repositories may contain UTF-8 characters.

* subversion/mod_dav_svn/mod_dav_svn.c

(server_conf_t): Add use_utf8 boolean.

(init): Initialise the native character set of Subversion's UTF-8

conversion routines to either ASCII (default) or UTF-8.

(SVNUseUTF8_cmd): New option command processor.

(cmds): Add new "SVNUseUTF8" option.

* subversion/include/svn_utf.h

(svn_utf_initialize2): Declare. Includes the ablity to force the native

character set to UTF-8, regardless of locale.

(svn_utf_initialize): Deprecate.

* subversion/libsvn_subr/deprecated.c

(svn_utf_initialize): Re-implement as wrapper around svn_utf_initialize2().

* subversion/libsvn_subr/cmdline.c

(svn_cmdline_init): Update funtion call to svn_utf_initialize2(), keeping

the native character set based on the current locale.

* subversion/libsvn_subr/utf.c

(svn_utf_initialize2): New.

(assume_native_charset_is_utf8): New global boolean variable. Defaults

to FALSE, and may be set to TRUE by svn_utf_initialize2() (which, like

its predecessor, is documented to not be thread-safe).

(get_ntou_xlate_handle_node, get_uton_xlate_handle_node): If the native

character set has been forced to UTF-8, use SVN_APR_UTF8_CHARSET instead

of SVN_APR_LOCALE_CHARSET.

  1. … 4 more files in changeset.
Test out my new and fancy ASF commit priviledges by changing the copyright

wording in our license headers to reflect ownership by the ASF.

* NOTICE:

Change terminology to ASF, and update a link.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the ASF, and update the project website.

* everywhere:

Change license text to reflect ASF ownership.

  1. … 891 more files in changeset.
* subversion/include/svn_utf.h

Add a newline, for documentation purposes.

Relicense Subversion under the Apache License, Version 2.0.

* NOTICE: New.

* LICENSE: New.

* COPYING,

subversion/LICENSE: Remove.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the SVN Corp, and that it contains contributions from

many people, as referenced in NOTICE.

* subversion/bindings/swig/python/LICENSE_FOR_PYTHON_BINDINGS:

Relicense the SVN parts under Apache 2.0.

* everywhere:

Change copyright notices in file headers to reflect the Apache 2.0 license.

  1. … 882 more files in changeset.
Adjust a bunch of our public header files:

- make sure everything the header needs is included

- make sure nothing is included which is NOT needed

Added an exception to svn_types.h: it now explicitly includes svn_error.h

since Everybody needs that thing. We go ahead and make it easy for them,

even though that is counter-philosophy.

After altering the header files, some .c files in our codebase would not

compile -- they used stuff that they did not explicitly include. Thus, a

goodly number of .c files were updated, too.

* subversion/libsvn_ra/wrapper_template.h:

* subversion/libsvn_ra/deprecated.c:

* subversion/libsvn_ra/compat.c:

* subversion/libsvn_subr/iter.c:

* subversion/libsvn_subr/cmdline.c:

* subversion/libsvn_subr/ssl_client_cert_pw_providers.c:

* subversion/libsvn_subr/error.c:

* subversion/libsvn_subr/auth.c:

* subversion/libsvn_subr/opt.c:

* subversion/libsvn_subr/checksum.c:

* subversion/libsvn_subr/compat.c:

* subversion/libsvn_subr/sha1.c:

* subversion/libsvn_subr/deprecated.c:

* subversion/libsvn_subr/ssl_server_trust_providers.c:

* subversion/mod_dav_svn/activity.c:

* subversion/mod_dav_svn/reports/log.c:

* subversion/tests/libsvn_fs/fs-test.c:

* subversion/tests/libsvn_repos/repos-test.c:

* subversion/svn/list-cmd.c:

* subversion/svn/changelist-cmd.c:

* subversion/svn/log-cmd.c:

* subversion/svn/conflict-callbacks.c:

* subversion/libsvn_fs_base/dag.c:

* subversion/libsvn_fs_base/util/fs_skels.c:

* subversion/include/svn_dirent_uri.h:

* subversion/include/svn_error_codes.h:

* subversion/include/svn_fs.h:

* subversion/include/svn_diff.h:

* subversion/include/svn_sorts.h:

* subversion/include/svn_mergeinfo.h:

* subversion/include/svn_base64.h:

* subversion/include/svn_dso.h:

* subversion/include/svn_ra_svn.h:

* subversion/include/svn_repos.h:

* subversion/include/svn_delta.h:

* subversion/include/svn_path.h:

* subversion/include/svn_subst.h:

* subversion/include/svn_xml.h:

* subversion/include/svn_props.h:

* subversion/include/svn_iter.h:

* subversion/include/svn_types.h:

* subversion/include/svn_config.h:

* subversion/include/svn_string.h:

* subversion/include/svn_io.h:

* subversion/include/svn_wc.h:

* subversion/include/svn_cmdline.h:

* subversion/include/svn_client.h:

* subversion/include/svn_user.h:

* subversion/include/svn_hash.h:

* subversion/include/svn_md5.h:

* subversion/include/svn_error.h:

* subversion/include/svn_pools.h:

* subversion/include/private/svn_log.h:

* subversion/include/svn_time.h:

* subversion/include/svn_utf.h:

* subversion/include/svn_auth.h:

* subversion/include/svn_ra.h:

* subversion/include/svn_opt.h:

* subversion/include/svn_checksum.h:

* subversion/libsvn_wc/deprecated.c:

* subversion/libsvn_wc/util.c:

* subversion/libsvn_wc/merge.c:

* subversion/libsvn_wc/tree_conflicts.c:

* subversion/libsvn_client/list.c:

* subversion/libsvn_client/log.c:

* subversion/libsvn_ra_neon/util.c:

* subversion/libsvn_ra_neon/log.c:

* subversion/libsvn_repos/deprecated.c:

* subversion/libsvn_fs_fs/tree.c:

* subversion/libsvn_fs_fs/fs_fs.c:

(): adjust #include statements appropriately

  1. … 69 more files in changeset.
When can't print a bad filename, then at least print the directory it's in.

(Reproduction recipe given below.)

* subversion/libsvn_subr/io.c

(entry_name_to_utf8): New helper function to give a better error.

(svn_io_get_dirents2, svn_io_copy_dir_recursively, svn_io_remove_dir2,

svn_io_get_dir_filenames, svn_io_dir_walk): Use new helper.

(svn_io_dir_read): Explain why we don't use the new helper here.

* subversion/libsvn_subr/utf.c

(invalid_utf8, check_utf8, check_cstring_utf8): Document that the

error code is APR_EINVAL.

* subversion/include/svn_utf.h: Document that when conversion fails the

error code is APR_EINVAL.

This change replaces cryptic and uninformative errors...

$ svn st -q

subversion/libsvn_subr/utf.c:597: (apr_err=22)

svn: Valid UTF-8 data

(hex: 20)

followed by invalid UTF-8 sequence

(hex: 90 1b 0a 5a)

$

...with equally cryptic but more informative errors:

$ svn st -q

subversion/libsvn_subr/io.c:126: (apr_err=22)

svn: Error converting entry in directory 'www' to UTF8

subversion/libsvn_subr/utf.c:597: (apr_err=22)

svn: Valid UTF-8 data

(hex: 20)

followed by invalid UTF-8 sequence

(hex: 90 1b 0a 5a)

$

This program will create such a file in cwd for testing:

#include <stdio.h>

#include <string.h>

int main()

{

const char fname[] = { 0x20, 0x90, 0x1b, 0x0a, 0x5a, 0 };

FILE *fp = fopen(fname, "w");

fclose(fp);

}

In most Unix shells, you can remove the file with "rm ' '*" afterwards.

  1. … 2 more files in changeset.
Mark deprecated functions with SVN_DEPRECATED.

* subversion/include/svn_types.h

(SVN_DEPRECATED): Define.

* subversion/include/svn_auth.h:

* subversion/include/svn_base64.h:

* subversion/include/svn_client.h:

* subversion/include/svn_cmdline.h:

* subversion/include/svn_config.h:

* subversion/include/svn_delta.h:

* subversion/include/svn_diff.h:

* subversion/include/svn_dso.h:

* subversion/include/svn_error.h:

* subversion/include/svn_fs.h:

* subversion/include/svn_hash.h:

* subversion/include/svn_io.h:

* subversion/include/svn_opt.h:

* subversion/include/svn_ra.h:

* subversion/include/svn_ra_svn.h:

* subversion/include/svn_repos.h:

* subversion/include/svn_subst.h:

* subversion/include/svn_utf.h:

* subversion/include/svn_wc.h: Mark deprecated functions with SVN_DEPRECATED.

* www/hacking.html

  (deprecation): Update example.

Review by: blair

julianfoad

  1. … 20 more files in changeset.
Fix code formatting in some headers.

* subversion/include/svn_auth.h:

* subversion/include/svn_base64.h:

* subversion/include/svn_client.h:

* subversion/include/svn_config.h:

* subversion/include/svn_delta.h:

* subversion/include/svn_dso.h:

* subversion/include/svn_error.h:

* subversion/include/svn_fs.h:

* subversion/include/svn_hash.h:

* subversion/include/svn_io.h:

* subversion/include/svn_ra.h:

* subversion/include/svn_ra_svn.h:

* subversion/include/svn_repos.h:

* subversion/include/svn_utf.h: Place function types on separate lines.

Suggested by: julianfoad

  1. … 13 more files in changeset.
Purge AS400 port specific code.

The AS400 port is no longer maintained nor does anyone have plans to

maintain it. That's not so bad, but keeping the port code consistent with

changes made to trunk is becoming rather difficult, see

http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=141147.

* subversion/include/svn_utf.h

* subversion/libsvn_client/add.c

* subversion/libsvn_ra_svn/streams.c

* subversion/libsvn_subr/cmdline.c

* subversion/libsvn_subr/io.c

* subversion/libsvn_subr/prompt.c

* subversion/libsvn_subr/utf.c

* subversion/svn/main.c

* subversion/svn/util.c

* subversion/svnlook/main.c

* subversion/tests/libsvn_ra_local/ra-local-test.c

* subversion/tests/libsvn_subr/target-test.c

Remove AS400 blocked code and related comments.

  1. … 12 more files in changeset.
Channeling Erik Hülsmann, remove all trailing whitespace within our source

tree:

for extsn in c h cpp java py pl rb; do

sed -i -e 's/[ \t]*$//' `find . -name "*.$extsn" | xargs grep '[ \t]$' -l`

done

Inspired by: ehu

  1. … 449 more files in changeset.
Rev svn_utf_cstring_*_utf8_ex so xlate_handle_node_t structs are

cached based on the conversion taking place rather than a string

key argument.

Review by: lundblad

julianfoad

* subversion/include/svn_utf.h

(svn_utf_cstring_to_utf8_ex2, svn_utf_cstring_from_utf8_ex2): New.

(svn_utf_cstring_to_utf8_ex, svn_utf_cstring_from_utf8_ex):

Deprecate.

* subversion/libsvn_subr/cmdline.c

(SVN_UTF_CONTOU_XLATE_HANDLE, SVN_UTF_UTOCON_XLATE_HANDLE,

SVN_UTF_ETOU_XLATE_HANDLE): Remove.

(svn_cmdline_cstring_from_utf8, svn_cmdline_cstring_to_utf8,

svn_cmdline__getopt_init): Change calls to svn_utf_cstring_*_utf8_ex

to use svn_utf_cstring_*_utf8_ex2.

* subversion/libsvn_subr/io.c

(SVN_UTF_ETOU_XLATE_HANDLE, SVN_UTF_UTOE_XLATE_HANDLE): Remove.

(svn_io_create_unique_link, svn_io_read_link): Change calls to

svn_utf_cstring_*_utf8_ex to use svn_utf_cstring_*_utf8_ex2.

* subversion/libsvn_subr/utf.c

(get_xlate_key): New function.

(convert_cstring): Update doc string.

(svn_utf_cstring_to_utf8_ex2): New.

(svn_utf_cstring_to_utf8_ex): Reimplement as wrapper around

svn_utf_cstring_to_utf8_ex2.

(svn_utf_cstring_from_utf8_ex2): New.

(svn_utf_cstring_from_utf8_ex): Reimplement as wrapper around

svn_utf_cstring_from_utf8_ex2.

* subversion/libsvn_client/diff.c,

subversion/libsvn_diff/diff_file.c,

subversion/libsvn_repos/hooks.c,

subversion/libsvn_subr/stream.c,

subversion/libsvn_subr/subst.c,

subversion/svn/util.c:

Change all callers of svn_utf_cstring_*_utf8_ex to use

svn_utf_cstring_*_utf8_ex2.

  1. … 9 more files in changeset.
Fix typos in comments.

* subversion/libsvn_fs_base/notes/structure

Typo fix from Kamesh Jayachandran <kamesh@collab.net>.

* subversion/libsvn_repos/dump.c

Pronunciation consistency fix from Ed Price <ed.price@gmail.com>.

* subversion/libsvn_repos/load.c

Move a doc string from inside to just before the function.

* subversion/libsvn_subr/path.c

Delete an obsolete comment.

* subversion/include/svn_io.h

* subversion/include/svn_repos.h

* subversion/include/svn_utf.h

* subversion/libsvn_client/client.h

* subversion/libsvn_client/list.c

* subversion/libsvn_fs_fs/revs-txns.c

* subversion/libsvn_wc/adm_files.c

Fix typos.

  1. … 10 more files in changeset.
OS400/EBCDIC Port: Handle xlate page differences.

This is one of several patches to allow Subversion to run on IBM's

OS400 V5R4.

OS400 uses integers (Coded Character Set Identifiers or CCSIDs in

IBM-speak) to represent charsets rather than strings, e.g. 1208 vs.

"UTF-8". This has two implications for the subversion code:

1) apr_xlate_open() has a different signature, taking ints for topage

and frompage.

2) APR_DEFAULT_CHARSET and APR_LOCALE_CHARSET are of type int not

const char *.

The addition of new "wrapper" symbols for APR_DEFAULT_CHARSET and

APR_LOCALE_CHARSET address the bulk of these problems, leaving only

some minor error message creation tweaks.

Approved By: Philip Martin <philip@codematters.co.uk>

* subversion/include/svn_utf.h

(SVN_APR_LOCALE_CHARSET, SVN_APR_DEFAULT_CHARSET): New symbol

replacements for APR_LOCALE_CHARSET and APR_DEFAULT_CHARSET

respectively.

* subversion/libsvn_client/diff.c

(svn_client_diff2, svn_client_diff_peg2):

* subversion/libsvn_diff/diff_file.c

(svn_diff_file_output_unified):

* subversion/libsvn_subr/cmdline.c

(svn_cmdline_output_encoding):

Use SVN_APR_LOCALE_CHARSET in place of APR_LOCALE_CHARSET.

* subversion/libsvn_subr/utf.c

(SVN_APR_UTF8_CHARSET) New symbolic constant.

(get_xlate_handle_node): Use SVN_APR_DEFAULT_CHARSET and

SVN_APR_LOCALE_CHARSET in place of APR_DEFAULT_CHARSET and

APR_LOCALE_CHARSET respectively. Disable assert that doesn't

apply to V5R4 and handle error condition this may now permit.

Cast arguments to apr_xlate_open() to agree with OS400 signature.

(convert_to_stringbuf): Account for fact xlate_handle_node_t

topage and frompage members are always ints on OS400 when

creating error messages.

  1. … 4 more files in changeset.
Reformat the code to use a consistent no-space-before-param-list-paren style.

See here for the vote that decided this:

http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=111877

From: "Peter N. Lundblad" <peter@famlundblad.se>

To: "Peter N. Lundblad" <peter@famlundblad.se>

cc: dev@subversion.tigris.org

Subject: Results of: [VOTE] New space-before-parens style

Date: Wed, 8 Feb 2006 12:00:35 +0100 (CET)

Message-ID: <Pine.LNX.4.55.0602080918350.10805@localhost.localdomain>

I took the opportunity to make spacing among all parens in SVN_ERR

macro calls consistent. But I did not address consistency of casts,

nor whether a function name should always appear below its return type

in declarations and definitions, nor whether there should be a space

before/after the "*" when declaring pointer return types.

* www/hacking.html

(coding-style): Document that we are no-space-before-paren now.

* everywhere: Reformat.

  1. … 365 more files in changeset.
Fix small errors in comments.

* subversion/include/svn_client.h

* subversion/include/svn_error.h

* subversion/include/svn_io.h

* subversion/include/svn_utf.h

* subversion/include/svn_wc.h

* subversion/include/svn_xml.h

* subversion/libsvn_delta/svndiff.c

* subversion/libsvn_fs_base/key-gen.h

* subversion/libsvn_fs_fs/fs_fs.c

* subversion/svn/blame-cmd.c

Fix typos and similar small errors in comments.

* subversion/svn/main.c

* subversion/svnadmin/main.c

* subversion/svndumpfilter/main.c

* subversion/svnlook/main.c

* subversion/svnserve/main.c

Remove an incorrect comment.

* subversion/libsvn_subr/io.c

Update a comment to reflect changes in APR.

* subversion/include/svn_fs.h

* subversion/include/svn_user.h

Change some comments into Doxygen style.

  1. … 17 more files in changeset.
Improve Doxygen "@since" and "@deprecated" usage. Move those to the end of

each comment so that Doxygen uses the first descriptive sentence as the

item's brief description. Make their wording and punctuation consistent.

Patch by: Marcel Gosselin <marcel.gosselin@polymtl.ca>

(Tweaked by me.)

* subversion/include/svn_client.h

* subversion/include/svn_delta.h

* subversion/include/svn_diff.h

* subversion/include/svn_error.h

* subversion/include/svn_error_codes.h

* subversion/include/svn_fs.h

* subversion/include/svn_hash.h

* subversion/include/svn_io.h

* subversion/include/svn_opt.h

* subversion/include/svn_path.h

* subversion/include/svn_props.h

* subversion/include/svn_ra.h

* subversion/include/svn_repos.h

* subversion/include/svn_sorts.h

* subversion/include/svn_string.h

* subversion/include/svn_subst.h

* subversion/include/svn_types.h

* subversion/include/svn_utf.h

* subversion/include/svn_version.h

* subversion/include/svn_wc.h

* subversion/include/svn_xml.h

Move and clean up "@since" and "@deprecated" and one "@note" lines.

  1. … 20 more files in changeset.
Format "@since" and "@deprecated" labels consistently.

  1. … 10 more files in changeset.
* subversion/include/svn_utf.h: Use @note in docstring and fix typo

in #endif comment.

Various fixes to r10788, r10796.

* include/svn_utf.h (svn_utf_initialize): Add pool argument.

* libsvn_subr/utf.c (svn_utf_initialize): Create the hashtable pool as a

subpool of the pool passed in the new argument.

(get_xlate_handle_node): Look for the xlate handle in the pool if there is no

global cache. Register a cleanup that marks the node as defunct.

Check for defunct nodes before returning them. e concistent about checking

if the UTF-8 routines were initialized by checking the hash table

(instead of sometimes checking the mutex).

(put_xlate_handle_node): New pool argument, callers updated. Store the

handle in the pool if there is no global cache. Store the handle in the

global cache, if one, even in the single-threaded case. Same concistency

change as for get_xlate_handle_node.

* libsvn_subr/cmdline.c (svn_cmdline_initialize): Create a separate pool for

the UTF-8 initialization.

  1. … 2 more files in changeset.
Fix issue #2016. Cache UTF8 translation handles in a global hash table

instead of in the current pool, which improves performance, especially on

Windows.

* include/svn_utf.h (svn_utf_initialize): New function.

* libsvn_subr/utf.c (xlate_handle_mutex, xlate_handle_hash): New variables.

(xlate_handle_node_t): New struct.

(xlate_cleanup, svn_utf_initialize, put_xlate_handle_node): New functions.

(get_xlate_handle_node): Renamed from get_xlate_handle and rewritten using

a global hash table and locking in MT environments.

(get_ntou_xlate_handle_node, get_uton_xlate_handle_node,

svn_utf_stringbuf_to_utf8, svn_utf_string_to_utf8, svn_utf_cstring_to_utf8,

svn_utf_cstring_to_utf8_ex, svn_utf_stringbuf_from_utf8,

svn_utf_string_from_utf8, svn_utf_cstring_from_utf8,

svn_utf_cstring_from_utf8_ex, svn_utf_cstring_from_utf8_string): Use

{get,put}_xlate_handle_node for the

xlate handle.

* libsvn_subr/cmdline.c (svn_cmdline_initialize): Initialize UTF-8 routines.

  1. … 2 more files in changeset.
Update copyright notices for 2004, resolving issue #1651.

(See also revision 8019, which fixed a couple of missed spots.)

  1. … 361 more files in changeset.
Clearing the field for issue #872. Clean up the svn_utf API.

* subversion/include/svn_utf.h (svn_utf_cstring_to_utf8_stringbuf): Remove.

It was only used internally in utf.c.

(svn_utf_cstring_to_utf8): Remove 'xlator' parameter. All callers changed.

(svn_utf_cstring_to_utf8_ex) New. Use where 'xlator' wasn't NULL in calls

to svn_utf_cstring_to_utf8.

(svn_utf_cstring_from_utf8_ex). Analogous to svn_utf_cstring_to_utf8_ex.

* subversion/libsvn_subr/utf.c (get_xlate_handle): New. Refactor from

get_ntou_xlate_handle and get_uton_xlate_handle.

(get_ntou_xlate_handle, get_uton_xlate_handle): Reimplement in terms

of get_xlate_handle.

(svn_utf_cstring_to_utf8_stringbuf): Remove.

(convert_cstring): New. Common implementation for string converters.

(svn_utf_cstring_to_utf8, svn_utf_cstring_from_utf8): Reimplement

in terms of convert_cstring.

(svn_utf_cstring_to_utf8_ex, svn_utf_cstring_from_utf8_ex): New.

  1. … 18 more files in changeset.
Clearing the field for issue #872.

* subversion/libsvn_subr/error.c (svn_handle_error): Stop using

svn_utf_utf8_to_native, now that each svn_error_t has its own pool;

use svn_utf_cstring_from_utf8_fuzzy instead. Also, don't convert the

file name in the error location output.

* subversion/libsvn_subr/utf.c (svn_utf_utf8_to_native): Remove.

(svn_utf_cstring_from_utf8_fuzzy): Clear the error before returning.

* subversion/include/svn_utf.h (svn_utf_utf8_to_native): Remove.

  1. … 2 more files in changeset.
Adjust some of the includes in our headers files. There were some

unused includes, some stylistic ordering of includes, some <> instead

of "", and an improper location of one include.

This may address issue 1274 and issue 1308. (haven't tested that)

* include/svn_pools.h: moved include of apr_want.h outside of the C++

namespace block. We don't want to impose C on foreign headers.

* svnlook/main.c: insert a blank line between classes of includes

* libsvn_subr/path.c: add svn_io.h since it was removed from some

header, yet is needed in this file.

* libsvn_subr/config_auth.c: add svn_io.h. reorder blocks of includes.

* include/svn_sorts.h, include/svn_base64.h, include/svn_ra_svn.h,

include/svn_delta.h, include/svn_path.h, include/svn_subst.h,

include/svn_xml.h, include/svn_types.h, include/svn_config.h,

include/svn_wc.h, include/svn_client.h, include/svn_hash.h,

include/svn_error.h, include/svn_utf.h: remove unneeded includes,

reorder some blocks, fix some delimiters, add whitespace, etc.

  1. … 17 more files in changeset.
doxygen police cleanup sweep. this corrects the doubled up first sentences

we still had in many comments from when REPEAT_BRIEF was set to NO in our

doxygen config, and fixes a bunch of markup errors i found at the same time.

* subversion/include/svn_fs.h

* subversion/include/svn_diff.h

* subversion/include/svn_sorts.h

* subversion/include/svn_test.h

* subversion/include/svn_base64.h

* subversion/include/svn_ra_svn.h

* subversion/include/svn_repos.h

* subversion/include/svn_delta.h

* subversion/include/svn_path.h

* subversion/include/svn_subst.h

* subversion/include/svn_props.h

* subversion/include/svn_types.h

* subversion/include/svn_config.h

* subversion/include/svn_string.h

* subversion/include/svn_io.h

* subversion/include/svn_wc.h

* subversion/include/svn_client.h

* subversion/include/svn_quoprint.h

* subversion/include/svn_hash.h

* subversion/include/svn_md5.h

* subversion/include/svn_error.h

* subversion/include/svn_pools.h

* subversion/include/svn_time.h

* subversion/include/svn_utf.h

* subversion/include/svn_ra.h

clean up doxygen comments.

  1. … 24 more files in changeset.