Checkout Tools
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Changeset 877310 is being indexed.

More eol-style property fixing.

* subversion/libsvn_subr/debug.c,

subversion/tests/cmdline/entries_tests.py,

subversion/include/svn_editor.h,

subversion/include/private/svn_debug.h,

subversion/libsvn_ra_serf/auth_kerb.c,

subversion/libsvn_ra_serf/auth_kerb.h,

subversion/libsvn_delta/editor.c:

Set the eol-style to native.

  1. … 6 more files in changeset.
Some more refinement of the new editor code:

- add cancellation support into the core editor

- assert that callbacks are provided, if they get invoked

* subversion/include/svn_editor.h:

(svn_editor_create): accept CANCEL_FUNC and CANCEL_BATON params

* subversion/libsvn_delta/editor.c:

(svn_editor_t): add CANCEL_FUNC and CANCEL_BATON members

(svn_editor_create): add CANCEL_FUNC and CANCEL_BATON params, and store

them into the editor structure.

(svn_editor_add_directory, svn_editor_add_directory_streamy,

svn_editor_add_file, svn_editor_add_symlink, svn_editor_add_absent,

svn_editor_set_props, svn_editor_set_text, svn_editor_set_target,

svn_editor_delete, svn_editor_copy, svn_editor_move): call the new

cancellation functions, and test for the callback

(svn_editor_complete, svn_editor_abort): test for the callback. these

functions do not test for cancellation since they are the last things

to be called, and we may as well let them wrap up.

  1. … 1 more file in changeset.
Switch the editor's scratch_pool to clear-on-exit rather than entry. This

is a bit more code, but it should help to keep peak memory a bit lower.

Another change in this revision is modifying the "child stream" on

add_directory_streamy to move to an iterative callback to fetch children,

rather than a stream. Much easier than setting up stream readers/writers

and serialization mechanisms.

* subversion/include/svn_editor.h:

(svn_editor_cb_add_directory_streamy_t): adjust this callback type to

have an iterative callback, rather than an svn_stream_t.

(svn_editor_add_directory_streamy): adjust params to provide a callback

to fetch child names, rather than a stream.

* subversion/libsvn_delta/editor.c:

(svn_editor_add_directory, svn_editor_add_file, svn_editor_add_symlink,

svn_editor_add_absent, svn_editor_set_props, svn_editor_set_text,

svn_editor_set_target, svn_editor_delete, svn_editor_copy,

svn_editor_move, svn_editor_complete, svn_editor_abort): switch the

scratch_pool to clear-on-exit

(svn_editor_add_directory_streamy): adjust parameters to a callback

rather than a stream. change scratch_pool to clear-on-exit.

Suggested by: rhuijben

  1. … 1 more file in changeset.
Switch to using an internal scratch_pool for all of the callbacks. This

will help ensure/optimize pool usage within the editor drive.

* subversion/include/svn_editor.h:

(svn_editor_add_directory, svn_editor_add_directory_streamy,

svn_editor_add_file, svn_editor_add_symlink, svn_editor_add_absent,

svn_editor_set_props, svn_editor_set_text, svn_editor_set_target,

svn_editor_delete, svn_editor_copy, svn_editor_move,

svn_editor_complete, svn_editor_abort): remove SCRATCH_POOL param

* subversion/libsvn_delta/editor.c:

(svn_editor_t): add SCRATCH_POOL member

(svn_editor_create): construct a scratch pool as a subpool of the result

pool (ie. a pool that lives at least as long as this editor)

(svn_editor_add_directory, svn_editor_add_directory_streamy,

svn_editor_add_file, svn_editor_add_symlink, svn_editor_add_absent,

svn_editor_set_props, svn_editor_set_text, svn_editor_set_target,

svn_editor_delete, svn_editor_copy, svn_editor_move,

svn_editor_complete, svn_editor_abort): remove SCRATCH_POOL param.

clear the pool on entry, then pass to the callback.

  1. … 1 more file in changeset.
Dump out some basic skeleton structure for a new editor interface.

* subversion/include/svn_editor.h: new interface

* subversion/libsvn_delta/editor.c: new implementation

  1. … 1 more file in changeset.