Checkout Tools
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix various typos detected by codespell

* include/private/svn_auth_private.h, include/private/svn_branch_impl.h,

include/private/svn_config_private.h, include/private/svn_diff_tree.h,

include/private/svn_mergeinfo_private.h, include/private/svn_object_pool.h,

include/private/svn_repos_private.h, include/private/svn_subr_private.h,

include/private/svn_temp_serializer.h, include/private/svn_utf_private.h,

include/private/svn_wc_private.h, include/svn_auth.h, include/svn_client.h,

include/svn_cmdline.h, include/svn_compat.h, include/svn_fs.h,

include/svn_ra.h, include/svn_repos.h, include/svn_types.h,

include/svn_types_impl.h, include/svn_version.h, include/svn_wc.h,

include/svn_x509.h:

(): Spelling fixes

  1. … 22 more files in changeset.
Use libsecret to implement the GNOME Keyring provider by default

instead of libgnome-keyring. The GNOME project have deprecated

libgnome-keyring and libsecret is the preferred replacement. The old

implementation using libgnome-keyring can still be chosen at configure

time. Both implementations read and write passwords that can be used

by the other implementation.

The configure option '--with-gnome-keyring' now controls the new

implementation while the option '--with-old-gnome-keyring' controls

the previous implementation.

* build/ac-macros/libsecret.m4: New, provides --with-gnome-keyring.

* configure.ac: Change --with-gnome-keyring to --with-old-gnome-keyring

and disable by default.

* aclocal.m4: Include libsecret.m4.

* subversion/libsvn_auth_gnome_keyring/gnome_keyring.c: Add new

libsecret implementation conditional on SVN_HAVE_LIBSECRET, make old

code conditional on SVN_HAVE_GNOME_KEYRING,

* subversion/libsvn_subr/auth.c

(svn_auth_get_platform_specific_provider): Make already conditional

code depend on SVN_HAVE_LIBSECRET.

* subversion/include/svn_auth.h

(SVN_AUTH_PARAM_GNOME_KEYRING_UNLOCK_PROMPT_FUNC,

SVN_AUTH_PARAM_GNOME_KEYRING_UNLOCK_PROMPT_BATON): Deprecate.

* subversion/include/private/svn_cmdline_private.h

(svn_cmdline__auth_gnome_keyring_unlock_prompt): Deprecate.

* subversion/libsvn_subr/prompt.c

(svn_cmdline__auth_gnome_keyring_unlock_prompt): Make conditional.

* subversion/tests/libsvn_subr/auth-test.c

(test_platform_specific_auth_providers): Make already conditional

code depend on SVN_HAVE_LIBSECRET.

  1. … 8 more files in changeset.
Apply the standard pre-branch whitespace cleanup via

tools/dev/remove-trailing-whitespace.zsh

There should be no functional changes.

* .ycm_extra_conf.py

* build/generator/gen_win.py

* build/generator/gen_win_dependencies.py

* subversion/bindings/javahl/native/EditorProxy.h

* subversion/bindings/javahl/native/StateReporter.cpp

* subversion/bindings/javahl/native/org_apache_subversion_javahl_util_ConfigImpl_Category.cpp

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c

* subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c

* subversion/bindings/swig/ruby/test/test_fs.rb

* subversion/bindings/swig/ruby/test/util.rb

* subversion/bindings/swig/ruby/test/windows_util.rb

* subversion/include/private/svn_fs_fs_private.h

* subversion/include/private/svn_packed_data.h

* subversion/include/private/svn_repos_private.h

* subversion/include/private/svn_sorts_private.h

* subversion/include/private/svn_subr_private.h

* subversion/include/private/svn_wc_private.h

* subversion/include/svn_auth.h

* subversion/include/svn_cache_config.h

* subversion/include/svn_client.h

* subversion/include/svn_cmdline.h

* subversion/include/svn_diff.h

* subversion/include/svn_fs.h

* subversion/include/svn_io.h

* subversion/include/svn_ra.h

* subversion/include/svn_repos.h

* subversion/include/svn_string.h

* subversion/libsvn_client/blame.c

* subversion/libsvn_client/commit.c

* subversion/libsvn_client/commit_util.c

* subversion/libsvn_client/copy.c

* subversion/libsvn_client/diff.c

* subversion/libsvn_client/externals.c

* subversion/libsvn_client/log.c

* subversion/libsvn_client/patch.c

* subversion/libsvn_client/ra.c

* subversion/libsvn_client/update.c

* subversion/libsvn_delta/svndiff.c

* subversion/libsvn_diff/parse-diff.c

* subversion/libsvn_fs/fs-loader.c

* subversion/libsvn_fs_base/lock.c

* subversion/libsvn_fs_fs/cached_data.c

* subversion/libsvn_fs_fs/fs_fs.c

* subversion/libsvn_fs_fs/hotcopy.c

* subversion/libsvn_fs_fs/id.c

* subversion/libsvn_fs_fs/index.c

* subversion/libsvn_fs_fs/index.h

* subversion/libsvn_fs_fs/lock.c

* subversion/libsvn_fs_fs/low_level.c

* subversion/libsvn_fs_fs/low_level.h

* subversion/libsvn_fs_fs/pack.c

* subversion/libsvn_fs_fs/recovery.c

* subversion/libsvn_fs_fs/rev_file.c

* subversion/libsvn_fs_fs/revprops.c

* subversion/libsvn_fs_fs/revprops.h

* subversion/libsvn_fs_fs/stats.c

* subversion/libsvn_fs_fs/transaction.c

* subversion/libsvn_fs_fs/tree.c

* subversion/libsvn_fs_fs/verify.c

* subversion/libsvn_fs_x/cached_data.c

* subversion/libsvn_fs_x/changes.c

* subversion/libsvn_fs_x/dag.h

* subversion/libsvn_fs_x/fs.h

* subversion/libsvn_fs_x/fs_id.c

* subversion/libsvn_fs_x/fs_x.c

* subversion/libsvn_fs_x/hotcopy.c

* subversion/libsvn_fs_x/hotcopy.h

* subversion/libsvn_fs_x/index.c

* subversion/libsvn_fs_x/index.h

* subversion/libsvn_fs_x/lock.c

* subversion/libsvn_fs_x/lock.h

* subversion/libsvn_fs_x/low_level.c

* subversion/libsvn_fs_x/low_level.h

* subversion/libsvn_fs_x/noderevs.c

* subversion/libsvn_fs_x/pack.c

* subversion/libsvn_fs_x/reps.c

* subversion/libsvn_fs_x/rev_file.c

* subversion/libsvn_fs_x/revprops.c

* subversion/libsvn_fs_x/revprops.h

* subversion/libsvn_fs_x/string_table.c

* subversion/libsvn_fs_x/string_table.h

* subversion/libsvn_fs_x/transaction.c

* subversion/libsvn_fs_x/tree.c

* subversion/libsvn_fs_x/util.c

* subversion/libsvn_fs_x/verify.c

* subversion/libsvn_ra_local/ra_plugin.c

* subversion/libsvn_ra_serf/ra_serf.h

* subversion/libsvn_ra_serf/serf.c

* subversion/libsvn_ra_serf/update.c

* subversion/libsvn_ra_serf/util.c

* subversion/libsvn_ra_svn/client.c

* subversion/libsvn_ra_svn/marshal.c

* subversion/libsvn_repos/authz_pool.c

* subversion/libsvn_repos/config_pool.c

* subversion/libsvn_repos/dump.c

* subversion/libsvn_repos/fs-wrap.c

* subversion/libsvn_repos/log.c

* subversion/libsvn_subr/bit_array.c

* subversion/libsvn_subr/cache-membuffer.c

* subversion/libsvn_subr/config.c

* subversion/libsvn_subr/dirent_uri.c

* subversion/libsvn_subr/fnv1a.c

* subversion/libsvn_subr/gpg_agent.c

* subversion/libsvn_subr/hash.c

* subversion/libsvn_subr/io.c

* subversion/libsvn_subr/object_pool.c

* subversion/libsvn_subr/packed_data.c

* subversion/libsvn_subr/prefix_string.c

* subversion/libsvn_subr/sorts.c

* subversion/libsvn_subr/sqlite.c

* subversion/libsvn_subr/subst.c

* subversion/libsvn_subr/sysinfo.c

* subversion/libsvn_subr/types.c

* subversion/libsvn_subr/utf.c

* subversion/libsvn_subr/utf8proc/utf8proc_data.c

* subversion/libsvn_subr/x509info.c

* subversion/libsvn_wc/diff.h

* subversion/libsvn_wc/props.c

* subversion/libsvn_wc/update_editor.c

* subversion/libsvn_wc/wc.h

* subversion/libsvn_wc/wc_db.c

* subversion/libsvn_wc/wc_db.h

* subversion/mod_dav_svn/lock.c

* subversion/mod_dav_svn/mod_dav_svn.c

* subversion/mod_dav_svn/status.c

* subversion/svn/auth-cmd.c

* subversion/svn/info-cmd.c

* subversion/svn/mergeinfo-cmd.c

* subversion/svn/notify.c

* subversion/svn/propget-cmd.c

* subversion/svn/svn.c

* subversion/svnadmin/svnadmin.c

* subversion/svnserve/logger.c

* subversion/svnserve/serve.c

* subversion/svnserve/server.h

* subversion/svnserve/svnserve.c

* subversion/tests/cmdline/blame_tests.py

* subversion/tests/cmdline/checkout_tests.py

* subversion/tests/cmdline/commit_tests.py

* subversion/tests/cmdline/export_tests.py

* subversion/tests/cmdline/externals_tests.py

* subversion/tests/cmdline/lock_tests.py

* subversion/tests/cmdline/merge_tests.py

* subversion/tests/cmdline/merge_tree_conflict_tests.py

* subversion/tests/cmdline/move_tests.py

* subversion/tests/cmdline/redirect_tests.py

* subversion/tests/cmdline/stat_tests.py

* subversion/tests/cmdline/svnadmin_tests.py

* subversion/tests/cmdline/switch_tests.py

* subversion/tests/cmdline/update_tests.py

* subversion/tests/libsvn_client/client-test.c

* subversion/tests/libsvn_client/mtcc-test.c

* subversion/tests/libsvn_fs/fs-test.c

* subversion/tests/libsvn_fs/locks-test.c

* subversion/tests/libsvn_fs_fs/fs-fs-fuzzy-test.c

* subversion/tests/libsvn_fs_fs/fs-fs-pack-test.c

* subversion/tests/libsvn_fs_x/fs-x-pack-test.c

* subversion/tests/libsvn_fs_x/string-table-test.c

* subversion/tests/libsvn_ra/ra-test.c

* subversion/tests/libsvn_subr/cache-test.c

* subversion/tests/libsvn_subr/checksum-test.c

* subversion/tests/libsvn_subr/config-test.c

* subversion/tests/libsvn_subr/io-test.c

* subversion/tests/libsvn_subr/packed-data-test.c

* subversion/tests/libsvn_subr/priority-queue-test.c

* subversion/tests/libsvn_subr/sqlite-test.c

* subversion/tests/libsvn_subr/string-test.c

* subversion/tests/libsvn_subr/subst_translate-test.c

* subversion/tests/libsvn_subr/x509-test.c

* subversion/tests/libsvn_wc/op-depth-test.c

* subversion/tests/svn_test_main.c

* tools/dev/benchmarks/RepoPerf/copy_repo.py

* tools/dev/benchmarks/RepoPerf/win_repo_bench.py

* tools/dev/build-svn-deps-win.pl

* tools/dev/fsfs-access-map.c

* tools/dev/po-merge.py

* tools/dev/x509-parser.c

* tools/diff/diff.c

* tools/dist/backport.pl

* tools/dist/backport_tests.py

* tools/hook-scripts/mailer/mailer.py

* tools/server-side/svnpubsub/daemonize.py

* win-tests.py

Remove unneeded whitespace via script.

  1. … 184 more files in changeset.
Followup to r1543992, add the usual deprecated version number.

This feels a tad awkward since gnome_keyring, kwallet and gpg_agent

should all have basically never been added as public APIs and nobody

should have wanted to use them since. But I guess since we didn't

bother to mark them as deprecated till now they're not until 1.9.

* subversion/include/svn_auth.h

(svn_auth_get_windows_simple_provider,

svn_auth_get_windows_ssl_client_cert_pw_provider,

svn_auth_get_windows_ssl_server_trust_provider,

svn_auth_get_keychain_simple_provider,

svn_auth_get_keychain_ssl_client_cert_pw_provider,

svn_auth_get_gnome_keyring_simple_provider,

svn_auth_get_gnome_keyring_ssl_client_cert_pw_provider,

svn_auth_get_kwallet_simple_provider,

svn_auth_get_kwallet_ssl_client_cert_pw_provider,

svn_auth_get_gpg_agent_simple_provider): Mark as deprecated in 1.9

Mark platform specific svn_auth_get_* functions as deprecated to discourage

api consumers from using them and point them towards

svn_auth_get_platform_specific_provider().

* subversion/include/svn_auth.h

(svn_auth_get_windows_simple_provider,

svn_auth_get_windows_ssl_client_cert_pw_provider,

svn_auth_get_windows_ssl_server_trust_provider,

svn_auth_get_keychain_simple_provider,

svn_auth_get_keychain_ssl_client_cert_pw_provider,

svn_auth_get_gnome_keyring_simple_provider,

svn_auth_get_gnome_keyring_ssl_client_cert_pw_provider,

svn_auth_get_kwallet_simple_provider,

svn_auth_get_kwallet_ssl_client_cert_pw_provider,

svn_auth_get_gpg_agent_simple_provider): Deprecate

* subversion/libsvn_subr/auth.h

(svn_auth__get_windows_simple_provider,

svn_auth__get_windows_ssl_client_cert_pw_provider,

svn_auth__get_windows_ssl_server_trust_provider,

svn_auth__get_keychain_simple_provider,

svn_auth__get_keychain_ssl_client_cert_pw_provider,

svn_auth__get_gnome_keyring_simple_provider,

svn_auth__get_gnome_keyring_ssl_client_cert_pw_provider,

svn_auth__get_kwallet_simple_provider,

svn_auth__get_kwallet_ssl_client_cert_pw_provider,

svn_auth__get_gpg_agent_simple_provider): Add private delcartions.

* subversion/libsvn_subr/gpg_agent.c,

subversion/libsvn_subr/macos_keychain.c,

subversion/libsvn_subr/win32_crypto.c:

(svn_auth__get_*): Convert public versions to private versions.

* subversion/libsvn_subr/deprecated.c

(svn_auth_get_*): Implement public versions as wrappers of the new private

versions.

* subversion/libsvn_subr/auth.c

(svn_auth_get_platform_specific_provider): Use private versions

of the platform specific svn_auth_get_* functions in order

to avoid warnings about using deprecated functions.

  1. … 6 more files in changeset.
Fix building SWIG bindings with release mode on OS X (i.e. out of the tarball).

When ./autogen.sh --release is used we generate the SWIG interface then rather

than at build time. This allows users to use SWIG bindings without needing

SWIG installed. However, we were trying to hide the gnome keyring callback

helper at SWIG interface generation time that may not be available at build

time.

There is no reason to hide the definitions needed for this helper on platforms

without gnome-keyring support since there is actually nothing tied to the

gnome keyring being available when they are used. If the gnome keyring auth

provider isn't available or enabled the callback will simply never be called.

* subversion/include/svn_auth.h

(svn_auth_gnome_keyring_unlock_prompt_func_t,

SVN_AUTH_PARAM_GNOME_KEYRING_UNLOCK_PROMPT_FUNC,

SVN_AUTH_PARAM_GNOME_KEYRING_UNLOCK_PROMPT_BATON): Make available regardless

of the platform by moving outside of the #if block.

* subversion/bindings/swig/core.i

(svn_auth_set_gnome_keyring_unlock_prompt_func): Remove the unnecessary

#ifdef block around this %inline.

  1. … 1 more file in changeset.
Fix accidental breakage from r1484017

* subversion/include/svn_auth.h

(SVN_AUTH_PARAM_CONFIG_CATEGORY_CONFIG, SVN_AUTH_PARAM_CONFIG_CATEGORY_SERVERS):

Wrap long lines properly.

* subversion/include/svn_auth.h

(SVN_AUTH_PARAM_CONFIG_CATEGORY_CONFIG): Improve documentation.

(SVN_AUTH_PARAM_CONFIG_CATEGROY_SERVERS): Add documentation.

* subversion/include/svn_auth.h

(SVN_AUTH_PARAM_DEFAULT_USERNAME, SVN_AUTH_PARAM_DEFAULT_PASSWORD):

Split the documentation out for each one so the links to these constants

work.

* subversion/include/svn_auth.h

(svn_auth_forget_credentials): Add missing @since marker.

Finish issue #4346 ("svn_auth_cleanup_walk() API and friends needs a

rethink").

Reenvision the svn_auth_cleanup_walk() function and plumbing as a

generic config-based credential walker that includes the ability to

trigger a deletion. This seems better match for the extent and

limitations of the implementation, which is but a mere convenience

wrapper around the management of Subversion's config-based auth store

and was never remotely related to "providers" or even "the auth

subsystem" in a meaningful way. Morever, by associating this logic

with a specific auth store (our config-based stuff), we can introduce

new auth stores (e.g., an encrypted store) without being tied to this

API.

(Don't hate me, rhuijben.)

* subversion/include/svn_auth.h

(svn_auth_cleanup_func_t, svn_auth_cleanup_walk): Removed.

(svn_auth_forget_credentials): New function.

* subversion/include/svn_config.h

(svn_config_auth_walk_func_t): Was svn_auth_cleanup_func_t(),

but trades the disinteresting 'provider' parameter for a 'hash'

parameter.

(svn_config_walk_auth_data): Was svn_auth.h:svn_auth_cleanup_walk(),

but drops the 'auth_baton' parameter in favor of 'config_dir' to

avoid the pretense that the auth_baton's registered providers even

matter. Also, provides all auth data via the callback now (which

is not strictly "cleanup" focused.

* subversion/libsvn_subr/config_auth.c

(svn_config_walk_auth_data): New function, a merge of

svn_auth_cleanup_walk() and svn_auth__simple_cleanup_walk(), but

which accepts a 'config_dir' instead of an 'auth_baton'.

* subversion/libsvn_subr/simple_providers.c

(svn_auth__simple_cleanup_walk): Merged into svn_config_cleanup_auth_data().

* subversion/libsvn_subr/auth.h

(svn_auth__simple_cleanup_walk): Removed unused prototype.

* subversion/libsvn_subr/auth.c

(make_cache_key): New helper.

(svn_auth_first_credentials): Use make_cache_key().

(svn_auth_forget_credentials): New function.

(svn_auth_cleanup_walk): Merged into svn_config_cleanup_auth_data().

* subversion/tests/libsvn_subr/auth-test.c

(cleanup_callback): Adjust to new prototype. Call

svn_auth_forget_credentials(), too.

(test_auth_clear): Add some comments, and track API changes.

  1. … 6 more files in changeset.
* subversion/include/svn_auth.h,

* subversion/libsvn_subr/auth.c,

* subversion/libsvn_subr/simple_providers.c

Leave a bunch of FIXME comments for another day. I need to think

more about how to truly legitimize this whole

svn_auth_cleanup_walk() API and call tree.

  1. … 2 more files in changeset.
Minor tweaks for API consistency.

* subversion/include/svn_auth.h

(svn_auth_cleanup_func_t): Was svn_auth_cleanup_callback.

(svn_auth_cleanup_walk): Track type change, rename 'cleanup' to

'cleanup_func', and update docstring for a bit more clarity.

* subversion/libsvn_subr/auth.h

Track type and parameter name changes. Also, employ the same

internal preprocessor stuffs and formatting thereof that other

header files use (__cplusplus, SVN_<libname>_<filename>).

* subversion/libsvn_subr/auth.c,

* subversion/libsvn_subr/simple_providers.c

Track type and parameter name changes.

  1. … 3 more files in changeset.
* subversion/include/svn_auth.h

(svn_auth_cleanup_callback): Clarify a point in the doc string.

Fix Doxygen mark-up.

* subversion/include/svn_auth.h

(svn_auth_cleanup_callback): Fix mark-up and a parameter name.

* subversion/include/svn_client.h

(svn_proplist_receiver2_t, svn_client_propget5): Fix mark-up.

  1. … 1 more file in changeset.
Resolve issue #2775, by providing an api that allows removing cached

credentials for our api users.

As our credentials are keyed by 'realm' and the exact format

is provider specific I added a simple iterator over the cached

credentials, so a client can provide a UI on top, or simply guess

which ones to delete by checking if they contain a specific url.

* subversion/include/svn_auth.h

(svn_auth_cleanup_callback): New typedef.

(svn_auth_cleanup_walk): New function.

* subversion/libsvn_subr/auth.c

(includes): Add auth.h

(svn_auth_cleanup_walk): New function.

* subversion/libsvn_subr/auth.h

(svn_auth__file_path): New function.

(svn_auth__simple_cleanup_walk): New function.

* subversion/libsvn_subr/config_auth.c

(auth_file_path): Rename to ...

(svn_auth__file_path): ... this and make library public.

(svn_config_read_auth_data): Update caller.

(svn_config_write_auth_data): Update caller.

* subversion/libsvn_subr/simple_providers.c

(includes): Add several.

(svn_auth__simple_cleanup_walk): New function.

* subversion/tests/libsvn_subr/auth-test.c

(includes): Add svn_auth_private.h.

(cleanup_callback): New function.

(test_auth_clear): Extend to verify the credential is really gone.

  1. … 5 more files in changeset.
Fix a simple to trigger, but never reported segfault in the auth helper code.

* subversion/include/svn_auth.h

(SVN_AUTH_PARAM_STORE_PLAINTEXT_PASSWORDS,

SVN_AUTH_PARAM_DONT_STORE_SSL_CLIENT_CERT_PP,

SVN_AUTH_PARAM_STORE_SSL_CLIENT_CERT_PP_PLAINTEXT): Mark as new in 1.6.

* subversion/libsvn_subr/simple_providers.c

(svn_auth__simple_creds_cache_set): If nobody has set

SVN_AUTH_PARAM_STORE_PLAINTEXT_PASSWORDS (introduced in 1.6),

we shouldn't segfault.

  1. … 1 more file in changeset.
Fix a number of comments which refer to the ernstwhile neon library.

Due to dependencies, this also triggers a complete rebuild, for gstein's

benefit.

* subversion/include/svn_ra.h,

subversion/include/svn_error_codes.h,

subversion/include/svn_auth.h,

subversion/include/private/svn_dav_protocol.h:

Update comment references to either ra_serf, or generic HTTP-speak.

  1. … 3 more files in changeset.
Move gpg-agent behind GNOME Keyring, Kwallet, and Keychain, by default.

We don't want to disturb existing setups that use existing password

caching mechanisms on *NIX systems.

* subversion/include/svn_auth.h

(svn_auth_get_platform_specific_provider): Document the new default order.

* subversion/libsvn_subr/auth.c

(svn_auth_get_platform_specific_client_providers): Add a new macro

SVN__DEFAULT_AUTH_PROVIDER_LIST that expands to the default list

of auth providers (previously the list was listed twice).

Change the list to reflect the priority order described above.

  1. … 1 more file in changeset.
Remove libsvn_auth_gpg_agent and move gpg-agent support into libsvn_subr.

There is no need to put gpg-agent support into a library loaded at runtime.

The svn code talks to the GPG agent via a UNIX stream socket.

There are no massive external library dependencies involved that

we need to keep at a distance, as with GNOME or KDE.

This should also fix the problem where svn fails to enable gpg-agent

support on Mac OS X because of a filename mismatch (*.so vs. *.dylib).

* subversion/include/svn_auth.h

(svn_auth_gpg_agent_version): Remove declaration. A version function

is only needed for DSOs.

(svn_auth_get_gpg_agent_simple_provider): Declare this function on Darwin.

Remove mention of libsvn_auth_gpg_agent from docstring.

* subversion/libsvn_auth_gpg_agent,

subversion/libsvn_auth_gpg_agent/version.c: Remove.

* subversion/libsvn_auth_gpg_agent/gpg_agent.c: Move to ...

* subversion/libsvn_subr/gpg_agent.c: ... here. Wrap all code into

the SVN_HAVE_GPG_AGENT define.

* subversion/libsvn_subr/auth.c

(svn_auth_get_platform_specific_provider): Directly call

svn_auth_get_gpg_agent_simple_provider() if SVN_HAVE_GPG_AGENT is defined

instead of loading gpg-agent support as a DSO.

* subversion/bindings/swig/core.i: Remove svn_auth_gpg_agent_version.

* configure.ac,

build.conf,

build/generator/gen_make.py,

build/generator/gen_win.py: Remove references to libsvn_auth_gpg_agent.

  1. … 8 more files in changeset.
Small cleanups related to the new gpg-agent feature. No functional change.

* subversion/include/svn_auth.h

(svn_auth_get_platform_specific_provider,

svn_auth_get_platform_specific_client_providers): Mention gpg-agent

in docstrings.

* subversion/libsvn_subr/config_file.c

(svn_config_ensure): gpg-agent has not been tested on all platforms,

and we don't compile it on windows. So put it into the "Unix-like systems"

group instead of claiming it ran on all platforms.

Also remove it from the example line that enables keychain on Mac OS X.

Most Mac users probably prefer keychain and those that don't will be

smart enough to configure gpg-agent anyway.

  1. … 1 more file in changeset.
* subversion/include/svn_auth.h

(svn_auth_gpg_agent_version): Add @since tag.

(svn_auth_get_gpg_agent_simple_provider): Fix @since tag.

Reintegrate the gpg-agent-password-store branch.

It is now working quite well. Further cleanup can happen on trunk.

The merge was an interesting experience. In addition to the problems

fixed by r1150760 and r1150762, I ended up with 3 unrelated content

and 8 unrelated svn:mergeinfo changes on the following files:

M subversion/include/private/svn_temp_serializer.h

M subversion/include/private/svn_string_private.h

M subversion/include/private/svn_adler32.h

M subversion/libsvn_fs_fs/temp_serializer.c

M subversion/libsvn_fs_fs/temp_serializer.h

M subversion/libsvn_subr/hash.c

M subversion/libsvn_subr/svn_temp_serializer.c

M subversion/libsvn_subr/adler32.c

D tools/dist/templates/stable-release-ann.ezt

D tools/dist/templates/rc-release-ann.ezt

M notes/ra-serf-testing.txt

All these changes were reverted before commit. I suppose they were due

to faulty sync merges from trunk, probably done by myself.

But I don't really know what happened here...

  1. … 9 more files in changeset.
Fix Doxygen mark-up related to the use of '@a' to refer to an argument.

  1. … 12 more files in changeset.
Remove #include "svn_version.h" from a number of public header files, to reduce

build time in third party build environments and when switching between

branches.

This file modifies in some build scenarios because it contains the version

number and version description texts.

This change is similar to another recursive header include cleanup performed

early in Subversion 1.7 development.

* subversion/include/svn_auth.h

* subversion/include/svn_client.h

* subversion/include/svn_delta.h

* subversion/include/svn_diff.h

* subversion/include/svn_repos.h

* subversion/include/svn_wc.h

(includes): Remove svn_version.h

* subversion/libsvn_ra_svn/client.c

* subversion/svn/main.c

* subversion/svnlook/main.c

* subversion/svnsync/main.c

* subversion/svnversion/main.c

* tools/dev/svnraisetreeconflict/main.c

(includes): Add svn_version.h

  1. … 11 more files in changeset.
Add "const" to all "apr_array_header_t *" input parameters in public and

private APIs.

(Note that we are allowed to add "const" to a pointer parameter of a public

API, and have done so before, because that is a backward-compatible API

change and doesn't change the ABI at all.)

The public functions whose prototypes are changed are listed individually

below; the private functions are not.

* subversion/include/svn_auth.h

(svn_auth_open)

* subversion/include/svn_client.h

(svn_client_get_commit_log_t,

svn_client_copy5,

svn_client_copy4,

svn_client_move5,

svn_client_patch)

* subversion/include/svn_delta.h

(svn_delta_path_driver,

svn_file_rev_handler_t,

svn_file_rev_handler_old_t)

* subversion/include/svn_fs.h

(svn_fs_change_txn_props)

* subversion/include/svn_mergeinfo.h

(svn_rangelist_diff,

svn_rangelist_merge,

svn_rangelist_remove,

svn_rangelist_intersect,

svn_rangelist_inheritable2,

svn_rangelist_inheritable,

svn_rangelist_dup)

* subversion/include/svn_opt.h

(svn_opt_args_to_target_array3,

svn_opt_args_to_target_array2,

svn_opt_args_to_target_array,

svn_opt_eat_peg_revisions)

* subversion/include/svn_ra.h

(svn_ra_file_rev_handler_t,

svn_ra_get_locations,

svn_ra_plugin_t.get_locations)

* subversion/include/svn_ra_svn.h

(svn_ra_svn_command_handler,

svn_ra_svn_set_capabilities,

svn_ra_svn_parse_tuple,

svn_ra_svn_parse_proplist)

* subversion/include/svn_repos.h

(svn_repos_file_rev_handler_t,

svn_repos_trace_node_locations,

svn_repos_fs_get_mergeinfo,

svn_repos_fs_change_txn_props,

svn_repos_remember_client_capabilities)

* subversion/include/svn_sorts.h

(svn_sort__bsearch_lower_bound)

* subversion/include/svn_string.h

(svn_cstring_match_glob_list)

* subversion/include/svn_wc.h

(svn_wc_get_status_editor3,

svn_wc_get_update_editor4,

svn_wc_get_update_editor3,

svn_wc_get_switch_editor4,

svn_wc_get_switch_editor3,

svn_wc_match_ignore_list)

* subversion/include/private/svn_cmdline_private.h

* subversion/include/private/svn_opt_private.h

* subversion/libsvn_client/blame.c

* subversion/libsvn_client/client.h

* subversion/libsvn_client/commit.c

* subversion/libsvn_client/commit_util.c

* subversion/libsvn_client/copy.c

* subversion/libsvn_client/deprecated.c

* subversion/libsvn_client/merge.c

* subversion/libsvn_client/mergeinfo.c

* subversion/libsvn_client/mergeinfo.h

* subversion/libsvn_client/patch.c

* subversion/libsvn_client/ra.c

* subversion/libsvn_delta/compat.c

* subversion/libsvn_delta/path_driver.c

* subversion/libsvn_fs_base/reps-strings.c

* subversion/libsvn_fs_base/revs-txns.c

* subversion/libsvn_fs_base/revs-txns.h

* subversion/libsvn_fs_fs/fs_fs.c

* subversion/libsvn_fs_fs/fs_fs.h

* subversion/libsvn_fs/fs-loader.c

* subversion/libsvn_fs/fs-loader.h

* subversion/libsvn_ra/compat.c

* subversion/libsvn_ra/ra_loader.c

* subversion/libsvn_ra/ra_loader.h

* subversion/libsvn_ra/wrapper_template.h

* subversion/libsvn_ra_local/ra_plugin.c

* subversion/libsvn_ra_neon/get_locations.c

* subversion/libsvn_ra_neon/props.c

* subversion/libsvn_ra_neon/ra_neon.h

* subversion/libsvn_ra_serf/getlocations.c

* subversion/libsvn_ra_serf/ra_serf.h

* subversion/libsvn_ra_svn/client.c

* subversion/libsvn_ra_svn/cyrus_auth.c

* subversion/libsvn_ra_svn/editorp.c

* subversion/libsvn_ra_svn/internal_auth.c

* subversion/libsvn_ra_svn/marshal.c

* subversion/libsvn_ra_svn/ra_svn.h

* subversion/libsvn_repos/fs-wrap.c

* subversion/libsvn_repos/log.c

* subversion/libsvn_repos/repos.c

* subversion/libsvn_repos/repos.h

* subversion/libsvn_repos/rev_hunt.c

* subversion/libsvn_subr/auth.c

* subversion/libsvn_subr/cmdline.c

* subversion/libsvn_subr/deprecated.c

* subversion/libsvn_subr/mergeinfo.c

* subversion/libsvn_subr/opt.c

* subversion/libsvn_subr/sorts.c

* subversion/libsvn_subr/svn_string.c

* subversion/libsvn_wc/adm_ops.c

* subversion/libsvn_wc/deprecated.c

* subversion/libsvn_wc/diff.c

* subversion/libsvn_wc/status.c

* subversion/libsvn_wc/update_editor.c

* subversion/libsvn_wc/util.c

* subversion/mod_dav_svn/dav_svn.h

* subversion/mod_dav_svn/reports/file-revs.c

* subversion/mod_dav_svn/util.c

* subversion/svn/cl.h

* subversion/svn/props.c

* subversion/svn/switch-cmd.c

* subversion/svn/util.c

* subversion/svndumpfilter/main.c

* subversion/svnserve/serve.c

* subversion/tests/libsvn_repos/repos-test.c

* subversion/tests/libsvn_subr/mergeinfo-test.c

  1. … 78 more files in changeset.
Test out my new and fancy ASF commit priviledges by changing the copyright

wording in our license headers to reflect ownership by the ASF.

* NOTICE:

Change terminology to ASF, and update a link.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the ASF, and update the project website.

* everywhere:

Change license text to reflect ASF ownership.

  1. … 891 more files in changeset.
Fix some outdated stylistic conventions. Whitespace should not occur

before a open-parentheses that is part of a function definition,

declaration, or type definition. In all these cases, shift the open-paren

up one line to the func/type name.

No functional change.

* subversion/include/svn_delta.h:

* subversion/include/svn_types.h:

* subversion/include/svn_wc.h:

* subversion/include/svn_cmdline.h:

* subversion/include/svn_client.h:

* subversion/include/svn_auth.h:

* subversion/include/svn_opt.h:

* subversion/include/svn_ra.h:

(): adjust declarations to avoid whitespace before func paren.

Found by: blair

  1. … 7 more files in changeset.
Relicense Subversion under the Apache License, Version 2.0.

* NOTICE: New.

* LICENSE: New.

* COPYING,

subversion/LICENSE: Remove.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the SVN Corp, and that it contains contributions from

many people, as referenced in NOTICE.

* subversion/bindings/swig/python/LICENSE_FOR_PYTHON_BINDINGS:

Relicense the SVN parts under Apache 2.0.

* everywhere:

Change copyright notices in file headers to reflect the Apache 2.0 license.

  1. … 882 more files in changeset.
* subversion/include/svn_auth.h

(svn_auth_get_ssl_client_cert_pw_file_provider2,

svn_auth_get_ssl_client_cert_pw_file_provider): Fix doc strings.