Checkout Tools
  • last updated 4 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Revert r1668597.
[Reverted in r1668617]

Fix docstring issues in mod_dav_svn.h found during 1.9 API review.

No functional change.

* subversion/include/mod_dav_svn.h


dav_svn_get_repos_path): Add Doxygen deprecation info. We can't use

SVN_DEPRECATED here due to header restrictions.

Fix unbounded memory usage in mod_authz_svn when SVNPathAuthz short_circuit

option is used.

* subversion/include/mod_dav_svn.h

(dav_svn_split_uri2, dav_svn_get_repos_path2): New.

(dav_svn_split_uri, dav_svn_get_repos_path): Update docstring.

* subversion/mod_authz_svn/mod_authz_svn.c

(get_access_conf): Call dav_svn_get_repos_path2() instead of

dav_svn_get_repos_path() passing SCRATCH_POOL as POOL parameter.

* subversion/mod_dav_svn/mod_dav_svn.c

(dav_svn_get_repos_path): Rename to ...

(dav_svn_get_repos_path2): ... this, adding POOL parameter and use it for

all allocations.

(dav_svn_get_repos_path): New, wraps dav_svn_get_repos_path2().

* subversion/mod_dav_svn/repos.c

(dav_svn_split_uri): Rename to ...

(dav_svn_split_uri2): ... this, adding POOL parameter and use it for

all allocations.

(dav_svn_split_uri): New, wraps dav_svn_split_uri2().

  1. … 3 more files in changeset.
Improve Doxygen output from mod_dav_svn.h.

* doc/doxygen.conf

(PREDEFINED): Pre-define 'AP_MODULE_DECLARE()' so that Doxygen doesn't

think it is a function itself.

* subversion/include/mod_dav_svn.h

(dav_svn_split_uri, dav_svn_get_repos_path): Convert to Doxygen mark-up.

  1. … 1 more file in changeset.
Rename a function parameter for clarity.

* subversion/include/mod_dav_svn.h

(dav_svn_split_uri): Rename 'repos_name' parameter to 'repos_basename',

and note in the docstring how it's *not* the same as the "repository

name" as optionally defined via the SVNReposName directive.

* subversion/mod_dav_svn/repos.c

(dav_svn_split_uri): Rename 'repos_name' parameter to 'repos_basename'.

(get_resource): Rename 'repos_name' parameter to 'repo_basename'.

  1. … 1 more file in changeset.
Fix a few doxygen errors in our header files.

* subversion/include/svn_diff.h




Make sure functions get doc'd, and fix an error or two.

  1. … 3 more files in changeset.
Test out my new and fancy ASF commit priviledges by changing the copyright

wording in our license headers to reflect ownership by the ASF.


Change terminology to ASF, and update a link.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the ASF, and update the project website.

* everywhere:

Change license text to reflect ASF ownership.

  1. … 891 more files in changeset.
Relicense Subversion under the Apache License, Version 2.0.

* NOTICE: New.



subversion/LICENSE: Remove.

* subversion/libsvn_subr/opt.c

(svn_opt__print_version_info): Note that the product as a whole is

copyrighted by the SVN Corp, and that it contains contributions from

many people, as referenced in NOTICE.

* subversion/bindings/swig/python/LICENSE_FOR_PYTHON_BINDINGS:

Relicense the SVN parts under Apache 2.0.

* everywhere:

Change copyright notices in file headers to reflect the Apache 2.0 license.

  1. … 882 more files in changeset.
* subversion/include/mod_dav_svn.h

Trim off some extraneous text from the header doc string (which

should've been removed in r27672).

* subversion/include/mod_dav_svn.h

Make header doc string Doxygen-friendly, and correct copyright date.

Fix various cosmetic and documentation errors.

Patch by: Ed Price <>

* contrib/client-side/

* contrib/client-side/svncopy.README

* contrib/hook-scripts/

* notes/fs-improvements.txt

* notes/wc-improvements

* subversion/bindings/java/README

* subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/tests/

* subversion/include/mod_dav_svn.h

* subversion/include/svn_auth.h

* subversion/include/svn_types.h

* subversion/include/svn_wc.h

* subversion/libsvn_client/client.h

* subversion/libsvn_fs_base/notes/fs-history

* subversion/libsvn_wc/adm_ops.c

* subversion/libsvn_wc/entries.c

* subversion/libsvn_wc/entries.h

* subversion/libsvn_wc/log.c

* subversion/svn/main.c

* subversion/svnserve/serve.c

* subversion/tests/cmdline/svntest/

* www/faq.html

Fix typos, spelling, punctuation and wording in documentation.

Fix whitespace.


* build/win32/

* subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/tests/

* subversion/tests/README

* tools/test-scripts/svntest/examples/debian-gnulinux-shared/mod_dav_svn.conf

* tools/test-scripts/svntest/mod_dav_svn.conf

Fix test directory name in documentation and examples, after r17718 moved it.

* notes/releases.txt: Remove obsolete text. Fix test directory name.

Add 'make check-swig-py'. Fix whitespace.

  1. … 27 more files in changeset.
Add a function to mod_dav_svn to get the path of the repository on disk.

This can be useful for other Apache modules.

Patch by: Markus Rückert <>

(Comment tweaks by Max Bowsher <>.)

* subversion/include/mod_dav_svn.h

(dav_svn_get_repos_path): New.

* subversion/mod_dav_svn/mod_dav_svn.c

Include mod_dav_svn.h.

(dav_svn_get_repos_path): New.

  1. … 1 more file in changeset.
Update copyright notices for 2004, resolving issue #1651.

(See also revision 8019, which fixed a couple of missed spots.)

  1. … 361 more files in changeset.
The handling around dav_svn.h was incorrect. It is a private header, so it

should never have been moved to include/. This commit reverts changes from

r6184 and r6180. The single, public function is now in its own header and

dav_svn.h moves back to its original location.

* subversion/mod_dav_svn/dav_svn.h:

- moved back from include/mod_dav_svn.h

(dav_svn_split_uri): removed; move to a new mod_dav_svn.h

* subversion/include/mod_dav_svn.h:

- new header

(dav_svn_split_uri): declaration. moved from dav_svn.h

* subversion/mod_dav_svn/merge.c:

* subversion/mod_dav_svn/mod_dav_svn.c:

* subversion/mod_dav_svn/log.c:

* subversion/mod_dav_svn/deadprops.c:

* subversion/mod_dav_svn/update.c:

* subversion/mod_dav_svn/liveprops.c:

* subversion/mod_dav_svn/version.c:

* subversion/mod_dav_svn/activity.c:

* subversion/mod_dav_svn/util.c:

- renamed #include from "mod_dav_svn.h" to "dav_svn.h"

* subversion/mod_dav_svn/repos.c:

- renamed #include from "mod_dav_svn.h" to "dav_svn.h"

- also include (new) "mod_dav_svn.h"

  1. … 11 more files in changeset.
Merge /branches/partial-authz-dev to /trunk, r7571:7672.

See the branch for full log messages.

Here's my nutshell summary of the new 'partial read-authz feature':

If a client checks out or updates a tree, a server authz system now

has the ability to selectively deny read-access on arbitrary files and

dirs by supplying a authz_read_func to svn_repos_dir_delta(). In this

situation, dir_delta() will call new absent_[file|dir]() editor

functions instead of the usual [open|add] functions. The DAV layer

now marshals these messages over the network, and libsvn_wc marks the

appropriate wc entries as 'absent'. Entries marked 'absent' are

essentially treated like 'deleted' ones; most client commands can't

see them at all. (But 'svn up' *does* report them to the server, in

case read-access is re-granted.)

(There are still a couple of small wc bugs, specifically triggered by

repeated granting/ungranting of read-access to files. They'll be

fixed RSN.)

Final note: this change upgrades working copies from format 2 to

format 3 'in place'. Format 1 wc's are no longer supported.

  1. … 27 more files in changeset.
Finish issue #495 - mod_dav_svn needs to delete activities.

* subversion/include/mod_dav_svn.h

(dav_svn_delete_activity): New.

* subversion/mod_dav_svn/activity.c

(dav_svn_get_txn): Test for existence before trying to read the value.

(dav_svn_delete_activity): New.

* subversion/mod_dav_svn/repos.c

(dav_svn_get_parent_resource): Generate a private resource for the

parent of an activity.

(dav_svn_remove_resource): Add support for DELETE on an activity.

* subversion/libsvn_ra_dav/commit.c

(delete_activity, commit_abort_edit): New.

(commit_close_edit): Now calls delete_activity() on success.

(svn_ra_dav__get_commit_editor): Add commit_abort_edit() to the

vtable filling.

* subversion/libsvn_client/commit.c

(svn_client_commit): Don't claim that a commit is no longer in

progress until it *successfully* finishes.

* subversion/tests/clients/cmdline/

(test_list): No longer expect failed_commit() to fail. (Huh?)

  1. … 5 more files in changeset.
With Ben Collins-Sussman and Greg Stein, finish issue #971: Send

Last-Modified, Expires, and Cache-Control headers for versioned


* subversion/mod_dav_svn/repos.c: Include http_request.h.

(dav_svn_set_headers): Send the appropriate headers, or cause them

to be sent by Apache.

* subversion/include/mod_dav_svn.h, subversion/mod_dav_svn/liveprops.c

(dav_svn_get_last_modified_time): Allow either return parameter to

be NULL.

  1. … 2 more files in changeset.
Prelude to issue #971: factorize some timestamp-retrieval code in

mod_dav_svn, so that we can eventually send out Last-Modified headers.

* include/mod_dav_svn.h (enum dav_svn_time_format,

dav_svn_get_last_modified_time): declare new enum and function.

* mod_dav_svn/liveprops.c (dav_svn_get_last_modified_time): new

factorized function...

(dav_svn_insert_prop): ... which originally lived here. Use new func.

  1. … 1 more file in changeset.
Get mod_authz_svn to build on Windows.

* build/generator/ (WinGeneratorBase.get_win_defines): Factor out

common defines for all modules, and add AP_DECLARE_EXPORT for mod_dav_svn.

(WinGeneratorBase.get_win_lib_dirs, WinGeneratorBase.get_win_libs):

Don't add mod_dav.lib to the list for mod_authz_svn.

* build/generator/ (Generator.write): Add mod_dav_svn to the

dependency list of mod_authz_svn.

* subversion/include/mod_dav_svn.h (dav_svn_split_url): AP_MODULE_DECLARE

this function.

* subversion/mod_dav_svn/repos.c (dav_svn_split_url): Likewise.

* build.conf (__ALL__): Add mod_authz_svn.

  1. … 4 more files in changeset.
* build.conf

(mod_authz_svn): new section.

* subversion/mod_authz_svn/mod_authz_svn.c

New Apache module to allow path based access control to the repository.

* subversion/include/mod_dav_svn.h

Moved from subversion/mod_dav_svn/mod_dav_svn.h, so that mod_authz_svn and

possibly other modules can use it.

  1. … 4 more files in changeset.