Checkout Tools
  • last updated 8 hours ago
Constraints: committers
Constraints: files
Constraints: dates

Changeset 1721648 is being indexed.

Fix Python bindings with SWIG < 3.0.6, followup on 1721488.

“%pythoncode { ... }” had to be changed to “%pythoncode %{ ... %}” to avoid

macro expansion (done in r1721488). This was a latent bug in the bindings

exposed by stricter parsing in SWIG 3.x.

However, there was a bug in SWIG through 3.0.6 which would remove part of the

commented lines inside the “%pythoncode %{ ... %}” block. This caused the

"right" fix to break everywhere except 3.0.6+.

As discussed in the SWIG bug tracker[0], an alternative form of the pythoncode

directive can be used to inline the contents of a specified file. Use of this

form works in all supported SWIG versions.


* subversion/bindings/swig/include/proxy.swg:

(proxy_pythoncode): Copy %pythoncode contents to ...

* subversion/bindings/swig/include/

... new file which is included in proxy.swg via “%pythoncode "..."”


* build/ac-macros/swig.m4


Remove 3.x related SWIG restrictions. All SWIG versions are supported again.

  1. … 3 more files in changeset.
Enable building bindings with SWIG >= 3.0.6

This reinstates r1690591 and adds the minimum version checks for SWIG

proposed by Joe Orton in

* build/ac-macros/swig.m4,


Change version check and documentation to allow SWIG >= 3.0.6

* subversion/bindings/swig/include/proxy.swg:

Use %{ %} with %pythoncode so comments avoid the SWIG processor,

fixing the bindings with SWIG >= 3.0.6.

  1. … 2 more files in changeset.
Followup to r1700844: fix the build.

* build/ac-macros/swig.m4


Only require swig when --with-swig was passed.

swig: Error out if --with-swig was passed but swig not found.

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): As above.

Also, change the magic string used by SVN_CHECK_SWIG/SVN_FIND_SWIG to

communicate the "--with-swig passed without value" case.

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): In a comment, remove a mention of obsolete files.

* build/ac-macros/swig.m4:

(SVN_FIND_SWIG): Update version warning on SWIG to complain about 3.0.0 and


Revert r1659397; it breaks too many buildbots.

* TODO: Re-added.

* build/ac-macros/swig.m4: Reverted.

  1. … 1 more file in changeset.
[Reverted in r1659546]

Do not attempt to build bindings with Swig 3.0+. Current versions

break the Python bindings.

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Add an upper limite to supported Swig versions.

Do not configure bindings if the detected Swig is not suitable.

* TODO: Remove.

  1. … 1 more file in changeset.
Allow Swig to use Ruby 2.0 and 2.1.

Patch by: James McCoy <jamessan{_AT_}>

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Adjust include path for Ruby 2.

* Allow Ruby 2.0 and 2.1.

  1. … 1 more file in changeset.
Reintegrate tweak-build-take-two branch to trunk.

Summary of changes:

** Split standards-compliance mode and maintainer mode compiler flags

out of CFLAGS, so that compilation command lines that do not

generate (too many) warnings or are not forced to comply with ISO

C '90 can be constructed without having to resort to stripping

individual flags out of CFLAGS.

$ svn diff -r1424288:1424822 \

^/subversion/branches/tweak-build-take-two/ \

^/subversion/branches/tweak-build-take-two/aclocal.m4 \

^/subversion/branches/tweak-build-take-two/build/ac-macros/compiler.m4 \


** Now that warning and standards-compliance mode macros are no

longer part of CFLAGS, stop stripping them in the Swig wrapper

configury, except for Ruby, which is more delicate.

$ svn diff -r1424329:1425040 \


** Allow optimization and debugging to coexist, including in

maintainer mode, adding a new configure option

--enable-optimize. Neither --enable-optimize nor --enable-debug

will override any optimization or debugging flags set by the user

in C(XX)FLAGS at configure time. If debugging and optimization are

enabled at the same time, we will try to use -O1, then -O; if

debuggin is not enabled, we will try -O2 first.

$ svn diff -c1424860 \


** Remove an obsolete autoconf macro that was not used anywhere and

is superceded with SVN_CFLAGS_ADD_IFELSE.

$ svn diff -c1424297 \


** Move the sqlite-amalgamation directory from the root of the source tree

under subversion/include/private to make include paths safer from

possible collision with sqlite include files from other install locations.

$ svn diff -c1425050 \


** Allow a user to set a custom set of compiler flags at configure time that

are used for Subversion sources, but not, e.g., Swig-generated sources,

like this:

$ ./configure CUSERFLAGS=--flags-for-C CXXUSERFLAGS=--flags-for-C++

$ svn diff -c1425086 \


  1. … 14 more files in changeset.
Similar to r1421645, but for the Python bindings: filter out noisy warnings.

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Filter some noise from the output of 'make swig-py'.

Make the warnings issued when building the Ruby bindings *much* less verbose.

The removed warnings are the result of swig's---ahem---interesting way of

generating code. Hopefully, this helps us find more errors, more quickly.

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Filter out a number of compiler warnings flags for the Ruby


The swig python bindings generate a lot of shadowed variables, which then

emit a number of warnings when compiling. Turn off those warnings for swig-py.

* build/ac-macros/swig.m4:

Filter -Wshadow from SWIG_PY_COMPILE.

fix Ruby 1.9 deprecation warning for Config, use RbConfig


replace Config with RbConfig

* build/ac-macros/swig.m4

replace Config with RbConfig

Approved by: gstein

  1. … 1 more file in changeset.
* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Strip -std=c89 from CFLAGS in a second place, just

like -ansi.

* build/ac-macros/swig.m4: When checking how to link ruby libraries,

include all libraries that libruby depends on in the linker argument

list, rather than just the ruby library itself. Should fix the build on

OpenBSD with ruby-1.9. The configure script could not detect rb_errinfo()

because linking ruby libraries failed as the -pthread argument was missing.

This argument isn't part of the LIBRUBYARG value in rbconfig, but of LIBS.

Remove check for maximal version of SWIG.

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Remove check for maximal version of SWIG.

* subversion/bindings/swig/INSTALL: Update documentation.

  1. … 1 more file in changeset.
Support SWIG 2.0.2.

* build/ac-macros/swig.m4


* subversion/bindings/swig/INSTALL: Support SWIG 2.0.2.

  1. … 1 more file in changeset.
[ This was reverted/redone as part of issue #3850, which see. ]

Don't error on 'none: bad command or file name' when SWIG was disabled

at configure-time.

(Yes, I'm on Debian, thanks for asking.)


(check-SWIG): New target.

(swig-py, swig-pl, swig-rb): Use new target to fail early.

* build/generator/

(Generator.write): Use the new target in, too.

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Don't check for 'none', just set the thing to 'none'.

As a side effect, the message to stdout is obliterated.

  1. … 2 more files in changeset.
Fix comparisons of SWIG version in build system. Previously

generator.swig.Generator.version() was returning 20001 for SWIG 2.0.1, which

was incorrectly compared with hardcoded integers corresponding to SWIG 1.3.2*

(e.g. 103024 for SWIG 1.3.24).

This change also fixes building of Ruby bindings with SWIG 2.0.0 and 2.0.1.

* build/generator/swig/

(Generator.version): Return a tuple of integers instead of

a single integer.

* build/generator/swig/

(Generator.checkout, Generator._skip_checkout):

* build/generator/swig/

(Generator.write_external_runtime): Compare tuples returned by

generator.swig.Generator.version() with tuples of integers.

* build/ac-macros/swig.m4


* subversion/bindings/swig/INSTALL: Declare SWIG 2.0.1 supported.

  1. … 4 more files in changeset.
Fix warnings about missing AC_LANG_SOURCE with autoconf 2.68; tested also

against 2.59.

Kudos to Philip Martin for pointing me at final bit needed to fix this.

* build/ac-macros/kwallet.m4 (SVN_LIB_KWALLET),

build/ac-macros/swig.m4 (SVN_FIND_SWIG),

build/ac-macros/gssapi.m4 (SVN_LIB_RA_SERF_GSSAPI),

build/ac-macros/neon.m4 (SVN_NEON_CONFIG),


  1. … 4 more files in changeset.
* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Remove -std=c89 (equivalent to -ansi) from SWIG_RB_COMPILE.

Apply ASF license headers to a number of files included under that license

but lacking said header.

Patch by: Niall Pemberton <niallp{_AT_}>

  1. … 175 more files in changeset.
Fix Issue #3458: Use '$SED' instead of 'sed'.


* build/ac-macros/berkeley-db.m4


* build/ac-macros/neon.m4


* build/ac-macros/svn-macros.m4


* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Use '$SED' instead of 'sed'.

  1. … 4 more files in changeset.
Follow-up to r38377:

* build/ac-macros/swig.m4



Revert r38218. Buildbots now provide 'config.log' when an error occurs.

  1. … 16 more files in changeset.
Make `configure` sometimes print the content of 'config.log' when an error occurs.

* build/ac-macros/svn-macros.m4


* build/ac-macros/apache.m4:

* build/ac-macros/apr.m4:

* build/ac-macros/apr_memcache.m4:

* build/ac-macros/aprutil.m4:

* build/ac-macros/berkeley-db.m4:

* build/ac-macros/ctypesgen.m4:

* build/ac-macros/gssapi.m4:

* build/ac-macros/java.m4:

* build/ac-macros/kwallet.m4:

* build/ac-macros/neon.m4:

* build/ac-macros/sasl.m4:

* build/ac-macros/serf.m4:

* build/ac-macros/sqlite.m4:

* build/ac-macros/swig.m4:

* build/ac-macros/zlib.m4:

* Use SVN_MSG_ERROR() instead of AC_MSG_ERROR().

[Reverted in r38285.]

  1. … 16 more files in changeset.
* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Allow SWIG 1.3.39.

Follow-up to r35852:

Improve check for rb_errinfo().

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Define HAVE_RB_ERRINFO if rb_errinfo() is available.

* subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c

(callback_rescue): Use rb_errinfo() if HAVE_RB_ERRINFO is defined.

  1. … 1 more file in changeset.
Respect CFLAGS in SWIG bindings.

* build/ac-macros/swig.m4


* build/ Don't print BASECFLAGS and OPT.


(COMPILE_SWIG_PY): Delete $(CFLAGS) which is now in $(SWIG_PY_COMPILE).

(COMPILE_SWIG_RB): Delete $(CFLAGS) which is now in $(SWIG_RB_COMPILE).

(swig-pl): Appropriately set OPTIMIZE when calling $(MAKE) in

subversion/bindings/swig/perl/native directory.

* subversion/bindings/swig/perl/native/ Respect CFLAGS.

  1. … 3 more files in changeset.