Checkout Tools
  • last updated 4 hours ago
Constraints: committers
Constraints: files
Constraints: dates

Changeset 1137545 is being indexed.

* build/ac-macros/swig.m4: When checking how to link ruby libraries,

include all libraries that libruby depends on in the linker argument

list, rather than just the ruby library itself. Should fix the build on

OpenBSD with ruby-1.9. The configure script could not detect rb_errinfo()

because linking ruby libraries failed as the -pthread argument was missing.

This argument isn't part of the LIBRUBYARG value in rbconfig, but of LIBS.

Remove check for maximal version of SWIG.

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Remove check for maximal version of SWIG.

* subversion/bindings/swig/INSTALL: Update documentation.

  1. … 1 more file in changeset.
Support SWIG 2.0.2.

* build/ac-macros/swig.m4


* subversion/bindings/swig/INSTALL: Support SWIG 2.0.2.

  1. … 1 more file in changeset.
[ This was reverted/redone as part of issue #3850, which see. ]

Don't error on 'none: bad command or file name' when SWIG was disabled

at configure-time.

(Yes, I'm on Debian, thanks for asking.)


(check-SWIG): New target.

(swig-py, swig-pl, swig-rb): Use new target to fail early.

* build/generator/

(Generator.write): Use the new target in, too.

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Don't check for 'none', just set the thing to 'none'.

As a side effect, the message to stdout is obliterated.

  1. … 2 more files in changeset.
Fix comparisons of SWIG version in build system. Previously

generator.swig.Generator.version() was returning 20001 for SWIG 2.0.1, which

was incorrectly compared with hardcoded integers corresponding to SWIG 1.3.2*

(e.g. 103024 for SWIG 1.3.24).

This change also fixes building of Ruby bindings with SWIG 2.0.0 and 2.0.1.

* build/generator/swig/

(Generator.version): Return a tuple of integers instead of

a single integer.

* build/generator/swig/

(Generator.checkout, Generator._skip_checkout):

* build/generator/swig/

(Generator.write_external_runtime): Compare tuples returned by

generator.swig.Generator.version() with tuples of integers.

* build/ac-macros/swig.m4


* subversion/bindings/swig/INSTALL: Declare SWIG 2.0.1 supported.

  1. … 4 more files in changeset.
Fix warnings about missing AC_LANG_SOURCE with autoconf 2.68; tested also

against 2.59.

Kudos to Philip Martin for pointing me at final bit needed to fix this.

* build/ac-macros/kwallet.m4 (SVN_LIB_KWALLET),

build/ac-macros/swig.m4 (SVN_FIND_SWIG),

build/ac-macros/gssapi.m4 (SVN_LIB_RA_SERF_GSSAPI),

build/ac-macros/neon.m4 (SVN_NEON_CONFIG),


  1. … 4 more files in changeset.
* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Remove -std=c89 (equivalent to -ansi) from SWIG_RB_COMPILE.

Apply ASF license headers to a number of files included under that license

but lacking said header.

Patch by: Niall Pemberton <niallp{_AT_}>

  1. … 175 more files in changeset.
Fix Issue #3458: Use '$SED' instead of 'sed'.


* build/ac-macros/berkeley-db.m4


* build/ac-macros/neon.m4


* build/ac-macros/svn-macros.m4


* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Use '$SED' instead of 'sed'.

  1. … 4 more files in changeset.
Follow-up to r38377:

* build/ac-macros/swig.m4



Revert r38218. Buildbots now provide 'config.log' when an error occurs.

  1. … 16 more files in changeset.
Make `configure` sometimes print the content of 'config.log' when an error occurs.

* build/ac-macros/svn-macros.m4


* build/ac-macros/apache.m4:

* build/ac-macros/apr.m4:

* build/ac-macros/apr_memcache.m4:

* build/ac-macros/aprutil.m4:

* build/ac-macros/berkeley-db.m4:

* build/ac-macros/ctypesgen.m4:

* build/ac-macros/gssapi.m4:

* build/ac-macros/java.m4:

* build/ac-macros/kwallet.m4:

* build/ac-macros/neon.m4:

* build/ac-macros/sasl.m4:

* build/ac-macros/serf.m4:

* build/ac-macros/sqlite.m4:

* build/ac-macros/swig.m4:

* build/ac-macros/zlib.m4:

* Use SVN_MSG_ERROR() instead of AC_MSG_ERROR().

[Reverted in r38285.]

  1. … 16 more files in changeset.
* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Allow SWIG 1.3.39.

Follow-up to r35852:

Improve check for rb_errinfo().

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Define HAVE_RB_ERRINFO if rb_errinfo() is available.

* subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c

(callback_rescue): Use rb_errinfo() if HAVE_RB_ERRINFO is defined.

  1. … 1 more file in changeset.
Respect CFLAGS in SWIG bindings.

* build/ac-macros/swig.m4


* build/ Don't print BASECFLAGS and OPT.


(COMPILE_SWIG_PY): Delete $(CFLAGS) which is now in $(SWIG_PY_COMPILE).

(COMPILE_SWIG_RB): Delete $(CFLAGS) which is now in $(SWIG_RB_COMPILE).

(swig-pl): Appropriately set OPTIMIZE when calling $(MAKE) in

subversion/bindings/swig/perl/native directory.

* subversion/bindings/swig/perl/native/ Respect CFLAGS.

  1. … 3 more files in changeset.
Fix building Ruby bindings with Ruby 1.9.

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Use appropriate -I options.

* subversion/bindings/swig/core.i: Use RSTRING_LEN().

* subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c

(): Include <version.h>.

(rb_holder_pop, svn_swig_rb_set_pool, svn_swig_rb_to_apr_array_row_prop,

svn_swig_rb_to_apr_array_prop, svn_swig_rb_array_to_apr_array_revision_range,

name, read_handler_rbio): Use RARRAY_LEN(), RARRAY_PTR() and RSTRING_LEN().

(callback_rescue): Use rb_errinfo() instead of ruby_errinfo when Ruby >=1.9 is used.

* subversion/bindings/swig/include/svn_types.swg

(_swig_rb_closed): Use RSTRING_LEN().

* subversion/bindings/swig/include/svn_string.swg

(%typemap(in) svn_stringbuf_t *, %typemap(in) svn_stringbuf_t *node_name,

%typemap(in) const svn_string_t * (svn_string_t value)): Use RSTRING_LEN().

Unrelated changes which fix 'implicit declarations of svn_md5_digest_to_cstring()'

and some 'casts to pointer from integer of different size' accidentally discovered

when building Ruby bindings with Ruby 1.9:

* subversion/bindings/swig/core.i: Include svn_md5_h.swg.

* subversion/bindings/swig/svn_fs.i:

* subversion/bindings/swig/svn_wc.i:

* subversion/bindings/swig/svn_delta.i: Include "svn_md5.h" to get the

prototype for svn_md5_digest_to_cstring() (used in some typemaps in


  1. … 7 more files in changeset.
Follow-up to r35647:

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Fix quoting so that it works on all platforms.

Tested by: stsp

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Do not quote $rbconfig_sitedir inside a quoted

and backtick'ed invocation of sed.

This does not work on OpenBSD, where neither m4 nor /bin/sh

swallow the extra quotes around $rbconfig_sitedir, causing

sed to see " instead of s as the command character.

As a result of this problem, ruby bindings where installing

stuff in wacky places.

If this breaks things on other platforms, we need a better fix.

The only problem I could imagine is people using spaces in their

ruby install path, which is a silly thing to do given that these

paths are often used by configure scripts written in /bin/sh.

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Allow SWIG 1.3.36.

Resolve crazy space/tab mix.

* build/ac-macros/apache.m4

* build/ac-macros/swig.m4

* build/ac-macros/neon.m4

  1. … 2 more files in changeset.
* (AC_PREREQ): Require autoconf >= 2.58.


* build/ac-macros/apache.m4:

* build/ac-macros/java.m4:

* build/ac-macros/neon.m4:

* build/ac-macros/serf.m4:

* build/ac-macros/sqlite.m4:

* build/ac-macros/svn-macros.m4:

* build/ac-macros/swig.m4:

* build/ac-macros/zlib.m4:


  1. … 8 more files in changeset.
Increase SWIG upper bound to 1.3.31.

* build/ac-macros/swig.m4

* subversion/bindings/swig/INSTALL

  1. … 1 more file in changeset.
Don't use changequote.

* build/ac-macros/swig.m4 (SVN_FIND_SWIG): Use @<:@ and @:>@ instead of

changequote(<<, >>) for [ and ].

Suggested by: malcolm

Link with ruby library.

* build/ac-macros/swig.m4 (SVN_FIND_SWIG): Detect ruby library.

* (SWIG_RB_LINK): Register.

* build.conf (libsvn_swig_ruby): Use SWIG_RB_LIBS for linking.

Suggested by: Joe Swatosh

  1. … 2 more files in changeset.
Clean up Ruby part configuration script.

* build/ac-macros/swig.m4 (SVN_FIND_SWIG):

- Use changequote() to use "[]" in Ruby script.

- Store configurations of ruby to rbconfig_XXX and use them to clean up.

We seem to be working just fine with SWIG 1.3.29 already, so bump the stated

prerequisite versions.

* subversion/bindings/swig/INSTALL: Increase maximum SWIG version to 1.3.29.

* build/ac-macros/swig.m4: Ditto.

  1. … 1 more file in changeset.
Remove duplication of directories searched for include files, which may

not be harmful but makes build messages ugly. Problem scenario:


SWIG_RB_COMPILE includes SWIG_RB_INCLUDES, which includes







Patch by: me

Review by: kou


(COMPILE_PY_WRAPPER): Remove SWIG_INCLUDES, which is included in


(COMPILE_RB_WRAPPER): Remove SWIG_INCLUDES, which is included in


* build/ac-macros/swig.m4 (SVN_FIND_SWIG): Remove SWIG_RB_INCLUDES from


  1. … 1 more file in changeset.
Followup to r18491: update documentation to reflect that SWIG 1.3.28 is

compatible with Subversion.

* subversion/bindings/swig/INSTALL

* build/ac-macros/swig.m4 (SVN_FIND_SWIG):

Update list of acceptable SWIG versions to include SWIG 1.3.28.

  1. … 1 more file in changeset.
Upgrade the SWIG bindings to be compatible with SWIG 1.3.28.

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Allow SWIG 1.3.28.

* build/generator/swig/

(write_external_runtime): Don't add rubytracking.swg for SWIG 1.3.28.

  1. … 1 more file in changeset.
Update documentation to reflect that SWIG 1.3.26 and 1.3.27 are compatible with


Suggested by: julianfoad

* subversion/bindings/swig/INSTALL

Update list of acceptable SWIG versions to include SWIG 1.3.26 and 1.3.27.

* subversion/bindings/swig/NOTES

Remove warning about required versions of SWIG. Instead, folks can look in

INSTALL to find the list of acceptable SWIG versions.

* build/ac-macros/swig.m4

(SVN_FIND_SWIG): Clarify warning text. Remove subversion/bindings/swig/NOTES

from list of locations which contain version numbers.

  1. … 2 more files in changeset.