Checkout Tools
  • last updated 5 hours ago
Constraints: committers
Constraints: files
Constraints: dates

Changeset 1863265 is being indexed.

On '1.12.x' branch: Backport r1863262 (Do not print password to screen in A contrib script, so backported without voting.

Do not print password to screen in

* contrib/client-side/svn_load_dirs/

(sanitize_pwd): New function.

(safe_read_from_pipe, read_from_process): Update the sites printing

the command line to screen to use sanitize_pwd.

(usage): Warn that other local OS users may be able to see the

password passed on the command-line.

Fix indentation; that is, replace the 2 tab occurrences by 8 spaces.

Patch by: Geoffrey Alary <geoffrey.alary{_AT_}>

On branch swig-py3: Fix test after merging shelving-v3

* subversion/bindings/swig/python/tests/

(SubversionClientTestCase.test_shelf): Relax assert condition to be suitable

for changed behavior of shelved_func callback in


Win32: tweak the SSL certificate validation override to avoid hitting the wire

for URL based objects and revocation checks.

The primary purpose of this callback is to resolve SVN_AUTH_SSL_UNKNOWNCA

failures using CryptoAPI and Windows local certificate stores. To do so, we

should be fine with just using the immediately available data on the local


Doing the opposite of that appears to be troublesome, as always connecting

to remote CRL and OCSP endpoints can result in spurious errors or significant

(user-reported) network stalls caused by timeouts if the endpoints are

inaccessible or unreliable.

The new approach should also be in par with the default basic behavior of

several major browsers, for example:

* subversion/libsvn_subr/win32_crypto.c

(windows_validate_certificate): Use the CERT_CHAIN_CACHE_ONLY_URL_RETRIEVAL

and CERT_CHAIN_REVOCATION_CHECK_CACHE_ONLY flags when preparing the

certificate chain. Ignore errors in obtaining valid revocation information

when verifying the chain, as they could be induced by the new cache-only


On branch swig-py3: avoid crash when status is NULL

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c

(svn_swig_py_client_status_func) Allow NULL for status.

On branch swig-py3: Catchup to trunk @r1862753.
  1. … 166 more files in changeset.
* STATUS: Vote for r1860936 group.

* STATUS (r1860936 group): Point to a backport branch which resolves a trivial merge conflict, and so should allow the backports buildbot to test it.
Create a backport branch for the r1860936 group, with its three revisions merged and the trivial conflict resolved.
* STATUS: Nominate r1860936, r1860951, r1860958.
* STATUS: Nominate r1860936, r1860951, r1860958.
* STATUS: Nominate r1860936, r1860951, r1860958.
In svnserve, consistently handle errors in opening a repository.

These errors are still logged and reported to the client, as they were

before, but now it is done in the same way as everywhere else. (The error

logging now happens higher up the call stack.)

* subversion/svnserve/serve.c

After reporting an error to the client, don't log it explicity here and

then clear it; instead return it so the caller can do so.

Adjust expectations of a new test to account for differences between RA

layers. A follow-up to r1860936.

* subversion/tests/libsvn_ra/ra-test.c

(test_get_deleted_rev_errors): Expect a generic error code when running

over HTTP, otherwise the specific error code for this error case.

Provide a way for svnserve's 'get-deleted-rev' API to return 'not deleted'.

Previously the answer 'not deleted' was indistinguishable from an error when

using the svnserve protocol.

The standard 'svn' client software does not appear to invoke this case, but

it is meant to be a valid answer and is supported by the other repository

access protocols.

To work around the problem without changing the protocol, we re-purpose the

obsolete error code 'SVN_ERR_ENTRY_MISSING_REVISION' to communicate this

'not deleted' reply to the client.

(Re-purposing an old error code was not essential. An alternative would be

to create a new error code which would become part of the public API in the

next minor release, but would be deemed non-public when backported to older

release lines.)

Behaviour changes:

- With a new client against a new server, such queries are now handled


- With an old client against a new server, the client will report a more

informative error message.

- With a new client against an old server, there is no improvement.

* subversion/svnserve/serve.c

(get_deleted_rev): If the answer is SVN_INVALID_REVNUM, return a


* subversion/libsvn_ra_svn/client.c

(ra_svn_get_deleted_rev): Convert the error SVN_ERR_ENTRY_MISSING_REVISION

back to a response of SVN_INVALID_REVNUM.

* subversion/tests/libsvn_ra/ra-test.c

(commit_two_changes): New.


test_get_deleted_rev_errors): New tests.

(test_funcs): Run them.

Update table of contents to match actual section names in INSTALL.

* STATUS: Remove accidental double nomination.
* STATUS: Nominate VS2019 build support.
* STATUS: Nominate VS2019 build support.
* STATUS: Nominate VS2019 build support.
* STATUS: Cast vote.
* STATUS: Propose r1859732, r1859734 for backport to 1.12.x (

io: Implement the functions that check for node existence using

the native Win32 APIs on Windows).

Update Sqlite query parsing code in wc-queries-test to handle some new

intermediate explanation lines without warnings.

* subversion/tests/libsvn_wc/wc-queries-test.c

(explanation_item): Add some booleans.

(parse_explanation_item): Allow a few more constructs that caused

unneeded warnings.

Merge r1857391 from trunk:

* r1857391

Fix build with APR 1.7.0.


Bogus configure script check relies on APR internals.




+1: stsp, rhuijben (bindings change so 2+1's is enough)

    • ?
* STATUS: Expand revision range to allow backport script to handle this patch.
* STATUS: Cast some votes.
* STATUS: Nominate patch
* build/generator/

(quote_value): Fix yet another stupid bug introduced by remote testing :(.

* build/generator/

(quote_define): Fix another stupid typo.

Following up on r1860175, fix typo in python code.

* build/generator/

(quote_define): Add missing ':'.