Checkout Tools
  • last updated 1 hour ago
Constraints: committers
Constraints: files
Constraints: dates

Changeset 1850935 is being indexed.

Follow-up to r1850913:

* staging/docs/community-guide/releasing.part.html

(#tarball-signing): Track URL change.

* staging/docs/community-guide/releasing.part.html

(tarball-signing): Fix public key list url.

* tools/dev/unix-build/Makefile.svn: Stop compiling httpd in maintainer mode

for now. APR gets some _FMT_T constants for 64 bit types wrong on OpenBSD,

and this leads to many format string warnings which make httpd 2.4's build

fail due to -Werror. Non-maintainer mode builds don't force -Werror, so this

works around the problem until the underlying APR issue has been addressed.

* tools/dev/unix-build/Makefile.svn: Remove mod-proxy diff during httpd-clean.

* tools/dev/unix-build/Makefile.svn: Apply a patch to make mod_proxy build

without APR threads in httpd 2.4.

* tools/dev/unix-build/Makefile.svn: OpenBSD's JDK no longer supports dlopen()

of shared objects which do not end in '.so' because a local patch to load

objects with versioned names was dropped from OpenBSD's ports tree during an

update of the JDK. Work around this by manually symlinking

* upcoming.part.html: Automatically regenerated
* subversion/bindings/cxx/src/client_status.cpp

(status, async::status): Move closer to the almost-always-auto style.

* subversion/bindings/cxx/include/svnxx/client/status.hpp

(client::async::status): Tweak wording in the docstring.

* subversion/bindings/cxx/include/svnxx/detail/future.hpp


future::future): Fix -Wshadow warning from gcc.

subversion/include/svn_client.h: use uppercase CR/LF in the doc string.
Extend the blame callback with a string length parameter.

* subversion/incluce/svn_client.h

* subversion/libsvn_client/blame.c

(svn_client_blame_receiver4_t): typedef for new callback

(svn_client_blame6): new API using the svn_client_blame_receiver4_t callback

* subversion/libsvn_client/deprecated.c

(svn_client_blame5): moved API there, calling svn_client_blame6 using a

callback shim

(blame_wrapper_receiver3): callback shim for svn_client_blame5

Invent a model of asynchronous operations in SVN++.

[in subversion/bindings/cxx]

* README: Document a warning about the current async op model.

* svnxx/client/context.hpp

(detail::context_ptr): Make this a shared pointer because asynchronous

operations have to hold on to a weak reference to the context.

(detail::weak_context_ptr): New.

* svnxx/client/status.hpp: Don't include <future>, use detail/future.hpp.

(client::status): Pass revision by const-reference. Update docstring.

(client::async::status): New.

* svnxx/detail/future.hpp: New. Provides std::future-like tools for SVN++.

* src/future.cpp,

src/private/future_private.hpp: New.

* src/private/client_context_private.hpp

(impl::unwrap): Return a shared pointer to the client context.

* src/private.hpp: Include private/future_private.hpp.

* src/client_status.cpp

(impl::(anon)::status_func): Moved here so that it can be used from

impl::status. Check that the wrapped callback functor is not null

before invoking it.

(impl::status): New; common implementation for the status operation.

(client::status): Use impl::status. Keep the client context alive.

(client::async::status): New.

* tests/test_client_status.cpp

(working_copy_root, status_callback): Move to anonymous scope.

(async_example): New test case.

    • ?
* subversion/bindings/cxx/src/aprwrap/pool.hpp

(apr::pool::get): Fix typo in comment. No functional change.

Keep the SVN++ global pool alive as long as there are any users.

[in subversion/bindings/cxx]

* include/svnxx/init.hpp

(detail::global_state): Renamed from detail::context.

(init): Derive directly from the global_state shared pointer.

(init::~init): Add explicit destructor (for debugging).

* src/private/init_private.hpp: Do not include svn_private_config.h.

(detail::global_state): Renamed from detail::context.

(detail::global_state::get): Don't try to translate the exception

message, because neither APR nor the localisation library are

likely to have been initialized.

* src/aprwrap/pool.hpp: Include init_private.hpp.

(apr::pool::pool): Add a constructor overload that uses the global

pool from a known global state reference.

* src/aprwrap/impl.cpp

(apr::pool::get_root_pool): Rename detail::context to detail::global_state.

* src/debug.cpp,

src/private/debug_private.hpp: New files.

* src/private/client_context_private.hpp: Include init_private.hpp.

(client::context::state): New member, keeps the global state alive as

long as the client context is viable.

(client::context::get_state): New accessor.

(client::context::get_ctx): Renamed from 'get'.

(impl::unwrap): Make the context_wrapper a final class.

* src/init.cpp:

Include debug_private.hpp and apr_pools.h instead of svn_pools.h.

(init::init): Use global_state and add pool debugging logs.

(init::~init): Implement, with pool debugging logs.

(notify_root_pool_cleanup): New; tracks the global pool's destruction.

(create_root_pool): Add pool debugging logs. Avoid leaking the root pool.

(detail::global_state): Add pool debugging logs.

* src/client_status.cpp

(client::status): use the client context's renamed get_ctx() accessor.

* tests/test_init.cpp: Rename detail::context to detail::global_state.

    • ?
* tools/dev/unix-build/Makefile.svn: Undo the APR configure script hack

introduced in r1849589. This hack should not be needed anymore.

* tools/dev/unix-build/Makefile.svn: Patch httpd 2.4.37 so that it will

compile with non-threaded APR (see r1663375).

* tools/dev/unix-build/Makefile.svn: Pull mod_deflate -Werror compile fix

from's r1849590 instead of generating a diff locally.

* tools/

(DIST_RELEASE_URL): New constant.


Determine the latest release by checking dist/release/, not by checking

tags, in order to also show changes that have been merged into a patch

release that has not been announced yet.

This change will cause tonight's bot run to effectively revert r1850708 (and

add Monday's merge to the output as well), re-adding all the merges that

went into 1.11.1 to the Web site — which is correct, since 1.11.1 has not yet

been published.

Add 'x-wc-copy-mods' to the help tests, following r1850720.
Fix some RA session breakage in the WC editor (issue #4786).

* subversion/include/private/svn_client_private.h


(svn_client__repos_to_wc_copy_dir): Note broken foreign-repo copy.

(svn_client__repos_to_wc_copy_internal): Save and restore the session URL.

* tools/dev/unix-build/Makefile.svn: Fix a config error which made's "test authenticated only access via group"

trigger a segfault in httpd cause authz_owner_get_file_group in

mod_authz_groupfile.c somehow ended up being a NULL pointer...?!?

* subversion/include/private/svn_client_private.h

(svn_client__wc_copy_mods): Add a doc string.

Un-break the build. A follow-up to r1850720.

* subversion/svn/svn.c

(svn_cl__cmd_table): Remove an empty initializer list, as it's invalid C

and broke the build on Windows.

Implement an experimental 'x-wc-copy-mods' command.

This can be used to comprehensively test the WC editor (issue #4786).

* subversion/include/private/svn_client_private.h,


(svn_client__wc_copy_mods): New.

* subversion/svn/svn.c

(svn_cl__cmd_table): Add 'x-wc-copy-mods' command.

* subversion/svn/cl.h

(svn_opt_subcommand_t): Declare 'svn_cl__wc_copy_mods'.

* subversion/svn/shelf-cmd.c

(svn_cl__wc_copy_mods): New.

* upcoming.part.html: Automatically regenerated
Improvements to the 'WC editor' for issue #4786.

* subversion/include/private/svn_client_private.h

(svn_client__wc_editor): Specify the form of path arguments to the editor.

(svn_client__wc_replay): Same, and add a WC abspath argument.

* subversion/libsvn_client/commit.c

(svn_client__wc_replay): Add a WC abspath argument, and make all editor

paths relative to (the URL of) that path.

* subversion/libsvn_client/client.h,


(svn_client__condense_commit_items2): New.

* subversion/libsvn_client/wc_editor.c



file_close): Add support for making a text-delta against a non-empty


* subversion/libsvn_wc/revert.c

Update the top-of-file comment to mention removing/keeping

local files, for issue #4798.

* STATUS: Nominate r1850651.

* notes/knobs: Document SVNXX_USE_BOOST and SVNXX_POOL_DEBUG.