Checkout Tools
  • last updated 8 hours ago
Constraints: committers
Constraints: files
Constraints: dates

Changeset 1164684 is being indexed.

* STATUS: +0 for r1164426 group. I believe it improves correctness,

I don't know about performance, and in any case I didn't test it.

Fix bitness mismatch warning.

* subversion/libsvn_repos/replay.c

(path_drive_cb_baton, path_driver_cb_func): Use a size_t instead of int.

* STATUS: Vote for issue 3999.

Vote for the r1164517 group.

* STATUS: Nominate r1164645, fix for issue #3999 'svn merge with bad

option or target segfaults'.

This ship isn't sailing with 1.7, so bump the @since tags.

(Well, that's not technically correct, since svn_editor.h is in the 1.7

tarball. But, it's considered private for the purposes of that release,

and nothing actually uses it, so this is a better change from a documentation/

backward compat stance.)

* subversion/include/private/svn_editor.h:

s/@since New in 1.7./@since New in 1.8./

Fix issue #3999 'svn merge with bad option or target segfaults'.

* subversion/libsvn_client/cmdline.c

(check_root_url_of_target): Instead of segfaulting, do as the doc string

promises: "If a root url is not found for TARGET because it does not

exist in the repository, then return with no error".

* STATUS: Propose r1164426,r1164614.
Remove the need to filter in C by using the NODES_CURRENT view.

* subversion/libsvn_wc/wc-queries.sql


* subversion/libsvn_wc/wc_db.c

(struct read_children_walker_info_item_t): Remove.

(svn_wc__db_read_children_walker_info): Only handle one row per name.

Add some merge tips (a backport branch seems like overkill).
Propose the issue #4003 fixes for backport.
Fix issue #4003 ("'svn patch' seems unable to delete properties").

* subversion/libsvn_client/patch.c

(install_patched_prop_targets): If the result of the patching

operation is that a formerly-non-empty property is now empty, just

try to remove the property altogether.

* subversion/tests/cmdline/

(patch_deletes_prop): Remove @XFail decorator.

Propose the issue #4004 fixes for backport.
* subversion/libsvn_client/client.h

(svn_client__get_diff_editor): Improve the documentation of the 'text_deltas'

parameter and remove a to-do note that was done in r1162040.

Fix issue #4004 ("'svn patch --reverse-diff' chokes on patches which

add files with props").

* subversion/libsvn_client/patch.c

(apply_patches): Don't try to install property changes into a file

we've deleted.

* subversion/tests/cmdline/

(patch_reversed_add_with_props, patch_reversed_add_with_props2):

Remove @XFail decorator.

Add a pair of XFail-ing regression tests for issue #4004.

* subversion/tests/cmdline/


patch_reversed_add_with_props2): New test functions, XFail.

(test_list): Add references to new tests.

Add an XFail-ing regression test for issue #4003 ("'svn patch' seems

unable to delete properties").

* subversion/tests/cmdline/

(patch_deletes_prop): New two-part test (currently marked as XFail).

(test_list): Add reference to patch_deletes_prop().

* STATUS: Nominate r1164386 for 1.7.x
Make recursive operations that use svn_wc__internal_walk_children, such

as info and propset, faster by using C code instead of SQL's GROUP/ORDER.

This may also be a correctness fix, the original SQL may not always

return data from a single row and may not return the highest op_depth,

see the discussion at:

* subversion/libsvn_wc/wc-queries.sql


* subversion/libsvn_wc/wc_db.c

(struct read_children_info_item_t): Add comment.

(struct read_children_walker_info_item_t): New.

(svn_wc__db_read_children_walker_info): Handle rows in any order.

Found by: <>

Avoid a database operation for the very common case where 'svn info' isn't

called on an actual only (tree conflicted) node by reordering a few operations.

* subversion/libsvn_wc/info.c

(svn_wc__get_info): Only check if a node is an actual-only node after we've

determined that it isn't a normal node.

* subversion/tests/cmdline/svntest/

(TestFactory.__init__): Properly reparent passed-in PREV_DISK.

Rename 'repos_diff_summarize.c' to 'diff_summarize.c', as it is no longer

specific to repository diffs.

* subversion/libsvn_client/diff_summarize.c

New name for ...

* subversion/libsvn_client/repos_diff_summarize.c

... this.

* subversion/include/svn_delta.h

(svn_delta_editor_t): Tweak doc strings to clarify that paths are relative

to the root of the edit.

* STATUS: Vote/approve r1161683/r1161721.
* STATUS: Vote for r1163792.

Don't break file external status during WC post-commit bumping.

* subversion/libsvn_wc/wc-queries.sql

(STMT_APPLY_CHANGES_TO_BASE_NODE): Preserve file external state.

* subversion/tests/cmdline/ (commit_file_external): Pass.

* STATUS: Nominate r1163953 for 1.7.x
* subversion/libsvn_client/repos_diff.c


absent_file): Remove two fixups for bugs in serf. These fixups were added

in 1163704, to resolve a regression.

Make ra_serf report absent files and directories with the complete editor

path instead of just the basename to unbreak some usage patterns that expect

ra_serf to follow the delta editor documentation.

* subversion/libsvn_ra_serf/update.c

(start_report): Construct the full editor path for absent callbacks, to

support editor usages that rely on this. (Our standard update editor


* subversion/libsvn_repos/reporter.c (drive): Comment weirdness.