Checkout Tools
  • last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed: SOAPService does not work

(OFBIZ-11259)

This was broken by r1839451 committed at the bottom of OFBIZ-10438

A simple fix is to allow "webtools/control/SOAPService/serviceName?WSDL" scheme.

  1. … 1 more file in changeset.
"Applied fix from trunk for revision: 1869001"

------------------------------------------------------------------------

r1869001 | mthl | 2019-10-26 16:42:02 +0200 (sam. 26 oct. 2019) | 9 lignes

Fixed: Handle whitelist of serializable classes from properties

(OFBIZ-11261)

There was a bug regarding the way the ‘ListOfSafeObjectsForInputStream’ value

defined in the “SafeObjectInputStream.properties” file was handled. Mistakenly

only one class identifier was allowed.

The tests have not been backported from ‘trunk’ because of the way

‘UtilProperties#setPropertyValueInMemory’ work in 17.12.

------------------------------------------------------------------------

Fixed: Handle whitelist of serializable classes from properties

(OFBIZ-11261)

There was a bug regarding the way the ‘ListOfSafeObjectsForInputStream’ value

defined in the “SafeObjectInputStream.properties” file was handled. Mistakenly

only one class identifier was allowed.

The tests have not been backported from ‘trunk’ because of the way

‘UtilProperties#setPropertyValueInMemory’ work in 18.12.

Fixed: Update release revision number into embedded documentation
    • ?
    ./release18.12/docs/asciidoc/user-manual.adoc
    • ?
    ./release18.12/docs/asciidoc/developer-manual.adoc
Applied fix from trunk for revision: 1868911

===

Improved: Activate / Finish EmplPositionType ValidResponsibilities

(OFBIZ-11045)

Most of code / form / screen already exist to manage EmpPositionType, except

1. menu item

2. screen menu fields

Fixed wrong entity name in the entityCondition prepared in ListValidResponsibilities form

Thanks Olivier Heintz for reporting and providing the patch

Applied fix from trunk for revision: 1868738

===

Improved: User should be notified with success message on creating shopping list in ecommerce component

(OFBIZ-9522)

On performing any action, user should be notified with the success message if the action has been performed successfully.

Thanks Chandrashekhar Dhakad for the patch

Fixed: Use ‘ConcurrentHashMap’ to avoid ‘ConcurrentModificationException’

(OFBIZ-11258)

When trying to load components in their dependency order the

‘toBeLoadedComponents’ map is modified while being iterated over which

is not safe for non-concurrent maps.

Fixed: Make ‘javadoc’ build work with recent Java

(OFBIZ-11257)

With a recent OpenJDK release we had the following error

```

> Task :javadoc

javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.

javadoc: error - The code being documented uses modules but the

packages defined in https://docs.oracle.com/javaee/7/api/ are in the

unnamed module.

[...]

2 errors

100 warnings

> Task :javadoc FAILED

```

With ‘javadoc --source 8’ this error disappears as described in

JDK-8212233 [1].

[1] https://bugs.openjdk.java.net/browse/JDK-8212233

Fixed: Adapt some javadoc to let the build succeed

"Applied fix from trunk for revision: 1868615"

------------------------------------------------------------------------

r1868615 | jleroux | 2019-10-19 10:12:07 +0200 (sam. 19 oct. 2019) | 6 lignes

Fixed: Fix multi modal opening

(OFBIZ-11211)

Simplifies a little bit the current code.

Thanks: Leila for patch and Carl for confirmation

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868611"

------------------------------------------------------------------------

r1868611 | jleroux | 2019-10-19 08:42:07 +0200 (sam. 19 oct. 2019) | 11 lignes

Improved: Handling tenant in XmlRpcEventHandler

(OFBIZ-10284)

The XMLRPC service does not support tenants. Even if the tenant domain is

included in the HTTP request the call does not affect the correct tenant.

The issue and fix has been discussed in in the thread

https://markmail.org/message/bz4dofrxqp6i7ove

jleroux: I was able to port the R16 patch provided by Rajesh to the trunk.

Thanks: Rajesh Kumar Mallah

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868611"

------------------------------------------------------------------------

r1868611 | jleroux | 2019-10-19 08:42:07 +0200 (sam. 19 oct. 2019) | 11 lignes

Improved: Handling tenant in XmlRpcEventHandler

(OFBIZ-10284)

The XMLRPC service does not support tenants. Even if the tenant domain is

included in the HTTP request the call does not affect the correct tenant.

The issue and fix has been discussed in in the thread

https://markmail.org/message/bz4dofrxqp6i7ove

jleroux: I was able to port the R16 patch provided by Rajesh to the trunk.

Thanks: Rajesh Kumar Mallah

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868553"

------------------------------------------------------------------------

r1868553 | jleroux | 2019-10-17 16:26:42 +0200 (jeu. 17 oct. 2019) | 14 lignes

Fixed: FTL error for purchase order with Bulk Item Type

(OFBIZ-11252)

Steps to regenerate:

1. Login into the ordermgr application and click on Order Entry tab

2. Create PO with any supplier

3. Fill details and click on Continue

4. Now select Product Category with Item type Bulk and add the description and

Click on add to order

5. Finalize order with Finalize Order button

6. Add Term type, ship group option, etc details and create Order.

7. Scroll down to Order Items section and See the FTL error on the screen.

Thanks: Devanshu Vyas

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868553"

------------------------------------------------------------------------

r1868553 | jleroux | 2019-10-17 16:26:42 +0200 (jeu. 17 oct. 2019) | 14 lignes

Fixed: FTL error for purchase order with Bulk Item Type

(OFBIZ-11252)

Steps to regenerate:

1. Login into the ordermgr application and click on Order Entry tab

2. Create PO with any supplier

3. Fill details and click on Continue

4. Now select Product Category with Item type Bulk and add the description and

Click on add to order

5. Finalize order with Finalize Order button

6. Add Term type, ship group option, etc details and create Order.

7. Scroll down to Order Items section and See the FTL error on the screen.

Thanks: Devanshu Vyas

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868545"

------------------------------------------------------------------------

r1868545 | jleroux | 2019-10-17 14:19:33 +0200 (jeu. 17 oct. 2019) | 16 lignes

Fixed: EditExample always update status, because current Status not shown

(OFBIZ-11230)

In the EditExample Form, the drop-down is populates with the Valid change status

only. So current status is not in the list and the status print in the drop-down

is the next authorized. I want to modify exampleName or exampleType, I go to

editExample and change what I want and validate. The problem is status is also

changed!

There are 12 other same or similar cases. For the first of them (in FinAccount)

there is the same bug: when I change FinAccount Name, status change too. If I

add current="first-in-list" in the tag drop-down it works

jleroux: Quote is a peculiar case due to OFBIZ-7337 which was a wrong fix

Thanks: Oliver for the analysis and the fix

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868545"

------------------------------------------------------------------------

r1868545 | jleroux | 2019-10-17 14:19:33 +0200 (jeu. 17 oct. 2019) | 16 lignes

Fixed: EditExample always update status, because current Status not shown

(OFBIZ-11230)

In the EditExample Form, the drop-down is populates with the Valid change status

only. So current status is not in the list and the status print in the drop-down

is the next authorized. I want to modify exampleName or exampleType, I go to

editExample and change what I want and validate. The problem is status is also

changed!

There are 12 other same or similar cases. For the first of them (in FinAccount)

there is the same bug: when I change FinAccount Name, status change too. If I

add current="first-in-list" in the tag drop-down it works

jleroux: Quote is a peculiar case due to OFBIZ-7337 which was a wrong fix

Thanks: Oliver for the analysis and the fix

------------------------------------------------------------------------

Improved: no functional change

Just better English in message

  1. … 2 more files in changeset.
"Applied fix from trunk for revision: 1868395"

------------------------------------------------------------------------

r1868395 | jleroux | 2019-10-13 12:37:08 +0200 (dim. 13 oct. 2019) | 8 lignes

Fixed: Merge UrlRegexpTransform and OfbizUrlTransform classes

(OFBIZ-11229)

OFBIZ-4361 depends on this issue. Here is a first version, the main identified

point was when the request isn't present (email send, service call) the website

isn't pull from context. This solves this aspect

Thanks: Nicolas for the patch

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868395"

------------------------------------------------------------------------

r1868395 | jleroux | 2019-10-13 12:37:08 +0200 (dim. 13 oct. 2019) | 8 lignes

Fixed: Merge UrlRegexpTransform and OfbizUrlTransform classes

(OFBIZ-11229)

OFBIZ-4361 depends on this issue. Here is a first version, the main identified

point was when the request isn't present (email send, service call) the website

isn't pull from context. This solves this aspect

Thanks: Nicolas for the patch

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868298"

------------------------------------------------------------------------

r1868298 | jleroux | 2019-10-11 18:45:16 +0200 (ven. 11 oct. 2019) | 20 lignes

Fixed: NotSerializableException after uploading images to an order

(OFBIZ-11123)

I found that using in r1866259 the same fix than Si Chen used in OFBIZ-750 was

wrong. The code just above this fix is

{code:java}

if (obj instanceof Serializable) {

reqAttrMap.put(name, obj);

}

{code}

The problem with this code is that if does not handle inner Maps which may

contain a non Serializable Object. So the solution is rather to get one level

deeper and apply the same. We can then remove the harcoded lines with

"uploadedFile" and "_REQUEST_HANDLER_" below. Then all possible cases are handled

as long as we have not inner-inner-Maps

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868298"

------------------------------------------------------------------------

r1868298 | jleroux | 2019-10-11 18:45:16 +0200 (ven. 11 oct. 2019) | 20 lignes

Fixed: NotSerializableException after uploading images to an order

(OFBIZ-11123)

I found that using in r1866259 the same fix than Si Chen used in OFBIZ-750 was

wrong. The code just above this fix is

{code:java}

if (obj instanceof Serializable) {

reqAttrMap.put(name, obj);

}

{code}

The problem with this code is that if does not handle inner Maps which may

contain a non Serializable Object. So the solution is rather to get one level

deeper and apply the same. We can then remove the harcoded lines with

"uploadedFile" and "_REQUEST_HANDLER_" below. Then all possible cases are handled

as long as we have not inner-inner-Maps

------------------------------------------------------------------------

Improved: no functional change

As reported by Ethan Vos on user ML, sometimes the alias between wget and

Invoke-WebRequest is not present on Windows 7, better keep it simple!

Also removes the comment:

Anyway I believe this should be only used in dev environment

which is no longer true

  1. … 1 more file in changeset.
"Applied fix from trunk for revision: 1867998"

------------------------------------------------------------------------

r1867998 | jleroux | 2019-10-05 10:05:54 +0200 (sam. 05 oct. 2019) | 8 lignes

Improved: no functional change

As reported by Ethan Vos on user ML, sometimes the alias between wget and

Invoke-WebRequest is not present on Windows 7, better keep it simple!

Also removes the comment:

Anyway I believe this should be only used in dev environment

which is no longer true

------------------------------------------------------------------------

Applied fix from trunk for revision: 1867972

===

Reverted: User is unable to update the review of product

(OFBIZ-10799)

Reverted rev 1867904

Thanks: Deepak Dixit for reporting the issue.

Applied fix from trunk for revision: 1867972

===

Reverted: User is unable to update the review of product

(OFBIZ-10799)

Reverted rev 1867904

Thanks: Deepak Dixit for reporting the issue.

Improved: Use website to generate links on email content

(OFBIZ-4361)

OFBiz contains a nice process to generate link through WebSite entity.

Unfortunately when you send an email, the standard service didn't propage the website

to the body content email, so we can't use it.

This improvement is needed on forgot password process to resolve the correct uri

and go back on good OFBiz component: where the user requested for a new password.

Applied fix from trunk for revision: 1867937

===

'At least one phone number is required below' message should be uneditable while creating new customer using partymgr

(OFBIZ-11113)

Thanks: Arpit Mor for report and Saurabh Dixit for the patch.

Applied fix from trunk for revision: 1867937

===

'At least one phone number is required below' message should be uneditable while creating new customer using partymgr

(OFBIZ-11113)

Thanks: Arpit Mor for report and Saurabh Dixit for the patch.

Applied fix from trunk for revision: 1867930

===

Fixed: Check run payment(A/P) transactions not getting available for reconciliation

(OFBIZ-10796)

Check run payment group transactions don't get available for Financial Account reconciliation. Though the financial account balance gets updated during the A/P check run process, the system must allow the user with an additional step of reconciling the transactions.

The cause of this is that the financial account transaction doesn't get created in the 'Created' status and has an 'Approved' status. An approved status financial transaction directly updates the financial account balance and thus don't appear in the list of the transactions to be reconciled.

Thanks: Chinmay Patidar for your contribution and Pierre Smits for the review.

Applied fix from trunk for revision: 1867930

===

Fixed: Check run payment(A/P) transactions not getting available for reconciliation

(OFBIZ-10796)

Check run payment group transactions don't get available for Financial Account reconciliation. Though the financial account balance gets updated during the A/P check run process, the system must allow the user with an additional step of reconciling the transactions.

The cause of this is that the financial account transaction doesn't get created in the 'Created' status and has an 'Approved' status. An approved status financial transaction directly updates the financial account balance and thus don't appear in the list of the transactions to be reconciled.

Thanks: Chinmay Patidar for your contribution and Pierre Smits for the review.