ofbiz

Checkout Tools
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Changeset 1868548 is being indexed.

"Applied fix from trunk for revision: 1868545"

------------------------------------------------------------------------

r1868545 | jleroux | 2019-10-17 14:19:33 +0200 (jeu. 17 oct. 2019) | 16 lignes

Fixed: EditExample always update status, because current Status not shown

(OFBIZ-11230)

In the EditExample Form, the drop-down is populates with the Valid change status

only. So current status is not in the list and the status print in the drop-down

is the next authorized. I want to modify exampleName or exampleType, I go to

editExample and change what I want and validate. The problem is status is also

changed!

There are 12 other same or similar cases. For the first of them (in FinAccount)

there is the same bug: when I change FinAccount Name, status change too. If I

add current="first-in-list" in the tag drop-down it works

jleroux: Quote is a peculiar case due to OFBIZ-7337 which was a wrong fix

Thanks: Oliver for the analysis and the fix

------------------------------------------------------------------------

"Applied fix from plugins for revision: 1868545"

------------------------------------------------------------------------

r1868545 | jleroux | 2019-10-17 14:19:33 +0200 (jeu. 17 oct. 2019) | 16 lignes

Fixed: EditExample always update status, because current Status not shown

(OFBIZ-11230)

In the EditExample Form, the drop-down is populates with the Valid change status

only. So current status is not in the list and the status print in the drop-down

is the next authorized. I want to modify exampleName or exampleType, I go to

editExample and change what I want and validate. The problem is status is also

changed!

There are 12 other same or similar cases. For the first of them (in FinAccount)

there is the same bug: when I change FinAccount Name, status change too. If I

add current="first-in-list" in the tag drop-down it works

jleroux: Quote is a peculiar case due to OFBIZ-7337 which was a wrong fix

Thanks: Oliver for the analysis and the fix

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868545"

------------------------------------------------------------------------

r1868545 | jleroux | 2019-10-17 14:19:33 +0200 (jeu. 17 oct. 2019) | 16 lignes

Fixed: EditExample always update status, because current Status not shown

(OFBIZ-11230)

In the EditExample Form, the drop-down is populates with the Valid change status

only. So current status is not in the list and the status print in the drop-down

is the next authorized. I want to modify exampleName or exampleType, I go to

editExample and change what I want and validate. The problem is status is also

changed!

There are 12 other same or similar cases. For the first of them (in FinAccount)

there is the same bug: when I change FinAccount Name, status change too. If I

add current="first-in-list" in the tag drop-down it works

jleroux: Quote is a peculiar case due to OFBIZ-7337 which was a wrong fix

Thanks: Oliver for the analysis and the fix

------------------------------------------------------------------------

Fixed: EditExample always update status, because current Status not shown

(OFBIZ-11230)

In the EditExample Form, the drop-down is populates with the Valid change status

only. So current status is not in the list and the status print in the drop-down

is the next authorized. I want to modify exampleName or exampleType, I go to

editExample and change what I want and validate. The problem is status is also

changed!

There are 12 other same or similar cases. For the first of them (in FinAccount)

there is the same bug: when I change FinAccount Name, status change too. If I

add current="first-in-list" in the tag drop-down it works

jleroux: Quote is a peculiar case due to OFBIZ-7337 which was a wrong fix

Thanks: Oliver for the analysis and the fix

Improved: Upgrade Tomcat from 9.0.26 to 9.0.27

(OFBIZ-11249)

Forgot a plugin, as ever :/

Improved: Convert AutoAcctgAgreementTests Unit Test from XML to Groovy

(OFBIZ-11248)

Thanks: Devanshu Vyas for your contribution.

Improved: Upgrade Tomcat from 9.0.26 to 9.0.27

(OFBIZ-11249)

Update to Commons Daemon 1.2.2 to pick up the fix for a regression in Commons

Daemon 1.2.0 and 1.2.1 that triggered a crash on startup when running on a

Windows OS that had not been fully updated.

That's where you see how the Tomcat team takes care of their users :)

Implemented: Providing utilities for integration tests

(OFBIZ-11247)

First step to simply using "userLogin" in tests

Thanks: Mathieu for the idea on dev ML

Improved: Unit test case for service - createAcctgTransEntry

(OFBIZ-9004)

Thanks: Deepak Nigam for initial patch and Suraj for Groovy conversion

Improved: no functional change

Just better English in message

"Applied fix from trunk for revision: 1868395"

------------------------------------------------------------------------

r1868395 | jleroux | 2019-10-13 12:37:08 +0200 (dim. 13 oct. 2019) | 8 lignes

Fixed: Merge UrlRegexpTransform and OfbizUrlTransform classes

(OFBIZ-11229)

OFBIZ-4361 depends on this issue. Here is a first version, the main identified

point was when the request isn't present (email send, service call) the website

isn't pull from context. This solves this aspect

Thanks: Nicolas for the patch

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868395"

------------------------------------------------------------------------

r1868395 | jleroux | 2019-10-13 12:37:08 +0200 (dim. 13 oct. 2019) | 8 lignes

Fixed: Merge UrlRegexpTransform and OfbizUrlTransform classes

(OFBIZ-11229)

OFBIZ-4361 depends on this issue. Here is a first version, the main identified

point was when the request isn't present (email send, service call) the website

isn't pull from context. This solves this aspect

Thanks: Nicolas for the patch

------------------------------------------------------------------------

Fixed: Merge UrlRegexpTransform and OfbizUrlTransform classes

(OFBIZ-11229)

OFBIZ-4361 depends on this issue. Here is a first version, the main identified

point was when the request isn't present (email send, service call) the website

isn't pull from context. This solves this aspect

Thanks: Nicolas for the patch

Improved: Unit test case for service - ProcessRepairReplacementReturn

(OFBIZ-8869)

OrderTests.groovy has been splitted in other files, this test fits in

OrderReturnTests.groovy

Thanks: Avnindra Sharma for initial test and Suraj for Groovy conversion

Improved: Unit test case for service - ProcessRefundReturnForReplacement

(OFBIZ-8868)

OrderTests.groovy has been splitter in other files, this test fits in

OrderReturnTests.groovy

Thanks: Avnindra Sharma for initial test and Suraj for Groovy conversion

Improved: Unit test case for service - sendOrderConfirmation

(OFBIZ-8507)

Move to Groovy before deciding on moving OrderNotificationTests.groovy

from order to ecommerce or moving EmailOrderScreens from ecommerce to order

"Applied fix from trunk framework for revision: 1868298"

------------------------------------------------------------------------

r1868298 | jleroux | 2019-10-11 18:45:16 +0200 (ven. 11 oct. 2019) | 20 lignes

Fixed: NotSerializableException after uploading images to an order

(OFBIZ-11123)

I found that using in r1866259 the same fix than Si Chen used in OFBIZ-750 was

wrong. The code just above this fix is

{code:java}

if (obj instanceof Serializable) {

reqAttrMap.put(name, obj);

}

{code}

The problem with this code is that if does not handle inner Maps which may

contain a non Serializable Object. So the solution is rather to get one level

deeper and apply the same. We can then remove the harcoded lines with

"uploadedFile" and "_REQUEST_HANDLER_" below. Then all possible cases are handled

as long as we have not inner-inner-Maps

------------------------------------------------------------------------

?\026

"Applied fix from trunk for revision: 1868298"

------------------------------------------------------------------------

r1868298 | jleroux | 2019-10-11 18:45:16 +0200 (ven. 11 oct. 2019) | 20 lignes

Fixed: NotSerializableException after uploading images to an order

(OFBIZ-11123)

I found that using in r1866259 the same fix than Si Chen used in OFBIZ-750 was

wrong. The code just above this fix is

{code:java}

if (obj instanceof Serializable) {

reqAttrMap.put(name, obj);

}

{code}

The problem with this code is that if does not handle inner Maps which may

contain a non Serializable Object. So the solution is rather to get one level

deeper and apply the same. We can then remove the harcoded lines with

"uploadedFile" and "_REQUEST_HANDLER_" below. Then all possible cases are handled

as long as we have not inner-inner-Maps

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868298"

------------------------------------------------------------------------

r1868298 | jleroux | 2019-10-11 18:45:16 +0200 (ven. 11 oct. 2019) | 20 lignes

Fixed: NotSerializableException after uploading images to an order

(OFBIZ-11123)

I found that using in r1866259 the same fix than Si Chen used in OFBIZ-750 was

wrong. The code just above this fix is

{code:java}

if (obj instanceof Serializable) {

reqAttrMap.put(name, obj);

}

{code}

The problem with this code is that if does not handle inner Maps which may

contain a non Serializable Object. So the solution is rather to get one level

deeper and apply the same. We can then remove the harcoded lines with

"uploadedFile" and "_REQUEST_HANDLER_" below. Then all possible cases are handled

as long as we have not inner-inner-Maps

------------------------------------------------------------------------

Fixed: NotSerializableException after uploading images to an order

(OFBIZ-11123)

I found that using in r1866259 the same fix than Si Chen used in OFBIZ-750 was

wrong. The code just above this fix is

{code:java}

if (obj instanceof Serializable) {

reqAttrMap.put(name, obj);

}

{code}

The problem with this code is that if does not handle inner Maps which may

contain a non Serializable Object. So the solution is rather to get one level

deeper and apply the same. We can then remove the harcoded lines with

"uploadedFile" and "_REQUEST_HANDLER_" below. Then all possible cases are handled

as long as we have not inner-inner-Maps

Improved: Add a discussion feature in order detail view for following

communication about the order (mail, phone etc.)

(OFBIZ-11210)

Adds missing ASL2 header

Improved: Update build.gradle to the latest dependencies

(OFBIZ-11245)

Updates dependency-check-report.html
Update wiki demo help
Improved: Convert AutoAcctgAdminTests Unit Test from XML to Groovy

(OFBIZ-11243)

Thanks: Jacques Le Roux for the review and test.

Improved: Improve the job search view with a better limit and a default sort

(OFBIZ-11241)

Adds a 50 items limit by default instead of 20

Adds a default sort on -runtime to have a look on the lasts jobs executed

Thanks: Carl Demus

Improved: Refactor OrderTests.groovy and separate order and return test services

(OFBIZ-11239)

Forgot to commit OrderNotificationTests.groovy in last commit

Improved: Refactor OrderTests.groovy and separate order and return test services

(OFBIZ-11239)

Based on Suraj's patch

This also moves

testQuickReturnOrder to OrderReturnTests.groovy

the requirement tests in OrderRequirementTests.groovy

renames OrderTest.groovy to OrderNotificationTests.groovy since it contains

only that

renames test-case for OrderTests.xml "order-tests-xml"

Test pass

Thanks: Suraj for initial patch

Improved: Unit test case for service - createPaymentContent.

(OFBIZ-9093)

Thanks: Deepak Nigam for reporting and Yogesh Naroliya for providing the updated patch.

Improved: Unit test case for service - AutoAssignRequirementToSupplier.

(OFBIZ-8934)

Thanks: Avnindra Sharma for reporting, Anushi Gupta for providing the updated patch.