ofbiz

Checkout Tools
  • last updated 25 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Changeset 1868300 is being indexed.

"Applied fix from trunk for revision: 1868298"

------------------------------------------------------------------------

r1868298 | jleroux | 2019-10-11 18:45:16 +0200 (ven. 11 oct. 2019) | 20 lignes

Fixed: NotSerializableException after uploading images to an order

(OFBIZ-11123)

I found that using in r1866259 the same fix than Si Chen used in OFBIZ-750 was

wrong. The code just above this fix is

{code:java}

if (obj instanceof Serializable) {

reqAttrMap.put(name, obj);

}

{code}

The problem with this code is that if does not handle inner Maps which may

contain a non Serializable Object. So the solution is rather to get one level

deeper and apply the same. We can then remove the harcoded lines with

"uploadedFile" and "_REQUEST_HANDLER_" below. Then all possible cases are handled

as long as we have not inner-inner-Maps

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868298"

------------------------------------------------------------------------

r1868298 | jleroux | 2019-10-11 18:45:16 +0200 (ven. 11 oct. 2019) | 20 lignes

Fixed: NotSerializableException after uploading images to an order

(OFBIZ-11123)

I found that using in r1866259 the same fix than Si Chen used in OFBIZ-750 was

wrong. The code just above this fix is

{code:java}

if (obj instanceof Serializable) {

reqAttrMap.put(name, obj);

}

{code}

The problem with this code is that if does not handle inner Maps which may

contain a non Serializable Object. So the solution is rather to get one level

deeper and apply the same. We can then remove the harcoded lines with

"uploadedFile" and "_REQUEST_HANDLER_" below. Then all possible cases are handled

as long as we have not inner-inner-Maps

------------------------------------------------------------------------

Fixed: NotSerializableException after uploading images to an order

(OFBIZ-11123)

I found that using in r1866259 the same fix than Si Chen used in OFBIZ-750 was

wrong. The code just above this fix is

{code:java}

if (obj instanceof Serializable) {

reqAttrMap.put(name, obj);

}

{code}

The problem with this code is that if does not handle inner Maps which may

contain a non Serializable Object. So the solution is rather to get one level

deeper and apply the same. We can then remove the harcoded lines with

"uploadedFile" and "_REQUEST_HANDLER_" below. Then all possible cases are handled

as long as we have not inner-inner-Maps

Improved: Add a discussion feature in order detail view for following

communication about the order (mail, phone etc.)

(OFBIZ-11210)

Adds missing ASL2 header

Improved: Update build.gradle to the latest dependencies

(OFBIZ-11245)

Updates dependency-check-report.html
Update wiki demo help
Improved: Convert AutoAcctgAdminTests Unit Test from XML to Groovy

(OFBIZ-11243)

Thanks: Jacques Le Roux for the review and test.

Improved: Improve the job search view with a better limit and a default sort

(OFBIZ-11241)

Adds a 50 items limit by default instead of 20

Adds a default sort on -runtime to have a look on the lasts jobs executed

Thanks: Carl Demus

Improved: Refactor OrderTests.groovy and separate order and return test services

(OFBIZ-11239)

Forgot to commit OrderNotificationTests.groovy in last commit

Improved: Refactor OrderTests.groovy and separate order and return test services

(OFBIZ-11239)

Based on Suraj's patch

This also moves

testQuickReturnOrder to OrderReturnTests.groovy

the requirement tests in OrderRequirementTests.groovy

renames OrderTest.groovy to OrderNotificationTests.groovy since it contains

only that

renames test-case for OrderTests.xml "order-tests-xml"

Test pass

Thanks: Suraj for initial patch

Improved: Unit test case for service - createPaymentContent.

(OFBIZ-9093)

Thanks: Deepak Nigam for reporting and Yogesh Naroliya for providing the updated patch.

Improved: Unit test case for service - AutoAssignRequirementToSupplier.

(OFBIZ-8934)

Thanks: Avnindra Sharma for reporting, Anushi Gupta for providing the updated patch.

Improved: Unit test case for service - ProcessRefundReturn.

(OFBIZ-8867)

Thanks: Avnindra Sharma for reporting, Rushikesh Mawal for providing the updated patch.

Improved: Unit test case for service - GetReturnItemInitialCost.

(OFBIZ-8862)

Thanks: Avnindra Sharma for reporting, Anushi Gupta for providing the updated patch.

Improved: Unit test case for service - ProcessRefundImmediatelyReturn.

(OFBIZ-8865)

Thanks: Avnindra Sharma for reporting, Anushi Gupta for providing the updated patch.

Improved: Unit test case for service - ProcessCrossShipReplacementReturn.

(OFBIZ-8864)

Thanks: Avnindra Sharma for reporting, Anushi Gupta for providing the updated patch.

Improved: Unit test case for service - ProcessCreditReturn.

(OFBIZ-8863)

Thanks: Avnindra Sharma for reporting, Rushikesh Mawal for providing the updated patch and Jacques for review.

Improved: Unit test case for service - CheckCreateOrderRequirement.

(OFBIZ-8935)

Thanks: Avnindra Sharma for reporting and Anushi Gupta for providing the updated patch.

Improved: UI of the order status section in status column of order items table on orderview screen.

(OFBIZ-11106)

Thanks: Chandrashekhar Dhakad for reporting the issue and providing the patch.

Improved: Refactor ‘ComponentConfig.ClasspathInfo’

(OFBIZ-11192)(OFBIZ-11238)

The validity checks have been moved at construction time instead of

relying on client code to ensure that the class path information are

sound.

A new ‘ComponentConfig.ClasspathInfo.Type’ enum has been defined to

improve type safety.

The location of the class path information is now using a

‘java.nio.file.Path’ class instance.

Improved: Specify that the component dependencies are never ‘null’

(OFBIZ-11238)

Improved: Use ‘Path’ for component config ‘rootLocation’ attribute

(OFBIZ-11192)

The method ‘ComponentConfig#getRootLocation’ has been removed

and replaced by ‘ComponentConfig#rootLocation’.

The callers have been adapted.

Improved: Rewrite ‘Classpath’ class

(OFBIZ-11237)

This class has been moved to ‘org.apache.ofbiz.base.container’ to be

able to reduce its visibility to the “package” level.

The API has been change to avoid unnecessary checks and simpler dataflow.

There was no need to provide thread safety so the ‘synchronized’

blocks have been removed.

Improved: no functional change

In r1868022 I added the POS_SALES_CHANNEL was suggested in OFBIZ-10965. Actually

that was wrong. Tt's already in PosTypeData.xml though with a wrong sequenceId

This fixes it

Improved: no functional change

Adds the POS_SALES_CHANNEL was suggested in OFBIZ-10965 and could be useful

Improved: no functional change

As reported by Ethan Vos on user ML, sometimes the alias between wget and

Invoke-WebRequest is not present on Windows 7, better keep it simple!

Also removes the comment:

Anyway I believe this should be only used in dev environment

which is no longer true

"Applied fix from trunk for revision: 1867998"

------------------------------------------------------------------------

r1867998 | jleroux | 2019-10-05 10:05:54 +0200 (sam. 05 oct. 2019) | 8 lignes

Improved: no functional change

As reported by Ethan Vos on user ML, sometimes the alias between wget and

Invoke-WebRequest is not present on Windows 7, better keep it simple!

Also removes the comment:

Anyway I believe this should be only used in dev environment

which is no longer true

------------------------------------------------------------------------

Improved: no functional change

As reported by Ethan Vos on user ML, sometimes the alias between wget and

Invoke-WebRequest is not present on Windows 7, better keep it simple!

Also removes the comment:

Anyway I believe this should be only used in dev environment

which is no longer true

Improved: Remove unnecessary semicolon