ofbiz

------------------------------------------------------------------------

r1868298 | jleroux | 2019-10-11 18:45:16 +0200 (ven. 11 oct. 2019) | 20 lignes

Fixed: NotSerializableException after uploading images to an order

(OFBIZ-11123)

I found that using in r1866259 the same fix than Si Chen used in OFBIZ-750 was

wrong. The code just above this fix is

{code:java}

if (obj instanceof Serializable) {

reqAttrMap.put(name, obj);

}

{code}

The problem with this code is that if does not handle inner Maps which may

contain a non Serializable Object. So the solution is rather to get one level

deeper and apply the same. We can then remove the harcoded lines with

"uploadedFile" and "_REQUEST_HANDLER_" below. Then all possible cases are handled

as long as we have not inner-inner-Maps

------------------------------------------------------------------------

(OFBIZ-11123)

I found that using in r1866259 the same fix than Si Chen used in OFBIZ-750 was

wrong. The code just above this fix is

{code:java}

if (obj instanceof Serializable) {

reqAttrMap.put(name, obj);

}

{code}

The problem with this code is that if does not handle inner Maps which may

contain a non Serializable Object. So the solution is rather to get one level

deeper and apply the same. We can then remove the harcoded lines with

"uploadedFile" and "_REQUEST_HANDLER_" below. Then all possible cases are handled

as long as we have not inner-inner-Maps

(OFBIZ-11245)

(OFBIZ-11239)

Forgot to commit OrderNotificationTests.groovy in last commit

(OFBIZ-11239)

Based on Suraj's patch

This also moves

testQuickReturnOrder to OrderReturnTests.groovy

the requirement tests in OrderRequirementTests.groovy

renames OrderTest.groovy to OrderNotificationTests.groovy since it contains

only that

renames test-case for OrderTests.xml "order-tests-xml"

Test pass

Thanks: Suraj for initial patch

(OFBIZ-8934)

Thanks: Avnindra Sharma for reporting, Anushi Gupta for providing the updated patch.

(OFBIZ-8867)

Thanks: Avnindra Sharma for reporting, Rushikesh Mawal for providing the updated patch.

(OFBIZ-8862)

Thanks: Avnindra Sharma for reporting, Anushi Gupta for providing the updated patch.

(OFBIZ-8865)

Thanks: Avnindra Sharma for reporting, Anushi Gupta for providing the updated patch.

(OFBIZ-8864)

Thanks: Avnindra Sharma for reporting, Anushi Gupta for providing the updated patch.

(OFBIZ-8863)

Thanks: Avnindra Sharma for reporting, Rushikesh Mawal for providing the updated patch and Jacques for review.

(OFBIZ-8935)

Thanks: Avnindra Sharma for reporting and Anushi Gupta for providing the updated patch.

(OFBIZ-11106)

Thanks: Chandrashekhar Dhakad for reporting the issue and providing the patch.

(OFBIZ-11238)

(OFBIZ-11192)

The method ‘ComponentConfig#getRootLocation’ has been removed

and replaced by ‘ComponentConfig#rootLocation’.

The callers have been adapted.

(OFBIZ-11237)

This class has been moved to ‘org.apache.ofbiz.base.container’ to be

able to reduce its visibility to the “package” level.

The API has been change to avoid unnecessary checks and simpler dataflow.

There was no need to provide thread safety so the ‘synchronized’

blocks have been removed.

Adds the POS_SALES_CHANNEL was suggested in OFBIZ-10965 and could be useful

As reported by Ethan Vos on user ML, sometimes the alias between wget and

Invoke-WebRequest is not present on Windows 7, better keep it simple!

Also removes the comment:

Anyway I believe this should be only used in dev environment

which is no longer true

------------------------------------------------------------------------

r1867998 | jleroux | 2019-10-05 10:05:54 +0200 (sam. 05 oct. 2019) | 8 lignes

Improved: no functional change

As reported by Ethan Vos on user ML, sometimes the alias between wget and

Invoke-WebRequest is not present on Windows 7, better keep it simple!

Also removes the comment:

Anyway I believe this should be only used in dev environment

which is no longer true

------------------------------------------------------------------------

As reported by Ethan Vos on user ML, sometimes the alias between wget and

Invoke-WebRequest is not present on Windows 7, better keep it simple!

Also removes the comment:

Anyway I believe this should be only used in dev environment

which is no longer true