ofbiz

Checkout Tools
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Changeset 1867940 is being indexed.

Applied fix from trunk for revision: 1867937

===

'At least one phone number is required below' message should be uneditable while creating new customer using partymgr

(OFBIZ-11113)

Thanks: Arpit Mor for report and Saurabh Dixit for the patch.

Applied fix from trunk for revision: 1867937

===

'At least one phone number is required below' message should be uneditable while creating new customer using partymgr

(OFBIZ-11113)

Thanks: Arpit Mor for report and Saurabh Dixit for the patch.

Applied fix from trunk for revision: 1867937

===

'At least one phone number is required below' message should be uneditable while creating new customer using partymgr

(OFBIZ-11113)

Thanks: Arpit Mor for report and Saurabh Dixit for the patch.

'At least one phone number is required below' message should be uneditable while creating new customer using partymgr

(OFBIZ-11113)

Thanks: Arpit Mor for report and Saurabh Dixit for the patch.

Improved: Unit test case for service - sendOrderCompleteNotification

(OFBIZ-8812)

As Suraj somehow mentioned at https://markmail.org/message/zlf5chufefekb5r2,

we can use the same ticket while converting the test to Groovy

Tests pass

Thanks: Avnindra Sharma for the initial patch (here converted to Groovy)

Applied fix from trunk for revision: 1867930

===

Fixed: Check run payment(A/P) transactions not getting available for reconciliation

(OFBIZ-10796)

Check run payment group transactions don't get available for Financial Account reconciliation. Though the financial account balance gets updated during the A/P check run process, the system must allow the user with an additional step of reconciling the transactions.

The cause of this is that the financial account transaction doesn't get created in the 'Created' status and has an 'Approved' status. An approved status financial transaction directly updates the financial account balance and thus don't appear in the list of the transactions to be reconciled.

Thanks: Chinmay Patidar for your contribution and Pierre Smits for the review.

Applied fix from trunk for revision: 1867930

===

Fixed: Check run payment(A/P) transactions not getting available for reconciliation

(OFBIZ-10796)

Check run payment group transactions don't get available for Financial Account reconciliation. Though the financial account balance gets updated during the A/P check run process, the system must allow the user with an additional step of reconciling the transactions.

The cause of this is that the financial account transaction doesn't get created in the 'Created' status and has an 'Approved' status. An approved status financial transaction directly updates the financial account balance and thus don't appear in the list of the transactions to be reconciled.

Thanks: Chinmay Patidar for your contribution and Pierre Smits for the review.

Applied fix from trunk for revision: 1867930

===

Fixed: Check run payment(A/P) transactions not getting available for reconciliation

(OFBIZ-10796)

Check run payment group transactions don't get available for Financial Account reconciliation. Though the financial account balance gets updated during the A/P check run process, the system must allow the user with an additional step of reconciling the transactions.

The cause of this is that the financial account transaction doesn't get created in the 'Created' status and has an 'Approved' status. An approved status financial transaction directly updates the financial account balance and thus don't appear in the list of the transactions to be reconciled.

Thanks: Chinmay Patidar for your contribution and Pierre Smits for the review.

Fixed: Check run payment(A/P) transactions not getting available for reconciliation

(OFBIZ-10796)

Check run payment group transactions don't get available for Financial Account reconciliation. Though the financial account balance gets updated during the A/P check run process, the system must allow the user with an additional step of reconciling the transactions.

The cause of this is that the financial account transaction doesn't get created in the 'Created' status and has an 'Approved' status. An approved status financial transaction directly updates the financial account balance and thus don't appear in the list of the transactions to be reconciled.

Thanks: Chinmay Patidar for your contribution and Pierre Smits for the review.

Improved: Unit test case for service - sendOrderPayRetryNotification

(OFBIZ-8813)

As Suraj somehow mentioned at https://markmail.org/message/zlf5chufefekb5r2,

we can use the same ticket while converting the test to Groov

Tests pass

Thanks: Avnindra Sharma for the initial patch (here converted to Groovy)

Improved: Unit test case for service - SendOrderBackorderNotification

(OFBIZ-8810)

As Suraj somehow mentioned at https://markmail.org/message/zlf5chufefekb5r2,

we can use the same ticket while converting the test to Groov

Tests pass

Thanks: Avnindra Sharma for the initial patch (here converted to Groovy)

Improved: Convert testSendOrderChangeNotification to Groovy

(OFBIZ-11233)

Tests pass

Improved: Unit test case for service - testSendOrderChangeNotification

(OFBIZ-8811)

Removes duplicated order-tests-data-load

Tests pass

Improved: Unit test case for service - testSendOrderChangeNotification

(OFBIZ-8811)

Fixes to right place

There were no reasons to add an OrderTest.xml file,

testSendOrderChangeNotification fits in OrderTests.xml

It was even wrong because of duplicated order-test test-case

Tests pass

Applied fix from trunk for revision: 1867910

===

Fixed: Sales By Store Report not working

(OFBIZ-11119)

Added Null check to avoid Exception.

Thanks: Chandan Khandelwal for your contribution.

Applied fix from trunk for revision: 1867910

===

Fixed: Sales By Store Report not working

(OFBIZ-11119)

Added Null check to avoid Exception.

Thanks: Chandan Khandelwal for your contribution.

Applied fix from trunk for revision: 1867910

===

Fixed: Sales By Store Report not working

(OFBIZ-11119)

Added Null check to avoid Exception.

Thanks: Chandan Khandelwal for your contribution.

Fixed: Sales By Store Report not working

(OFBIZ-11119)

Added Null check to avoid Exception.

Thanks: Chandan Khandelwal for your contribution.

Applied fix from trunk for revision: 1867904

===

Fixed: User is unable to update the review of product

(OFBIZ-10799)

Redirected request with eligible parameters so that If the user had a search using any parameter result should persist after the update.

Thanks: Ashish Sharma for report and Pierre Smits and Jacques Le Roux for the review.

Applied fix from trunk for revision: 1867904

===

Fixed: User is unable to update the review of product

(OFBIZ-10799)

Redirected request with eligible parameters so that If the user had a search using any parameter result should persist after the update.

Thanks: Ashish Sharma for report and Pierre Smits and Jacques Le Roux for the review.

Applied fix from trunk for revision: 1867904

===

Fixed: User is unable to update the review of product

(OFBIZ-10799)

Redirected request with eligible parameters so that If the user had a search using any parameter result should persist after the update.

Thanks: Ashish Sharma for report and Pierre Smits and Jacques Le Roux for the review.

Fixed: User is unable to update the review of product

(OFBIZ-10799)

Redirected request with eligible parameters so that If the user had a search using any parameter result should persist after the update.

Thanks: Ashish Sharma for report and Pierre Smits and Jacques Le Roux for the review.

Improved: Unit test case for service - SendOrderBackorderNotification

(OFBIZ-8810)(OFBIZ-9647)(OFBIZ-9671)

While working on this I stumbled upon an issue related with

webSiteId="OrderEntry" well related by Ratnesh Upadhyay in OFBIZ-9647.

Unlike him I decided not to remove the webSiteId="OrderEntry" entries but to

replace them by webSiteId="WebStore"

Tests pass!

Applied fix from trunk for revision: 1867879

===

Improved: Added backward compatibility for inputParamEnumId in promotion management.

(OFBIZ-11105)

Thanks: Lalit Dashora for reporting and providing the patch, Jacques Le Roux for review.

Improved: Added backward compatibility for inputParamEnumId in promotion management.

(OFBIZ-11105)

Thanks: Lalit Dashora for reporting and providing the patch, Jacques Le Roux for review.

Improved: no functional change

Formats Javadoc

Improved: Unit test case for service - AssociatedRequirementWithRequestItem.

(OFBIZ-8933)

Thanks: Avnindra Sharma for reporting and Anushi Gupta for providing the updated patch.

Improved: Unit test case for service - CheckCreateStockRequirementAtp.

(OFBIZ-8938)

Thanks: Avnindra Sharma for reporting and Anushi Gupta for providing the updated patch.

"Applied fix from plugins for revision: 1867849"

------------------------------------------------------------------------

r1867849 | jleroux | 2019-10-01 19:32:02 +0200 (mar. 01 oct. 2019) | 18 lignes

Fixed: Issue with "User name filed" while creating the new user

(OFBIZ-11226)

Steps to regenerate:

Open URL https://demo-trunk.ofbiz.apache.org

2. Click on the "Register" button for creating a new customer

3. Enter all the mandatory details for the registring a new customer

4. Enter the user name with a dot (.), for example: "demo.user"

5. Click on the "Save" button

Actual: Error message "Username can only have letters, digits and the _-

characters" is displaying on the screen.

Expected: Dot (.) should be also allowed in validation rules when we enter user

name manually with a dot (.)

Thanks: Vedansh Tiwari for report

------------------------------------------------------------------------

"Applied fix from plugins for revision: 1867849"

------------------------------------------------------------------------

r1867849 | jleroux | 2019-10-01 19:32:02 +0200 (mar. 01 oct. 2019) | 18 lignes

Fixed: Issue with "User name filed" while creating the new user

(OFBIZ-11226)

Steps to regenerate:

Open URL https://demo-trunk.ofbiz.apache.org

2. Click on the "Register" button for creating a new customer

3. Enter all the mandatory details for the registring a new customer

4. Enter the user name with a dot (.), for example: "demo.user"

5. Click on the "Save" button

Actual: Error message "Username can only have letters, digits and the _-

characters" is displaying on the screen.

Expected: Dot (.) should be also allowed in validation rules when we enter user

name manually with a dot (.)

Thanks: Vedansh Tiwari for report

------------------------------------------------------------------------