ofbiz

Checkout Tools
  • last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Changeset 1863019 is being indexed.

Improved: Remove support for “ofbiz-containers.xml”

(OFBIZ-11100)

To extend the containers loaded on startup, it was possible too both

edit the “ofbiz-containers.xml” file or alternatively to define a

container in a component.

This redundancy adds extra complexity in the startup process for no

good extensibility reason. The component container loader is more

flexible since it allows developper to add new containers without

touching the framework so it is better to only rely on this option.

The component loader is now hard-coded directly in code.

Removes the Gradle Wrapper files copies in tools\Buildbot\Gradle\Wrapper

The Gradle Wrapper files will stay in branches and trunk, so not point getting

them during builds. As we know all we be handled during RM.

No functional change, updates README.html on wiki
Reverted: Resolve build.gradle warnings

(OFBIZ-11133)

As discussed OFBIZ-11133, reverts r1862326.

Actually only puts back the wrapper files in gradle/wrapper directory

I used

gradlew wrapper --gradle-version=5.0 --distribution-type=bin

to regenerate the version.

Only gradle-wrapper.properties was correctly regenerated, gradle-wrapper.jar was

still the 5.5 version (weird but true).

So I copied gradle-wrapper.jar 5.0 version from

tools\Buildbot\Gradle\Wrapper\R18.12

There were no changes in gradlew scripts

Reverted: Remove the Gradle wrapper from our release packages and add a step to

our build notes

(OFBIZ-10145)

As discussed in dev ML and OFBIZ-11133, reverts all commits done for OFBIZ-10145:

r1862356, r1862354, r1862353, r1861783, r1861766

But keeps in README.doc the added line in r1861766:

==== Clean system and load the complete OFBiz data

I'm uncertain about what will happen with the gradle/wrapper directory and the

wrapper version there (currently 5.5 and in between these commits).

But anyway not a big deal to get it back

Improved: Avoid confusing indirections in ‘StartupControlPanel#start’

(OFBIZ-11137)

The ‘StartupControlPanel#start’ method is delegating its job to

smaller private methods to improve readability. However the

conditionnals were previously hidden inside those methods with the

unfortunate consequence of making case analysis hard.

To avoid this undesirable effect, the conditionals has been moved

inside the ‘StartupControlPanel#start’ method and some delegate

methods has been inlined when their implementation was trivial. The

parameters of the remaining delegate methods has be refined to avoid

passing around unneeded things.

Improved: Rewrite ‘Start#determineCommandType’

(OFBIZ-11137)

Rename it to ‘Start.CommandType#valueOf’ and use a set to determine

the type of command instead of repetitive stream iterations.

Assuming ‘Set#contains’ is a constant operation, The algorithmic

complexity in worth case has dropped from O(n*m) to O(n+m) where n is

the number of command types and m is the number of startup commands.

In this particular case where n and m are small, the theorical gain

is not significative in term of actual performance.

"Applied fix from trunk framework for revision: 1862648"

------------------------------------------------------------------------

r1862648 | jleroux | 2019-07-06 11:42:46 +0200 (sam. 06 juil. 2019) | 14 lignes

Fixed: Error message is displayed when user having space in username logs

in at ecommerce

(OFBIZ-10671)

Pierre pointed out that the NotValidUserName label NL translation was wrong and

proposed a right one.

Looking at it closer EN and FR were not totally right either. I have fixed them.

Before committing, I wondered if we should remove all other languages, then

English would be used. Or if we let it as is for users of these languages to

propose a fix, as Pierre did. I'm more for the later, then end users who don't

speak English would at least have something they can read and possibly amend.

Thanks: Pierre Smits

------------------------------------------------------------------------

?\026

"Applied fix from trunk for revision: 1862648"

------------------------------------------------------------------------

r1862648 | jleroux | 2019-07-06 11:42:46 +0200 (sam. 06 juil. 2019) | 14 lignes

Fixed: Error message is displayed when user having space in username logs

in at ecommerce

(OFBIZ-10671)

Pierre pointed out that the NotValidUserName label NL translation was wrong and

proposed a right one.

Looking at it closer EN and FR were not totally right either. I have fixed them.

Before committing, I wondered if we should remove all other languages, then

English would be used. Or if we let it as is for users of these languages to

propose a fix, as Pierre did. I'm more for the later, then end users who don't

speak English would at least have something they can read and possibly amend.

Thanks: Pierre Smits

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1862648"

------------------------------------------------------------------------

r1862648 | jleroux | 2019-07-06 11:42:46 +0200 (sam. 06 juil. 2019) | 14 lignes

Fixed: Error message is displayed when user having space in username logs

in at ecommerce

(OFBIZ-10671)

Pierre pointed out that the NotValidUserName label NL translation was wrong and

proposed a right one.

Looking at it closer EN and FR were not totally right either. I have fixed them.

Before committing, I wondered if we should remove all other languages, then

English would be used. Or if we let it as is for users of these languages to

propose a fix, as Pierre did. I'm more for the later, then end users who don't

speak English would at least have something they can read and possibly amend.

Thanks: Pierre Smits

------------------------------------------------------------------------

Fixed: Error message is displayed when user having space in username logs

in at ecommerce

(OFBIZ-10671)

Pierre pointed out that the NotValidUserName label NL translation was wrong and

proposed a right one.

Looking at it closer EN and FR were not totally right either. I have fixed them.

Before committing, I wondered if we should remove all other languages, then

English would be used. Or if we let it as is for users of these languages to

propose a fix, as Pierre did. I'm more for the later, then end users who don't

speak English would at least have something they can read and possibly amend.

Thanks: Pierre Smits

Improved: Make ‘FormRenderer#getUsedFields’ more generic

(OFBIZ-11135)

We want to be able to reuse the selection of used fields for any form

renderers. As a consequence it seems more appropriate to move the

behavior of ‘FormRenderer#getUsedFields’ to the ‘ModelFormField’

class.

Additionally we have decoupled the filtering logic from the iteration

process by constructing a stateful predicate.

The corresponding unit tests have been adapted to both changes.

Improved: Navigate from a domain to another with automated signed in

authentication

(OFBIZ-10307)

Currently the CORS demonstration in example component is useless.

This tooltip allows local users to test it.

"Applied fix from trunk framework for revision: 1862466 "

------------------------------------------------------------------------

r1862466 | jleroux | 2019-07-03 15:30:28 +0200 (mer. 03 juil. 2019) | 20 lignes

Fixed: Error message is displayed when user having space in username logs

in at ecommerce

(OFBIZ-10671)

Steps to regenerate:

# Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]

# Click on register in header section

# Provide all the mandatory information but provide a user name such that is

contains a space (like: Walter White or Jesse Pinkman)

# Click on save button

Actual: When user clicks on save button then he is redirected to main page of

ecommerce and an error message is displayed.

Similarly when user with space in username tries to login, error message is

displayed.

Praven: Added standard regex for username allowed alphabets, numbers, and _-

jleroux: actually "-" was missing in the regepx definition.

Thanks: Arpit Mor for report and Praveen Sharma for the fix

------------------------------------------------------------------------

?\026

"Applied fix from plugins for revision: 1862466 "

------------------------------------------------------------------------

r1862466 | jleroux | 2019-07-03 15:30:28 +0200 (mer. 03 juil. 2019) | 20 lignes

Fixed: Error message is displayed when user having space in username logs

in at ecommerce

(OFBIZ-10671)

Steps to regenerate:

# Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]

# Click on register in header section

# Provide all the mandatory information but provide a user name such that is

contains a space (like: Walter White or Jesse Pinkman)

# Click on save button

Actual: When user clicks on save button then he is redirected to main page of

ecommerce and an error message is displayed.

Similarly when user with space in username tries to login, error message is

displayed.

Praven: Added standard regex for username allowed alphabets, numbers, and _-

jleroux: actually "-" was missing in the regepx definition.

Thanks: Arpit Mor for report and Praveen Sharma for the fix

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1862466 "

------------------------------------------------------------------------

r1862466 | jleroux | 2019-07-03 15:30:28 +0200 (mer. 03 juil. 2019) | 20 lignes

Fixed: Error message is displayed when user having space in username logs

in at ecommerce

(OFBIZ-10671)

Steps to regenerate:

# Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]

# Click on register in header section

# Provide all the mandatory information but provide a user name such that is

contains a space (like: Walter White or Jesse Pinkman)

# Click on save button

Actual: When user clicks on save button then he is redirected to main page of

ecommerce and an error message is displayed.

Similarly when user with space in username tries to login, error message is

displayed.

Praven: Added standard regex for username allowed alphabets, numbers, and _-

jleroux: actually "-" was missing in the regepx definition.

Thanks: Arpit Mor for report and Praveen Sharma for the fix

------------------------------------------------------------------------

"Applied fix from plugins for revision: 1862466 "

------------------------------------------------------------------------

r1862466 | jleroux | 2019-07-03 15:30:28 +0200 (mer. 03 juil. 2019) | 20 lignes

Fixed: Error message is displayed when user having space in username logs

in at ecommerce

(OFBIZ-10671)

Steps to regenerate:

# Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]

# Click on register in header section

# Provide all the mandatory information but provide a user name such that is

contains a space (like: Walter White or Jesse Pinkman)

# Click on save button

Actual: When user clicks on save button then he is redirected to main page of

ecommerce and an error message is displayed.

Similarly when user with space in username tries to login, error message is

displayed.

Praven: Added standard regex for username allowed alphabets, numbers, and _-

jleroux: actually "-" was missing in the regepx definition.

Thanks: Arpit Mor for report and Praveen Sharma for the fix

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1862466 "

------------------------------------------------------------------------

r1862466 | jleroux | 2019-07-03 15:30:28 +0200 (mer. 03 juil. 2019) | 20 lignes

Fixed: Error message is displayed when user having space in username logs

in at ecommerce

(OFBIZ-10671)

Steps to regenerate:

# Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]

# Click on register in header section

# Provide all the mandatory information but provide a user name such that is

contains a space (like: Walter White or Jesse Pinkman)

# Click on save button

Actual: When user clicks on save button then he is redirected to main page of

ecommerce and an error message is displayed.

Similarly when user with space in username tries to login, error message is

displayed.

Praven: Added standard regex for username allowed alphabets, numbers, and _-

jleroux: actually "-" was missing in the regepx definition.

Thanks: Arpit Mor for report and Praveen Sharma for the fix

------------------------------------------------------------------------

Fixed: Error message is displayed when user having space in username logs

in at ecommerce

(OFBIZ-10671)

Steps to regenerate:

# Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]

# Click on register in header section

# Provide all the mandatory information but provide a user name such that is

contains a space (like: Walter White or Jesse Pinkman)

# Click on save button

Actual: When user clicks on save button then he is redirected to main page of

ecommerce and an error message is displayed.

Similarly when user with space in username tries to login, error message is

displayed.

Praven: Added standard regex for username allowed alphabets, numbers, and _-

jleroux: actually "-" was missing in the regepx definition.

Thanks: Arpit Mor for report and Praveen Sharma for the fix

Documented: adds a missing new line in main README.adoc in order to get the 2

bullets of "Manual setting" section correctly

Improved: Remove the Gradle wrapper from our release packages and add a step to

our build notes

(OFBIZ-10145)

Oops, I was wrong for the repeated "-Xms64m" in gradlew

scripts. It's "-Xms64m" and "-Xmx64m"

Improved: Upgrade to Gradle 5.5

(OFBIZ-11131)

Update the trunk wrapper in tools.

I used

gradlew wrapper --gradle-version=5.5 --distribution-type=all

locally and explained on dev ML.

Improved: Remove the Gradle wrapper from our release packages and add a step to

our build notes

(OFBIZ-10145)

Fixes a typo in my previous commit about repeated "-Xms64m" in gradlew

Improved: Remove the Gradle wrapper from our release packages and add a step to

our build notes

(OFBIZ-10145)

Applies the last waiting gradlew.bat.patch in OFBIZ-10145

Fixes a trivial issue in Mathieu last commits: repeated "-Xms64m" in gradlew

scripts.

Uses HTTP in init-gradle-wrapper.ps1 instead of HTTP. Not everyone has an HTTPS

access to the tools repo.

Fixed: All local XML schema files are now present in classpath

(OFBIZ-11132)

Previously there was some warnings about missing “.xsd” files that

‘UtilXml#resolveEntity’ failed to find in classpath. This has been

fixed by declaring all “dtd” directories inside components as resources.

Improved: Rewrite ‘loadHandlerMap’

(OFBIZ-10453)

This retrieves the attribute "class" instead of "className" which was

mistakenly used in revision 1862323.

Improved: Factorize collecting events defined in “controller.xml”

(OFBIZ-10453)

Reverted: Mathieu's changes in ConfigXMLReader.java from yesterday

OFBiz was crashing

Reverts rev. 1862324, 1862323, 1862322

Fixed: Add missing ‘:GradleOK’ label in “gradlew.bat”

(OFBIZ-11131)

This fixes a mistake done in previous commit done when migrating our

“gradlew” modifications to the updated script.

Improved: Upgrade to Gradle 5.5

(OFBIZ-11131)

The upgrade has been done with the following command:

$ ./gradlew wrapper --gradle-version=5.5 --distribution-type=bin

Our “gradlew” scripts modification has been preserved and

“gradle/init-gradle-wrapper.sh” has been updated to download the new

version of the wrapper jar.