ofbiz

Checkout Tools
  • last updated 19 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Adapt ‘ContainerConfig#getConfigurations’

(OFBIZ-11256)

Remove unused declared ‘ContainerException’ in signature and fix the

javadoc to match the actual specification.

Improved: Mark ‘ContainerConfig#configurations’ as final

(OFBIZ-11256)

Use uppercase to match coding standards.

Improved: Avoid unecessary breakage in ‘ContainerConfig’

(OFBIZ-11256)

This restores ‘public’ modifiers on fields and move the ‘Property’

inner class back to ‘Configuration’ to avoid breakage of client code

extending the ‘Container’ interface.

In order to smooth the transition towards using getters instead of

direct field accesss, the public modifiers on fields are now marked as

deprecated.

Implemented: Allow deprecated public fields

(OFBIZ-11256)

Improved: Add ‘PropertyChildren’ interface

(OFBIZ-11256)

This allows removing some duplicated method overloads.

Fixed: Make ‘javadoc’ build work with recent Java

(OFBIZ-11257)

With a recent OpenJDK release we had the following error

```

> Task :javadoc

javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.

javadoc: error - The code being documented uses modules but the

packages defined in https://docs.oracle.com/javaee/7/api/ are in the

unnamed module.

[...]

2 errors

100 warnings

> Task :javadoc FAILED

```

With ‘javadoc --source 8’ this error disappears as described in

JDK-8212233 [1].

[1] https://bugs.openjdk.java.net/browse/JDK-8212233

Fixed: Adapt some javadoc to let the build succeed

Fixed: Make ‘javadoc’ build work with recent Java

(OFBIZ-11257)

With a recent OpenJDK release we had the following error

```

> Task :javadoc

javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.

javadoc: error - The code being documented uses modules but the

packages defined in https://docs.oracle.com/javaee/7/api/ are in the

unnamed module.

[...]

2 errors

100 warnings

> Task :javadoc FAILED

```

With ‘javadoc --source 8’ this error disappears as described in

JDK-8212233 [1].

[1] https://bugs.openjdk.java.net/browse/JDK-8212233

Fixed: Format ‘XmlRpcEventHandler’

(OFBIZ-10284)

This removes coding style errors introduced in revision 1868611.

Improved: no functional change

Adds missing ASL2 header

"Applied fix from trunk for revision: 1868615"

------------------------------------------------------------------------

r1868615 | jleroux | 2019-10-19 10:12:07 +0200 (sam. 19 oct. 2019) | 6 lignes

Fixed: Fix multi modal opening

(OFBIZ-11211)

Simplifies a little bit the current code.

Thanks: Leila for patch and Carl for confirmation

------------------------------------------------------------------------

Fixed: Fix multi modal opening

(OFBIZ-11211)

Simplifies a little bit the current code.

Thanks: Leila for patch and Carl for confirmation

"Applied fix from trunk framework for revision: 1868611"

------------------------------------------------------------------------

r1868611 | jleroux | 2019-10-19 08:42:07 +0200 (sam. 19 oct. 2019) | 11 lignes

Improved: Handling tenant in XmlRpcEventHandler

(OFBIZ-10284)

The XMLRPC service does not support tenants. Even if the tenant domain is

included in the HTTP request the call does not affect the correct tenant.

The issue and fix has been discussed in in the thread

https://markmail.org/message/bz4dofrxqp6i7ove

jleroux: I was able to port the R16 patch provided by Rajesh to the trunk.

Thanks: Rajesh Kumar Mallah

------------------------------------------------------------------------

?\026

"Applied fix from trunk for revision: 1868611"

------------------------------------------------------------------------

r1868611 | jleroux | 2019-10-19 08:42:07 +0200 (sam. 19 oct. 2019) | 11 lignes

Improved: Handling tenant in XmlRpcEventHandler

(OFBIZ-10284)

The XMLRPC service does not support tenants. Even if the tenant domain is

included in the HTTP request the call does not affect the correct tenant.

The issue and fix has been discussed in in the thread

https://markmail.org/message/bz4dofrxqp6i7ove

jleroux: I was able to port the R16 patch provided by Rajesh to the trunk.

Thanks: Rajesh Kumar Mallah

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868611"

------------------------------------------------------------------------

r1868611 | jleroux | 2019-10-19 08:42:07 +0200 (sam. 19 oct. 2019) | 11 lignes

Improved: Handling tenant in XmlRpcEventHandler

(OFBIZ-10284)

The XMLRPC service does not support tenants. Even if the tenant domain is

included in the HTTP request the call does not affect the correct tenant.

The issue and fix has been discussed in in the thread

https://markmail.org/message/bz4dofrxqp6i7ove

jleroux: I was able to port the R16 patch provided by Rajesh to the trunk.

Thanks: Rajesh Kumar Mallah

------------------------------------------------------------------------

Improved: Handling tenant in XmlRpcEventHandler

(OFBIZ-10284)

The XMLRPC service does not support tenants. Even if the tenant domain is

included in the HTTP request the call does not affect the correct tenant.

The issue and fix has been discussed in in the thread

https://markmail.org/message/bz4dofrxqp6i7ove

jleroux: I was able to port the R16 patch provided by Rajesh to the trunk.

Thanks: Rajesh Kumar Mallah

Improved: Refactor ‘ContainerConfig’ class

(OFBIZ-11256)

This removes some code duplication, make things immutable and add some javadoc.

Improved: Use ‘checkstyle’ linting tool

(OFBIZ-11251)

Linting [1] is a software engineering practice which make the code more

readable and maintainable by improving its consistency and avoiding

potential programming mistakes. Gradle provides a core plugin for the

‘checkstyle’ tool [2][3] which implement a linting facility for the Java

language.

The check is done with the ‘gradlew check’ command.

There are currently a lot reported errors that will need to be fixed

incrementally in the future. We ensure that new errors will not be

introduced by defining a global threshold of “allowed” errors

corresponding to the sum of errors found in the framework and in the

official plugins.

[1] https://en.wikipedia.org/wiki/Lint_(software)

[2] https://checkstyle.org/

[3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html

Thanks: Taher Alkhateeb and Jacques Le Roux for their feedback

Fixed: Move OrderNotificationTests.groovy from order to ecommerce

(OFBIZ-11255)

Fixes the errors in framework only tests, order and ecommerce suites tests pass

    • ?
    /ofbiz-plugins/trunk/ecommerce/testdef/EcommerceTest.xml
  1. /ofbiz-plugins/trunk/ecommerce/src/main/groovy/org
  2. /ofbiz-plugins/trunk/ecommerce/src/main/groovy
Improved: Remove unused methods related to properties in UtilProperties and

EntityUtilProperties

(OFBIZ-11254)

While removing the POS I forgot to remove specific methods I added in

UtilProperties: setPropertyValue(*,*,*) and setPropertyValueInMemory.

I finally found that setPropertyValueInMemory is used in one test and so maybe

usefull. setPropertyValue(*,*,*) is unused and can be safemy removed. It's also

called from EntityUtilProperties so should also be removed there.

This removes it, and also slightly formats

EntityUtilProperties::setPropertyValueInMemory

Fixed: Down the log level to inform to use genericBasePermissionCheck

After the migration of genericBasePermissionCheck from mini-lang to groovy, I set a warning message to inform that we need to migrate simple-method call.

But this simple-method is massively use on standard mini-lang script and finally populate with non interesting inform the log in production site.

I down the level to inform only on development state

Fixed: Down the log level to inform when a property number is empty

When you call a property number undefined, UtilProperty return the default value and you have in console a warning :

UtilProperties |W| Error converting String to Integer; using defaultNumber 60.

Or in general if you call and resolve an empty value for a property, they is no reason to inform it as error.

"Applied fix from trunk framework for revision: 1868553" (by hand)

------------------------------------------------------------------------

r1868553 | jleroux | 2019-10-17 16:26:42 +0200 (jeu. 17 oct. 2019) | 14 lignes

Fixed: FTL error for purchase order with Bulk Item Type

(OFBIZ-11252)

Steps to regenerate:

1. Login into the ordermgr application and click on Order Entry tab

2. Create PO with any supplier

3. Fill details and click on Continue

4. Now select Product Category with Item type Bulk and add the description and

Click on add to order

5. Finalize order with Finalize Order button

6. Add Term type, ship group option, etc details and create Order.

7. Scroll down to Order Items section and See the FTL error on the screen.

Thanks: Devanshu Vyas

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868553"

------------------------------------------------------------------------

r1868553 | jleroux | 2019-10-17 16:26:42 +0200 (jeu. 17 oct. 2019) | 14 lignes

Fixed: FTL error for purchase order with Bulk Item Type

(OFBIZ-11252)

Steps to regenerate:

1. Login into the ordermgr application and click on Order Entry tab

2. Create PO with any supplier

3. Fill details and click on Continue

4. Now select Product Category with Item type Bulk and add the description and

Click on add to order

5. Finalize order with Finalize Order button

6. Add Term type, ship group option, etc details and create Order.

7. Scroll down to Order Items section and See the FTL error on the screen.

Thanks: Devanshu Vyas

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868553"

------------------------------------------------------------------------

r1868553 | jleroux | 2019-10-17 16:26:42 +0200 (jeu. 17 oct. 2019) | 14 lignes

Fixed: FTL error for purchase order with Bulk Item Type

(OFBIZ-11252)

Steps to regenerate:

1. Login into the ordermgr application and click on Order Entry tab

2. Create PO with any supplier

3. Fill details and click on Continue

4. Now select Product Category with Item type Bulk and add the description and

Click on add to order

5. Finalize order with Finalize Order button

6. Add Term type, ship group option, etc details and create Order.

7. Scroll down to Order Items section and See the FTL error on the screen.

Thanks: Devanshu Vyas

------------------------------------------------------------------------

Fixed: FTL error for purchase order with Bulk Item Type

(OFBIZ-11252)

Steps to regenerate:

1. Login into the ordermgr application and click on Order Entry tab

2. Create PO with any supplier

3. Fill details and click on Continue

4. Now select Product Category with Item type Bulk and add the description and

Click on add to order

5. Finalize order with Finalize Order button

6. Add Term type, ship group option, etc details and create Order.

7. Scroll down to Order Items section and See the FTL error on the screen.

Thanks: Devanshu Vyas

"Applied fix from trunk framework for revision: 1868545" (by hand)

------------------------------------------------------------------------

r1868545 | jleroux | 2019-10-17 14:19:33 +0200 (jeu. 17 oct. 2019) | 16 lignes

Fixed: EditExample always update status, because current Status not shown

(OFBIZ-11230)

In the EditExample Form, the drop-down is populates with the Valid change status

only. So current status is not in the list and the status print in the drop-down

is the next authorized. I want to modify exampleName or exampleType, I go to

editExample and change what I want and validate. The problem is status is also

changed!

There are 12 other same or similar cases. For the first of them (in FinAccount)

there is the same bug: when I change FinAccount Name, status change too. If I

add current="first-in-list" in the tag drop-down it works

jleroux: Quote is a peculiar case due to OFBIZ-7337 which was a wrong fix

Thanks: Oliver for the analysis and the fix

------------------------------------------------------------------------

"Applied fix from trunk framework for revision: 1868545"

------------------------------------------------------------------------

r1868545 | jleroux | 2019-10-17 14:19:33 +0200 (jeu. 17 oct. 2019) | 16 lignes

Fixed: EditExample always update status, because current Status not shown

(OFBIZ-11230)

In the EditExample Form, the drop-down is populates with the Valid change status

only. So current status is not in the list and the status print in the drop-down

is the next authorized. I want to modify exampleName or exampleType, I go to

editExample and change what I want and validate. The problem is status is also

changed!

There are 12 other same or similar cases. For the first of them (in FinAccount)

there is the same bug: when I change FinAccount Name, status change too. If I

add current="first-in-list" in the tag drop-down it works

jleroux: Quote is a peculiar case due to OFBIZ-7337 which was a wrong fix

Thanks: Oliver for the analysis and the fix

------------------------------------------------------------------------

?\026

"Applied fix from plugins for revision: 1868545"

------------------------------------------------------------------------

r1868545 | jleroux | 2019-10-17 14:19:33 +0200 (jeu. 17 oct. 2019) | 16 lignes

Fixed: EditExample always update status, because current Status not shown

(OFBIZ-11230)

In the EditExample Form, the drop-down is populates with the Valid change status

only. So current status is not in the list and the status print in the drop-down

is the next authorized. I want to modify exampleName or exampleType, I go to

editExample and change what I want and validate. The problem is status is also

changed!

There are 12 other same or similar cases. For the first of them (in FinAccount)

there is the same bug: when I change FinAccount Name, status change too. If I

add current="first-in-list" in the tag drop-down it works

jleroux: Quote is a peculiar case due to OFBIZ-7337 which was a wrong fix

Thanks: Oliver for the analysis and the fix

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1868545"

------------------------------------------------------------------------

r1868545 | jleroux | 2019-10-17 14:19:33 +0200 (jeu. 17 oct. 2019) | 16 lignes

Fixed: EditExample always update status, because current Status not shown

(OFBIZ-11230)

In the EditExample Form, the drop-down is populates with the Valid change status

only. So current status is not in the list and the status print in the drop-down

is the next authorized. I want to modify exampleName or exampleType, I go to

editExample and change what I want and validate. The problem is status is also

changed!

There are 12 other same or similar cases. For the first of them (in FinAccount)

there is the same bug: when I change FinAccount Name, status change too. If I

add current="first-in-list" in the tag drop-down it works

jleroux: Quote is a peculiar case due to OFBIZ-7337 which was a wrong fix

Thanks: Oliver for the analysis and the fix

------------------------------------------------------------------------