Clone
Jacques Le Roux
committed
on 26 May 19
Improved: Use Groovy Truth instead of UtilValidate Class in Groovy (OFBIZ-11064)
As we all know, Groovy is a powerful language with great bu… Show more
Improved: Use Groovy Truth instead of UtilValidate Class in Groovy (OFBIZ-11064)

As we all know, Groovy is a powerful language with great built-in functions.

Groovy Truth[1] is one of them, which is not used properly in our code base.

We have used UtilValidate Class to validate arguments for Empty or NotEmpty,

which can easily be done in groovy with built-in functionality[1].

Current Code: if (UtilValidate.isNotEmpty(locations)) { ... }

Groovy Built-in Code: if (locations) { ... }

[1] - http://groovy-lang.org/semantics.html#Groovy-Truth

We need to careful for some points while we change this:

Like:

maxRetry = 0

if (!maxRetry)

{  // Not set, use a default  maxRetry = -1 }

Because groovy evaluates zero to be false, it wouldn't be possible to set

maxRetry to zero.  So it's best not to use groovy truth for null-checks on

numbers in some cases.

Thanks: Pawan Verma

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1860051 13f79535-47bb-0310-9956-ffa450edef68

Show less