Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Corrected some line is longer than 150 characters checkstyle issues. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)

  1. … 47 more files in changeset.
Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in plugins component. (OFBIZ-11886)

  1. … 36 more files in changeset.
Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in plugins component. (OFBIZ-11880) Thanks Jacques for review.

  1. … 58 more files in changeset.
Improved: Replace try-finally with try with resources(OFBIZ-11826)

Set checkstyleMain.maxErrors to 26678 (-4)

Thanks: Jacques for the review.

  1. … 1 more file in changeset.
Improved: Change resources with proper naming convention in all plugin components. (OFBIZ-11739) Also, made MODULE as private data member of class instead of public. Thanks Jacques for review.

  1. … 61 more files in changeset.
Improved: replaces module by MODULE everywhere

  1. … 71 more files in changeset.
Fixed: replaceFirst sensible to variable pattern (OFBIZ-11396)

When using variable pattern with replaceFirst you may cross issues if the

pattern contains specific tokens. For instance on Windows with the path

"C:\projectsASF\Git\ofbiz-framework/" you have inside the token "\p" which has

a special meaning.

Fixed: replaceFirst sensible to variable pattern (OFBIZ-11396)

When using variable pattern with replaceFirst you may cross issues if the

pattern contains specific tokens. For instance on Windows with the path

"C:\projectsASF\Git\ofbiz-framework/" you have inside the token "\p" which has

a special meaning.

Fixed: replaceFirst sensible to variable pattern (OFBIZ-11396)

When using variable pattern with replaceFirst you may cross issues if the

pattern contains specific tokens. For instance on Windows with the path

"C:\projectsASF\Git\ofbiz-framework/" you have inside the token "\p" which has

a special meaning.

"Applied fix from plugins for revision: 1865347" ------------------------------------------------------------------------ r1865347 | jleroux | 2019-08-17 13:34:01 +0200 (sam. 17 août 2019) | 9 lignes

Fixed: Issue loading solr component (JNDI timeout)

(OFBIZ-11156)

We need to provide a JNDI environment property for Solr to load faster

Fixes previous commit where I hastily harcoded in jndi.properties file

Used a system property which can be used to define a JNDI environment

property

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1865351 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
"Applied fix from plugins for revision: 1865347" ------------------------------------------------------------------------ r1865347 | jleroux | 2019-08-17 13:34:01 +0200 (sam. 17 août 2019) | 9 lignes

Fixed: Issue loading solr component (JNDI timeout)

(OFBIZ-11156)

We need to provide a JNDI environment property for Solr to load faster

Fixes previous commit where I hastily harcoded in jndi.properties file

Used a system property which can be used to define a JNDI environment

property

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release18.12@1865350 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Fixed: Issue loading solr component (JNDI timeout) (OFBIZ-11156)

We need to provide a JNDI environment property for Solr to load faster

Fixes previous commit where I hastily harcoded in jndi.properties file

Used a system property which can be used to define a JNDI environment

property

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1865347 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Improved: Add missing ‘static’ modifier for private methods (OFBIZ-11098)

In order to make it clear when a method is not depending on the

internal state of an object, it is a good practice to declare it as

static.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1860939 13f79535-47bb-0310-9956-ffa450edef68

  1. … 2 more files in changeset.
Improved: Use the ‘@Override’ annotation (OFBIZ-10939)

The ‘@Override’ annotation helps readers understand that the method at

hand is overriding a super class or implementing an interface.

Additionally it allows the compiler to check if the methods annotated

with ‘@Override’ are actually implementing an abstract method.

Using that annotation makes ‘@see foo.bar.ParentClass#myMethod’

comments useless, so those they have been removed for the newly

annotated methods.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1860028 13f79535-47bb-0310-9956-ffa450edef68

  1. … 16 more files in changeset.
Improved: Remove redundant type declarations (OFBIZ-10937)

Since Java 1.7, when defining generic types it is unnecessary to

redefine those types in the constructor when it is already done in the

declared type.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1860025 13f79535-47bb-0310-9956-ffa450edef68

  1. … 43 more files in changeset.
Improved: Fix or Silence various warnings (OFBIZ-10701)

In order to detect potential issues early, the linting compiler option should be

used by default and disabled with {{./gradlew -PXlint:none build}}.

Additionally it is important to reduce the number of warnings otherwise new

warnings will remain unnoticed.

The warning related to the com.googlecode.concurrentlinkedhashmap dependency

should resolves itself once we handle upgrade to Caffeine like proposed in

OFBIZ-6747.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1848673 13f79535-47bb-0310-9956-ffa450edef68

  1. … 30 more files in changeset.
Improved: Missing Java Option solr.log.dir. Logging may be missing or incomplete (OFBIZ-9375)

This fixes and completes r1800457

I put a wrong path in solrconfig.properties for solr.log.dir

(/runtime/indexes/solr instead of runtime/logs/solr).

This also adds the log level.

Not sure this has a real impact on Solr logging (from the

Solr admin UI does not seem to work.) But at least we no longer have this

annoying message. People interested in Solr logging will dig in...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1800484 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Improved: Missing Java Option solr.log.dir. Logging may be missing or incomplete (OFBIZ-9375)

The tip suggested by Jinghai I committed at r1795781 did not work.

This reverts r1795781 and offers a better solid solution.

Byproduct: fixes imports and tabs in OFBizSolrContextFilter.java

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1800457 13f79535-47bb-0310-9956-ffa450edef68

  1. … 3 more files in changeset.
Implemented: renamed the directory specialpurpose to plugins (OFBIZ-7972)

In another step towards completing the plugin system for OFBiz, we renamed

the /specialpurpose directory to /plugins and changed all occurences of the

word "specialpurpose" to "plugins" in all files found in the system

Reference discussion: http://markmail.org/message/hpyuxkmftiyn44w2

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1778271 13f79535-47bb-0310-9956-ffa450edef68

  1. … 28 more files in changeset.
Implemented: Update Apache Solr/Lucene to release 6.2.1 (OFBIZ-8316)

Upgraded Apache Solr/Lucene from 5.3.1 to 6.2.1.

Thanks: Michael Brohl and Cao PengAn for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1776930 13f79535-47bb-0310-9956-ffa450edef68

  1. … 89 more files in changeset.
Implemented: removed the "controller" related logic, that is now provided by the new ControlFilter, from the ContextFilter; modified existing applications to use the two filters in a chain; removed from the other specialized filters all the logic that was duplicated or extended from ContextFilter.

A web application, in order to leverage the OFBiz framework, requires that a

series of objects are in its contexts (servlet context, session and request)

such as "delegator", "delegatorName", "dispatcher", "security" etc. etc...

This setup is performed by the logic contained in the servlet filter implemented

by the ContextFilter class.

The execution of this logic is required for the application to run properly.

However, before this commit, in the ContextFilter there was other logic, related

to access control and redirection rules (some of them performed in coordination

with the ControlServlet), making it difficult to deploy this filter in all the

web applications, especially the ones that implement special handling of paths.

In fact, this filter was deployed in most but not all the web application in the

OFBiz codebase: specifically it was not deployed in web applications that

require the execution of other filters (e.g. CatalogUrlFilter, etc...) like the

ones in the "ecommerce" and "solr" components.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761304 13f79535-47bb-0310-9956-ffa450edef68

  1. … 24 more files in changeset.
Implemented: To follow Jacopo's change (rev. 1760725) on ControlFilter, cleaned up the OFBizSolrContextFilter and setup a filter chain in web.xml.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761214 13f79535-47bb-0310-9956-ffa450edef68

    • -234
    • +115
    ./OFBizSolrContextFilter.java
  1. … 2 more files in changeset.
Fix for View screen in Apache Solr Integration Component is broken (OFBIZ-8225).

The duplicated login form is caused by not return after ContextFilter do the filter.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1760463 13f79535-47bb-0310-9956-ffa450edef68

Clean OFBizSolrContextFilter.java to follow ContextFilter.java's changes.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1759401 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-6274) Renamed OFBiz artefacts from org.ofbiz.* to org.apache.ofbiz.*.Thanks to Taher for working on it.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1752920 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +657
    ./OFBizSolrContextFilter.java
    • -0
    • +82
    ./OFBizSolrLoadAdminUiServlet.java
    • -0
    • +96
    ./OFBizSolrRedirectServlet.java
  1. … 634 more files in changeset.