Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Remove unused imports from Java files (OFBIZ-11930) (#36)

Improved: Remove unused imports from Java files

(OFBIZ-11930)

Thanks: Priya Sharma

  1. … 9 more files in changeset.
Improved: Corrected some line is longer than 150 characters checkstyle issues. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)

    • -40
    • +50
    ./ofbiz/solr/webapp/OFBizSolrContextFilter.java
  1. … 45 more files in changeset.
Improved: Corrected all incorrect indentation level issues in plugins component, also fixed some case indentation checkstyle issues. (OFBIZ-11922)

    • -26
    • +44
    ./ofbiz/solr/SolrProductSearch.java
  1. … 12 more files in changeset.
Improved: Updated case indentation to 0 for all switch statements in plugins component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904)

    • -38
    • +19
    ./ofbiz/solr/SolrProductSearch.java
  1. … 15 more files in changeset.
Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in plugins component. (OFBIZ-11886)

  1. … 34 more files in changeset.
Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in plugins component. (OFBIZ-11880) Thanks Jacques for review.

    • -3
    • +1
    ./ofbiz/solr/webapp/OFBizSolrContextFilter.java
    • -4
    • +0
    ./ofbiz/solr/webapp/OFBizSolrRedirectServlet.java
  1. … 55 more files in changeset.
Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for plugins component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace.

'{' is not followed by whitespace.

'}' is not followed by whitespace.

'}' is not preceded with whitespace.

'typecast' is not followed by whitespace.

'try' is not followed by whitespace.

';' is preceded with whitespace.

  1. … 26 more files in changeset.
Improved: Corrected all checkstyle issues related to succeeding space for comma in plugins directory. (OFBIZ-11805) Thanks Jacques and Ritesh Kumar for review.

  1. … 13 more files in changeset.
Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review.

  1. … 8 more files in changeset.
Improved: Merge identical catch blocks in single catch block(OFBIZ-11827)

In Java SE 7 and later, a single catch block can handle more than one type of exception. This feature can reduce code duplication and lessen the temptation to catch an overly broad exception.

Thanks: Jacques for the review.

    • -34
    • +3
    ./ofbiz/solr/SolrProductSearch.java
  1. … 20 more files in changeset.
Improved: Replace try-finally with try with resources(OFBIZ-11826)

Set checkstyleMain.maxErrors to 26678 (-4)

Thanks: Jacques for the review.

    • -8
    • +2
    ./ofbiz/solr/webapp/OFBizSolrContextFilter.java
  1. … 1 more file in changeset.
Improved: Enforce noninstantiability to LdapLoginWorker, OFBizSolrLoginWorker class. (#23)

(OFBIZ-11747)

Made class as final, added private constructor and made static variables as private.

    • -21
    • +16
    ./ofbiz/solr/control/OFBizSolrLoginWorker.java
  1. … 2 more files in changeset.
Improved: Change resources with proper naming convention in all plugin components. (OFBIZ-11739) Also, made MODULE as private data member of class instead of public. Thanks Jacques for review.

    • -6
    • +6
    ./ofbiz/solr/webapp/OFBizSolrContextFilter.java
    • -1
    • +1
    ./ofbiz/solr/webapp/OFBizSolrRedirectServlet.java
  1. … 57 more files in changeset.
Improved: Used utility provided by OFBizTestCase class for userLogin instead of fetching from DB test cases also removed unused fetching of userLogin in some cases (OFBIZ-11618)

  1. … 1 more file in changeset.
Improved: replaces module by MODULE everywhere

    • -41
    • +41
    ./ofbiz/solr/SolrProductSearch.java
    • -7
    • +7
    ./ofbiz/solr/webapp/OFBizSolrContextFilter.java
    • -1
    • +1
    ./ofbiz/solr/webapp/OFBizSolrRedirectServlet.java
  1. … 66 more files in changeset.
Fixed: replaceFirst sensible to variable pattern (OFBIZ-11396)

When using variable pattern with replaceFirst you may cross issues if the

pattern contains specific tokens. For instance on Windows with the path

"C:\projectsASF\Git\ofbiz-framework/" you have inside the token "\p" which has

a special meaning.

    • -3
    • +4
    ./ofbiz/solr/webapp/OFBizSolrRedirectServlet.java
Fixed: replaceFirst sensible to variable pattern (OFBIZ-11396)

When using variable pattern with replaceFirst you may cross issues if the

pattern contains specific tokens. For instance on Windows with the path

"C:\projectsASF\Git\ofbiz-framework/" you have inside the token "\p" which has

a special meaning.

    • -3
    • +4
    ./ofbiz/solr/webapp/OFBizSolrRedirectServlet.java
Fixed: replaceFirst sensible to variable pattern (OFBIZ-11396)

When using variable pattern with replaceFirst you may cross issues if the

pattern contains specific tokens. For instance on Windows with the path

"C:\projectsASF\Git\ofbiz-framework/" you have inside the token "\p" which has

a special meaning.

    • -3
    • +4
    ./ofbiz/solr/webapp/OFBizSolrRedirectServlet.java
"Applied fix from plugins for revision: 1865347" ------------------------------------------------------------------------ r1865347 | jleroux | 2019-08-17 13:34:01 +0200 (sam. 17 août 2019) | 9 lignes

Fixed: Issue loading solr component (JNDI timeout)

(OFBIZ-11156)

We need to provide a JNDI environment property for Solr to load faster

Fixes previous commit where I hastily harcoded in jndi.properties file

Used a system property which can be used to define a JNDI environment

property

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1865351 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +1
    ./ofbiz/solr/webapp/OFBizSolrContextFilter.java
  1. … 1 more file in changeset.
"Applied fix from plugins for revision: 1865347" ------------------------------------------------------------------------ r1865347 | jleroux | 2019-08-17 13:34:01 +0200 (sam. 17 août 2019) | 9 lignes

Fixed: Issue loading solr component (JNDI timeout)

(OFBIZ-11156)

We need to provide a JNDI environment property for Solr to load faster

Fixes previous commit where I hastily harcoded in jndi.properties file

Used a system property which can be used to define a JNDI environment

property

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release18.12@1865350 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +1
    ./ofbiz/solr/webapp/OFBizSolrContextFilter.java
  1. … 1 more file in changeset.
Fixed: Issue loading solr component (JNDI timeout) (OFBIZ-11156)

We need to provide a JNDI environment property for Solr to load faster

Fixes previous commit where I hastily harcoded in jndi.properties file

Used a system property which can be used to define a JNDI environment

property

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1865347 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +1
    ./ofbiz/solr/webapp/OFBizSolrContextFilter.java
  1. … 1 more file in changeset.
Improved: Inline ‘UtilGenerics#checkList’ (OFBIZ-11141)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1863492 13f79535-47bb-0310-9956-ffa450edef68

  1. … 4 more files in changeset.
Improved: Inline ‘UtilGenerics#checkMap’ (OFBIZ-11141)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1863491 13f79535-47bb-0310-9956-ffa450edef68

  1. … 4 more files in changeset.
Improved: Inline ‘UtilGenerics#checkSet’ (OFBIZ-11141)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1863490 13f79535-47bb-0310-9956-ffa450edef68

Improved: Add missing ‘static’ modifier for private methods (OFBIZ-11098)

In order to make it clear when a method is not depending on the

internal state of an object, it is a good practice to declare it as

static.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1860939 13f79535-47bb-0310-9956-ffa450edef68

    • -1
    • +3
    ./ofbiz/solr/webapp/OFBizSolrContextFilter.java
  1. … 2 more files in changeset.
Improved: Use the ‘@Override’ annotation (OFBIZ-10939)

The ‘@Override’ annotation helps readers understand that the method at

hand is overriding a super class or implementing an interface.

Additionally it allows the compiler to check if the methods annotated

with ‘@Override’ are actually implementing an abstract method.

Using that annotation makes ‘@see foo.bar.ParentClass#myMethod’

comments useless, so those they have been removed for the newly

annotated methods.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1860028 13f79535-47bb-0310-9956-ffa450edef68

    • -9
    • +4
    ./ofbiz/solr/webapp/OFBizSolrContextFilter.java
  1. … 16 more files in changeset.
Improved: Remove useless null check (OFBIZ-10054)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1860026 13f79535-47bb-0310-9956-ffa450edef68

Improved: Remove redundant type declarations (OFBIZ-10937)

Since Java 1.7, when defining generic types it is unnecessary to

redefine those types in the constructor when it is already done in the

declared type.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1860025 13f79535-47bb-0310-9956-ffa450edef68

    • -14
    • +14
    ./ofbiz/solr/SolrProductSearch.java
    • -1
    • +1
    ./ofbiz/solr/webapp/OFBizSolrContextFilter.java
  1. … 38 more files in changeset.
Improved: Refactor boolean returns from methods (OFBIZ-10725)

I was wondering if we should close. I just had a look and using this regexp:

if \(.*\) \{\R.*return true;

I found

* 60 matches in applications

* 138 in framework

* 4 in plugins

I only checked the 1st two in applications and they really match

While at it this improves 3 of the 4 in plugins (the other is in a loop)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1858350 13f79535-47bb-0310-9956-ffa450edef68

  1. … 2 more files in changeset.
Improved: Fix or Silence various warnings (OFBIZ-10701)

In order to detect potential issues early, the linting compiler option should be

used by default and disabled with {{./gradlew -PXlint:none build}}.

Additionally it is important to reduce the number of warnings otherwise new

warnings will remain unnoticed.

The warning related to the com.googlecode.concurrentlinkedhashmap dependency

should resolves itself once we handle upgrade to Caffeine like proposed in

OFBIZ-6747.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1848673 13f79535-47bb-0310-9956-ffa450edef68

    • -12
    • +16
    ./ofbiz/solr/SolrProductSearch.java
    • -1
    • +0
    ./ofbiz/solr/webapp/OFBizSolrRedirectServlet.java
  1. … 25 more files in changeset.