Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Remove unused imports from Java files (OFBIZ-11930) (#36)

Improved: Remove unused imports from Java files

(OFBIZ-11930)

Thanks: Priya Sharma

  1. … 9 more files in changeset.
Improved: Corrected some line is longer than 150 characters checkstyle issues. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)

  1. … 45 more files in changeset.
Improved: Corrected all incorrect indentation level issues in plugins component, also fixed some case indentation checkstyle issues. (OFBIZ-11922)

  1. … 12 more files in changeset.
Improved: Updated case indentation to 0 for all switch statements in plugins component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904)

  1. … 15 more files in changeset.
Improved: Update build.gradle to the latest dependencies (OFBIZ-11903)

See

https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check

for libs not upgraded.

    • -1
    • +1
    ./home/solrdefault/conf/solrconfig.xml
  1. … 3 more files in changeset.
Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in plugins component. (OFBIZ-11886)

  1. … 34 more files in changeset.
Improved: Use Error.ftl everywhere it's not yet used (OFBIZ-11890)

Removes all error*.jsp reference, no longer used

  1. … 21 more files in changeset.
Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in plugins component. (OFBIZ-11880) Thanks Jacques for review.

  1. … 55 more files in changeset.
Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for plugins component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace.

'{' is not followed by whitespace.

'}' is not followed by whitespace.

'}' is not preceded with whitespace.

'typecast' is not followed by whitespace.

'try' is not followed by whitespace.

';' is preceded with whitespace.

  1. … 26 more files in changeset.
Improved: Corrected all checkstyle issues related to succeeding space for comma in plugins directory. (OFBIZ-11805) Thanks Jacques and Ritesh Kumar for review.

  1. … 13 more files in changeset.
Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review.

  1. … 8 more files in changeset.
Improved: Merge identical catch blocks in single catch block(OFBIZ-11827)

In Java SE 7 and later, a single catch block can handle more than one type of exception. This feature can reduce code duplication and lessen the temptation to catch an overly broad exception.

Thanks: Jacques for the review.

  1. … 20 more files in changeset.
Improved: Replace try-finally with try with resources(OFBIZ-11826)

Set checkstyleMain.maxErrors to 26678 (-4)

Thanks: Jacques for the review.

  1. … 1 more file in changeset.
Improved: Enforce noninstantiability to LdapLoginWorker, OFBizSolrLoginWorker class. (#23)

(OFBIZ-11747)

Made class as final, added private constructor and made static variables as private.

  1. … 2 more files in changeset.
Improved: Change resources with proper naming convention in all plugin components. (OFBIZ-11739) Also, made MODULE as private data member of class instead of public. Thanks Jacques for review.

  1. … 57 more files in changeset.
Improved: Used utility provided by OFBizTestCase class for userLogin instead of fetching from DB test cases also removed unused fetching of userLogin in some cases (OFBIZ-11618)

  1. … 1 more file in changeset.
Improved: Update build.gradle to the latest dependencies

(OFBIZ-11603)

I tried to update to Groovy 3 but got a compile issue with commons-cli.

I did not dig further.

    • -1
    • +1
    ./home/solrdefault/conf/solrconfig.xml
  1. … 5 more files in changeset.
Improved: replaces module by MODULE everywhere

  1. … 66 more files in changeset.
Fixed: replaceFirst sensible to variable pattern (OFBIZ-11396)

When using variable pattern with replaceFirst you may cross issues if the

pattern contains specific tokens. For instance on Windows with the path

"C:\projectsASF\Git\ofbiz-framework/" you have inside the token "\p" which has

a special meaning.

Fixed: replaceFirst sensible to variable pattern (OFBIZ-11396)

When using variable pattern with replaceFirst you may cross issues if the

pattern contains specific tokens. For instance on Windows with the path

"C:\projectsASF\Git\ofbiz-framework/" you have inside the token "\p" which has

a special meaning.

Fixed: replaceFirst sensible to variable pattern (OFBIZ-11396)

When using variable pattern with replaceFirst you may cross issues if the

pattern contains specific tokens. For instance on Windows with the path

"C:\projectsASF\Git\ofbiz-framework/" you have inside the token "\p" which has

a special meaning.

Fixed: Add XML declaration in “web.xml” files (OFBIZ-6993)

These declarations avoid SAXParseException traceback when parsing web.xml

the first time in WebappUtil.parseWebXmlFile

A schema conformance issue has been fixed in ecommerce “web.xml”.

(cherry picked from commit 1158664ba37264fa6b8429033bad768175ff10d5)

# Conflicts handled by hand

# msggateway/webapp/msggateway/WEB-INF/web.xml

  1. … 25 more files in changeset.
Fixed: Add XML declaration in “web.xml” files (OFBIZ-6993)

These declarations avoid SAXParseException traceback when parsing web.xml

the first time in WebappUtil.parseWebXmlFile

A schema conformance issue has been fixed in ecommerce “web.xml”.

  1. … 25 more files in changeset.
Fixed: Add XML declaration in “web.xml” files (OFBIZ-6993)

These declarations avoid SAXParseException traceback when parsing web.xml

the first time in WebappUtil.parseWebXmlFile

A schema conformance issue has been fixed in ecommerce “web.xml”.

# Conflicts handled by hand

# msggateway/webapp/msggateway/WEB-INF/web.xml

  1. … 25 more files in changeset.
"Applied fix from plugins for revision: 1865347" ------------------------------------------------------------------------ r1865347 | jleroux | 2019-08-17 13:34:01 +0200 (sam. 17 août 2019) | 9 lignes

Fixed: Issue loading solr component (JNDI timeout)

(OFBIZ-11156)

We need to provide a JNDI environment property for Solr to load faster

Fixes previous commit where I hastily harcoded in jndi.properties file

Used a system property which can be used to define a JNDI environment

property

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1865351 13f79535-47bb-0310-9956-ffa450edef68

"Applied fix from plugins for revision: 1865347" ------------------------------------------------------------------------ r1865347 | jleroux | 2019-08-17 13:34:01 +0200 (sam. 17 août 2019) | 9 lignes

Fixed: Issue loading solr component (JNDI timeout)

(OFBIZ-11156)

We need to provide a JNDI environment property for Solr to load faster

Fixes previous commit where I hastily harcoded in jndi.properties file

Used a system property which can be used to define a JNDI environment

property

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release18.12@1865350 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Issue loading solr component (JNDI timeout) (OFBIZ-11156)

We need to provide a JNDI environment property for Solr to load faster

Fixes previous commit where I hastily harcoded in jndi.properties file

Used a system property which can be used to define a JNDI environment

property

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1865347 13f79535-47bb-0310-9956-ffa450edef68

Improved: Update build.gradle to the latest dependencies (OFBIZ-11151) We can update Guava to v28: https://mvnrepository.com/artifact/org.apache.solr/solr-core/8.2.0.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1865336 13f79535-47bb-0310-9956-ffa450edef68

Improved: Update build.gradle to the latest dependencies (OFBIZ-11151)

Like for OFBIZ-10922 some updates were not possible. Please refer to the Jira

for more information

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1864973 13f79535-47bb-0310-9956-ffa450edef68

    • -1
    • +1
    ./home/solrdefault/conf/solrconfig.xml
  1. … 5 more files in changeset.
Improved: Inline ‘UtilGenerics#checkList’ (OFBIZ-11141)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1863492 13f79535-47bb-0310-9956-ffa450edef68

  1. … 4 more files in changeset.