Clone Tools
  • last updated 12 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed: Unable to remove items from onePageCheckout screen of e-commerce. (OFBIZ-10800)

Thanks Arpit Mor for reporting and Dhaval Wagela for the patch.

  1. … 1 more file in changeset.
Fixed: Unable to remove items from onePageCheckout screen of e-commerce. (OFBIZ-10800)

Thanks Arpit Mor for reporting and Dhaval Wagela for the patch.

  1. … 1 more file in changeset.
Fixed: Unable to remove items from onePageCheckout screen of e-commerce. (OFBIZ-10800)

Thanks Arpit Mor for reporting and Dhaval Wagela for the patch.

  1. … 1 more file in changeset.
Improved: Use Groovy Truth instead of UtilValidate Class in Groovy (OFBIZ-11064)

As we all know, Groovy is a powerful language with great built-in functions.

Groovy Truth[1] is one of them, which is not used properly in our code base.

We have used UtilValidate Class to validate arguments for Empty or NotEmpty,

which can easily be done in groovy with built-in functionality[1].

Current Code: if (UtilValidate.isNotEmpty(locations)) { ... }

Groovy Built-in Code: if (locations) { ... }

[1] - http://groovy-lang.org/semantics.html#Groovy-Truth

We need to careful for some points while we change this:

Like:

maxRetry = 0

if (!maxRetry)

{ // Not set, use a default maxRetry = -1 }

Because groovy evaluates zero to be false, it wouldn't be possible to set

maxRetry to zero. So it's best not to use groovy truth for null-checks on

numbers in some cases.

Thanks: Pawan Verma

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1860051 13f79535-47bb-0310-9956-ffa450edef68

  1. … 13 more files in changeset.
Applied fix from trunk for revision: 1850712 ===

Improved: Replace jQuery.bind() with jQuery.on()

(OFBIZ-10758)

As of jQuery 3.0, .bind() has been deprecated. It was superseded by the .on() method for attaching event handlers to a document.

Additional change:

Improved boolean returns with single statement, replacing if blocks with explicit boolean return.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release18.12@1850714 13f79535-47bb-0310-9956-ffa450edef68

  1. … 20 more files in changeset.
Improved: Replace jQuery.bind() with jQuery.on() (OFBIZ-10758) As of jQuery 3.0, .bind() has been deprecated. It was superseded by the .on() method for attaching event handlers to a document. Additional change: Improved boolean returns with single statement, replacing if blocks with explicit boolean return.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1850712 13f79535-47bb-0310-9956-ffa450edef68

  1. … 20 more files in changeset.
Applied fix from trunk for revision: 1838816 ===

Fixed: Java object rendering on billing section of one page anonymous checkout process.

(OFBIZ-10425)

Thanks Jason Hao for reporting and Priya Sharma for providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1838818 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Java object rendering on billing section of one page anonymous checkout process. (OFBIZ-10425) Thanks Jason Hao for reporting and Priya Sharma for providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1838816 13f79535-47bb-0310-9956-ffa450edef68

Applied fix from trunk for revision: 1836107 === Fixed: UI issue on blog screens on storefront (OFBIZ-10466) Thanks: Pritam Kute for reporting the issue and providing the patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1836108 13f79535-47bb-0310-9956-ffa450edef68

Fixed: UI issue on blog screens on storefront (OFBIZ-10466) Thanks: Pritam Kute for reporting the issue and providing the patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1836107 13f79535-47bb-0310-9956-ffa450edef68

Completed: Remove applet concept in OFBiz (OFBIZ-10094)

Completes r1818646, again forgot the plugins :/

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1819019 13f79535-47bb-0310-9956-ffa450edef68

  1. … 3 more files in changeset.
Improved: Restructuring of ecommerce container according to responsive behaviour of bootstrap (OFBIZ-10106) Thanks Parakh Maheshwari for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1819000 13f79535-47bb-0310-9956-ffa450edef68

  1. … 4 more files in changeset.
Improved: Updated footer markup, now footer will be render properly on all pages. Thanks Parakh for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1818789 13f79535-47bb-0310-9956-ffa450edef68

  1. … 3 more files in changeset.
Improved: Update markup of Product Detail page according to standard markup given by Bootstrap v4.0.s (OFBIZ-10099) Thanks Mayank Lambhate for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1818787 13f79535-47bb-0310-9956-ffa450edef68

  1. … 3 more files in changeset.
Improved: Using Bootstrap Framework for E-Commerce Website (OFBIZ-9760) Applied patch from jira issue. Now Header and footer will be according to bootstrap markup. Thanks Mayank, Parakh and Saurabh for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1816274 13f79535-47bb-0310-9956-ffa450edef68

  1. … 7 more files in changeset.
Improved: Moved form.css and reset.css from common theme to ecommerce plugin as its only for ecommerce. (OFBIZ-9771)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1811223 13f79535-47bb-0310-9956-ffa450edef68

Improved: Moved ecommain.css from common theme to ecommerce plugin as its only for ecommerce. (OFBIZ-9771)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1811221 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +1826
    ./ecommain.css
Applied patch from jira issue - OFBIZ-7705 - Remove Google Checkout component from specialpurpose as it was discontinued. Thanks Ravi for removing the reference of Google Checkout from everywhere.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1751393 13f79535-47bb-0310-9956-ffa450edef68

  1. … 6 more files in changeset.
Applied patch from jira issue OFBIZ-4569 - Update address dialog shows multiple CommonUpdatingData when required field is missing. ============================================================================================ Open update address dialog (profile->Manage Addresses->Edit) Remove one of the required field. Hit submit couple of times. You need notice, it shows 'CommonUpdatingData' at the top.

It should validate the form before adding the label.

============================================================================================

Thanks Kiran for reporting the issue, Thanks Deepak for providing the patch for this issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1639859 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
A patch from K Sharad Bhushan "An issue on billing error messages display" https://issues.apache.org/jira/browse/OFBIZ-4736

Billing error messages are displayed in shipping address section, instead of billing address section

Just a element "id" change..

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1305053 13f79535-47bb-0310-9956-ffa450edef68

Errors from ajax calls weren't being handled properly after the migration to jQuery.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1302219 13f79535-47bb-0310-9956-ffa450edef68

CVE-2012-1621: Escape errors returned from ajax calls in the checkout pages

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1302218 13f79535-47bb-0310-9956-ffa450edef68

OnePageCheckout creates new billing/shipping phone number even if user selects the default values (https://issues.apache.org/jira/browse/OFBIZ-4446, https://issues.apache.org/jira/browse/OFBIZ-4447) A patch from Kiran Gawd.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1203129 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
UPDATE: Ajax callings in CheckoutProcess.js are not handling server-side errors correctly (https://issues.apache.org/jira/browse/OFBIZ-4342) A patch from Jonatan Soto: All methods that do ajax calls in CheckoutProcess.js are not dealing with the server-side errors. They should be treated in the success callback using an existing method called getServerError(data). This method looks for the _ERROR_MESSAGE* keys of the JSON object returned by the server.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1179340 13f79535-47bb-0310-9956-ffa450edef68

Update - Update the jQuery library to version 1.5.1. A few changes were necessary for this step. I updated the jQuery flot library to the current release, because the old one doesn't work with the new jQuery version, i also updated the jsTree Plugin to make it work with the new jQuery Version.

Note in jQuery 1.5 the implementation of the ajax function has been changed.

For more Information have a look at: http://blog.jquery.com/2011/01/31/jquery-15-released/

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1082916 13f79535-47bb-0310-9956-ffa450edef68

  1. … 5 more files in changeset.
A patch from Sascha Rodekamp "jQuery ecommerce onepagecheckout issue" (https://issues.apache.org/jira/browse/OFBIZ-4067) - OFBIZ-4067

Rohit reported a bug in the jQuery implementation (ecommerce):

With the jQuery branch being merged into the trunk, 2 new issues have been identified in the onepagecheckout, and they are:

1) the remove item link does not work in the shoppingcart panel, and

2) the cart is not updated if cart quantity is changed or promo codes are entered.

There was also a caching problem in IE.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1056672 13f79535-47bb-0310-9956-ffa450edef68

3 patches from Sascha Rodekamp "Localisation of labels in javascript" (https://issues.apache.org/jira/browse/OFBIZ-3964) - OFBIZ-3964

This cames from Adam's advice: http://markmail.org/message/kai5lfvlnsz7xwki

Sascha comes to this solution

The Idea is to have a method which takes a JSON Object with uiLabel Resources and label entries and returns the resolved labels in a JSON Object which can be used directly in the JS Code.

The advantage of this way, is that we have only one Ajax request which reads all labels. The alternative is an Ajax request for each label, which simplify the request (because you haven't to create a complex JSON Object) but is very expansive.

* Replaces all JS alerts with the new fancy error boxes

* Adds a few uiLabels

I simply fixed some typos. I did not test all cases but did a good review.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1056497 13f79535-47bb-0310-9956-ffa450edef68

  1. … 6 more files in changeset.
Merges the jQuery branch back to the trunk

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1044503 13f79535-47bb-0310-9956-ffa450edef68

  1. … 50 more files in changeset.
make the blog more presentable and it looks it is now working again. Nice implementation by Al Beyers This blog is a nice demo to show the possibilities of the ofbiz content component

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1001622 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Some places in ofbiz were doing dom manipulation without waiting for the dom to be finished loading. Wrap such code with a dom:loaded observer.

Also, change all window->load calls to dom:loaded observers. The former

happens after all images have finished loading, while the later happens

just after the dom has finished parsing. This is better, as sometimes

the images may take a long time to finish downloading, and until they do,

none of the manipulation will take place.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@997420 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.