Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Corrected some line is longer than 150 characters checkstyle issues. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)

  1. … 46 more files in changeset.
Improved: Corrected all incorrect indentation level issues in plugins component, also fixed some case indentation checkstyle issues. (OFBIZ-11922)

  1. … 15 more files in changeset.
Improved: Updated case indentation to 0 for all switch statements in plugins component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904)

  1. … 16 more files in changeset.
Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in plugins component. (OFBIZ-11886)

  1. … 35 more files in changeset.
Documented: migrate help link to asciidoc user manual for Plugin Ebay (OFBIZ-11587)

All files have been migrated to asciidoc format and help link now point

to the html file generated from the asciidoc files

In the global Help Docbook index tree, remove all points about

Ebay and add a short page with a link to the new help

Remove docbook help files for Ebay

    • -0
    • +35
    ./data/HELP_EBAY.xml
    • -47
    • +0
    ./data/helpdata/HELP_EBAY_EditEbayConfiguration.xml
    • -41
    • +0
    ./data/helpdata/HELP_EBAY_Features.xml
    • -47
    • +0
    ./data/helpdata/HELP_EBAY_ManageOrdersFromEbay.xml
    • -57
    • +0
    ./data/helpdata/HELP_EBAY_ProductsExportToEbay.xml
    • -47
    • +0
    ./data/helpdata/HELP_EBAY_eBayOrders.xml
  1. … 1 more file in changeset.
Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in plugins component. (OFBIZ-11887)

  1. … 22 more files in changeset.
Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in plugins component. (OFBIZ-11880) Thanks Jacques for review.

  1. … 58 more files in changeset.
Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for plugins component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace.

'{' is not followed by whitespace.

'}' is not followed by whitespace.

'}' is not preceded with whitespace.

'typecast' is not followed by whitespace.

'try' is not followed by whitespace.

';' is preceded with whitespace.

  1. … 29 more files in changeset.
Improved: Merge identical catch blocks in single catch block(OFBIZ-11827)

In Java SE 7 and later, a single catch block can handle more than one type of exception. This feature can reduce code duplication and lessen the temptation to catch an overly broad exception.

Thanks: Jacques for the review.

  1. … 21 more files in changeset.
Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component. (#28)

* Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component.

(OFBIZ-11804)

Improved: Change resources with proper naming convention in all plugin components. (OFBIZ-11739) Also, made MODULE as private data member of class instead of public. Thanks Jacques for review.

  1. … 60 more files in changeset.
Improved: Apply multi-block attr to each application (OFBIZ-11706)

For remaining plugin applications.

    • -2
    • +0
    ./template/find/EbayAdvancedSearch.ftl
  1. … 16 more files in changeset.
Documented: ofbiz-plugins / ebay, migration for Help docbook file to asciidoc (OFBIZ-11587)

- ebay.adoc call (with include) other files

    • -0
    • +38
    ./src/docs/asciidoc/_include/ebay-ShippingMethods.adoc
    • -0
    • +55
    ./src/docs/asciidoc/_include/ebay-configurations.adoc
    • -0
    • +59
    ./src/docs/asciidoc/_include/ebay-export-to-ebay.adoc
    • -0
    • +36
    ./src/docs/asciidoc/_include/ebay-import-orders.adoc
    • -0
    • +37
    ./src/docs/asciidoc/_include/ebay-import-single-transaction.adoc
    • -0
    • +52
    ./src/docs/asciidoc/_include/ebay-intro.adoc
    • -0
    • +29
    ./src/docs/asciidoc/_include/ebay-search-product.adoc
    • -0
    • +50
    ./src/docs/asciidoc/ebay.adoc
Improved: replaces module by MODULE everywhere

    • -41
    • +41
    ./src/main/java/org/apache/ofbiz/ebay/EbayHelper.java
  1. … 70 more files in changeset.
Fixed: Ensure that the SameSite attribute is set to 'strict' for all cookies.

(OFBIZ-11470)

As reported by OWASP ZAP:

A cookie has been set without the SameSite attribute, which means that the

cookie can be sent as a result of a 'cross-site' request. The SameSite attribute

is an effective counter measure to cross-site request forgery, cross-site script

inclusion, and timing attacks.

The solution was not obvious in OFBiz for 2 reasons:

1. There is no HttpServletResponse::setHeader. So we need to use a filter

(SameSiteFilter) and even that is not enough because of 2:

2. To prevent session fixation we force Tomcat to generates a new jsessionId,

ultimately put in cookie, in LoginWorker::login. So we need to add a call to

SameSiteFilter::addSameSiteCookieAttribute in

UtilHttp::setResponseBrowserDefaultSecurityHeaders.

  1. … 20 more files in changeset.
Fixed: Ensure that the SameSite attribute is set to 'strict' for all cookies.

(OFBIZ-11470)

As reported by OWASP ZAP:

A cookie has been set without the SameSite attribute, which means that the

cookie can be sent as a result of a 'cross-site' request. The SameSite attribute

is an effective counter measure to cross-site request forgery, cross-site script

inclusion, and timing attacks.

The solution was not obvious in OFBiz for 2 reasons:

1. There is no HttpServletResponse::setHeader. So we need to use a filter

(SameSiteFilter) and even that is not enough because of 2:

2. To prevent session fixation we force Tomcat to generates a new jsessionId,

ultimately put in cookie, in LoginWorker::login. So we need to add a call to

SameSiteFilter::addSameSiteCookieAttribute in

UtilHttp::setResponseBrowserDefaultSecurityHeaders.

  1. … 20 more files in changeset.
Fixed: Ensure that the SameSite attribute is set to 'strict' for all cookies.

(OFBIZ-11470)

As reported by OWASP ZAP:

A cookie has been set without the SameSite attribute, which means that the

cookie can be sent as a result of a 'cross-site' request. The SameSite attribute

is an effective counter measure to cross-site request forgery, cross-site script

inclusion, and timing attacks.

The solution was not obvious in OFBiz for 2 reasons:

1. There is no HttpServletResponse::setHeader. So we need to use a filter

(SameSiteFilter) and even that is not enough because of 2:

2. To prevent session fixation we force Tomcat to generates a new jsessionId,

ultimately put in cookie, in LoginWorker::login. So we need to add a call to

SameSiteFilter::addSameSiteCookieAttribute in

UtilHttp::setResponseBrowserDefaultSecurityHeaders.

  1. … 20 more files in changeset.
Improved: Added all the service level error messages for missing required field for plugins/ebay component. (OFBIZ-7471)

Thanks Jagpreet for reporting and Anushi Gupta for the patch.

Fixed: Add XML declaration in “web.xml” files (OFBIZ-6993)

These declarations avoid SAXParseException traceback when parsing web.xml

the first time in WebappUtil.parseWebXmlFile

A schema conformance issue has been fixed in ecommerce “web.xml”.

(cherry picked from commit 1158664ba37264fa6b8429033bad768175ff10d5)

# Conflicts handled by hand

# msggateway/webapp/msggateway/WEB-INF/web.xml

  1. … 25 more files in changeset.
Fixed: Add XML declaration in “web.xml” files (OFBIZ-6993)

These declarations avoid SAXParseException traceback when parsing web.xml

the first time in WebappUtil.parseWebXmlFile

A schema conformance issue has been fixed in ecommerce “web.xml”.

  1. … 25 more files in changeset.
Fixed: Add XML declaration in “web.xml” files (OFBIZ-6993)

These declarations avoid SAXParseException traceback when parsing web.xml

the first time in WebappUtil.parseWebXmlFile

A schema conformance issue has been fixed in ecommerce “web.xml”.

# Conflicts handled by hand

# msggateway/webapp/msggateway/WEB-INF/web.xml

  1. … 25 more files in changeset.
Improved: no functional change We use HSTS but anyway replaces HTTP by HTTPS in some data.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1869102 13f79535-47bb-0310-9956-ffa450edef68

  1. … 2 more files in changeset.
Improved: Inline ‘UtilGenerics#checkList’ (OFBIZ-11141)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1863492 13f79535-47bb-0310-9956-ffa450edef68

  1. … 5 more files in changeset.
Improved: Inline ‘UtilGenerics#checkMap’ (OFBIZ-11141)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1863491 13f79535-47bb-0310-9956-ffa450edef68

  1. … 4 more files in changeset.
Improved: Use ‘UtilGenerics#checkCollection’ when possible (OFBIZ-11141)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1863488 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Improved: Remove redundant type declarations (OFBIZ-10937)

Since Java 1.7, when defining generic types it is unnecessary to

redefine those types in the constructor when it is already done in the

declared type.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1860025 13f79535-47bb-0310-9956-ffa450edef68

    • -10
    • +10
    ./src/main/java/org/apache/ofbiz/ebay/EbayHelper.java
  1. … 40 more files in changeset.
Improved: Missing uiLabel for Create New on CMS Content Find Screen (OFBIZ-11005)

Steps to regenerate:

Go to https://demo-trunk.ofbiz.apache.org/content/control/CMSContentFind

Find missing uiLabel for Create New, showing as CommonCreateNew.

jleroux: This is related with OFBIZ-9905, we decided to use only CommonCreate

This do that and fix others which were missing in OFBIZ-9905

Thanks: Pawan Verma for report, Suraj for comment

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1858516 13f79535-47bb-0310-9956-ffa450edef68

  1. … 5 more files in changeset.
Applied fix from trunk for revision: 1853904 ===

Improved: Updated plugin code to fix console warning related to deprecated method. Removed Double constructor call as its depracated since jdk 9. Also replace the CellType::getCellTypeEnum method call with CellTyoe::getCellType

(OFBIZ-10757)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release18.12@1854692 13f79535-47bb-0310-9956-ffa450edef68

  1. … 6 more files in changeset.
Improved: Updated plugin code to fix console warning related to deprecated method. Removed Double constructor call as its depracated since jdk 9. Also replace the CellType::getCellTypeEnum method call with CellTyoe::getCellType (OFBIZ-10757)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1853904 13f79535-47bb-0310-9956-ffa450edef68

  1. … 6 more files in changeset.
"Applied fix from plugins for revision: 1851068 " ------------------------------------------------------------------------ r1851068 | jleroux | 2019-01-11 17:12:01 +0100 (ven. 11 janv. 2019) | 12 lignes

Fixed: Add session tracking mode and make cookie secure

(OFBIZ-6655)

Following "Session timeout for webapps" discussion on dev ML

https://markmail.org/message/p6fbiojjrwb2ybxd

We decided to put back the session-timeout value in web.xml files and to remove

the line

session.setMaxInactiveInterval(60*60); //in seconds

from ControlEventListener.java

Thanks: Deepak Nigam for report and Girish Vasmatkar for discussion

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release18.12@1851073 13f79535-47bb-0310-9956-ffa450edef68

  1. … 22 more files in changeset.