Clone Tools
  • last updated 27 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Corrected some line is longer than 150 characters checkstyle issues. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)

    • -39
    • +51
    ./main/java/org/apache/ofbiz/birt/BirtWorker.java
  1. … 38 more files in changeset.
Improved: Corrected all incorrect indentation level issues in plugins component, also fixed some case indentation checkstyle issues. (OFBIZ-11922)

  1. … 15 more files in changeset.
Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in plugins component. (OFBIZ-11886)

  1. … 33 more files in changeset.
Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in plugins component. (OFBIZ-11887)

  1. … 21 more files in changeset.
Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in plugins component. (OFBIZ-11880) Thanks Jacques for review.

  1. … 55 more files in changeset.
Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for plugins component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace.

'{' is not followed by whitespace.

'}' is not followed by whitespace.

'}' is not preceded with whitespace.

'typecast' is not followed by whitespace.

'try' is not followed by whitespace.

';' is preceded with whitespace.

    • -1
    • +1
    ./main/java/org/apache/ofbiz/birt/BirtWorker.java
  1. … 29 more files in changeset.
Improved: Corrected all checkstyle issues related to succeeding space for comma in plugins directory. (OFBIZ-11805) Thanks Jacques and Ritesh Kumar for review.

  1. … 13 more files in changeset.
Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review.

  1. … 11 more files in changeset.
Improved: Change resources with proper naming convention in all plugin components. (OFBIZ-11739) Also, made MODULE as private data member of class instead of public. Thanks Jacques for review.

    • -2
    • +2
    ./main/java/org/apache/ofbiz/birt/BirtWorker.java
  1. … 57 more files in changeset.
Documented: ofbiz-plugins / Birt, review existing adoc and migration for Help docbook file to asciidoc (OFBIZ-11587)

* add license in each file, and remove trailing space

* better numberer list management

* add section Birt in Ofbiz user screen with help migrated file

    • -55
    • +71
    ./docs/asciidoc/_include/bt-creating reports.adoc
    • -0
    • +75
    ./docs/asciidoc/_include/bt-help.adoc
  1. … 1 more file in changeset.
Improved: replaces module by MODULE everywhere

    • -6
    • +6
    ./main/java/org/apache/ofbiz/birt/BirtWorker.java
  1. … 62 more files in changeset.
Improved: no functional change This file inadvertently slipped in with a previous commit, it's not needed.

    • -41
    • +0
    ./docs/asciidoc/images/OFBiz-Logo.svg
Improved: no functional change This file inadvertently slipped in with a previous commit, it's not needed.

    • -41
    • +0
    ./docs/asciidoc/images/OFBiz-Logo.svg
Improved: no functional change This file inadvertently slipped in with a previous commit, it's not needed.

    • -41
    • +0
    ./docs/asciidoc/images/OFBiz-Logo.svg
Improved: no functional change

This was added for OFBIZ-9198 but was superfluous since the same is already in

the included ecommerce controller

    • -0
    • +41
    ./docs/asciidoc/images/OFBiz-Logo.svg
  1. … 1 more file in changeset.
Improved: no functional change

This was added for OFBIZ-9198 but was superfluous since the same is already in

the included ecommerce controller

    • -0
    • +41
    ./docs/asciidoc/images/OFBiz-Logo.svg
  1. … 1 more file in changeset.
Improved: no functional change

This was added for OFBIZ-9198 but was superfluous since the same is already in

the included ecommerce controller

    • -0
    • +41
    ./docs/asciidoc/images/OFBiz-Logo.svg
  1. … 1 more file in changeset.
Improved: Inline ‘UtilGenerics#checkList’ (OFBIZ-11141)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1863492 13f79535-47bb-0310-9956-ffa450edef68

  1. … 5 more files in changeset.
Improved: Inline ‘UtilGenerics#checkMap’ (OFBIZ-11141)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1863491 13f79535-47bb-0310-9956-ffa450edef68

  1. … 2 more files in changeset.
Improved: Use the ‘@Override’ annotation (OFBIZ-10939)

The ‘@Override’ annotation helps readers understand that the method at

hand is overriding a super class or implementing an interface.

Additionally it allows the compiler to check if the methods annotated

with ‘@Override’ are actually implementing an abstract method.

Using that annotation makes ‘@see foo.bar.ParentClass#myMethod’

comments useless, so those they have been removed for the newly

annotated methods.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1860028 13f79535-47bb-0310-9956-ffa450edef68

  1. … 16 more files in changeset.
Improved: Remove redundant type declarations (OFBIZ-10937)

Since Java 1.7, when defining generic types it is unnecessary to

redefine those types in the constructor when it is already done in the

declared type.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1860025 13f79535-47bb-0310-9956-ffa450edef68

  1. … 40 more files in changeset.
"Applied fix from plugins for revision: 1859735 " ------------------------------------------------------------------------ r1859735 | jleroux | 2019-05-22 18:41:04 +0200 (mer. 22 mai 2019) | 12 lignes

Fixed: massPrintOrders service does not work

(OFBIZ-11049)

This problem was similar to what was resolved by r1806237 for OFBIZ-9138.

This fixes it by using the same solution than in r1806237. If the visual theme

is unknown in the the service context get the default theme from

general.properties using ThemeFactory::resolveTheme.

sendPrintFromScreen, createFileFromScreen, sendBirtMail, getXslFo and

printReportPdf (in example) were concerned

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1859739 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
"Applied fix from plugins for revision: 1859735 " ------------------------------------------------------------------------ r1859735 | jleroux | 2019-05-22 18:41:04 +0200 (mer. 22 mai 2019) | 12 lignes

Fixed: massPrintOrders service does not work

(OFBIZ-11049)

This problem was similar to what was resolved by r1806237 for OFBIZ-9138.

This fixes it by using the same solution than in r1806237. If the visual theme

is unknown in the the service context get the default theme from

general.properties using ThemeFactory::resolveTheme.

sendPrintFromScreen, createFileFromScreen, sendBirtMail, getXslFo and

printReportPdf (in example) were concerned

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release18.12@1859737 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Fixed: massPrintOrders service does not work (OFBIZ-11049)

This problem was similar to what was resolved by r1806237 for OFBIZ-9138.

This fixes it by using the same solution than in r1806237. If the visual theme

is unknown in the the service context get the default theme from

general.properties using ThemeFactory::resolveTheme.

sendPrintFromScreen, createFileFromScreen, sendBirtMail, getXslFo and

printReportPdf (in example) were concerned

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1859735 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
"Applied fix from plugins for revision: 1849119" ------------------------------------------------------------------------ r1849119 | jleroux | 2018-12-17 18:42:20 +0100 (lun. 17 déc. 2018) | 5 lignes

Improved: Plugins Asciidoc documentation must be standalone

(OFBIZ-10658)

Removes toc information after ":toclevels:" 3 is used in build.gradle

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1849162 13f79535-47bb-0310-9956-ffa450edef68

Improved: Plugins Asciidoc documentation must be standalone (OFBIZ-10658)

Removes toc information after ":toclevels:" 3 is used in build.gradle

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1849119 13f79535-47bb-0310-9956-ffa450edef68

Improved: Fix or Silence various warnings (OFBIZ-10701)

In order to detect potential issues early, the linting compiler option should be

used by default and disabled with {{./gradlew -PXlint:none build}}.

Additionally it is important to reduce the number of warnings otherwise new

warnings will remain unnoticed.

The warning related to the com.googlecode.concurrentlinkedhashmap dependency

should resolves itself once we handle upgrade to Caffeine like proposed in

OFBIZ-6747.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1848673 13f79535-47bb-0310-9956-ffa450edef68

    • -4
    • +0
    ./main/java/org/apache/ofbiz/birt/BirtWorker.java
  1. … 24 more files in changeset.
Fixed: Standalone Asciidoc plugins documents can't render logo correctly in PDF (OFBIZ-10677)

Forgot to commit the birt.adoc file with the way to generate the logo

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1848396 13f79535-47bb-0310-9956-ffa450edef68

Documented: Standalone Asciidoc plugins documents can't render logo correctly in PDF (OFBIZ-10677)

It does not work, I'll revisit that later.

Using Buildbot to copy the logo locally would work, but only to generate for us.

Not for users who would want to generate locally. They could use a manual copy.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1847708 13f79535-47bb-0310-9956-ffa450edef68

"Applied fix from plugins for revision: 1847272 " ------------------------------------------------------------------------ r1847272 | jleroux | 2018-11-23 15:27:05 +0100 (ven. 23 nov. 2018) | 10 lignes

Fixed: Plugins Asciidoc documentation must be standalone

(OFBIZ-10658)

Completes the standalone document part as required by guidelines.

Note that using ":toclevels: 3" does not work when generating with Gradle

because of the OOTB definition "'toclevels': '5'" in build.gradle

It does when used apart in Asciidoc editors. I believe OOTB a 3 levels is enough

and the numbers are superfluous if not unpleasant.

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/branches/release17.12@1847274 13f79535-47bb-0310-9956-ffa450edef68