Clone Tools
  • last updated 24 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Corrected some line is longer than 150 characters checkstyle issues. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)

    • -39
    • +51
    ./src/main/java/org/apache/ofbiz/birt/BirtWorker.java
  1. … 38 more files in changeset.
Improved: Inconsistent String Comparisons(OFBIZ-9254)

There are some inconsistencies in the code for string comparison statusId.equals(PRUN_COMPLETED) whereas it should be written as PRUN_COMPLETED.equals(statusId) cause the former can throw NullPointerException if the variable found to be NULL.

Thanks: Devanshu for your contribution.

    • -12
    • +12
    ./groovyScripts/order/CheckReportBy.groovy
    • -2
    • +2
    ./groovyScripts/order/NetBeforeOverheadReport.groovy
  1. … 11 more files in changeset.
Improved: Corrected all incorrect indentation level issues in plugins component, also fixed some case indentation checkstyle issues. (OFBIZ-11922)

  1. … 15 more files in changeset.
Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in plugins component. (OFBIZ-11886)

  1. … 33 more files in changeset.
Improved: Use Error.ftl everywhere it's not yet used (OFBIZ-11890)

Removes all error*.jsp reference, no longer used

  1. … 21 more files in changeset.
Documented: migrate help link to asciidoc user manual for Plugin BIRT (OFBIZ-11587)

All files have been migrated to asciidoc format and help link now point

to the html file generated from the asciidoc files

In the global Help Docbook index tree, change BIRT help page to a short

page with a link to the new help

Remove docbook help files for BIRT

Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in plugins component. (OFBIZ-11887)

  1. … 21 more files in changeset.
Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in plugins component. (OFBIZ-11880) Thanks Jacques for review.

  1. … 55 more files in changeset.
Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for plugins component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace.

'{' is not followed by whitespace.

'}' is not followed by whitespace.

'}' is not preceded with whitespace.

'typecast' is not followed by whitespace.

'try' is not followed by whitespace.

';' is preceded with whitespace.

  1. … 29 more files in changeset.
Improved: Corrected all checkstyle issues related to succeeding space for comma in plugins directory. (OFBIZ-11805) Thanks Jacques and Ritesh Kumar for review.

  1. … 13 more files in changeset.
Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review.

  1. … 11 more files in changeset.
[Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762) (#24)

* [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

* [Improved]: Updated all ocurances where we only needed to pass the throwable object, without a message

- We have now added one more utility method to handle these cases. (OFBIZ-11762)

Co-authored-by: Priya Sharma <priya.sharma@example.com>

    • -3
    • +1
    ./groovyScripts/accounting/AcctgTransEntriesSearchResultsParameters.groovy
    • -4
    • +1
    ./groovyScripts/accounting/IncomeStatementParameters.groovy
    • -3
    • +1
    ./groovyScripts/accounting/InvoiceAcctgTransEntryParameters.groovy
    • -3
    • +1
    ./groovyScripts/accounting/PaymentAcctgTransEntryParameters.groovy
    • -2
    • +1
    ./groovyScripts/order/NetBeforeOverheadReport.groovy
    • -2
    • +1
    ./groovyScripts/order/ProductDemandReport.groovy
    • -2
    • +1
    ./groovyScripts/order/SalesReport.groovy
  1. … 20 more files in changeset.
Improved: Change resources with proper naming convention in all plugin components. (OFBIZ-11739) Also, made MODULE as private data member of class instead of public. Thanks Jacques for review.

  1. … 57 more files in changeset.
Documented: ofbiz-plugins / Birt, review existing adoc and migration for Help docbook file to asciidoc (OFBIZ-11587)

* add license in each file, and remove trailing space

* better numberer list management

* add section Birt in Ofbiz user screen with help migrated file

    • -0
    • +75
    ./src/docs/asciidoc/_include/bt-help.adoc
  1. … 1 more file in changeset.
Improved: replaces module by MODULE everywhere

  1. … 62 more files in changeset.
Fixed: Ensure that the SameSite attribute is set to 'strict' for all cookies.

(OFBIZ-11470)

As reported by OWASP ZAP:

A cookie has been set without the SameSite attribute, which means that the

cookie can be sent as a result of a 'cross-site' request. The SameSite attribute

is an effective counter measure to cross-site request forgery, cross-site script

inclusion, and timing attacks.

The solution was not obvious in OFBiz for 2 reasons:

1. There is no HttpServletResponse::setHeader. So we need to use a filter

(SameSiteFilter) and even that is not enough because of 2:

2. To prevent session fixation we force Tomcat to generates a new jsessionId,

ultimately put in cookie, in LoginWorker::login. So we need to add a call to

SameSiteFilter::addSameSiteCookieAttribute in

UtilHttp::setResponseBrowserDefaultSecurityHeaders.

  1. … 17 more files in changeset.
Fixed: Ensure that the SameSite attribute is set to 'strict' for all cookies.

(OFBIZ-11470)

As reported by OWASP ZAP:

A cookie has been set without the SameSite attribute, which means that the

cookie can be sent as a result of a 'cross-site' request. The SameSite attribute

is an effective counter measure to cross-site request forgery, cross-site script

inclusion, and timing attacks.

The solution was not obvious in OFBiz for 2 reasons:

1. There is no HttpServletResponse::setHeader. So we need to use a filter

(SameSiteFilter) and even that is not enough because of 2:

2. To prevent session fixation we force Tomcat to generates a new jsessionId,

ultimately put in cookie, in LoginWorker::login. So we need to add a call to

SameSiteFilter::addSameSiteCookieAttribute in

UtilHttp::setResponseBrowserDefaultSecurityHeaders.

  1. … 17 more files in changeset.
Fixed: Ensure that the SameSite attribute is set to 'strict' for all cookies.

(OFBIZ-11470)

As reported by OWASP ZAP:

A cookie has been set without the SameSite attribute, which means that the

cookie can be sent as a result of a 'cross-site' request. The SameSite attribute

is an effective counter measure to cross-site request forgery, cross-site script

inclusion, and timing attacks.

The solution was not obvious in OFBiz for 2 reasons:

1. There is no HttpServletResponse::setHeader. So we need to use a filter

(SameSiteFilter) and even that is not enough because of 2:

2. To prevent session fixation we force Tomcat to generates a new jsessionId,

ultimately put in cookie, in LoginWorker::login. So we need to add a call to

SameSiteFilter::addSameSiteCookieAttribute in

UtilHttp::setResponseBrowserDefaultSecurityHeaders.

  1. … 17 more files in changeset.
Improvement: Dropdown/facet at Reports under 'Sale Orders By Channel' is not working fine (OFBIZ-10624)

Thanks, Ritesh Kumar and Dikpal Kanungo for your contribution.

Improvement: Print and Export of ViewFacilityInventoryByProduct report into new window (OFBIZ-10526)

Thanks, Sourabh Punyani and Pierre Smits for your contribution.

  1. … 1 more file in changeset.
Improved: no functional change This file inadvertently slipped in with a previous commit, it's not needed.

    • -41
    • +0
    ./src/docs/asciidoc/images/OFBiz-Logo.svg
Improved: no functional change This file inadvertently slipped in with a previous commit, it's not needed.

    • -41
    • +0
    ./src/docs/asciidoc/images/OFBiz-Logo.svg
Improved: no functional change This file inadvertently slipped in with a previous commit, it's not needed.

    • -41
    • +0
    ./src/docs/asciidoc/images/OFBiz-Logo.svg
Improved: no functional change

This was added for OFBIZ-9198 but was superfluous since the same is already in

the included ecommerce controller

    • -0
    • +41
    ./src/docs/asciidoc/images/OFBiz-Logo.svg
  1. … 1 more file in changeset.
Improved: no functional change

This was added for OFBIZ-9198 but was superfluous since the same is already in

the included ecommerce controller

    • -0
    • +41
    ./src/docs/asciidoc/images/OFBiz-Logo.svg
  1. … 1 more file in changeset.
Improved: no functional change

This was added for OFBIZ-9198 but was superfluous since the same is already in

the included ecommerce controller

    • -0
    • +41
    ./src/docs/asciidoc/images/OFBiz-Logo.svg
  1. … 1 more file in changeset.
Fixed: Add XML declaration in “web.xml” files (OFBIZ-6993)

These declarations avoid SAXParseException traceback when parsing web.xml

the first time in WebappUtil.parseWebXmlFile

A schema conformance issue has been fixed in ecommerce “web.xml”.

(cherry picked from commit 1158664ba37264fa6b8429033bad768175ff10d5)

# Conflicts handled by hand

# msggateway/webapp/msggateway/WEB-INF/web.xml

  1. … 22 more files in changeset.
Fixed: Add XML declaration in “web.xml” files (OFBIZ-6993)

These declarations avoid SAXParseException traceback when parsing web.xml

the first time in WebappUtil.parseWebXmlFile

A schema conformance issue has been fixed in ecommerce “web.xml”.

  1. … 22 more files in changeset.
Fixed: Add XML declaration in “web.xml” files (OFBIZ-6993)

These declarations avoid SAXParseException traceback when parsing web.xml

the first time in WebappUtil.parseWebXmlFile

A schema conformance issue has been fixed in ecommerce “web.xml”.

# Conflicts handled by hand

# msggateway/webapp/msggateway/WEB-INF/web.xml

  1. … 22 more files in changeset.
Improved: Inline ‘UtilGenerics#checkList’ (OFBIZ-11141)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1863492 13f79535-47bb-0310-9956-ffa450edef68

  1. … 5 more files in changeset.