rainbowstone

Clone Tools
  • last updated 20 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Cannot find the declaration of element 'web-app' in version 3.0 files. (OFBIZ-6993)

I missed to backport changes web.xml (was OK in plugins)

  1. … 24 more files in changeset.
Fixed: With Rainbow theme, a scrollbar appears at bottom where it's not needed (OFBIZ-10174)

With Rainbow theme, even in large screens, a scrollbar appears at bottom where

it's useless.

The CSS which is adding a border-right on the application bar is adding extra

1px width causing this issue. Attached the patch to remove extra width for the

same.

Changes made by hand

Fixed: With Rainbow theme, a scrollbar appears at bottom where it's not needed (OFBIZ-10174)

With Rainbow theme, even in large screens, a scrollbar appears at bottom where

it's useless.

The CSS which is adding a border-right on the application bar is adding extra

1px width causing this issue. Attached the patch to remove extra width for the

same.

Thanks: Nameet Jain for the patch

Fixed: With Rainbow theme, a scrollbar appears at bottom where it's not needed (OFBIZ-10174)

With Rainbow theme, even in large screens, a scrollbar appears at bottom where

it's useless.

The CSS which is adding a border-right on the application bar is adding extra

1px width causing this issue. Attached the patch to remove extra width for the

same.

Thanks: Nameet Jain for the patch

Improved: Rainbow theme: use the United Nations flag ad default flag (OFBIZ-11705)

Oops, I missed to add the un flag files

    • -0
    • +68
    ./webapp/rainbowstone/flags/1x1/un.svg
    • -0
    • +68
    ./webapp/rainbowstone/flags/4x3/un.svg
Improved: Rainbow theme: use the United Nations flag ad default flag (OFBIZ-11705)

This follows OFBIZ-9866: where I proposed to use the United Nations flag

as default flag

Pierre noticed that no flag shows when a meta language (like en) is chosen.

I noticed that some meta language have default values (gb, fr, zh, th). So I did

not apply Pierre's GH PR#154 to keep those, because that can be increased.

I added the un.svg flag from https://en.wikipedia.org/wiki/United_Nations

I did not adapt its size. Since it's SVG it should be OK in most cases

I also added the necessary change at the end of in flag-icon.min.css

Thanks: Pierre Smits for the initial patch

    • -1
    • +1
    ./webapp/rainbowstone/flag-icon.min.css
Improved: Headerize external script in multi-block html template (OFBIZ-11741)

Allow external scripts within the multi-block html template, to be rendered

within the html head tag, when a new attribute data-import is set to “head”

Thanks: Jacques for review

  1. … 21 more files in changeset.
Improved: <script-template> widget tag (OFBIZ-11686)

The new tag allows us to render a freemarker template containing javascript,

as external script in html instead of inline script.

This helps to reduce CSP errors.

  1. … 16 more files in changeset.
Improvement: Help link using asciidoc files via generated html (OFBIZ-11693)

1. Add a general property: userDocUri containing uri for

ofbiz.apache.org html user-documentation generated by Buildbot

2. in each theme, add a test on helpAnchor field, if it's define help

link is now on ${userDocUri}#${helpAnchor}

* if userDocUri is not defined, the general property is used

  1. … 4 more files in changeset.
Fixed: POC for CSRF Token (OFBIZ-11306)

Fixes missing default NoCsrfDefenseStrategy in Header.ftl files

  1. … 3 more files in changeset.
Revert "Merge branch 'JacquesLeRoux-POC-for-CSRF-Token-OFBIZ-11306' into trunk"

This reverts commit 27e57522b15d71352c61919befc6eb451ed4e864.

  1. … 26 more files in changeset.
Revert "Merge branch 'JacquesLeRoux-POC-for-CSRF-Token-OFBIZ-11306' into trunk"

This reverts commit 0add8bedbca231ffd839eb733f1041ce5487e9d6.

  1. … 36 more files in changeset.
Merge branch 'JacquesLeRoux-POC-for-CSRF-Token-OFBIZ-11306' into trunk Because of GitHub message on PR56: This branch cannot be rebased due to conflicts

Much Conflicts, but that should be OK

  1. … 26 more files in changeset.
Merge branch 'JacquesLeRoux-POC-for-CSRF-Token-OFBIZ-11306' into trunk Because of GitHub message on PR56: This branch cannot be rebased due to conflicts

Conflicts handled by hand

RequestHandler.java

  1. … 36 more files in changeset.
Improved: type="text/css" was missing on a call to <<link rel="stylesheet/less>>

This was reported by OWASP ZAP: "The Content-Type header is missing or empty."

Considered a low vulnerability

Improved: type="text/css" was missing on a call to <<link rel="stylesheet/less>>

This was reported by OWASP ZAP: "The Content-Type header is missing or empty."

Considered a low vulnerability

Fixed: CommonTheme has a dependency on Flatgrey application.js

(OFBIZ-11466)

In theme.xml of common-theme there is a reference to application.js residing in

the Flatgrey theme. This should not be. The file should be in common-theme.

Thanks: Pierre Smits for report and fix. I have just also removed

rainbowstone/js/application.js since it's now in common-theme

    • -201
    • +0
    ./webapp/rainbowstone/js/application.js
  1. … 4 more files in changeset.
Fixed: CommonTheme has a dependency on Flatgrey application.js

(OFBIZ-11466)

In theme.xml of common-theme there is a reference to application.js residing in

the Flatgrey theme. This should not be. The file should be in common-theme.

Thanks: Pierre Smits for report and fix. I have just also removed

rainbowstone/js/application.js since it's now in common-theme

    • -201
    • +0
    ./webapp/rainbowstone/js/application.js
  1. … 4 more files in changeset.
Fixed: CommonTheme has a dependency on Flatgrey application.js

(OFBIZ-11466)

In theme.xml of common-theme there is a reference to application.js residing in

the Flatgrey theme. This should not be. The file should be in common-theme.

Thanks: Pierre Smits for report and fix. I have just also removed

rainbowstone/js/application.js since it's now in common-theme

    • -201
    • +0
    ./webapp/rainbowstone/js/application.js
  1. … 4 more files in changeset.
Improved: unify style application

(OFBIZ-11458)

remove unused property 'align-float'

  1. … 5 more files in changeset.
Improved: unify style application

(OFBIZ-11458)

remove unused property 'align-float'

  1. … 5 more files in changeset.
Improved: style alignment properties

(OFBIZ-11458)

Adding alignment properties (creating consistency across themes.

  1. … 5 more files in changeset.
Improved: style alignment properties

(OFBIZ-11458)

Adding alignment properties (creating consistency across themes.

  1. … 5 more files in changeset.
Implemented: Remove the user login security question.

(OFBIZ-11244)

Thanks Wiebke Pätzold for providing the patch.

  1. … 17 more files in changeset.
Implemented: Remove the user login security question.

(OFBIZ-11244)

Thanks Wiebke Pätzold for providing the patch.

  1. … 17 more files in changeset.
Improved: Implemented: Documented: Completed: Reverted: Fixed: Improved: no functional change (OFBIZ-) Explanation Thanks:

  1. … 39 more files in changeset.
Creates new POC-for-CSRF-Token-OFBIZ-11306 branch

To share with James and others and later when OK to create a PR

  1. … 39 more files in changeset.
Reverted: "Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)"

This reverts commit 3075027df7c82bcb381810d9d438150ef696254f.

  1. … 24 more files in changeset.
Reverted: "Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)"

This reverts commit a93b1fcb7859a754ba84b810c4736e7ef6778689.

  1. … 24 more files in changeset.
Revert "Improved: Update “web.xml” files version 3.0 → 4.0 (OFBIZ-6993)"

This reverts commit 226e901981b68941bbcf3e1025d2208061d28db6.

  1. … 24 more files in changeset.