Clone Tools
  • last updated 14 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed: setUserTimeZone should ran only once based on error (OFBIZ-11329)

This will be notably useful when committing CSRF solution as explained in

OFBIZ-11306:

SetTimeZoneFromBrowser when starting gives a RequestHandlerException:

Invalid or missing CSRF token for AJAX call to path '/SetTimeZoneFromBrowser'.

Also not only when starting.

Thanks: James Yong for review

(cherry picked from commit 350c71f4df45cbe5671b54e61f74f9a352d78e05)

# Conflicts:

# framework/common/groovyScripts/SetLocaleFromBrowser.groovy

# themes/common-theme/webapp/common/js/util/setUserTimeZone.js replaced

by setUserLocale.js modified by hand

I can compile locally but I can see a reason why and certainly not related to

these changes

  1. … 1 more file in changeset.
"Applied fix from trunk for revision: 1867577" (by hand) ------------------------------------------------------------------------ r1867577 | jleroux | 2019-09-26 16:41:50 +0200 (jeu. 26 sept. 2019) | 8 lignes

Fixed: Fix multi modal opening

(OFBIZ-11211)

The issue is that when closing the modal the div inside html dom is not removed.

Then opening a second time create another identical div. Since a lookup is based

on an unique id, this id is no more unique...

Thanks: Carl Demus

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1867579 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Send upload form with even-update-area doesn't work (Backport from trunk) (OFBIZ-11207) When you create a xml form with upload as type, you can't use on-event-update-area element to submit it by ajax. Otherwise, OFBiz return an error message on 'uploadFile is empty. To solve it, we analyze the enctype's form before submit it to move on FormData instead a direct serialize [1]

example form where the problem has been present

****

<form name='AddNicelyFile' type='upload' target='CreateNicelyFile'>

<field name='uploadedFile' title='File'><file/></field>

<field name='addButton'><submit/></field>

<on-event-update-area event-type='submit' area-id='window' area-target='FileDisplaying'/>

</form>

****

Thanks to Samuel Tregouet for this fix

[1] https://developer.mozilla.org/en-US/docs/Web/API/FormData/Using_FormData_Objects

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1867438 13f79535-47bb-0310-9956-ffa450edef68

Applied fix from trunk for revision: 1848441 ===

Fixed: UI bug in scrum component

(OFBIZ-10676)

When editing product backlog items, inserted javascript code was

executed on the client side. The confirmational blinking of the newly

added or changed value was implemented using the .html(value) function

of jQuery. This causes the html to be interpreted and the script to be

executed. But the data is stored, converting it into html, so not

considered to be a vulnerability.

The fix changes the call to .text. This prevents the html to be

interpreted.

Thanks Benjamin Jugl for providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1848442 13f79535-47bb-0310-9956-ffa450edef68

"Applied fix from trunk for revision: 1826797" ------------------------------------------------------------------------ r1826797 | jleroux | Thu Mar 15 11:29:59 2018 | 5 lines

Fixed: The getJSONuiLabel javascript function is no longer working

(OFBIZ-10277)

The data were well retrieve, but the syntax used to extract them was not working

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1826798 13f79535-47bb-0310-9956-ffa450edef68

Applied fix from trunk for revision: 1825211 ===

Fixed: Found element binding issue related to lookup work done at r#1825205

(OFBIZ-10012)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1825212 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Alert message : Developer: for lookups to work you must provide a form name! appears when try to select contentId from Lookup. (OFBIZ-10012) Applied slightly modified patch Thanks Sonal for reporting and Aditya Sharma for providing patch for the issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1825210 13f79535-47bb-0310-9956-ffa450edef68

  1. … 7 more files in changeset.
Implemented: renamed the common theme directory from "common" to "common-theme" (OFBIZ-10175)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821789 13f79535-47bb-0310-9956-ffa450edef68

  1. … 4325 more files in changeset.
Improved: Useful parameter usage extension and small fix of getDependentDropdownValues in miscAjaxFunctions.js. (OFBIZ-10103)

Thanks Kyra Pritzel-Hentley for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819139 13f79535-47bb-0310-9956-ffa450edef68

Improved: Replace Masked Input Plugin with jQuery-Mask-Plugin. (OFBIZ-9493) Thanks Aditya Shamra for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819117 13f79535-47bb-0310-9956-ffa450edef68

  1. … 5 more files in changeset.
Improved: Replace Inline js with External js in makeHyperlinkString macro (OFBIZ-9852) Thanks Aditya Sharma for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819113 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Improved: Moved plugins js from images to common/js (OFBIZ-5776)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818600 13f79535-47bb-0310-9956-ffa450edef68

  1. … 21 more files in changeset.
No functional change, better use console.error() here

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816706 13f79535-47bb-0310-9956-ffa450edef68

Improved: Use console.log instead of alert to show error message if setLocaleFromBrowser return error. setLocaleFromBrowser request called setUserLocale.js and its executed for each request, auth is set true for setLocaleFromBrowser service so it return error if it executed from login screen. Still need to refine way to set setLocaleFromBrowser as this request executed with each time when page refreshed.

This is an improvement related with OFBIZ-9264

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816537 13f79535-47bb-0310-9956-ffa450edef68

Improved: Replace Inline js with External js in renderDisplayField macro (OFBIZ-9843) Thanks Aditya Sharma for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816269 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Implemented: Framework: Remove inline js for toggleAll calling from ftls and also remove checkToggle, toggleAll and selectAll js functions Improved: (OFBIZ-8300)

Remove inline js for toggleAll, checkToggle and selectAll calling from ftls in

Framework component. Add class="selectAll" on parent checkbox element for select

all functionality.

Also remove js functions from OFBIZUtil.js. Functions are: toggleAll, selectAll,

toggle and checkToggle, as all its usage replaced with generic selectAll class

usage.

Thanks: Amardeep Singh Jhajj and Aditya Sharma

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814723 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Improved: Replace Inline Javascript with External Javascript (OFBIZ-9465)

As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m

inline javascript for various macros like renderLookupField, makeHyperlinkString,

shortDateInput etc in HtmlFormMacroLibrary.ftl should be replaced with a generic

code written as external javascript. Generic Javascript code should be written

in OfbizUtil.js and appropriate classes or identifiers should be used for

applying that. Any additional data can be passed with HTML 5 custom data attribute

(https://www.w3.org/TR/2011/WD-html5-20110525/elements.html

#embedding-custom-non-visible-data-with-the-data-attributes).

Deepak: I think we can use data-mask attribute to recognize the element instead

of adding class.

jeloux: I noticed a MaskFieldExampleForm was introduced with r1804027 but

not used in FormWidgetExampleScreens.xml so was not visible

Thanks: Aditya and Deepak

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814292 13f79535-47bb-0310-9956-ffa450edef68

  1. … 3 more files in changeset.
Reverted 1813609, found some improvements, so reverted commit

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1813610 13f79535-47bb-0310-9956-ffa450edef68

  1. … 2 more files in changeset.
Replace Inline Javascript with External Javascript (OFBIZ-9465) Applied patch from jira ticket, Removed inline code for masking and elrte (WYSISYG editor). Thanks Aditya Sharma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1813609 13f79535-47bb-0310-9956-ffa450edef68

  1. … 2 more files in changeset.
Improved: Moved date plugin from images/date to common/js/plugins(OFBIZ-5776)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1813586 13f79535-47bb-0310-9956-ffa450edef68

  1. … 92 more files in changeset.
Improved: Moved some utility js files from images to common-theme/js/util

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812158 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +192
    ./miscAjaxFunctions.js
    • -0
    • +35
    ./selectMultipleRelatedValues.js
  1. … 11 more files in changeset.
Improved: Moved OfbizUtil.js and fieldlookup.js from images to common-theme and made changes accordingly. (OFBIZ-5776)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809391 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +1088
    ./OfbizUtil.js
  1. … 12 more files in changeset.